neoneo-go

Author	SHA1	Message	Date
Anna Shaleva	51a54fa248	core: return default BaseExecFee if blockchain height is 0 For (bc *Blockchain).GetBaseExecFee().	2022-04-08 14:28:30 +03:00
Anna Shaleva	d3672eb14a	core: use BaseExecFee from InteropContext instead of Blockchain's one The InteropContext's one contains all relevant fee changes applied in the prevouse transactions of the current block.	2022-04-08 12:56:46 +03:00
Anna Shaleva	544f2c2cb2	core: use proper storage price within the whole interop context We shouldn't use StoragePrice from Blockchain because its dao doesn't contain the whole set of changes from previouse transactions in the current block. Instead, we should use an updated storage price for each transaction and retrieve the price from cached DAO.	2022-04-08 12:50:56 +03:00
Anna Shaleva	91a4bc5beb	core: use proper DAO to get ExecFeeFactor The usage of the Blockchain's one leads to the same ExecFeeFactor within a single block. What we need is to update ExecFeeFactor after each transaction invocation, thus, cached DAO should be used as it contains all relevant changes.	2022-04-08 12:50:50 +03:00
Anna Shaleva	16f952270c	core: add murmur32 to CryptoLib native contract Close #2415.	2022-04-05 10:46:52 +03:00
Anna Shaleva	b431e47d2a	core: add GetTransactionVMState to native Ledger contract Close #2343.	2022-04-05 10:37:02 +03:00
Anna Shaleva	4254407a9b	dao: add GetTxExecResult method	2022-04-05 10:36:50 +03:00
Anna Shaleva	18c5f638b9	dao: adjust usages of `Internal DB inconsistency` error	2022-04-04 19:16:58 +03:00
Anna Shaleva	6343720adf	dao: return ErrKeyNotFound from GetAppExecResults for dummy txs Otherwise decoding error may be returned which can be misleading.	2022-04-04 12:49:52 +03:00
Anna Shaleva	9a41356a3b	core: add getUint256FromItem helper to native ledger	2022-04-04 12:33:29 +03:00
Roman Khimov	4e375fd8f4	Merge pull request #2414 from nspcc-dev/eliminate-getstorageitems Eliminate GetStorageItems	2022-04-01 09:16:42 +03:00
Roman Khimov	c12a3b71d4	dao: drop GetStorageItems* APIs They're just adding another useless caching layer to the Seek.	2022-03-31 19:18:51 +03:00
Roman Khimov	60375e9db3	core: drop GetStorageItems interface It's not used and not useful.	2022-03-31 16:46:41 +03:00
Roman Khimov	3ab2ab5cba	core: drop outdated comment from storageFind	2022-03-31 16:39:11 +03:00
Anna Shaleva	8965441288	core: rebase core tests onto neotest	2022-03-30 19:00:53 +03:00
Anna Shaleva	35ef58a47e	core: move Oracle response script creation to a separate function	2022-03-30 18:59:43 +03:00
Anna Shaleva	a4dab3a5ba	core: adjust error message of native call	2022-03-30 12:18:01 +03:00
Anna Shaleva	59f3fa1ef1	neotest: adapt framework to work with *testing.B	2022-03-30 12:17:55 +03:00
Anna Shaleva	ff13af804d	core: adjust persist-related Blockchain tests `newTestChain` runs blockchain, so persist is likely already happened before the first test iteration. Explicit call to persist makes no sence here.	2022-03-30 11:46:44 +03:00
Anna Shaleva	28e936eb95	core: export GetMaxNotValidBeforeDelta blockchain API Mostly for tests, but it can also be useful as a separate API.	2022-03-30 11:46:44 +03:00
Anna Shaleva	e0ab4ec6f0	core: adjust helper test contract Method is allowed to have single return value on stack after its invocation. Make sure that test contract follows this rule.	2022-03-30 11:46:44 +03:00
Anna Shaleva	13252bb941	core: refactor helper test contracts generation * Move generator to a separate package. * Move loader to a separate package and get rid of the code duplications.	2022-03-30 11:46:29 +03:00
Anna Shaleva	889a7ec378	rpc: regenerate basic chain and adjust RPC server tests	2022-03-30 11:32:30 +03:00
Anna Shaleva	4a74c117ee	*: refactor TestCreateBasicChain and its dependencies Close #2355	2022-03-30 11:32:26 +03:00
Anna Shaleva	150041d25e	core: unexport native Management's GetMinimumDeploymentFee This method is used only from Management contract. We also have neotest-based tests for `getMinimumDeploymentFee`, it should be enough.	2022-03-29 15:01:10 +03:00
Roman Khimov	d5a9af5860	Revert "Revert "interop: use All flags for management deploy and update calls"" This reverts commit `526c423a61`, heading to 3.2.0.	2022-03-21 17:41:37 +03:00
Roman Khimov	526c423a61	Revert "interop: use All flags for management deploy and update calls" This reverts commit `37ca96c20b` and a part of `7945097543`, we need 0.98.2 release to be 3.1.0-compatible and this one breaks the testnet.	2022-03-21 14:32:11 +03:00
Roman Khimov	906d99571b	Merge pull request #2369 from nspcc-dev/goshechka *: go 1.18 support 🎉😍🎊🍰🥂	2022-03-18 15:07:20 +03:00
Roman Khimov	5616585697	block/dao: simplify trimming, avoid allocations The only user of (*Block).Trim() is in DAO and it already has a nice buffer usually, so creating another one makes no sense. It also simplifies error handling a lot.	2022-03-18 10:49:25 +03:00
Anna Shaleva	2096ad6e81	*: remove io/ioutil uses Close #1764.	2022-03-17 19:39:18 +03:00
Roman Khimov	6ece74a7c7	Merge pull request #2383 from nspcc-dev/oracle-redirection services: check Oracle response redirections	2022-03-04 22:19:22 +03:00
AnnaShaleva	537de18ac3	services: check Oracle response redirections 1. Move redirections check to the tcp level. Manually resolve request address and create connection for the first suitable resolved address. 2. Remove URIValidator. Redirections checks are set in the custom http client, so the user should take care of validation by himself when customizing the client.	2022-03-04 13:10:22 +03:00
Roman Khimov	ff60571869	Merge pull request #2378 from nspcc-dev/notary-adjustments *: several Notary subsystem adjustments, part 1	2022-03-02 11:58:36 +03:00
AnnaShaleva	92282c70cb	: support customisable NotaryServiceFeePerKey value Add corresponding methods to Notary contract. * Extend RPC Client API. * Adjust tests.	2022-03-01 19:08:16 +03:00
Anna Shaleva	49c995ec06	core: add tests for blockchain initialisation Close #1577.	2022-02-28 19:00:43 +03:00
AnnaShaleva	8e3f2417f4	core: add check for native activations history It should be consistent with storage states.	2022-02-28 18:49:18 +03:00
Anna Shaleva	032d9749c2	core: improve blockchain error messages	2022-02-28 18:49:18 +03:00
Anna Shaleva	a57c3f4842	core: fix InitWithIncompleteStateJump test	2022-02-28 18:49:18 +03:00
Anna Shaleva	9adcefc2ef	core: gracefully wrap Seek error if failed to retrieve header hases	2022-02-28 18:49:18 +03:00
Anna Shaleva	8d6aa1782d	core: fix StateRootInHeader error message for (*Blockchain).init()	2022-02-28 18:49:18 +03:00
Anna Shaleva	ad0c53c067	core: unify the format of error messages for (*Blockchain).init()	2022-02-28 18:49:12 +03:00
Anna Shaleva	21515e1835	core: refactor Level store creation for tests We don't need to create the whole DB configuration structure.	2022-02-25 12:14:17 +03:00
Anna Shaleva	339bec1632	core: adjust TestDumpAndRestore test `with state root` test should consider StateRootInHeader set to true.	2022-02-25 11:47:13 +03:00
Roman Khimov	7d6f087337	storage: drop (KeyPrefix).Bytes() API It allocates and most of the time we can avoid that.	2022-02-18 15:19:57 +03:00
Roman Khimov	7223caf369	dao: improve PutCurrentHeader logic Move serialization out of the core.	2022-02-18 15:05:25 +03:00
Roman Khimov	522229d731	storage: drop AppendPrefix/AppendPrefixInt APIs We're not using them anymore and they allocate.	2022-02-18 14:59:59 +03:00
Roman Khimov	d2db58d748	dao: move header hash store logic out of the core Which allows for more efficient buffer use along the way.	2022-02-18 14:54:05 +03:00
Roman Khimov	de2579ec07	dao: put contract IDs into keys using big endianness We don't have a need to iterate over them at the moment, but since we're changing the DB format in the next release anyway let's add this ability also, just in case.	2022-02-18 14:38:51 +03:00
Roman Khimov	600da6909c	storage: put uint32 into keys using in big endianness Which allows to iterate over the contents easily.	2022-02-18 14:35:17 +03:00
Roman Khimov	1ca918e631	dao: delay buffer creation until it's needed Verification contexts don't ever touch the storage, so these allocations can be avoided for them.	2022-02-18 14:24:45 +03:00
Roman Khimov	e864768c88	dao: simplify NewPrivate	2022-02-18 14:18:56 +03:00
Roman Khimov	5402e654d1	core: don't create useless DAO layer in GetTestVM We're already wrapping in interop.NewContext.	2022-02-18 14:12:44 +03:00
Roman Khimov	b60d4ff191	dao: deduplicate header->KV conversion	2022-02-18 14:12:44 +03:00
Roman Khimov	d8cf879499	dao: deduplicate DeleteBlock, no functional changes	2022-02-18 14:12:44 +03:00
Roman Khimov	f80680187e	storage: expose private storage map for more efficient MPT batch It couldn't be done previously with two maps and mixed storage, but now all of the storage changes are located in a single map, so it's trivial to do exact slice allocations and avoid string->[]byte conversions.	2022-02-17 23:41:10 +03:00
Roman Khimov	7dc8fc443f	dao: simplify buffer management for private DAO Private DAO is only used in a single thread which means we can safely reuse key/data buffers most of the time and handle it all in DAO. Doesn't affect any benchmarks.	2022-02-17 22:27:39 +03:00
Roman Khimov	9bfb3357f2	storage: add "private" mode to MemCachedStore Most of the time we don't need locking on the higher-level stores and we drop them after Persist, so that's what private MemCachedStore is for. It doesn't improve things in any noticeable way, some ~1% can be observed in neo-bench under various loads and even less than that in chain processing. But it seems to be a bit better anyway (less allocations, less locks).	2022-02-17 22:27:39 +03:00
Roman Khimov	aefb26255a	dao: drop DAO interface It's a remnant from the days when we had Simple and Cached DAO implementations, now it makes zero sense.	2022-02-16 18:24:20 +03:00
Roman Khimov	9d2ef775cf	storage: simplify (*MemCachedStore).Put/Delete interface They never return errors, so their interface should reflect that. This allows to remove quite a lot of useless and never tested code. Notice that Get still does return an error. It can be made not to do that, but usually we need to differentiate between successful/unsuccessful accesses anyway, so this doesn't help much.	2022-02-16 18:24:20 +03:00
Roman Khimov	be24bf6412	storage: drop Put and Delete from Store interface It's only changed with PutChangeSet, single KV operations are handled by MemCachedStore.	2022-02-16 18:24:20 +03:00
Roman Khimov	017795c9c1	storage: completely remove MemoryBatch If you need something like that, just wrap another MemCachedStore layer around it.	2022-02-16 16:13:12 +03:00
Roman Khimov	17a43b19e0	storage: remove Batch from Store We never use it for real underlying stores, so these implementations are useless (everything goes though PutChangeSet now).	2022-02-16 15:55:48 +03:00
Roman Khimov	35bdfc5eca	storage: use two maps for MemoryStore Simple and dumb as it is, this allows to separate contract storage from other things and dramatically improve Seek() time over storage (even though it's still unordered!) which in turn improves block processing speed. LevelDB LevelDB (KeepOnlyLatest) BoltDB BoltDB (KeepOnlyLatest) Master real 16m27,936s real 10m9,440s real 16m39,369s real 8m1,227s user 20m12,619s user 26m13,925s user 18m9,162s user 18m5,846s sys 2m56,377s sys 1m32,051s sys 9m52,576s sys 2m9,455s 2 maps real 10m49,495s real 8m53,342s real 11m46,204s real 5m56,043s user 14m19,922s user 24m6,225s user 13m25,691s user 15m4,694s sys 1m53,021s sys 1m23,006s sys 4m31,735s sys 2m8,714s neo-bench performance is mostly unaffected, ~0.5% for 1-1 test and 4% for 10K-10K test both fall within regular test error range.	2022-02-16 15:55:48 +03:00
Roman Khimov	b6a4947cfd	storage: drop STAccount prefix It's unused for a long time.	2022-02-16 13:06:57 +03:00
Roman Khimov	54bc603831	core: remove old storage items synchronously during jump There won't be a lot of them and GC experience we have shows that iterating over 1-2M of entries is not a huge problem for DBs we have.	2022-02-16 13:03:13 +03:00
Roman Khimov	805d81e441	core: drop old transfer data during state jump	2022-02-16 12:12:03 +03:00
Roman Khimov	3a2b800e5f	core: remove stale transfer entries, fix #2096 Initially I thought of doing it in the next persist cycle, but testing shows that it needs just ~2-5% of the time MPT GC does, so doing it in the same cycle doesn't affect anything.	2022-02-15 15:51:03 +03:00
Roman Khimov	c4b49a2d52	storage: deduplicate storage closing in tests	2022-02-14 17:29:21 +03:00
Roman Khimov	261552516b	stateroot: use a better word for logs	2022-02-14 17:29:21 +03:00
Roman Khimov	ccdda21718	stateroot: add and use DataMPTAux for auxiliary data Use DataMPT for nodes only, otherwise with 1M blocks with have 1M height-stateroot mapping entries that our GC has to iterate over for no reason.	2022-02-14 17:29:21 +03:00
Roman Khimov	ad606101c7	storage: add SeekGC interface for GC It's very special, single-purpose thing, but it improves cumulative time spent in GC by ~10% for LevelDB and by ~36% for BoltDB during 1050K mainnet chain processing. While the overall chain import time doesn't change in any noticeable way (~1%), I think it's still worth it, for machines with slower disks the difference might be more noticeable.	2022-02-14 17:29:21 +03:00
Roman Khimov	51b804ab0e	storage: generalize Level/Bolt seek implementations Too much in common. Just refactoring. no functional changes.	2022-02-12 23:09:37 +03:00
Roman Khimov	a5f8b8870a	storage: use Update for changeset processing Batch is only relevant in multithreaded context, internally it'll do some magic and use the same locking/updating Update does, so it makes little sense for us. This doesn't change benchmarks in any noticeable way.	2022-02-11 16:48:35 +03:00
Roman Khimov	6380647770	Merge pull request #2354 from nspcc-dev/mpt-value-based-gc Value-based MPT GC	2022-02-11 16:25:08 +03:00
Roman Khimov	c5f1e2fbcd	mpt: don't allocate for every key Microoptimization.	2022-02-11 14:19:54 +03:00
Roman Khimov	423c7883b8	core: implement basic GC for value-based storage scheme The key idea here is that even though we can't ensure MPT code won't make the node active again we can order the changes made to the persistent store in such a way that it practically doesn't matter. What happens is: * after persist if it's time to collect our garbage we do it synchronously right in the same thread working the underlying persistent store directly * all the other node code doesn't see much of it, it works with bc.dao or layers above it * if MPT doesn't find some stale deactivated node in the storage it's OK, it'll recreate it in bc.dao * if MPT finds it and activates it, it's OK too, bc.dao will store it * while GC is being performed nothing else changes the persistent store * all subsequent bc.dao persists only happen after the GC is completed which means that any changes to the (potentially) deleted nodes have a priority, it's OK for GC to delete something that'll be recreated with the next persist cycle Otherwise it's a simple scheme with node status/last active height stored in the value. Preliminary tests show that it works ~18% worse than the simple KeepOnlyLatest scheme, but this seems to be the best result so far. Fixes #2095.	2022-02-11 14:19:54 +03:00
Roman Khimov	c4ee310e85	mpt: modify refcounted storage scheme to make GC possible Add "active" flag into the node data and make the remainder modal, for active nodes it's a reference counter, for inactive ones the deactivation height is stored. Technically, refcounted chains storing just one trie don't need a flag, but it's a bit simpler this way.	2022-02-10 21:56:20 +03:00
Roman Khimov	86cb4ed80f	mpt: add the notion of MPT mode It directly affects the storage format, so it's important. ModeGC is not used at the moment, but defined for future extensibility.	2022-02-10 19:15:18 +03:00
Anna Shaleva	e306a90554	rpc: add NEP11-D tests to server and client Also refactor basic chain creation.	2022-02-09 11:57:16 +03:00
Roman Khimov	de99c3acdb	storage: provide a way to escape from SeekAsync goroutine A routine blocked on channel send here can't really exit, so avoid goroutine leak: goroutine 2813725 [chan send, 6 minutes]: github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).SeekAsync.func1.1(0xc01a7118f7, 0x2, 0x25, 0xc01a7118f9, 0x23, 0x23, 0xc0366c7c01) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:120 +0x86 github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).seek.func2(0xc0079e7920, 0xa, 0x30, 0xc0079e792a, 0x26, 0x26, 0x1) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:183 +0x347 github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).seek(0xc000458480, 0x135c028, 0xc0000445d0, 0xc00f1721d0, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:224 +0x4f4 github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).Seek(0xc000458480, 0xc00f1721d0, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, 0xc0357c6620) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:110 +0x8a github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).seek(0xc0331a4f00, 0x135bff0, 0xc00ae26ec0, 0xc00f1721d0, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:210 +0x379 github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).SeekAsync.func1(0xc0331a4f00, 0x135bff0, 0xc00ae26ec0, 0xc00f1721d0, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:119 +0xc5 created by github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).SeekAsync github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:118 +0xc8 goroutine 2822823 [chan send, 6 minutes]: github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).SeekAsync.func1.1(0xc011859b77, 0x3, 0x3, 0xc017bea8d0, 0x26, 0x26, 0xc00f1afc00) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:120 +0x86 github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).seek.func2(0xc011859b60, 0xa, 0xa, 0xc017bea8a0, 0x26, 0x26, 0xc00ad9fb00) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:200 +0x47e github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).seek.func2(0xc01d5d8c90, 0xa, 0x30, 0xc01d5d8c9a, 0x26, 0x26, 0x1) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:200 +0x47e github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).seek(0xc035e12900, 0x135c028, 0xc0000445d0, 0xc01773bf60, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:224 +0x4f4 github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).Seek(0xc035e12900, 0xc01773bf60, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, 0xc030c9e0e0) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:110 +0x8a github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).seek(0xc000458480, 0x135c028, 0xc0000445d0, 0xc01773bf60, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:210 +0x379 github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).Seek(0xc000458480, 0xc01773bf60, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, 0xc030c9e070) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:110 +0x8a github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).seek(0xc00b340c60, 0x135bff0, 0xc00f1afbc0, 0xc01773bf60, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:210 +0x379 github.com/nspcc-dev/neo-go/pkg/core/storage.(MemCachedStore).SeekAsync.func1(0xc00b340c60, 0x135bff0, 0xc00f1afbc0, 0xc01773bf60, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:119 +0xc5 created by github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).SeekAsync github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:118 +0xc8 ...	2022-02-09 00:22:42 +03:00
Roman Khimov	3307292597	storage: rework MemoryStore with a single map Doesn't affect any benchmarks or tests, but makes things a bit simpler.	2022-02-09 00:22:42 +03:00
Roman Khimov	2bc493a839	mpt: simplify makeStorageKey() interface	2022-02-08 12:38:03 +03:00
Roman Khimov	9719191770	Merge pull request #2342 from nspcc-dev/fix-management-contract-callflags Fix management contract callflags	2022-02-01 12:30:53 +03:00
Roman Khimov	7945097543	native: fix ContractManagement's call flags for update/deploy See neo-project/neo#2653.	2022-02-01 12:21:00 +03:00
Roman Khimov	1df447cd68	Merge pull request #2334 from nspcc-dev/extendable-validators Extendable validators	2022-02-01 12:09:56 +03:00
Roman Khimov	cda1c75db3	core: drop GetStandBy* methods They're misleading now that we have variable number of committee members/validators. The standby list can be seen in the configuration and the appropriate numbers can be received from it also.	2022-01-31 23:14:38 +03:00
Roman Khimov	e621f746a7	config/core: allow to change the number of validators Fixes #2320.	2022-01-31 23:14:38 +03:00
Evgeniy Stratonikov	e890c32dcc	rpc/client: remove dependency on `examples` Duplicate necessary structures in a dedicated micropackage. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-01-25 12:41:06 +03:00
Roman Khimov	6e9d725a29	config: consolidate ProtocolConfiguration consistency checks	2022-01-24 18:42:57 +03:00
Evgeniy Stratonikov	9871dc8f5a	compiler: update x/tools package Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-01-20 13:21:26 +03:00
Evgeniy Stratonikov	e7a0ecb349	compiler: provide `.go` filename to `Compile` First argument contains filename, thus we use '.go' suffix to distinguish between directories and files. Contract name should be provided in options. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-01-20 13:21:24 +03:00
Evgeniy Stratonikov	8af9c870b1	compiler: remove `CompileWithDebugInfo` It is a simple wrapper over `CompileWithOptions` which we don't really need. Custom options can be specified explicitly instead of using some random default. This default was introduced in `1578904da`, however tests written there use `CompileWithOptions` and all other tests pass on that commit even without this default. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-01-20 13:15:48 +03:00
Roman Khimov	42769d11ff	Merge pull request #2330 from nspcc-dev/transfer-logs-opt core: improve Seek and optimise seek time for transfer logs	2022-01-19 21:55:40 +03:00
Anna Shaleva	9b841b9b8f	core, rpc: use Seek to iterate over NEP* transfers The results are controversial a bit. MemoryPS is a special storage and the new approach doesn't help it to iterate through NEP17 transfers. However, on long distances (if transfers are requested for more than 1000 blocks, which is ~4.1 hours of mainnet chain) both LevelDB and BoltDB perform good enough with the new approach. Taking into account the fact that default value for the query period of `getnep17transfers` RPC handler is a week (~40K mainnet blocks) we can sacrifice MemoryPS performance in favour of BoltDB and LevelDB optimisation. Close #2263. Benchmark results: name old time/op new time/op delta Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1_Take100Blocks-8 783µs ±13% 1762µs ± 4% +125.12% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1_Take1000Blocks-8 6.91ms ± 2% 9.00ms ± 2% +30.28% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-100_Take100Blocks-8 1.43ms ± 8% 1.79ms ± 4% +24.93% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-100_Take1000Blocks-8 7.78ms ± 3% 8.93ms ± 2% +14.78% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1000_Take100Blocks-8 7.69ms ± 3% 1.73ms ±10% -77.50% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1000_Take1000Blocks-8 14.1ms ± 2% 9.0ms ± 2% -36.53% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1_Take100Blocks-8 768µs ± 3% 801µs ± 2% +4.24% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1_Take1000Blocks-8 8.03ms ± 2% 8.05ms ± 8% ~ (p=0.436 n=10+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-100_Take100Blocks-8 1.70ms ±16% 0.85ms ± 7% -49.85% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-100_Take1000Blocks-8 10.8ms ± 2% 8.1ms ± 2% -25.21% (p=0.000 n=10+8) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1000_Take100Blocks-8 10.8ms ± 2% 0.9ms ± 7% -92.12% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1000_Take1000Blocks-8 18.2ms ±13% 8.2ms ± 6% -54.95% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1_Take100Blocks-8 874µs ± 6% 823µs ± 2% -5.81% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1_Take1000Blocks-8 9.35ms ± 2% 8.14ms ± 2% -12.91% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-100_Take100Blocks-8 1.85ms ± 4% 0.89ms ±10% -51.68% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-100_Take1000Blocks-8 10.6ms ± 4% 8.2ms ± 2% -22.44% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1000_Take100Blocks-8 10.7ms ± 2% 0.9ms ± 2% -91.90% (p=0.000 n=8+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1000_Take1000Blocks-8 21.8ms ±15% 8.2ms ± 1% -62.25% (p=0.000 n=10+10) name old alloc/op new alloc/op delta Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1_Take100Blocks-8 650kB ± 0% 1010kB ± 7% +55.45% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1_Take1000Blocks-8 6.39MB ± 0% 9.89MB ± 1% +54.74% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-100_Take100Blocks-8 1.28MB ± 0% 1.14MB ± 0% -11.25% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-100_Take1000Blocks-8 7.02MB ± 0% 10.01MB ± 0% +42.54% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1000_Take100Blocks-8 7.02MB ± 0% 1.08MB ± 0% -84.64% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1000_Take1000Blocks-8 12.8MB ± 0% 10.0MB ± 0% -22.04% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1_Take100Blocks-8 823kB ± 3% 866kB ± 5% +5.19% (p=0.001 n=9+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1_Take1000Blocks-8 9.92MB ± 0% 9.85MB ± 0% -0.71% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-100_Take100Blocks-8 1.84MB ± 4% 1.01MB ± 5% -44.75% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-100_Take1000Blocks-8 11.0MB ± 0% 10.0MB ± 1% -8.45% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1000_Take100Blocks-8 11.0MB ± 0% 1.0MB ± 1% -90.55% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1000_Take1000Blocks-8 20.0MB ± 0% 10.1MB ± 0% -49.69% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1_Take100Blocks-8 913kB ± 5% 907kB ± 6% ~ (p=0.497 n=9+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1_Take1000Blocks-8 10.0MB ± 1% 10.0MB ± 1% -0.63% (p=0.001 n=10+8) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-100_Take100Blocks-8 1.92MB ± 2% 1.04MB ± 0% -45.53% (p=0.000 n=9+8) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-100_Take1000Blocks-8 11.1MB ± 1% 10.1MB ± 0% -9.22% (p=0.000 n=10+7) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1000_Take100Blocks-8 11.1MB ± 1% 1.0MB ± 0% -90.61% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1000_Take1000Blocks-8 20.4MB ± 1% 10.1MB ± 0% -50.46% (p=0.000 n=10+10) name old allocs/op new allocs/op delta Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1_Take100Blocks-8 11.1k ± 0% 11.7k ± 0% +5.35% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1_Take1000Blocks-8 110k ± 0% 110k ± 0% +0.55% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-100_Take100Blocks-8 22.0k ± 0% 11.9k ± 0% -46.14% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-100_Take1000Blocks-8 120k ± 0% 110k ± 0% -8.44% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1000_Take100Blocks-8 120k ± 0% 12k ± 0% -90.36% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1000_Take1000Blocks-8 219k ± 0% 110k ± 0% -49.73% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1_Take100Blocks-8 11.3k ± 0% 11.2k ± 0% -1.06% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1_Take1000Blocks-8 112k ± 0% 110k ± 0% -2.36% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-100_Take100Blocks-8 22.5k ± 0% 11.3k ± 0% -49.65% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-100_Take1000Blocks-8 124k ± 0% 110k ± 0% -11.08% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1000_Take100Blocks-8 124k ± 0% 11k ± 0% -90.84% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1000_Take1000Blocks-8 225k ± 0% 110k ± 0% -51.07% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1_Take100Blocks-8 11.4k ± 0% 11.3k ± 0% -1.36% (p=0.000 n=9+9) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1_Take1000Blocks-8 114k ± 0% 111k ± 0% -2.33% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-100_Take100Blocks-8 22.7k ± 0% 11.5k ± 0% -49.56% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-100_Take1000Blocks-8 125k ± 0% 111k ± 0% -11.12% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1000_Take100Blocks-8 125k ± 0% 11k ± 0% -90.82% (p=0.000 n=8+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1000_Take1000Blocks-8 229k ± 1% 111k ± 0% -51.42% (p=0.000 n=10+10)	2022-01-19 20:55:08 +03:00
Anna Shaleva	e3af21ab4a	core: add benchmark for ForEachNEP17Transfer	2022-01-19 20:54:35 +03:00
Anna Shaleva	cd42b8b20c	core: allow early Seek stop This simple approach allows to improve the performance of BoltDB and LevelDB in both terms of speed and allocations for retrieving GasPerVote value from the storage. MemoryPS's speed suffers a bit, but we don't use it for production environment. Part of #2322. Benchmark results: name old time/op new time/op delta NEO_GetGASPerVote/MemPS_10RewardRecords_1RewardDistance-8 25.3µs ± 1% 26.4µs ± 9% +4.41% (p=0.043 n=10+9) NEO_GetGASPerVote/MemPS_10RewardRecords_10RewardDistance-8 27.9µs ± 1% 30.1µs ±15% +7.97% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_10RewardRecords_100RewardDistance-8 55.1µs ± 1% 60.2µs ± 7% +9.27% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_1000RewardDistance-8 353µs ± 2% 416µs ±13% +17.88% (p=0.000 n=8+8) NEO_GetGASPerVote/MemPS_100RewardRecords_1RewardDistance-8 195µs ± 1% 216µs ± 7% +10.42% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_10RewardDistance-8 200µs ± 4% 214µs ± 9% +6.99% (p=0.002 n=9+8) NEO_GetGASPerVote/MemPS_100RewardRecords_100RewardDistance-8 223µs ± 2% 247µs ± 9% +10.60% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1000RewardDistance-8 612µs ±23% 855µs ±52% +39.60% (p=0.001 n=9+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1RewardDistance-8 11.3ms ±53% 10.7ms ±50% ~ (p=0.739 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_10RewardDistance-8 12.0ms ±37% 10.4ms ±65% ~ (p=0.853 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_100RewardDistance-8 11.3ms ±40% 10.4ms ±49% ~ (p=0.631 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1000RewardDistance-8 3.80ms ±45% 3.69ms ±27% ~ (p=0.931 n=6+5) NEO_GetGASPerVote/BoltPS_10RewardRecords_1RewardDistance-8 23.0µs ± 9% 22.6µs ± 4% ~ (p=0.059 n=8+9) NEO_GetGASPerVote/BoltPS_10RewardRecords_10RewardDistance-8 25.9µs ± 5% 24.8µs ± 4% -4.17% (p=0.006 n=10+8) NEO_GetGASPerVote/BoltPS_10RewardRecords_100RewardDistance-8 42.7µs ±13% 38.9µs ± 1% -8.85% (p=0.000 n=9+8) NEO_GetGASPerVote/BoltPS_10RewardRecords_1000RewardDistance-8 80.8µs ±12% 84.9µs ± 9% ~ (p=0.114 n=8+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_1RewardDistance-8 64.3µs ±16% 22.1µs ±23% -65.64% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_10RewardDistance-8 61.0µs ±34% 23.2µs ± 8% -62.04% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_100RewardDistance-8 62.2µs ±14% 25.7µs ±13% -58.66% (p=0.000 n=9+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_1000RewardDistance-8 359µs ±60% 325µs ±60% ~ (p=0.739 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1RewardDistance-8 242µs ±21% 13µs ±28% -94.49% (p=0.000 n=10+8) NEO_GetGASPerVote/BoltPS_1000RewardRecords_10RewardDistance-8 229µs ±23% 18µs ±70% -92.02% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_1000RewardRecords_100RewardDistance-8 238µs ±28% 20µs ±109% -91.38% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1000RewardDistance-8 265µs ±20% 77µs ±62% -71.04% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1RewardDistance-8 25.5µs ± 3% 24.7µs ± 7% ~ (p=0.143 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_10RewardDistance-8 27.4µs ± 2% 27.9µs ± 6% ~ (p=0.280 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_100RewardDistance-8 50.2µs ± 7% 47.4µs ±10% ~ (p=0.156 n=9+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1000RewardDistance-8 98.2µs ± 9% 94.6µs ±10% ~ (p=0.218 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_1RewardDistance-8 82.9µs ±13% 32.1µs ±22% -61.30% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_10RewardDistance-8 92.2µs ±11% 33.7µs ±12% -63.42% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_100RewardRecords_100RewardDistance-8 88.3µs ±22% 39.4µs ±14% -55.36% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_100RewardRecords_1000RewardDistance-8 106µs ±18% 78µs ±24% -26.20% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1RewardDistance-8 360µs ±24% 29µs ±53% -91.91% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_1000RewardRecords_10RewardDistance-8 353µs ±16% 50µs ±70% -85.72% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_100RewardDistance-8 381µs ±20% 47µs ±111% -87.64% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1000RewardDistance-8 434µs ±19% 113µs ±41% -74.04% (p=0.000 n=10+10) name old alloc/op new alloc/op delta NEO_GetGASPerVote/MemPS_10RewardRecords_1RewardDistance-8 4.82kB ± 0% 4.26kB ± 1% -11.62% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_10RewardRecords_10RewardDistance-8 4.99kB ± 0% 4.41kB ± 1% -11.56% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_100RewardDistance-8 8.45kB ± 0% 7.87kB ± 0% -6.88% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_1000RewardDistance-8 55.0kB ± 0% 54.5kB ± 0% -0.81% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1RewardDistance-8 29.1kB ± 0% 21.7kB ± 2% -25.56% (p=0.000 n=9+9) NEO_GetGASPerVote/MemPS_100RewardRecords_10RewardDistance-8 29.3kB ± 1% 21.8kB ± 2% -25.74% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_100RewardDistance-8 31.3kB ± 1% 23.6kB ± 1% -24.50% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1000RewardDistance-8 92.5kB ± 5% 84.7kB ± 3% -8.50% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_1000RewardRecords_1RewardDistance-8 324kB ±29% 222kB ±44% -31.33% (p=0.007 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_10RewardDistance-8 308kB ±32% 174kB ±14% -43.56% (p=0.000 n=10+8) NEO_GetGASPerVote/MemPS_1000RewardRecords_100RewardDistance-8 298kB ±23% 178kB ±36% -40.26% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1000RewardDistance-8 362kB ± 6% 248kB ± 6% -31.54% (p=0.004 n=6+5) NEO_GetGASPerVote/BoltPS_10RewardRecords_1RewardDistance-8 5.15kB ± 3% 4.64kB ± 2% -9.92% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_10RewardRecords_10RewardDistance-8 5.36kB ± 1% 4.75kB ± 5% -11.42% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_10RewardRecords_100RewardDistance-8 8.15kB ± 4% 7.53kB ± 1% -7.62% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_10RewardRecords_1000RewardDistance-8 33.2kB ± 5% 33.2kB ± 7% ~ (p=0.829 n=8+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_1RewardDistance-8 20.1kB ± 7% 5.8kB ±13% -70.90% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_10RewardDistance-8 19.8kB ±14% 6.2kB ± 5% -68.87% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_100RewardDistance-8 21.7kB ± 6% 8.0kB ± 7% -63.20% (p=0.000 n=9+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_1000RewardDistance-8 98.5kB ±44% 81.8kB ±48% ~ (p=0.143 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1RewardDistance-8 130kB ± 4% 4kB ± 9% -96.69% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_10RewardDistance-8 131kB ± 4% 5kB ±21% -96.48% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_1000RewardRecords_100RewardDistance-8 132kB ± 4% 6kB ±10% -95.39% (p=0.000 n=10+8) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1000RewardDistance-8 151kB ± 4% 26kB ±10% -82.46% (p=0.000 n=9+9) NEO_GetGASPerVote/LevelPS_10RewardRecords_1RewardDistance-8 5.92kB ± 3% 5.32kB ± 2% -10.01% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_10RewardDistance-8 6.09kB ± 2% 5.48kB ± 2% -10.00% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_100RewardDistance-8 9.61kB ± 1% 9.00kB ± 0% -6.29% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1000RewardDistance-8 33.4kB ± 7% 32.2kB ± 5% -3.60% (p=0.037 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_1RewardDistance-8 22.3kB ±10% 9.0kB ±16% -59.78% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_10RewardDistance-8 23.6kB ± 6% 8.5kB ±20% -63.76% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_100RewardDistance-8 24.2kB ± 9% 11.5kB ± 4% -52.34% (p=0.000 n=10+8) NEO_GetGASPerVote/LevelPS_100RewardRecords_1000RewardDistance-8 44.2kB ± 6% 30.8kB ± 9% -30.24% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1RewardDistance-8 144kB ± 4% 10kB ±24% -93.39% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_10RewardDistance-8 146kB ± 1% 11kB ±37% -92.14% (p=0.000 n=7+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_100RewardDistance-8 149kB ± 3% 11kB ±12% -92.28% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1000RewardDistance-8 171kB ± 4% 34kB ±12% -80.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta NEO_GetGASPerVote/MemPS_10RewardRecords_1RewardDistance-8 95.0 ± 0% 74.0 ± 0% -22.11% (p=0.001 n=8+9) NEO_GetGASPerVote/MemPS_10RewardRecords_10RewardDistance-8 100 ± 0% 78 ± 1% -21.70% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_100RewardDistance-8 153 ± 0% 131 ± 2% -14.25% (p=0.000 n=6+10) NEO_GetGASPerVote/MemPS_10RewardRecords_1000RewardDistance-8 799 ± 2% 797 ± 4% ~ (p=0.956 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1RewardDistance-8 438 ± 6% 167 ± 0% -61.86% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_100RewardRecords_10RewardDistance-8 446 ± 5% 172 ± 0% -61.38% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_100RewardDistance-8 506 ± 4% 232 ± 1% -54.21% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1000RewardDistance-8 1.31k ± 5% 0.97k ± 4% -26.20% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1RewardDistance-8 5.06k ± 1% 1.09k ± 2% -78.53% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_10RewardDistance-8 5.02k ± 3% 1.08k ± 0% -78.45% (p=0.000 n=10+8) NEO_GetGASPerVote/MemPS_1000RewardRecords_100RewardDistance-8 5.09k ± 3% 1.15k ± 2% -77.48% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1000RewardDistance-8 5.83k ± 1% 1.87k ± 3% -68.02% (p=0.004 n=6+5) NEO_GetGASPerVote/BoltPS_10RewardRecords_1RewardDistance-8 103 ± 2% 82 ± 1% -20.83% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_10RewardRecords_10RewardDistance-8 107 ± 0% 86 ± 0% -19.63% (p=0.000 n=8+8) NEO_GetGASPerVote/BoltPS_10RewardRecords_100RewardDistance-8 164 ± 1% 139 ± 0% -15.45% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_10RewardRecords_1000RewardDistance-8 820 ± 1% 789 ± 1% -3.70% (p=0.000 n=9+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_1RewardDistance-8 475 ± 0% 94 ± 3% -80.15% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_10RewardDistance-8 481 ± 0% 100 ± 2% -79.26% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_100RewardDistance-8 549 ± 0% 161 ± 2% -70.69% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_1000RewardDistance-8 1.61k ±19% 1.19k ±25% -26.05% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1RewardDistance-8 4.12k ± 0% 0.08k ± 2% -98.02% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_10RewardDistance-8 4.14k ± 0% 0.09k ± 3% -97.90% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_1000RewardRecords_100RewardDistance-8 4.19k ± 0% 0.15k ± 3% -96.52% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1000RewardDistance-8 4.82k ± 1% 0.74k ± 1% -84.58% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_10RewardRecords_1RewardDistance-8 112 ± 4% 90 ± 3% -19.45% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_10RewardDistance-8 116 ± 2% 95 ± 2% -17.90% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_100RewardDistance-8 170 ± 3% 148 ± 3% -12.99% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1000RewardDistance-8 800 ± 2% 772 ± 2% -3.50% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_1RewardDistance-8 480 ± 3% 118 ± 3% -75.32% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_10RewardDistance-8 479 ± 2% 123 ± 3% -74.33% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_100RewardRecords_100RewardDistance-8 542 ± 1% 183 ± 3% -66.34% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_100RewardRecords_1000RewardDistance-8 1.19k ± 1% 0.79k ± 1% -33.41% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1RewardDistance-8 4.21k ± 1% 0.13k ±21% -96.83% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_10RewardDistance-8 4.23k ± 1% 0.15k ±17% -96.48% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_100RewardDistance-8 4.27k ± 0% 0.19k ± 6% -95.51% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1000RewardDistance-8 4.89k ± 1% 0.79k ± 2% -83.80% (p=0.000 n=10+10)	2022-01-19 20:54:35 +03:00
Roman Khimov	4e864ca7fb	Merge pull request #2331 from nspcc-dev/extend-invokefunction-results Extend invokefunction results	2022-01-19 18:25:41 +03:00
Anna Shaleva	cc60bca491	core: adjust native Notary `withdraw` call flags It changes states and calls `transfer` method of GAS which emits `transfer` notification, so it requires States \| AllowCall \| AllowNotify, i.e. the widest permission. See https://github.com/nspcc-dev/neo-go/issues/1990#issuecomment-1014911528.	2022-01-19 11:33:33 +03:00
Roman Khimov	2e452df13a	rpc/storage: add storage changes to invoke* diagnostics	2022-01-19 00:02:19 +03:00
Roman Khimov	9c8ba5777e	Merge pull request #2323 from nspcc-dev/drop-blockchainer Reduce blockchainer.Blockchainer use	2022-01-14 20:47:26 +03:00
Roman Khimov	294a70646e	core: lock block addition on state jump It should be performed before we're able to process blocks or before we shutdown (which uses addition lock), fix panic: assignment to entry in nil map goroutine 5755 [running]: github.com/nspcc-dev/neo-go/pkg/core/storage.(MemoryStore).drop(...) /home/rik/dev/neo-go/pkg/core/storage/memory_store.go:74 github.com/nspcc-dev/neo-go/pkg/core/storage.(MemoryStore).PutChangeSet(0xc00093e700, 0xc0002051a0, 0xc000205200, 0x1, 0x1) /home/rik/dev/neo-go/pkg/core/storage/memory_store.go:100 +0x25c github.com/nspcc-dev/neo-go/pkg/core/storage.(MemoryStore).PutBatch(...) /home/rik/dev/neo-go/pkg/core/storage/memory_store.go:90 github.com/nspcc-dev/neo-go/pkg/core.(Blockchain).removeOldStorageItems(0xc000206a00) /home/rik/dev/neo-go/pkg/core/blockchain.go:495 +0x33a created by github.com/nspcc-dev/neo-go/pkg/core.(*Blockchain).jumpToStateInternal /home/rik/dev/neo-go/pkg/core/blockchain.go:553 +0x68a FAIL github.com/nspcc-dev/neo-go/pkg/core 52.084s	2022-01-14 20:25:39 +03:00
Roman Khimov	746644a4eb	network: decouple it from blockchainer.Blockchainer We don't need all of it.	2022-01-14 19:57:16 +03:00
Roman Khimov	ddb23ccf78	core: shrink blockchainer.StateRoot further, leave simple RO methods	2022-01-14 19:57:16 +03:00
Roman Khimov	077d5ccb03	core: drop dangerous methods from blockchainer.StateRoot CleanStorage and UpdateStateValidators should only be availabe to appropriate core modules.	2022-01-14 19:57:16 +03:00
Roman Khimov	380e706255	core/state*: drop blockchainer.Blockchainer use	2022-01-14 19:57:16 +03:00
Roman Khimov	59b2696849	services/consensus: drop blockchainer.Blockchainer use Simplify testing, avoid monstrous Blockchainer interface.	2022-01-14 19:57:16 +03:00
Roman Khimov	fc45d3b132	blockchain: properly set invocation counter for verification ctx Fix problem noted in #2270.	2022-01-14 19:57:16 +03:00
Roman Khimov	9f9bd7261c	core: return *interop.Context from GetTestVM Return everything needed, fix #2273.	2022-01-14 19:57:16 +03:00
Roman Khimov	ab2e60458d	interop: drop blockchainer dependency Use local interface.	2022-01-14 19:57:16 +03:00
Roman Khimov	bf1604454c	blockchainer/network: move StateSync interface to the user Only network package cares about it.	2022-01-14 19:57:14 +03:00
Roman Khimov	0ad3ea5944	network/cli: move Oracle service instantiation out of the network	2022-01-14 19:53:45 +03:00
Roman Khimov	5dd4db2c02	network/services: unify service lifecycle management Run with Start, Stop with Shutdown, make behavior uniform.	2022-01-14 19:53:45 +03:00
AnnaShaleva	ce5dfdbe90	nativetest: migrate Notary contract tests to neotest	2022-01-14 17:56:10 +03:00
Anna Shaleva	df6a7d4258	nativetest: migrate Oracle contract tests to neotest	2022-01-14 17:56:10 +03:00
Anna Shaleva	0e1f85b2bf	vm: optimise emit.Array() to use NEWARRAY0 for zero-lenght arrays	2022-01-14 17:56:10 +03:00
Anna Shaleva	2f18b114f2	nativetest: migrate NEO contract tests to neotest	2022-01-14 17:56:10 +03:00
Anna Shaleva	e0ca05f62c	nativetest: migrate Management contract tests to neotest	2022-01-14 17:56:04 +03:00
Anna Shaleva	7927c8d8f5	nativetest: migrate Designation contract tests to neotest	2022-01-14 16:47:31 +03:00
Anna Shaleva	3f1af71f52	nativetest: migrate GAS contract tests to neotest framework	2022-01-14 16:47:31 +03:00
Anna Shaleva	4e7435081f	nativetest: migrate Ledger contract tests to neotest	2022-01-14 16:47:27 +03:00
Anna Shaleva	bbe92c21ea	nativetest: migrate Policy contract tests to neotest	2022-01-14 16:34:33 +03:00
Anna Shaleva	2c46b81864	native: optimize gas per vote calculation GAS per vote records are being returned from Seek in ascending way, and we need the last record before the specified index which is close to the current chain's height (most of the time). To optimize we can iterate backwards strting from the last record using SeekBackwards. name old time/op new time/op delta NEO_GetGASPerVote/MemPS_10RewardRecords_1RewardDistance-8 27.7µs ± 8% 30.3µs ± 2% +9.36% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_10RewardDistance-8 32.1µs ± 6% 37.4µs ± 5% +16.41% (p=0.000 n=9+10) NEO_GetGASPerVote/MemPS_10RewardRecords_100RewardDistance-8 60.9µs ± 8% 68.1µs ± 9% +11.72% (p=0.001 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_1000RewardDistance-8 384µs ± 9% 437µs ± 2% +13.68% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1RewardDistance-8 227µs ± 5% 255µs ± 6% +12.37% (p=0.000 n=9+9) NEO_GetGASPerVote/MemPS_100RewardRecords_10RewardDistance-8 222µs ± 9% 332µs ±47% +49.64% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_100RewardDistance-8 245µs ± 8% 293µs ±13% +19.64% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_100RewardRecords_1000RewardDistance-8 731µs ±14% 1071µs ±57% +46.58% (p=0.001 n=9+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1RewardDistance-8 7.45ms ±48% 9.83ms ±44% +32.00% (p=0.019 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_10RewardDistance-8 8.54ms ±46% 10.18ms ±46% ~ (p=0.218 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_100RewardDistance-8 7.35ms ±43% 7.72ms ±56% ~ (p=0.579 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1000RewardDistance-8 3.52ms ±32% 3.91ms ±24% ~ (p=0.684 n=10+10) NEO_GetGASPerVote/BoltPS_10RewardRecords_1RewardDistance-8 25.2µs ± 5% 23.8µs ± 4% -5.25% (p=0.016 n=10+8) NEO_GetGASPerVote/BoltPS_10RewardRecords_10RewardDistance-8 29.5µs ± 8% 26.2µs ± 3% -11.13% (p=0.000 n=10+8) NEO_GetGASPerVote/BoltPS_10RewardRecords_100RewardDistance-8 44.9µs ±11% 40.2µs ± 9% -10.50% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_10RewardRecords_1000RewardDistance-8 100µs ± 9% 83µs ±15% -16.75% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_1RewardDistance-8 88.4µs ± 8% 65.8µs ±17% -25.52% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_10RewardDistance-8 88.9µs ± 7% 65.4µs ±20% -26.44% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_100RewardDistance-8 94.4µs ± 9% 63.1µs ±18% -33.15% (p=0.000 n=9+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_1000RewardDistance-8 354µs ±35% 443µs ±49% ~ (p=0.190 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1RewardDistance-8 469µs ±20% 227µs ±21% -51.66% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_10RewardDistance-8 468µs ±17% 267µs ±32% -42.92% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_1000RewardRecords_100RewardDistance-8 480µs ±14% 253µs ±20% -47.25% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1000RewardDistance-8 497µs ±15% 311µs ±37% -37.39% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1RewardDistance-8 27.2µs ± 8% 28.3µs ± 6% ~ (p=0.165 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_10RewardDistance-8 29.3µs ± 4% 30.2µs ± 8% ~ (p=0.089 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_100RewardDistance-8 51.7µs ±10% 54.3µs ±16% ~ (p=0.218 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1000RewardDistance-8 107µs ± 8% 112µs ±15% ~ (p=0.190 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_1RewardDistance-8 103µs ± 3% 97µs ±27% ~ (p=0.633 n=8+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_10RewardDistance-8 98.5µs ±10% 89.2µs ± 9% -9.46% (p=0.004 n=10+9) NEO_GetGASPerVote/LevelPS_100RewardRecords_100RewardDistance-8 100µs ±10% 95µs ±14% ~ (p=0.243 n=9+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_1000RewardDistance-8 222µs ± 7% 135µs ±40% -39.16% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1RewardDistance-8 587µs ± 3% 448µs ±29% -23.58% (p=0.000 n=8+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_10RewardDistance-8 569µs ± 9% 438µs ±24% -22.98% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_100RewardDistance-8 578µs ±17% 436µs ±19% -24.49% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1000RewardDistance-8 683µs ±10% 480µs ±29% -29.76% (p=0.000 n=9+9) name old alloc/op new alloc/op delta NEO_GetGASPerVote/MemPS_10RewardRecords_1RewardDistance-8 5.43kB ± 0% 4.83kB ± 0% -11.06% (p=0.000 n=9+9) NEO_GetGASPerVote/MemPS_10RewardRecords_10RewardDistance-8 5.74kB ± 0% 5.00kB ± 0% -12.91% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_100RewardDistance-8 9.90kB ± 0% 8.49kB ± 0% -14.24% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_1000RewardDistance-8 62.9kB ± 0% 55.6kB ± 0% -11.63% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1RewardDistance-8 37.5kB ± 0% 29.5kB ± 1% -21.31% (p=0.000 n=9+10) NEO_GetGASPerVote/MemPS_100RewardRecords_10RewardDistance-8 37.8kB ± 1% 30.0kB ± 2% -20.71% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_100RewardDistance-8 40.6kB ± 1% 32.0kB ± 1% -21.20% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1000RewardDistance-8 105kB ±13% 81kB ± 9% -22.81% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_1000RewardRecords_1RewardDistance-8 374kB ± 1% 282kB ±24% -24.58% (p=0.000 n=8+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_10RewardDistance-8 376kB ± 9% 280kB ±11% -25.55% (p=0.000 n=8+9) NEO_GetGASPerVote/MemPS_1000RewardRecords_100RewardDistance-8 359kB ± 9% 289kB ±19% -19.60% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1000RewardDistance-8 443kB ± 1% 362kB ± 8% -18.30% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_10RewardRecords_1RewardDistance-8 5.71kB ± 1% 5.17kB ± 1% -9.40% (p=0.000 n=10+7) NEO_GetGASPerVote/BoltPS_10RewardRecords_10RewardDistance-8 6.04kB ± 1% 5.40kB ± 1% -10.61% (p=0.000 n=10+8) NEO_GetGASPerVote/BoltPS_10RewardRecords_100RewardDistance-8 9.59kB ± 4% 8.19kB ± 1% -14.60% (p=0.000 n=10+8) NEO_GetGASPerVote/BoltPS_10RewardRecords_1000RewardDistance-8 41.6kB ± 2% 33.7kB ± 8% -18.98% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_1RewardDistance-8 29.2kB ± 2% 20.2kB ± 7% -30.94% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_10RewardDistance-8 29.6kB ± 4% 20.3kB ± 8% -31.58% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_100RewardDistance-8 32.4kB ± 4% 21.7kB ± 5% -33.25% (p=0.000 n=9+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_1000RewardDistance-8 98.8kB ±17% 109.8kB ±41% ~ (p=0.353 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1RewardDistance-8 220kB ± 2% 129kB ± 3% -41.40% (p=0.000 n=9+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_10RewardDistance-8 219kB ± 4% 135kB ± 7% -38.52% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_100RewardDistance-8 223kB ± 5% 132kB ± 6% -40.69% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1000RewardDistance-8 263kB ± 5% 155kB ± 8% -41.23% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1RewardDistance-8 6.19kB ± 1% 5.94kB ± 1% -4.15% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_10RewardRecords_10RewardDistance-8 6.51kB ± 0% 6.10kB ± 2% -6.27% (p=0.000 n=8+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_100RewardDistance-8 10.1kB ± 2% 9.7kB ± 3% -4.45% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1000RewardDistance-8 35.4kB ± 1% 33.6kB ± 3% -5.13% (p=0.000 n=9+9) NEO_GetGASPerVote/LevelPS_100RewardRecords_1RewardDistance-8 28.1kB ± 3% 22.6kB ±10% -19.58% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_10RewardDistance-8 28.0kB ± 3% 23.7kB ± 9% -15.54% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_100RewardDistance-8 29.5kB ± 3% 24.8kB ±10% -16.08% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_1000RewardDistance-8 53.7kB ± 4% 44.6kB ± 5% -16.83% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1RewardDistance-8 207kB ± 2% 148kB ± 3% -28.58% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_10RewardDistance-8 206kB ± 2% 148kB ± 4% -28.20% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_100RewardDistance-8 208kB ± 1% 149kB ± 3% -28.07% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1000RewardDistance-8 234kB ± 2% 171kB ± 5% -26.71% (p=0.000 n=10+10) name old allocs/op new allocs/op delta NEO_GetGASPerVote/MemPS_10RewardRecords_1RewardDistance-8 129 ± 1% 95 ± 1% -26.33% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_10RewardRecords_10RewardDistance-8 139 ± 1% 100 ± 1% -27.85% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_100RewardDistance-8 225 ± 1% 155 ± 1% -31.11% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_1000RewardDistance-8 1.22k ± 3% 0.86k ± 1% -29.14% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1RewardDistance-8 863 ± 2% 468 ± 4% -45.72% (p=0.000 n=9+9) NEO_GetGASPerVote/MemPS_100RewardRecords_10RewardDistance-8 872 ± 2% 490 ± 7% -43.89% (p=0.000 n=8+10) NEO_GetGASPerVote/MemPS_100RewardRecords_100RewardDistance-8 973 ± 1% 550 ± 5% -43.44% (p=0.000 n=9+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1000RewardDistance-8 2.11k ± 1% 1.37k ± 2% -35.11% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1RewardDistance-8 9.00k ± 1% 5.05k ± 1% -43.94% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_10RewardDistance-8 9.04k ± 1% 5.06k ± 1% -43.97% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_1000RewardRecords_100RewardDistance-8 9.15k ± 1% 5.10k ± 2% -44.24% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1000RewardDistance-8 10.2k ± 0% 5.8k ± 1% -42.60% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_10RewardRecords_1RewardDistance-8 136 ± 1% 103 ± 0% -24.15% (p=0.000 n=10+7) NEO_GetGASPerVote/BoltPS_10RewardRecords_10RewardDistance-8 146 ± 0% 107 ± 0% -26.71% (p=0.000 n=9+6) NEO_GetGASPerVote/BoltPS_10RewardRecords_100RewardDistance-8 232 ± 1% 164 ± 0% -29.46% (p=0.000 n=10+7) NEO_GetGASPerVote/BoltPS_10RewardRecords_1000RewardDistance-8 1.21k ± 1% 0.82k ± 1% -31.99% (p=0.000 n=10+8) NEO_GetGASPerVote/BoltPS_100RewardRecords_1RewardDistance-8 876 ± 0% 474 ± 0% -45.85% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_10RewardDistance-8 888 ± 0% 481 ± 0% -45.82% (p=0.000 n=9+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_100RewardDistance-8 990 ± 1% 550 ± 0% -44.49% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_1000RewardDistance-8 2.29k ± 8% 1.70k ±19% -25.86% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1RewardDistance-8 8.18k ± 1% 4.15k ± 2% -49.33% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_10RewardDistance-8 8.19k ± 1% 4.14k ± 0% -49.41% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_100RewardDistance-8 8.29k ± 1% 4.21k ± 2% -49.20% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1000RewardDistance-8 9.31k ± 1% 4.84k ± 1% -48.05% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1RewardDistance-8 144 ± 1% 112 ± 3% -22.09% (p=0.000 n=8+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_10RewardDistance-8 153 ± 2% 116 ± 3% -23.66% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_100RewardDistance-8 236 ± 1% 172 ± 4% -27.33% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1000RewardDistance-8 1.16k ± 0% 0.81k ± 1% -30.00% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_1RewardDistance-8 859 ± 1% 481 ± 2% -44.07% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_10RewardDistance-8 872 ± 1% 478 ± 2% -45.14% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_100RewardDistance-8 968 ± 1% 550 ± 2% -43.21% (p=0.000 n=10+8) NEO_GetGASPerVote/LevelPS_100RewardRecords_1000RewardDistance-8 1.89k ± 1% 1.19k ± 1% -37.21% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1RewardDistance-8 8.14k ± 0% 4.22k ± 0% -48.10% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_1000RewardRecords_10RewardDistance-8 8.17k ± 0% 4.21k ± 1% -48.43% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_100RewardDistance-8 8.23k ± 0% 4.28k ± 0% -48.00% (p=0.000 n=10+8) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1000RewardDistance-8 9.14k ± 0% 4.90k ± 1% -46.45% (p=0.000 n=10+10)	2022-01-13 13:47:05 +03:00
Anna Shaleva	04a8e6666f	storage: allow to seek backwards	2022-01-13 12:44:29 +03:00
AnnaShaleva	6bc92abe19	storage: allow to seek starting from some point	2022-01-13 12:44:29 +03:00
Anna Shaleva	7d5b20d8dd	core: fix comments formatting	2022-01-13 12:44:29 +03:00
Anna Shaleva	5770a581c3	store: improve Seek tests After #2193 Seek results are sorted in an ascending way, so technically the test was needed to be fixed along with these changes.	2022-01-13 12:44:29 +03:00
Anna Shaleva	9879514412	core: add benchmark for (*NEO).getGASPerVote	2022-01-13 12:44:19 +03:00
Roman Khimov	c942402957	blockchainer: drop Policer interface We never use it as a proper interface, so it makes no sense keeping it this way.	2022-01-12 00:58:03 +03:00
AnnaShaleva	8c6de35ec2	core: fix GAS distribution to primary node when notary enabled Close #2310.	2021-12-14 12:18:47 +03:00
Roman Khimov	b43335e591	Merge pull request #2306 from nspcc-dev/call-tokens compiler: use CALLT for native contract calls, fix #2257	2021-12-10 13:05:55 +03:00
Roman Khimov	299a7ea614	compiler: use CALLT for native contract calls, fix #2257	2021-12-10 11:58:50 +03:00
Roman Khimov	4c39b6600d	*: store application long along with tx/block Two times less keys inserted into the DB per tx leads to ~13% TPS improvement. We also drop one goroutine with it which isn't bad as well.	2021-12-09 15:39:26 +03:00
Roman Khimov	f87c595d94	core: fix TestRestoreAfterDeploy A bit longer script easily solves the size problem.	2021-12-08 12:05:31 +03:00
Roman Khimov	ac7e922606	native: avoid big.Int allocation in burn() addTokens and incBalance only read the amount, so it's not a problem.	2021-12-02 15:40:43 +03:00
Roman Khimov	a003879b84	native: avoid allocations in increaseBalance	2021-12-02 15:33:30 +03:00
Roman Khimov	ffeb3b8473	transaction: microoptimize Hash() It doesn't cost much, but it's used _a lot_, so optimizing it makes sense. name old time/op new time/op delta TxHash-8 4.89ns ± 5% 0.54ns ± 2% -88.86% (p=0.008 n=5+5) name old alloc/op new alloc/op delta TxHash-8 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta TxHash-8 0.00 0.00 ~ (all equal)	2021-12-02 14:48:35 +03:00
Roman Khimov	418ba1dbc3	*: use internal variables for simple big.NewInt() values Avoid additional allocations.	2021-12-01 21:36:25 +03:00
Roman Khimov	9576e10d04	storage: use map size hints to optimize subsequent persist() We're likely to have something comparable to the current changeset in the subsequent one. If it's bigger, no big deal, it'll be reallocated, if it's smaller, no big deal, the next one will be preallocated smaller.	2021-12-01 21:36:25 +03:00
Roman Khimov	428ba48444	mempool: use capacity parameter to avoid map reallocations Which is what happens in AddBlock that fills a new pool with exactly the number of transactions we know already.	2021-12-01 21:36:25 +03:00
Roman Khimov	748a70569a	mempool: use uint256 library for fee tracking It's very effective in avoiding allocations for big.Int, we don't have a microbenchmark for memppol, but this improves TPS metrics by ~1-2%, so it's noticeable.	2021-12-01 21:36:25 +03:00
Roman Khimov	01d15ff473	Merge pull request #2270 from nspcc-dev/vm-invoked-contracts Add invoked contract tracing	2021-12-01 11:27:27 +03:00
Anna Shaleva	1d1538c566	services: fix Oracle response transaction creation Problem: transactions with wrong hashes are accepted to the chain if consensus nodes are designated as Oracle nodes. The result is wrong MerkleRoot for the accepted block. Consensus nodes got such blocks right from the dbft and store them without errors, but if non-consensus nodes are present in the network, they just can't accept these "bad" blocks: ``` 2021-11-29T12:56:40.533+0300 WARN blockQueue: failed adding block into the blockchain {"error": "invalid block: MerkleRoot mismatch (expected a866b57ad637934f7a7700e3635a549387e644970b42681d865a54c3b3a46122, calculated d465aafabaf4539a3f619d373d178eeeeab7acb9847e746e398706c8c1582bf8)", "blockHeight": 17, "nextIndex": 18} ``` This problem happens because of transaction hash caching. We can't set transaction hash if transaction construction wasn't yet completed.	2021-11-30 10:43:58 +03:00
Roman Khimov	33e37e60e5	Merge pull request #2264 from nspcc-dev/fix-win-tests *: Windows compatibility fixes	2021-11-29 11:25:35 +03:00
AnnaShaleva	aefb6f9fee	*: fix tests failing due to path.Join usage Solution: Use `file/filepath` package to construct expected path. This package is OS-aware, see https://github.com/golang/go/issues/30616.	2021-11-29 11:11:09 +03:00
AnnaShaleva	06beb4d534	core: fix TestMemCachedPersist test Problem: ``` --- FAIL: TestMemCachedPersist (0.07s) --- FAIL: TestMemCachedPersist/BoltDBStore (0.07s) testing.go:894: TempDir RemoveAll cleanup: remove C:\Users\Anna\AppData\Local\Temp\TestMemCachedPersist_BoltDBStore294966711\001\test_bolt_db: The process cannot access the file because it is being used by another process. ``` Solution: Release the resources occupied by the DB.	2021-11-26 18:26:27 +03:00
Evgeniy Stratonikov	fac595bbdf	core: remove old storage items asynchronously Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-11-24 16:25:11 +03:00
Evgeniy Stratonikov	582d489c90	dao: add `P2PStateExchangeExtensions` setting to `dao.Version` Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-11-24 16:22:27 +03:00
Evgeniy Stratonikov	f1767f361d	dao: add `KeepOnlyLatestState` setting to `dao.Version` Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-11-24 16:22:27 +03:00
Evgeniy Stratonikov	f7e2d3d717	dao: add stateroot-related settings to `Version` Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-11-24 16:22:27 +03:00
Evgeniy Stratonikov	856e9cf67b	statesync: copy state by swapping prefix Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-11-24 16:22:27 +03:00
Evgeniy Stratonikov	6c5a7d9b29	dao: include settings in `Version` Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-11-24 16:22:26 +03:00
Evgeniy Stratonikov	856385b106	dao: use custom storage prefix We use 2 prefixes for storing items because of state synchronization. This commit allows to parametrize dao with the default prefix. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-11-24 16:22:07 +03:00
Roman Khimov	5fbe838fd4	core: add and use synchronous persist to avoid OOM `b9be892bf9` has made Persist asynchronous which is very effective in allowing the system to continue processing blocks/transactions while flushing things to disk. It at the same time is very dangerous in that if the disk is slow and it takes much time to flush KV set (more than persisting interval), there might be even bigger new KV set in MemCachedStore by the time it finishes. Even if the system immediately starts to flush this new data set it (being bigger) can take more time than the previous one. And while doing so a new data set will appear in memory, potentially again bigger than this. So we can easily end up with the system going out of control, consuming more and more memory and taking more and more time to persist a single set of data. To avoid this we need to detect such condition and just wait for Persist to really finish its job and release the resources.	2021-11-22 10:41:40 +03:00
Roman Khimov	83d0b2f465	interop: move invocation counter from VM to Context It's created for interop and used by interop, VM doesn't care.	2021-11-20 21:57:41 +03:00
Roman Khimov	29cda5112a	vm: simplify NEF loading by providing a special method Offsets are still handled outside of VM to avoid introducing manifest dependency (that's likely to be circular).	2021-11-20 21:57:41 +03:00
Roman Khimov	c53d978edd	vm: drop ParamCount from Context It's unused and it's useless.	2021-11-20 21:57:41 +03:00
Roman Khimov	765235eca3	vm: omit context parameter from Call() It's not used and should not be used to switch from contract to contract.	2021-11-20 21:57:41 +03:00
Roman Khimov	7b713762be	vm: do not increment invocation counter in Call Everywhere it matters (and that's callExFromNative() now) it's incremented already, so when we're doing Call() at the same time (and it's done to invoke `_initialize` method) we're effectively double-incrementing it.	2021-11-20 21:57:41 +03:00
Roman Khimov	a577d40de9	vm: move Jump method to the Context Because it's only relevant for execution context itself.	2021-11-20 21:57:35 +03:00
Roman Khimov	8c704a49b5	interop/contract: micro-optimize argument pushes Calling Estack() again and again is not very productive.	2021-11-19 16:26:01 +03:00
Roman Khimov	d1f4928e29	contract: drop useless code from call processing It's done already by LoadScriptWithCallingHash()	2021-11-19 16:22:30 +03:00
Roman Khimov	aa06770b3d	Merge pull request #2266 from nspcc-dev/nep-11-tracking NEP-11 tracking	2021-11-19 13:07:37 +03:00
Roman Khimov	ce9d0b22cf	*: use NEP-XX naming consistently in docs/comments Standards are NEP-11 and NEP-17, not NEP11, not NEP17, not anything else. Variable/function names of course can use whatever fits, but documents and comments should be consistent wrt this.	2021-11-19 12:58:46 +03:00
Roman Khimov	b622c1934d	core: only save token logs if there is something to save Makes no sense storing empty ones.	2021-11-18 00:09:10 +03:00
Roman Khimov	f3278ea5b2	core: reuse the transfer log buffer Make it a bit more efficient.	2021-11-18 00:09:10 +03:00
Roman Khimov	125e4231b0	core: store NEP-11 transfers, add accessor functions	2021-11-18 00:09:10 +03:00
Roman Khimov	7f40a0cfd8	state: prime token transfer info with the demand for new logs Setting NewNEPXXBatch avoids the need to get them from the database which is useful for newly tracked accounts.	2021-11-16 22:52:10 +03:00
Roman Khimov	095ed3f64e	dao: drop unused AppendNEP17Transfer()	2021-11-16 22:51:04 +03:00
Roman Khimov	c63aeb38bb	state: prepare for NEP-11 data tracking, refactor/rename There is a lot of similarity, so try reusing common code and use more neutral naming.	2021-11-16 19:18:06 +03:00
Roman Khimov	ecfe3e7247	Merge pull request #2260 from nspcc-dev/fix-notary-test-failure Fix notary test failure	2021-11-16 16:09:41 +03:00
Roman Khimov	3b08b5b19b	native: add NEP-11 tracking to management contract	2021-11-16 13:28:59 +03:00
Roman Khimov	f96d9d168e	native/interop: use oracle request signers for oracle response witness Oracle responses must use the same set of signers as oracle requests even though the transaction itself is signed by oracle nodes/contract. We can probably improve interop.Context by removing Tx field completely and adding more functionality to Container, but it's not very convenient for VerifyWitness and will require adding more stub-like methods for Block, so Tx is used for now (and we do have it in every relevant case).	2021-11-16 11:51:15 +03:00
Roman Khimov	65016e8070	core: fix data race in notary test I don't think it's possible with regular service functioning, but it happens during testing because of pointer reuse: WARNING: DATA RACE Read at 0x00c003a0e3f0 by goroutine 114: github.com/nspcc-dev/neo-go/pkg/services/notary.(Notary).verifyIncompleteWitnesses() /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:441 +0x1dc github.com/nspcc-dev/neo-go/pkg/services/notary.(Notary).OnNewRequest() /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:188 +0x205 github.com/nspcc-dev/neo-go/pkg/core.TestNotary.func11() /home/runner/work/neo-go/neo-go/pkg/core/notary_test.go:347 +0x612 github.com/nspcc-dev/neo-go/pkg/core.TestNotary() /home/runner/work/neo-go/neo-go/pkg/core/notary_test.go:443 +0xe33 testing.tRunner() /opt/hostedtoolcache/go/1.16.10/x64/src/testing/testing.go:1193 +0x202 Previous write at 0x00c003a0e3f0 by goroutine 104: github.com/nspcc-dev/neo-go/pkg/services/notary.(Notary).finalize() /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:338 +0x50a github.com/nspcc-dev/neo-go/pkg/services/notary.(Notary).PostPersist() /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:314 +0x297 github.com/nspcc-dev/neo-go/pkg/services/notary.(*Notary).Run() /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:169 +0x4a7	2021-11-15 17:33:02 +03:00
Roman Khimov	f48dffe0e6	core: fix fallback VUB value in notary test Serializing/deserializing the payload yields this: Error: Received unexpected error: both main and fallback transactions should have the same ValidUntil value	2021-11-15 17:32:14 +03:00
Roman Khimov	b31a8d750e	Merge pull request #2252 from nspcc-dev/packmap-packstruct vm: add PACKMAP/PACKSTRUCT, extend UNPACK	2021-11-12 18:25:54 +03:00
Roman Khimov	9cdd360606	Merge pull request #2251 from nspcc-dev/rules-witness-scope transaction: add new Rules witness scope	2021-11-12 18:25:39 +03:00
Roman Khimov	3e6ce3c221	vm: add PACKMAP/PACKSTRUCT, extend UNPACK See neo-project/neo-vm#443.	2021-11-12 17:19:59 +03:00
Roman Khimov	9875799893	transaction: add new Rules witness scope See neo-project/neo#2622. The implementation is somewhat asymmetric (and not very efficient) for binary/JSON encoding/decoding, but it should be sufficient.	2021-11-12 15:29:28 +03:00
Roman Khimov	0a7f8afcea	Merge pull request #2229 from nspcc-dev/contract-test Generic contract testing infrastructure	2021-11-11 11:46:55 +03:00
Evgeniy Stratonikov	ce549e4cb2	core/test: allow to determine system fee automatically Eventually this will be replaced by `pkg/neotest` invocations but for now it allows us to remove NNS constants together with the tests. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-11-11 11:15:15 +03:00
Evgeniy Stratonikov	e3625152c6	core: move NNS test out of core Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-11-11 11:15:15 +03:00
Roman Khimov	6b8e615094	Merge pull request #2234 from nspcc-dev/rpc/params-parsing rpc: method-specific parameters parsing optimisation	2021-11-10 20:45:44 +03:00
Anna Shaleva	1a32fcb2dc	core: specify `method not found` call error It's useful for debugging and external users.	2021-11-08 17:19:00 +03:00
Roman Khimov	328f8b7954	Merge pull request #2238 from nspcc-dev/fix-block-queue network: remove priority queue from block queue	2021-11-01 12:03:45 +03:00
Roman Khimov	8bb1ecb45a	network: remove priority queue from block queue Use circular buffer which is a bit more appropriate. The problem is that priority queue accepts and stores equal items which wastes memory even in normal usage scenario, but it's especially dangerous if the node is stuck for some reason. In this case it'll accept from peers and put into queue the same blocks again and again leaking memory up to OOM condition. Notice that queue length calculation might be wrong in case circular buffer wraps, but it's not very likely to happen (usually blocks not coming from the queue are added by consensus and it's not very fast in doing so).	2021-11-01 11:49:01 +03:00
Roman Khimov	67eac3a27f	Merge pull request #2196 from nspcc-dev/drop-badger-and-redis Drop Badger and Redis	2021-10-28 16:08:49 +03:00
AnnaShaleva	3fed7b8eec	core: handle empty MPT batch properly It's OK to have it.	2021-10-27 18:44:39 +03:00
Roman Khimov	1144a03486	storage: drop RedisDB, close #2130	2021-10-27 17:32:25 +03:00
Roman Khimov	fb4b87bb96	storage: drop BadgerDB support, close #2130	2021-10-27 17:31:55 +03:00
AnnaShaleva	2d196b3f35	rpc: refactor `calculatenetworkfee` handler Use (Blockchainer).VerifyWitness() to calculate network fee for contract-based witnesses.	2021-10-25 19:07:25 +03:00
Anna Shaleva	75d7891ca1	services: add ability to combine notary signers Notes for witnesses: * [N sig + M multisig + K contract] combination is possible where N, M, K >=0. * Each verification script should be properly filled in. * Each invocation script should either be empty or contain exactly one signature.	2021-10-25 12:22:13 +03:00
Roman Khimov	d551439654	Merge pull request #2193 from nspcc-dev/optimize-find core: optimise (*MemCachedStorage).Seek	2021-10-21 21:20:33 +03:00
Anna Shaleva	3450371910	core: split (*MemCachedStore) Seek and SeekAsync methods Use SeekAsync for System.Storage.Find and Seek for the rest of cases.	2021-10-21 10:05:12 +03:00
Anna Shaleva	dcda7bec63	core: squash PS-seeking and merging routines in (*MemCachedStore).Seek We don't need a separate routine to merge seek results.	2021-10-21 10:05:12 +03:00
Anna Shaleva	c88720bf45	core: remove memstore routine from (*MemCachedStore).SeekAsync It adds unnecessary overhead to computations.	2021-10-21 10:05:12 +03:00
Anna Shaleva	dfe2c667e1	core: do not hold the lock while seeking over persistent store	2021-10-21 10:05:12 +03:00
Anna Shaleva	07cbe4d253	core: add finalizer functions to interop context These functions are aimed to free the resources occupied by storage iterator by the end of script execution or whenever Finilize is called.	2021-10-21 10:05:12 +03:00
Anna Shaleva	0a4f45c9b0	core: add ability to free storage.Iterator resources	2021-10-21 10:05:12 +03:00
Anna Shaleva	89ee2e7720	core: refactor storage.Find and storage.Iterator to work with channel Add SeekAsync methods in order to fetch matching storage items on demand. Refactor storage.Find and storage.Iterator wrt these changes.	2021-10-21 10:05:12 +03:00
Anna Shaleva	f2ac07a3c0	core: do not copy key/value results got from MemCachedStore.Seek They are already copied inside the MemCachedStore.Seek, so that persistent storage can't change them anymore.	2021-10-21 10:05:12 +03:00
Anna Shaleva	72726d46d3	core: refactor callers of MemCachedStore.Seek MemCachedStore.Seek now sorts results, so its callers may omit sorting.	2021-10-21 10:05:12 +03:00
Anna Shaleva	7ba88e98e2	core: optimize (MemCachedStore).Seek operation Real persistent storage guarantees that result of Seek is sorted by keys. The idea of optimisation is to merge two sorted seek results into one (memStore+persistentStore), so that (MemCachedStore).Seek will return sorted list. The only thing that remains is to sort items got from (*MemoryStore).Seek.	2021-10-21 10:05:12 +03:00
Anna Shaleva	191cc45032	core: sort items in MemoryStore.Seek MemoryStore is used in a MemCachedStore as a persistent layer in tests. Further commits suppose that persistent storage returns sorted values from Seek, so sort the result of MemoryStore.Seek. Benchmark results for 10000 matching items in MemoryStore compared to master: name old time/op new time/op delta MemorySeek-8 712µs ± 0% 3850µs ± 0% +440.52% (p=0.000 n=8+8) name old alloc/op new alloc/op delta MemorySeek-8 160kB ± 0% 2724kB ± 0% +1602.61% (p=0.000 n=10+8) name old allocs/op new allocs/op delta MemorySeek-8 10.0k ± 0% 10.0k ± 0% +0.24% (p=0.000 n=10+10) For details on implementation efficiency see the https://github.com/nspcc-dev/neo-go/pull/2193#discussion_r722993358.	2021-10-21 10:05:12 +03:00
Anna Shaleva	d8210c0137	core: add benchmarks for iterator.Next, MemCached.Seek, Mem.Seek	2021-10-21 10:05:12 +03:00
Anna Shaleva	8d8071f97e	core: distinguish storage.KeyValue and storage.KeyValueExists We need Exists field for storage batch related code; other cases may go without Exists, so add new KeyValue structure and refactor related code.	2021-10-21 10:05:12 +03:00
Anna Shaleva	002b5a2c3c	core: add Trie.Find compatibility test	2021-10-15 10:28:08 +03:00
Anna Shaleva	495aba4174	core: try to collapse traversed Billet part on errStop	2021-10-13 14:47:59 +03:00
Anna Shaleva	892eadf86d	core: mandate passing `from` as a subprefix for (*Trie).Find However, we need to distinguish empty subprefix and nil subprefix (no start specified) to match the C# behaviour.	2021-10-13 14:47:41 +03:00
Anna Shaleva	8e7c76827b	core: optimise (Billet).Traverse and (Trie).Find (Billet).Traverse changes: 1. Get rid of the `offset` argument. We can cut `from` and pass just the part that remains. This implies that node with path matching `from` will also be included in the result, so additional check needs to be added to the callback function. 2. Pass `path` and `from` without search prefix. Append prefix to the result inside the callback. 3. Remove duplicating code. (Trie).Find changes: 1. Properly prepare `from` argument for traversing function. It closly depends on the `path` argument.	2021-10-13 13:52:33 +03:00
Anna Shaleva	43ac4e1517	rpc: implement `findstates` RPC handler	2021-10-13 11:41:05 +03:00
Anna Shaleva	7da394fd3f	core: check MPT node is not requested twice by StateSync module This check prevents infinite loop if something goes wrong with MPT nodes restore process.	2021-10-12 14:08:56 +03:00
Anna Shaleva	01143da621	rpc: add `getstate` RPC handler	2021-10-11 16:43:44 +03:00
Anna Shaleva	c8120a139d	core: add MaxKeyLength restrictions to MPT's operations	2021-10-06 16:37:23 +03:00
Evgeniy Stratonikov	e6aa9b76ee	mempool: reword `ErrConflict` message, fix #2197 Make it more user-friendly. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-09-28 09:57:42 +03:00
Anna Shaleva	b3ea7504cb	subscriptions: add container hash to notification event External users make use of it. Close #2190.	2021-09-24 17:42:02 +03:00
Roman Khimov	c009356b73	core: simplify component flushing in storeBlock Instead of flushing everything to `cache` and then to `bc.dao`, wrap `bc.dao` directly for block/tx data and AERs and then flush to it. Block/transactions are usually processed more quickly than other components, so they easily end up in `cache` where they directly affect Seek performance for any executing transaction. Simple as it is this change improves voter NEO transfer benchmark with 1000 accounts by more than 25%, from ~18500 TPS to ~23500 TPS. It doesn't affect much other cases.	2021-09-22 17:15:12 +03:00
Roman Khimov	b66bc33cf9	native: short-circuit successive GAS distributions GAS can only be distributed once in a block for particular address, so it makes little sense trying to calculate it again and again. This fixes neo-bench for NEO voter, because without it we get ~2500 TPS for single-address test and with it it jumps 13-fold to normal values like ~33500.	2021-09-22 17:13:55 +03:00
Anna Shaleva	06d3c21e3f	core: remove unused interopnames	2021-09-21 16:43:09 +03:00
Roman Khimov	4743d5aacf	Merge pull request #2181 from nspcc-dev/states-diff_testnet_289026 core: fix NEO balance state handler	2021-09-21 15:39:37 +03:00
Anna Shaleva	c113d682bd	core: fix NEO balance state handler We need to store NEO balance's LastUpdateHeight before GAS mint, because mint can call onNEP17Payment and onNEP17Payment can call NEO transfer which also calls GAS mint. Storing balance height allows to avoid recursion.	2021-09-20 19:23:35 +03:00
Roman Khimov	56dd7b7364	Merge pull request #2177 from nspcc-dev/fix-lint Replace golint with revive	2021-09-15 17:59:04 +03:00
Roman Khimov	1480e29548	Merge pull request #2178 from nspcc-dev/fix-oracle-unsupported-code transaction: fix ContentTypeNotSupported oracle code processing	2021-09-14 18:01:40 +03:00
Roman Khimov	24a3cce1ca	Merge pull request #2169 from nspcc-dev/states-diff_mainnet_131795 core: allow transfer 0 GAS/NEO with zero balance	2021-09-14 17:30:41 +03:00
Roman Khimov	8a440a4016	transaction: fix ContentTypeNotSupported oracle code processing Fix testnet block 311487 block processing and synchronization errors: 2021-09-14T15:18:53.611+0300 WARN peer disconnected {"addr": "20.198.226.132:20333", "reason": "invalid oracle response code", "peerCount": 10} Fix `8e9302f40b`.	2021-09-14 15:18:38 +03:00
Evgeniy Stratonikov	176b61e317	*: fix linter issues Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-09-14 14:39:39 +03:00
Roman Khimov	63e00ac128	Merge pull request #2166 from nspcc-dev/fix-nns-compat Fix NNS compatibility	2021-09-10 18:10:17 +03:00
Anna Shaleva	7fc57c9d58	core: allow transfer 0 GAS/NEO with zero balance This commit fixes states diff at 131795 block of mainnet. Transaction: ``` NEO-GO-VM > loadbase64 DAAQDBSPsxdYh6cITC3gUKI4oWmYxJs49gwUj7MXWIenCEwt4FCiOKFpmMSbOPYUwB8MCHRyYW5zZmVyDBT1Y+pAvCg9TQ4FxI6jBbPyoHNA70FifVtSOQwAEQwUj7MXWIenCEwt4FCiOKFpmMSbOPYMFL1Mb4Fqp6gHiEwzM6xSc8fLS+RpFMAfDAh0cmFuc2ZlcgwU9WPqQLwoPU0OBcSOowWz8qBzQO9BYn1bUjk= READY: loaded 176 instructions NEO-GO-VM 0 > ops INDEX OPCODE PARAMETER 0 PUSHDATA1 ("") << 2 PUSH0 3 PUSHDATA1 8fb3175887a7084c2de050a238a16998c49b38f6 25 PUSHDATA1 8fb3175887a7084c2de050a238a16998c49b38f6 47 PUSH4 48 PACK 49 PUSH15 50 PUSHDATA1 7472616e73666572 ("transfer") 60 PUSHDATA1 f563ea40bc283d4d0e05c48ea305b3f2a07340ef // NEO token 82 SYSCALL System.Contract.Call (627d5b52) 87 ASSERT 88 PUSHDATA1 ("") 90 PUSH1 91 PUSHDATA1 8fb3175887a7084c2de050a238a16998c49b38f6 113 PUSHDATA1 bd4c6f816aa7a807884c3333ac5273c7cb4be469 135 PUSH4 136 PACK 137 PUSH15 138 PUSHDATA1 7472616e73666572 ("transfer") 148 PUSHDATA1 f563ea40bc283d4d0e05c48ea305b3f2a07340ef // NEO token 170 SYSCALL System.Contract.Call (627d5b52) 175 ASSERT ``` Go's applog: ``` { "id" : 1, "result" : { "txid" : "0x97d2ccb01467b22c73a2cb95f7af298f3a5bd8c849d7044371898b8efecdaabd", "executions" : [ { "exception" : "at instruction 87 (ASSERT): ASSERT failed", "stack" : [], "gasconsumed" : "4988995", "notifications" : [], "trigger" : "Application", "vmstate" : "FAULT" } ] }, "jsonrpc" : "2.0" } ``` C#'s applog: ``` { "jsonrpc" : "2.0", "result" : { "executions" : [ { "stack" : [], "notifications" : [ { "contract" : "0xef4073a0f2b305a38ec4050e4d3d28bc40ea63f5", "state" : { "type" : "Array", "value" : [ { "type" : "ByteString", "value" : "j7MXWIenCEwt4FCiOKFpmMSbOPY=" }, { "type" : "ByteString", "value" : "j7MXWIenCEwt4FCiOKFpmMSbOPY=" }, { "value" : "0", "type" : "Integer" } ] }, "eventname" : "Transfer" }, { "contract" : "0xd2a4cff31913016155e38e474a2c06d08be276cf", "state" : { "value" : [ { "type" : "Any" }, { "type" : "ByteString", "value" : "vUxvgWqnqAeITDMzrFJzx8tL5Gk=" }, { "value" : "2490", "type" : "Integer" } ], "type" : "Array" }, "eventname" : "Transfer" }, { "contract" : "0xef4073a0f2b305a38ec4050e4d3d28bc40ea63f5", "state" : { "value" : [ { "value" : "vUxvgWqnqAeITDMzrFJzx8tL5Gk=", "type" : "ByteString" }, { "value" : "j7MXWIenCEwt4FCiOKFpmMSbOPY=", "type" : "ByteString" }, { "value" : "1", "type" : "Integer" } ], "type" : "Array" }, "eventname" : "Transfer" } ], "vmstate" : "HALT", "gasconsumed" : "9977990", "trigger" : "Application", "exception" : null } ], "txid" : "0x97d2ccb01467b22c73a2cb95f7af298f3a5bd8c849d7044371898b8efecdaabd" }, "id" : 1 } ```	2021-09-10 17:18:09 +03:00
Roman Khimov	aaccf748ac	nft-nd-nns: add getAllRecords method See neo-project/non-native-contracts#5.	2021-09-10 16:30:45 +03:00
Anna Shaleva	61fd7bd6ba	core: avoid `nil` values during natives manifest marshalling	2021-09-10 11:38:59 +03:00
Anna Shaleva	db13362e86	core: marshal Block.Nonce in upper-case hex	2021-09-09 15:52:51 +03:00
Anna Shaleva	51c8c0d82b	core: add tests for StateSync module	2021-09-07 19:43:27 +03:00
Anna Shaleva	0aedfd0038	core: fix bug in MPT pool during Update We need to copy the result of `TryGet` method, otherwice the slice can be modified inside `Add` or `Update` methods, which leads to inconsistent MPT pool state.	2021-09-07 19:43:27 +03:00
Anna Shaleva	36808b8904	core: clone MPT node while restoring it multiple times We need this to avoid collapse collisions. Example of such collapse described in https://github.com/nspcc-dev/neo-go/pull/2019#discussion_r689629704.	2021-09-07 19:43:27 +03:00
Anna Shaleva	5cd78c31af	core: allow to recover after state jump interruption We need several stages to manage state jump process in order not to mess up old and new contract storage items and to be sure about genesis state data are properly removed from the storage. Other operations do not require separate stage and can be performed each time `jumpToStateInternal` is called.	2021-09-07 19:43:27 +03:00
Anna Shaleva	5cda24b3af	core: initialize headers before current block	2021-09-07 19:43:27 +03:00
Anna Shaleva	0e0b55350a	core: convert (Blockchain).JumpToState to a callback We don't need this method to be exposed, the only its user is the StateSync module. At the same time StateSync module manages its state by itself which guarantees that (Blockchain).jumpToState will be called with proper StateSync stage.	2021-09-07 19:43:27 +03:00
Anna Shaleva	6381173293	core: store statesync-related storage items under temp prefix State jump should be an atomic operation, we can't modify contract storage items state on-the-fly. Thus, store fresh items under temp prefix and replase the outdated ones after state sync is completed. Related https://github.com/nspcc-dev/neo-go/pull/2019#discussion_r693350460.	2021-09-07 19:43:27 +03:00
Anna Shaleva	51f405471e	core: remove outdated blocks/txs/AERs/MPT nodes during state sync Before state sync process can be started, outdated MPT nodes should be removed from storage. After state sync is completed, outdated blocks/transactions/AERs should also be removed.	2021-09-07 19:43:27 +03:00
Anna Shaleva	a276a85b72	core: unify code of state sync module initialization	2021-09-07 19:43:27 +03:00
Anna Shaleva	3b7807e897	network: request unknown MPT nodes In this commit: 1. Request unknown MPT nodes from peers. Note, that StateSync module itself shouldn't be responsible for nodes requests, that's a server duty. 2. Do not request the same node twice, check if it is in storage already. If so, then the only thing remaining is to update refcounter.	2021-09-07 19:43:27 +03:00
Anna Shaleva	6a04880b49	core: collapse completed parts of Billet Some kind of marker is needed to check whether node has been collapsed or not. So introduce (HashNode).Collapsed	2021-09-07 19:43:27 +03:00
Anna Shaleva	74f1848d19	core: adjust LastUpdatedBlock calculation for NEP17 balances ...wrt P2PStateExchange setting.	2021-09-07 19:43:27 +03:00
Anna Shaleva	d67ff30704	core: implement statesync module And support GetMPTData and MPTData P2P commands.	2021-09-07 19:43:27 +03:00
Anna Shaleva	a22b1caa3e	core: implement MPT Billet structure for MPT restore MPT restore process is much simpler then regular MPT maintaining: trie has a fixed structure, we don't need to remove or rebuild MPT nodes. The only thing we should do is to replace Hash nodes to their unhashed counterparts and increment refcount. It's better not to touch the regular MPT code and create a separate structure for this.	2021-09-07 19:43:27 +03:00
Roman Khimov	c9e62769a6	Merge pull request #2143 from nspcc-dev/mpt/add_empty_values core: allow empty MPT Leaf values	2021-09-07 09:18:48 +03:00
Anna Shaleva	c95f2079d5	core: adjust comments on behaviour defferences for MPT TestCompatibility C# node does not return empty proof enymore in case if path is bad. C# node also throws an exception on bad Put. Our node does not return an error on delete if the key is empty.	2021-09-03 13:46:52 +03:00
Anna Shaleva	f721384ead	core: allow empty MPT Leaf values Allow it for (Trie).Put. And distinguish empty value and nil value for (Trie).PutBatch, because batch is already capable of handling both nil and empty value. For (*Trie).PutBatch putting nil value means deletion, while putting empty value means just putting LeafNode with an empty value.	2021-09-03 13:46:48 +03:00
Evgeniy Stratonikov	7371593bdc	native/policy: disallow blocking native contracts Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-09-03 11:11:06 +03:00
Roman Khimov	b07347e602	core: reuse PushItem for interops Probably less critical here, but still let's push things faster.	2021-08-30 23:43:58 +03:00
Roman Khimov	7b9558d756	Merge pull request #2142 from nspcc-dev/fix-customgroups-witness-scope runtime: fix CustomGroups witness	2021-08-26 18:13:08 +03:00
Roman Khimov	734eef3290	Merge pull request #2147 from nspcc-dev/drop-go-1.14 Drop Go 1.14, use 1.17	2021-08-26 17:59:21 +03:00
Roman Khimov	6d074a96e9	*: make tests use TempDir(), fix #1319 Simplify things, drop TempFile at the same time (refs. #1764)	2021-08-26 17:29:40 +03:00
Roman Khimov	40c6c065d2	Merge pull request #2140 from nspcc-dev/vm-optimize-stack Optimize VM stack	2021-08-26 10:31:31 +03:00
Roman Khimov	de4ed7d020	runtime: fix CustomGroups witness See neo-project/neo#2586.	2021-08-24 15:50:24 +03:00
Roman Khimov	930653418d	vm: rework stack as a simple slice Double-linked list is quite expensive to manage especially given that it requires microallocations for each Element. It can be replaced by simple slice which is much more effective for simple push/pop operations that are very typical in a VM. I've worried a little about more complex operations like XDROP/1024 or REVERSEN/1024 because these require copying quite substantial number of elements, but turns out these work fine too. At the moment Element is kept as a convenient wrapper for Bytes/BigInt/Bool/etc methods, but it can be changed in future. Many other potential optimizations are also possible now. Complex scripts: name old time/op new time/op delta ScriptFibonacci-8 1.11ms ± 2% 0.85ms ± 2% -23.40% (p=0.000 n=10+10) ScriptNestedRefCount-8 1.46ms ± 2% 1.16ms ± 1% -20.65% (p=0.000 n=10+10) ScriptPushPop/4-8 1.81µs ± 1% 1.54µs ± 4% -14.96% (p=0.000 n=8+10) ScriptPushPop/16-8 4.88µs ± 2% 3.91µs ± 2% -19.87% (p=0.000 n=9+9) ScriptPushPop/128-8 31.9µs ± 9% 26.7µs ± 3% -16.28% (p=0.000 n=9+8) ScriptPushPop/1024-8 235µs ± 1% 192µs ± 3% -18.31% (p=0.000 n=9+10) name old alloc/op new alloc/op delta ScriptFibonacci-8 392kB ± 0% 123kB ± 0% -68.68% (p=0.000 n=8+8) ScriptNestedRefCount-8 535kB ± 0% 266kB ± 0% -50.38% (p=0.000 n=6+10) ScriptPushPop/4-8 352B ± 0% 160B ± 0% -54.55% (p=0.000 n=10+10) ScriptPushPop/16-8 1.41kB ± 0% 0.64kB ± 0% -54.55% (p=0.000 n=10+10) ScriptPushPop/128-8 11.3kB ± 0% 8.7kB ± 0% -22.73% (p=0.000 n=10+10) ScriptPushPop/1024-8 90.1kB ± 0% 73.2kB ± 0% -18.75% (p=0.000 n=10+10) name old allocs/op new allocs/op delta ScriptFibonacci-8 9.14k ± 0% 3.53k ± 0% -61.41% (p=0.000 n=10+10) ScriptNestedRefCount-8 17.4k ± 0% 11.8k ± 0% -32.35% (p=0.000 n=10+10) ScriptPushPop/4-8 12.0 ± 0% 8.0 ± 0% -33.33% (p=0.000 n=10+10) ScriptPushPop/16-8 48.0 ± 0% 32.0 ± 0% -33.33% (p=0.000 n=10+10) ScriptPushPop/128-8 384 ± 0% 259 ± 0% -32.55% (p=0.000 n=10+10) ScriptPushPop/1024-8 3.07k ± 0% 2.05k ± 0% -33.14% (p=0.000 n=10+10) Some stack-management opcodes: name old time/op new time/op delta Opcodes/XDROP/0/1-8 255ns ± 9% 273ns ±11% +6.92% (p=0.016 n=11+10) Opcodes/XDROP/0/1024-8 362ns ± 2% 365ns ± 8% ~ (p=0.849 n=10+11) Opcodes/XDROP/1024/1024-8 3.20µs ± 2% 1.99µs ±12% -37.69% (p=0.000 n=11+11) Opcodes/XDROP/2047/2048-8 6.55µs ± 3% 1.75µs ± 5% -73.26% (p=0.000 n=10+11) Opcodes/DUP/null-8 414ns ± 6% 245ns ±12% -40.88% (p=0.000 n=11+11) Opcodes/DUP/boolean-8 411ns ± 8% 245ns ± 6% -40.31% (p=0.000 n=11+11) Opcodes/DUP/integer/small-8 684ns ± 8% 574ns ± 3% -16.02% (p=0.000 n=11+10) Opcodes/DUP/integer/big-8 675ns ± 6% 601ns ±10% -10.98% (p=0.000 n=11+11) Opcodes/DUP/bytearray/small-8 675ns ±10% 566ns ±10% -16.22% (p=0.000 n=11+11) Opcodes/DUP/bytearray/big-8 6.39µs ±11% 6.13µs ± 3% ~ (p=0.148 n=10+10) Opcodes/DUP/buffer/small-8 412ns ± 5% 261ns ± 8% -36.55% (p=0.000 n=9+11) Opcodes/DUP/buffer/big-8 586ns ±10% 337ns ± 7% -42.53% (p=0.000 n=11+11) Opcodes/DUP/struct/small-8 458ns ±12% 256ns ±12% -44.09% (p=0.000 n=11+11) Opcodes/DUP/struct/big-8 489ns ± 7% 274ns ± 5% -44.06% (p=0.000 n=10+10) Opcodes/DUP/pointer-8 586ns ± 7% 494ns ± 7% -15.67% (p=0.000 n=11+11) Opcodes/OVER/null-8 450ns ±14% 264ns ±10% -41.30% (p=0.000 n=11+11) Opcodes/OVER/boolean-8 450ns ±14% 264ns ±10% -41.31% (p=0.000 n=11+11) Opcodes/OVER/integer/small-8 716ns ± 9% 604ns ± 6% -15.65% (p=0.000 n=11+11) Opcodes/OVER/integer/big-8 696ns ± 5% 634ns ± 6% -8.89% (p=0.000 n=10+11) Opcodes/OVER/bytearray/small-8 693ns ± 1% 539ns ± 9% -22.18% (p=0.000 n=9+10) Opcodes/OVER/bytearray/big-8 6.33µs ± 2% 6.16µs ± 4% -2.79% (p=0.004 n=8+10) Opcodes/OVER/buffer/small-8 415ns ± 4% 263ns ± 8% -36.76% (p=0.000 n=9+11) Opcodes/OVER/buffer/big-8 587ns ± 5% 342ns ± 7% -41.70% (p=0.000 n=11+11) Opcodes/OVER/struct/small-8 446ns ±14% 257ns ± 8% -42.42% (p=0.000 n=11+11) Opcodes/OVER/struct/big-8 607ns ±26% 278ns ± 7% -54.25% (p=0.000 n=11+11) Opcodes/OVER/pointer-8 645ns ±12% 476ns ±10% -26.21% (p=0.000 n=11+11) Opcodes/PICK/2/null-8 460ns ±11% 264ns ± 9% -42.68% (p=0.000 n=11+11) Opcodes/PICK/2/boolean-8 460ns ± 4% 260ns ± 4% -43.37% (p=0.000 n=8+11) Opcodes/PICK/2/integer/small-8 725ns ± 7% 557ns ± 4% -23.19% (p=0.000 n=11+10) Opcodes/PICK/2/integer/big-8 722ns ±12% 582ns ± 6% -19.51% (p=0.000 n=11+11) Opcodes/PICK/2/bytearray/small-8 705ns ± 6% 545ns ± 4% -22.69% (p=0.000 n=11+11) Opcodes/PICK/2/bytearray/big-8 7.17µs ±36% 6.37µs ± 8% ~ (p=0.065 n=11+11) Opcodes/PICK/2/buffer/small-8 427ns ± 8% 253ns ± 8% -40.82% (p=0.000 n=11+11) Opcodes/PICK/2/buffer/big-8 590ns ± 3% 331ns ± 6% -43.83% (p=0.000 n=11+11) Opcodes/PICK/2/struct/small-8 428ns ± 8% 254ns ± 7% -40.64% (p=0.000 n=11+11) Opcodes/PICK/2/struct/big-8 489ns ±15% 283ns ± 7% -42.11% (p=0.000 n=11+11) Opcodes/PICK/2/pointer-8 553ns ± 7% 414ns ± 8% -25.18% (p=0.000 n=11+11) Opcodes/PICK/1024/null-8 531ns ± 4% 327ns ± 6% -38.49% (p=0.000 n=10+10) Opcodes/PICK/1024/boolean-8 527ns ± 5% 318ns ± 5% -39.78% (p=0.000 n=11+9) Opcodes/PICK/1024/integer/small-8 861ns ± 4% 683ns ± 4% -20.66% (p=0.000 n=11+11) Opcodes/PICK/1024/integer/big-8 882ns ± 4% 1060ns ±47% ~ (p=0.748 n=11+11) Opcodes/PICK/1024/bytearray/small-8 850ns ± 4% 671ns ± 5% -21.12% (p=0.000 n=10+11) Opcodes/PICK/1024/bytearray/big-8 6.32µs ±26% 6.75µs ± 4% +6.86% (p=0.019 n=10+11) Opcodes/PICK/1024/buffer/small-8 530ns ± 6% 324ns ± 5% -38.86% (p=0.000 n=10+11) Opcodes/PICK/1024/buffer/big-8 570ns ± 4% 417ns ±45% -26.82% (p=0.001 n=11+10) Opcodes/PICK/1024/struct/small-8 1.11µs ±122% 0.34µs ±11% -69.38% (p=0.000 n=11+10) Opcodes/PICK/1024/pointer-8 693ns ± 5% 568ns ±31% -18.10% (p=0.002 n=10+10) Opcodes/TUCK/null-8 450ns ±10% 275ns ± 8% -38.93% (p=0.000 n=11+11) Opcodes/TUCK/boolean-8 449ns ±13% 268ns ± 9% -40.16% (p=0.000 n=11+10) Opcodes/TUCK/integer/small-8 716ns ± 7% 599ns ± 7% -16.30% (p=0.000 n=11+11) Opcodes/TUCK/integer/big-8 718ns ± 8% 613ns ±11% -14.55% (p=0.000 n=11+11) Opcodes/TUCK/bytearray/small-8 700ns ±12% 558ns ± 7% -20.39% (p=0.000 n=11+11) Opcodes/TUCK/bytearray/big-8 5.88µs ± 7% 6.37µs ± 3% +8.31% (p=0.000 n=10+11) Opcodes/TUCK/buffer/small-8 425ns ± 6% 258ns ±12% -39.28% (p=0.000 n=11+11) Opcodes/TUCK/buffer/big-8 553ns ±19% 334ns ± 6% -39.57% (p=0.000 n=11+11) Opcodes/TUCK/struct/small-8 474ns ± 3% 263ns ±12% -44.51% (p=0.000 n=10+11) Opcodes/TUCK/struct/big-8 641ns ±24% 284ns ± 8% -55.63% (p=0.000 n=11+11) Opcodes/TUCK/pointer-8 635ns ±13% 468ns ±16% -26.31% (p=0.000 n=11+11) Opcodes/SWAP/null-8 227ns ±31% 212ns ±11% ~ (p=0.847 n=11+11) Opcodes/SWAP/integer-8 233ns ±32% 210ns ±14% ~ (p=0.072 n=10+11) Opcodes/SWAP/big_bytes-8 263ns ±39% 211ns ±11% ~ (p=0.056 n=11+11) Opcodes/ROT/null-8 308ns ±68% 223ns ±12% ~ (p=0.519 n=11+11) Opcodes/ROT/integer-8 226ns ±25% 228ns ± 9% ~ (p=0.705 n=10+11) Opcodes/ROT/big_bytes-8 215ns ±18% 218ns ± 7% ~ (p=0.756 n=10+11) Opcodes/ROLL/4/null-8 269ns ±10% 295ns ± 9% +9.42% (p=0.002 n=10+11) Opcodes/ROLL/4/integer-8 344ns ±48% 280ns ± 2% ~ (p=0.882 n=11+9) Opcodes/ROLL/4/big_bytes-8 276ns ±13% 288ns ± 4% +4.38% (p=0.046 n=9+11) Opcodes/ROLL/1024/null-8 4.21µs ±70% 1.01µs ± 9% -76.15% (p=0.000 n=11+11) Opcodes/ROLL/1024/integer-8 4.78µs ±82% 0.71µs ± 3% -85.06% (p=0.000 n=11+11) Opcodes/ROLL/1024/big_bytes-8 3.28µs ± 5% 1.35µs ±36% -58.91% (p=0.000 n=9+11) Opcodes/REVERSE3/null-8 219ns ± 9% 224ns ± 9% ~ (p=0.401 n=11+11) Opcodes/REVERSE3/integer-8 261ns ±28% 220ns ± 6% -15.67% (p=0.015 n=11+11) Opcodes/REVERSE3/big_bytes-8 245ns ±31% 218ns ± 7% ~ (p=0.051 n=10+11) Opcodes/REVERSE4/null-8 223ns ±10% 218ns ± 6% ~ (p=0.300 n=11+11) Opcodes/REVERSE4/integer-8 233ns ±10% 220ns ± 7% -5.74% (p=0.016 n=11+11) Opcodes/REVERSE4/big_bytes-8 225ns ±10% 220ns ± 7% ~ (p=0.157 n=10+11) Opcodes/REVERSEN/5/null-8 281ns ±12% 277ns ± 4% ~ (p=0.847 n=11+11) Opcodes/REVERSEN/5/integer-8 280ns ±11% 275ns ± 5% ~ (p=0.243 n=11+11) Opcodes/REVERSEN/5/big_bytes-8 283ns ± 9% 276ns ± 7% ~ (p=0.133 n=11+11) Opcodes/REVERSEN/1024/null-8 4.85µs ± 6% 1.94µs ± 6% -60.07% (p=0.000 n=10+11) Opcodes/REVERSEN/1024/integer-8 4.97µs ± 7% 1.99µs ±22% -59.88% (p=0.000 n=11+11) Opcodes/REVERSEN/1024/big_bytes-8 5.11µs ±10% 2.00µs ± 4% -60.87% (p=0.000 n=10+9) Opcodes/PACK/1-8 1.22µs ± 7% 0.95µs ± 6% -22.17% (p=0.000 n=10+11) Opcodes/PACK/255-8 11.1µs ± 4% 10.2µs ± 6% -7.96% (p=0.000 n=11+11) Opcodes/PACK/1024-8 38.9µs ± 4% 37.4µs ± 9% ~ (p=0.173 n=10+11) Opcodes/UNPACK/1-8 1.32µs ±34% 0.96µs ± 6% -27.57% (p=0.000 n=10+11) Opcodes/UNPACK/255-8 27.2µs ±14% 16.0µs ±13% -41.04% (p=0.000 n=11+11) Opcodes/UNPACK/1024-8 102µs ±10% 64µs ±16% -37.33% (p=0.000 n=10+11) name old alloc/op new alloc/op delta Opcodes/XDROP/0/1-8 0.00B 0.00B ~ (all equal) Opcodes/XDROP/0/1024-8 0.00B 0.00B ~ (all equal) Opcodes/XDROP/1024/1024-8 0.00B 0.00B ~ (all equal) Opcodes/XDROP/2047/2048-8 0.00B 0.00B ~ (all equal) Opcodes/DUP/null-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/DUP/boolean-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/DUP/integer/small-8 96.0B ± 0% 48.0B ± 0% -50.00% (p=0.000 n=11+11) Opcodes/DUP/integer/big-8 104B ± 0% 56B ± 0% -46.15% (p=0.000 n=11+11) Opcodes/DUP/bytearray/small-8 88.0B ± 0% 40.0B ± 0% -54.55% (p=0.000 n=11+11) Opcodes/DUP/bytearray/big-8 65.6kB ± 0% 65.6kB ± 0% -0.07% (p=0.000 n=10+9) Opcodes/DUP/buffer/small-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/DUP/buffer/big-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/DUP/struct/small-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/DUP/struct/big-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/DUP/pointer-8 112B ± 0% 64B ± 0% -42.86% (p=0.000 n=11+11) Opcodes/OVER/null-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/OVER/boolean-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/OVER/integer/small-8 96.0B ± 0% 48.0B ± 0% -50.00% (p=0.000 n=11+11) Opcodes/OVER/integer/big-8 104B ± 0% 56B ± 0% -46.15% (p=0.000 n=11+11) Opcodes/OVER/bytearray/small-8 88.0B ± 0% 40.0B ± 0% -54.55% (p=0.000 n=11+11) Opcodes/OVER/bytearray/big-8 65.6kB ± 0% 65.6kB ± 0% -0.07% (p=0.000 n=9+11) Opcodes/OVER/buffer/small-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/OVER/buffer/big-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/OVER/struct/small-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/OVER/struct/big-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/OVER/pointer-8 112B ± 0% 64B ± 0% -42.86% (p=0.000 n=11+11) Opcodes/PICK/2/null-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/PICK/2/boolean-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/PICK/2/integer/small-8 96.0B ± 0% 48.0B ± 0% -50.00% (p=0.000 n=11+11) Opcodes/PICK/2/integer/big-8 104B ± 0% 56B ± 0% -46.15% (p=0.000 n=11+11) Opcodes/PICK/2/bytearray/small-8 88.0B ± 0% 40.0B ± 0% -54.55% (p=0.000 n=11+11) Opcodes/PICK/2/bytearray/big-8 65.6kB ± 0% 65.6kB ± 0% -0.07% (p=0.001 n=9+11) Opcodes/PICK/2/buffer/small-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/PICK/2/buffer/big-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/PICK/2/struct/small-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/PICK/2/struct/big-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/PICK/2/pointer-8 112B ± 0% 64B ± 0% -42.86% (p=0.000 n=11+11) Opcodes/PICK/1024/null-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/PICK/1024/boolean-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/PICK/1024/integer/small-8 96.0B ± 0% 48.0B ± 0% -50.00% (p=0.000 n=11+11) Opcodes/PICK/1024/integer/big-8 104B ± 0% 56B ± 0% -46.15% (p=0.000 n=11+11) Opcodes/PICK/1024/bytearray/small-8 88.0B ± 0% 40.0B ± 0% -54.55% (p=0.000 n=11+11) Opcodes/PICK/1024/bytearray/big-8 65.6kB ± 0% 65.6kB ± 0% -0.07% (p=0.000 n=11+11) Opcodes/PICK/1024/buffer/small-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/PICK/1024/buffer/big-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/PICK/1024/struct/small-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/PICK/1024/pointer-8 112B ± 0% 64B ± 0% -42.86% (p=0.000 n=11+11) Opcodes/TUCK/null-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/TUCK/boolean-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/TUCK/integer/small-8 96.0B ± 0% 48.0B ± 0% -50.00% (p=0.000 n=11+11) Opcodes/TUCK/integer/big-8 104B ± 0% 56B ± 0% -46.15% (p=0.000 n=11+11) Opcodes/TUCK/bytearray/small-8 88.0B ± 0% 40.0B ± 0% -54.55% (p=0.000 n=11+11) Opcodes/TUCK/bytearray/big-8 65.6kB ± 0% 65.6kB ± 0% -0.07% (p=0.000 n=10+11) Opcodes/TUCK/buffer/small-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/TUCK/buffer/big-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/TUCK/struct/small-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/TUCK/struct/big-8 48.0B ± 0% 0.0B -100.00% (p=0.000 n=11+11) Opcodes/TUCK/pointer-8 112B ± 0% 64B ± 0% -42.86% (p=0.000 n=11+11) Opcodes/SWAP/null-8 0.00B 0.00B ~ (all equal) Opcodes/SWAP/integer-8 0.00B 0.00B ~ (all equal) Opcodes/SWAP/big_bytes-8 0.00B 0.00B ~ (all equal) Opcodes/ROT/null-8 0.00B 0.00B ~ (all equal) Opcodes/ROT/integer-8 0.00B 0.00B ~ (all equal) Opcodes/ROT/big_bytes-8 0.00B 0.00B ~ (all equal) Opcodes/ROLL/4/null-8 0.00B 0.00B ~ (all equal) Opcodes/ROLL/4/integer-8 0.00B 0.00B ~ (all equal) Opcodes/ROLL/4/big_bytes-8 0.00B 0.00B ~ (all equal) Opcodes/ROLL/1024/null-8 0.00B 0.00B ~ (all equal) Opcodes/ROLL/1024/integer-8 0.00B 0.00B ~ (all equal) Opcodes/ROLL/1024/big_bytes-8 0.00B 0.00B ~ (all equal) Opcodes/REVERSE3/null-8 0.00B 0.00B ~ (all equal) Opcodes/REVERSE3/integer-8 0.00B 0.00B ~ (all equal) Opcodes/REVERSE3/big_bytes-8 0.00B 0.00B ~ (all equal) Opcodes/REVERSE4/null-8 0.00B 0.00B ~ (all equal) Opcodes/REVERSE4/integer-8 0.00B 0.00B ~ (all equal) Opcodes/REVERSE4/big_bytes-8 0.00B 0.00B ~ (all equal) Opcodes/REVERSEN/5/null-8 0.00B 0.00B ~ (all equal) Opcodes/REVERSEN/5/integer-8 0.00B 0.00B ~ (all equal) Opcodes/REVERSEN/5/big_bytes-8 0.00B 0.00B ~ (all equal) Opcodes/REVERSEN/1024/null-8 0.00B 0.00B ~ (all equal) Opcodes/REVERSEN/1024/integer-8 0.00B 0.00B ~ (all equal) Opcodes/REVERSEN/1024/big_bytes-8 0.00B 0.00B ~ (all equal) Opcodes/PACK/1-8 144B ± 0% 96B ± 0% -33.33% (p=0.000 n=11+11) Opcodes/PACK/255-8 4.22kB ± 0% 4.18kB ± 0% -1.14% (p=0.000 n=11+11) Opcodes/PACK/1024-8 16.5kB ± 0% 16.5kB ± 0% -0.29% (p=0.000 n=11+11) Opcodes/UNPACK/1-8 168B ± 0% 72B ± 0% -57.14% (p=0.000 n=11+11) Opcodes/UNPACK/255-8 12.4kB ± 0% 7.8kB ± 0% -37.28% (p=0.000 n=11+11) Opcodes/UNPACK/1024-8 49.3kB ± 0% 52.8kB ± 0% +7.18% (p=0.000 n=11+11) name old allocs/op new allocs/op delta Opcodes/XDROP/0/1-8 0.00 0.00 ~ (all equal) Opcodes/XDROP/0/1024-8 0.00 0.00 ~ (all equal) Opcodes/XDROP/1024/1024-8 0.00 0.00 ~ (all equal) Opcodes/XDROP/2047/2048-8 0.00 0.00 ~ (all equal) Opcodes/DUP/null-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/DUP/boolean-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/DUP/integer/small-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/DUP/integer/big-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/DUP/bytearray/small-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/DUP/bytearray/big-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/DUP/buffer/small-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/DUP/buffer/big-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/DUP/struct/small-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/DUP/struct/big-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/DUP/pointer-8 2.00 ± 0% 1.00 ± 0% -50.00% (p=0.000 n=11+11) Opcodes/OVER/null-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/OVER/boolean-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/OVER/integer/small-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/OVER/integer/big-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/OVER/bytearray/small-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/OVER/bytearray/big-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/OVER/buffer/small-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/OVER/buffer/big-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/OVER/struct/small-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/OVER/struct/big-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/OVER/pointer-8 2.00 ± 0% 1.00 ± 0% -50.00% (p=0.000 n=11+11) Opcodes/PICK/2/null-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/PICK/2/boolean-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/PICK/2/integer/small-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/PICK/2/integer/big-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/PICK/2/bytearray/small-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/PICK/2/bytearray/big-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/PICK/2/buffer/small-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/PICK/2/buffer/big-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/PICK/2/struct/small-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/PICK/2/struct/big-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/PICK/2/pointer-8 2.00 ± 0% 1.00 ± 0% -50.00% (p=0.000 n=11+11) Opcodes/PICK/1024/null-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/PICK/1024/boolean-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/PICK/1024/integer/small-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/PICK/1024/integer/big-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/PICK/1024/bytearray/small-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/PICK/1024/bytearray/big-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/PICK/1024/buffer/small-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/PICK/1024/buffer/big-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/PICK/1024/struct/small-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/PICK/1024/pointer-8 2.00 ± 0% 1.00 ± 0% -50.00% (p=0.000 n=11+11) Opcodes/TUCK/null-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/TUCK/boolean-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/TUCK/integer/small-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/TUCK/integer/big-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/TUCK/bytearray/small-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/TUCK/bytearray/big-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=11+11) Opcodes/TUCK/buffer/small-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/TUCK/buffer/big-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/TUCK/struct/small-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/TUCK/struct/big-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=11+11) Opcodes/TUCK/pointer-8 2.00 ± 0% 1.00 ± 0% -50.00% (p=0.000 n=11+11) Opcodes/SWAP/null-8 0.00 0.00 ~ (all equal) Opcodes/SWAP/integer-8 0.00 0.00 ~ (all equal) Opcodes/SWAP/big_bytes-8 0.00 0.00 ~ (all equal) Opcodes/ROT/null-8 0.00 0.00 ~ (all equal) Opcodes/ROT/integer-8 0.00 0.00 ~ (all equal) Opcodes/ROT/big_bytes-8 0.00 0.00 ~ (all equal) Opcodes/ROLL/4/null-8 0.00 0.00 ~ (all equal) Opcodes/ROLL/4/integer-8 0.00 0.00 ~ (all equal) Opcodes/ROLL/4/big_bytes-8 0.00 0.00 ~ (all equal) Opcodes/ROLL/1024/null-8 0.00 0.00 ~ (all equal) Opcodes/ROLL/1024/integer-8 0.00 0.00 ~ (all equal) Opcodes/ROLL/1024/big_bytes-8 0.00 0.00 ~ (all equal) Opcodes/REVERSE3/null-8 0.00 0.00 ~ (all equal) Opcodes/REVERSE3/integer-8 0.00 0.00 ~ (all equal) Opcodes/REVERSE3/big_bytes-8 0.00 0.00 ~ (all equal) Opcodes/REVERSE4/null-8 0.00 0.00 ~ (all equal) Opcodes/REVERSE4/integer-8 0.00 0.00 ~ (all equal) Opcodes/REVERSE4/big_bytes-8 0.00 0.00 ~ (all equal) Opcodes/REVERSEN/5/null-8 0.00 0.00 ~ (all equal) Opcodes/REVERSEN/5/integer-8 0.00 0.00 ~ (all equal) Opcodes/REVERSEN/5/big_bytes-8 0.00 0.00 ~ (all equal) Opcodes/REVERSEN/1024/null-8 0.00 0.00 ~ (all equal) Opcodes/REVERSEN/1024/integer-8 0.00 0.00 ~ (all equal) Opcodes/REVERSEN/1024/big_bytes-8 0.00 0.00 ~ (all equal) Opcodes/PACK/1-8 5.00 ± 0% 4.00 ± 0% -20.00% (p=0.000 n=11+11) Opcodes/PACK/255-8 5.00 ± 0% 4.00 ± 0% -20.00% (p=0.000 n=11+11) Opcodes/PACK/1024-8 5.00 ± 0% 4.00 ± 0% -20.00% (p=0.000 n=11+11) Opcodes/UNPACK/1-8 5.00 ± 0% 3.00 ± 0% -40.00% (p=0.000 n=11+11) Opcodes/UNPACK/255-8 259 ± 0% 7 ± 0% -97.30% (p=0.000 n=11+11) Opcodes/UNPACK/1024-8 1.03k ± 0% 0.01k ± 0% -98.93% (p=0.000 n=11+11)	2021-08-24 15:28:14 +03:00
Roman Khimov	7808762ba0	transaction: avoid reencoding and reading what can't be read name old time/op new time/op delta DecodeFromBytes-8 1.79µs ± 2% 1.46µs ± 4% -18.44% (p=0.000 n=10+10) name old alloc/op new alloc/op delta DecodeFromBytes-8 800B ± 0% 624B ± 0% -22.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta DecodeFromBytes-8 10.0 ± 0% 8.0 ± 0% -20.00% (p=0.000 n=10+10)	2021-08-23 21:41:38 +03:00
Roman Khimov	2808f6857d	interop: don't allocate for Functions and Notifications in New Functions are usually immediately replaced (and it's OK for them to be nil, searching through an array with length of zero is fine), Notifications are usually appended to (and are absolutely useless in verification contexts).	2021-08-20 11:56:28 +03:00
Roman Khimov	a68a8aa8fc	core: simplify and correct notification handling * both 'to' and 'from' are either Null or Hash160, there is no other possibility for valid NEP-17. So returning util.Uint160{} in case of parsing error is wrong. * but this is what allowed burns/mints to work at the expense of error allocation inside of util.Uint160DecodeBytesBE() * Uint160 can technically fit into regular VM integer, so even though it'd be quite surprising to see it there, TryBytes() is more correct (and easier!) to use * same thing with `amount`, we have `TryInteger()` that easily covers all possible cases and does appropriate error checking inside	2021-08-20 11:26:16 +03:00
Roman Khimov	abc48229a3	block: Grow buffer on Trim, avoid reallocations	2021-08-20 11:05:46 +03:00
Anna Shaleva	5f9d38f640	core: refactor (DAO).StoreAsTransaction Squash (DAO).StoreAsTransaction and (*DAO).StoreConflictingTransactions. It's better to keep them this way, because StoreAsTransaction is always followed by StoreConflictingTransactions, so it's an atomic operation. The logic wasn't changed.	2021-08-18 13:39:28 +03:00
Anna Shaleva	4b35a1cf92	core: remove conflicting transactions wrt MaxTraceableBlocks	2021-08-18 13:31:47 +03:00
Roman Khimov	f477a48758	contract: block calls to contracts via Policy contract See neo-project/neo#2567.	2021-08-17 15:24:06 +03:00
Roman Khimov	adc660c3e0	Merge pull request #2123 from nspcc-dev/store-better Store better	2021-08-13 12:50:24 +03:00
Roman Khimov	ae071d4542	storage: introduce PutChangeSet and use it for Persist We're using batches in wrong way during persist, we already have all changes accumulated in two maps and then we move them to batch and then this is applied. For some DBs like BoltDB this batch is just another MemoryStore, so we essentially just shuffle the changeset from one map to another, for others like LevelDB batch is just a serialized set of KV pairs, it doesn't help much on subsequent PutBatch, we just duplicate the changeset again. So introduce PutChangeSet that allows to take two maps with sets and deletes directly. It also allows to simplify MemCachedStore logic. neo-bench for single node with 10 workers, LevelDB: Reference: RPS 30189.132 30556.448 30390.482 ≈ 30379 ± 0.61% TPS 29427.344 29418.687 29434.273 ≈ 29427 ± 0.03% CPU % 33.304 27.179 33.860 ≈ 31.45 ± 11.79% Mem MB 800.677 798.389 715.042 ≈ 771 ± 6.33% Patched: RPS 30264.326 30386.364 30166.231 ≈ 30272 ± 0.36% ⇅ TPS 29444.673 29407.440 29452.478 ≈ 29435 ± 0.08% ⇅ CPU % 34.012 32.597 33.467 ≈ 33.36 ± 2.14% ⇅ Mem MB 549.126 523.656 517.684 ≈ 530 ± 3.15% ↓ 31.26% BoltDB: Reference: RPS 31937.647 31551.684 31850.408 ≈ 31780 ± 0.64% TPS 31292.049 30368.368 31307.724 ≈ 30989 ± 1.74% CPU % 33.792 22.339 35.887 ≈ 30.67 ± 23.78% Mem MB 1271.687 1254.472 1215.639 ≈ 1247 ± 2.30% Patched: RPS 31746.818 30859.485 31689.761 ≈ 31432 ± 1.58% ⇅ TPS 31271.499 30340.726 30342.568 ≈ 30652 ± 1.75% ⇅ CPU % 34.611 34.414 31.553 ≈ 33.53 ± 5.11% ⇅ Mem MB 1262.960 1231.389 1335.569 ≈ 1277 ± 4.18% ⇅	2021-08-12 17:42:16 +03:00
Roman Khimov	5aff82aef4	Merge pull request #2119 from nspcc-dev/states-exchange/insole core, network: prepare basis for Insole module	2021-08-12 10:35:02 +03:00
Roman Khimov	47f0f4c45f	dao: completely drop Cached It was very useful in 2.0 days, but today it only serves one purpose that could easily (and more effectively!) be solved in another way.	2021-08-11 23:06:17 +03:00
Roman Khimov	3e60771175	core: deduplicate and simplify processNEP17Transfer a bit Just refactoring, no functional changes.	2021-08-11 22:36:26 +03:00
Roman Khimov	50ee1a1f91	*: don't use dao.Cached in tests There is no need to use it.	2021-08-11 21:02:50 +03:00
Roman Khimov	18682f2409	storage: don't use locks for memory batches They're inherently single-threaded, so locking makes no sense for them.	2021-08-11 18:55:07 +03:00
Roman Khimov	13da1b62fb	interop: fetch baseExecFee once and keep it in the Context It never changes during single execution, so we can cache it and avoid going to Policer via Chain for every instruction.	2021-08-11 15:42:23 +03:00
Anna Shaleva	0e3b9c48a2	core: add API to store StateSyncPoint and StateSyncCurrentBlockHeight We need it in order not to mess up the blockchain which has its own CurrentBlockHeight.	2021-08-10 14:06:28 +03:00
Anna Shaleva	cb01f533c0	core: store conflicting transactions in a separate method (DAO).StoreConflictingTransactions will be reused from the state sync module.	2021-08-10 13:47:13 +03:00
Anna Shaleva	72e654332e	core: refactor block queue It requires only two methods from Blockchainer: AddBlock and BlockHeight. New interface will allow to easily reuse the block queue for state exchange purposes.	2021-08-10 13:47:13 +03:00
Anna Shaleva	35501a281a	core: remove untraceable blocks wrt StateSyncInterval	2021-08-10 13:47:10 +03:00
Anna Shaleva	76c687aaa1	config: add P2PStateExchangeExtensions and StateSyncInterval settings	2021-08-10 11:00:32 +03:00
Roman Khimov	1e0c70ecb0	Merge pull request #2117 from nspcc-dev/io-grow Some io package improvements	2021-08-10 09:57:31 +03:00
Evgeniy Stratonikov	73e4040628	mpt: use `BinWriter.Grow()` instead of custom buffer Also add benchmarks. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-08-10 09:34:05 +03:00
Evgeniy Stratonikov	620295efe3	transaction: add benchmark for transaction serialization Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-08-09 12:01:38 +03:00
Evgeniy Stratonikov	23adb1e2fc	state: optimize `NEP17TransferLog.Append` Do not allocate a separate buffer for the transfer. ``` name old time/op new time/op delta NEP17TransferLog_Append-8 58.8µs ± 3% 32.1µs ± 1% -45.40% (p=0.000 n=10+9) name old alloc/op new alloc/op delta NEP17TransferLog_Append-8 118kB ± 1% 44kB ± 3% -63.00% (p=0.000 n=9+10) name old allocs/op new allocs/op delta NEP17TransferLog_Append-8 901 ± 1% 513 ± 3% -43.08% (p=0.000 n=9+8) ``` Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-08-09 11:09:49 +03:00
Evgeniy Stratonikov	403a4b75de	state/test: add benchmark for `NEP17TransferLog.Append` Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-08-09 11:09:49 +03:00
Evgeniy Stratonikov	b210a34b1e	state: optimize `NEP17Balance` deserialization ``` BenchmarkNEP17BalanceFromBytes/stackitem-8 2402318 503.3 ns/op 208 B/op 10 allocs/op BenchmarkNEP17BalanceFromBytes/from_bytes-8 7623139 160.7 ns/op 72 B/op 3 allocs/op ``` Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-08-09 11:09:49 +03:00
Evgeniy Stratonikov	3218b74ea5	state: optimize `NEP17Balance` serialization Put to slice directly and allow to provide pre-allocated buffer. ``` BenchmarkNEP17BalanceBytes/stackitem-8 1712475 673.4 ns/op 448 B/op 9 allocs/op BenchmarkNEP17BalanceBytes/bytes-8 13422715 75.80 ns/op 32 B/op 2 allocs/op BenchmarkNEP17BalanceBytes/bytes,_prealloc-8 25990371 46.46 ns/op 16 B/op 1 allocs/op ``` Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-08-09 11:09:06 +03:00
Roman Khimov	b989504d74	Merge pull request #2108 from nspcc-dev/optimize-mpt Some allocation optimizations	2021-08-06 14:51:10 +03:00
Evgeniy Stratonikov	bd2b1a0521	mpt: add `Size` method to trie nodes Knowing serialized size of the node is useful for preallocating byte-slice in advance. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-08-06 12:01:16 +03:00
Evgeniy Stratonikov	db80ef28df	mpt: move empty hash node in a separate type We use them quite frequently (consider children for a new branch node) and it is better to get rid of unneeded allocations. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-08-06 12:01:16 +03:00
Evgeniy Stratonikov	291a29af1e	*: do not use `WriteArray` for frequently used items `WriteArray` involves reflection, it makes sense to optimize serialization of transactions and application logs which are serialized constantly. Adding case in a type switch in `WriteArray` is not an option because we don't want new dependencies for `io` package. ``` name old time/op new time/op delta AppExecResult_EncodeBinary-8 852ns ± 3% 656ns ± 2% -22.94% (p=0.000 n=10+9) name old alloc/op new alloc/op delta AppExecResult_EncodeBinary-8 448B ± 0% 376B ± 0% -16.07% (p=0.000 n=10+10) name old allocs/op new allocs/op delta AppExecResult_EncodeBinary-8 7.00 ± 0% 5.00 ± 0% -28.57% (p=0.000 n=10+10) ``` ``` name old time/op new time/op delta Transaction_Bytes-8 1.29µs ± 3% 0.76µs ± 5% -41.52% (p=0.000 n=9+10) name old alloc/op new alloc/op delta Transaction_Bytes-8 1.21kB ± 0% 1.01kB ± 0% -16.56% (p=0.000 n=10+10) name old allocs/op new allocs/op delta Transaction_Bytes-8 12.0 ± 0% 7.0 ± 0% -41.67% (p=0.000 n=10+10) ``` Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-08-06 11:59:20 +03:00
Roman Khimov	39f874d03f	core: don't recalculate witness script hash We know it already, but with current loading code VM will hash it once more. It doesn't help a lot and still it costs nothing to avoid this overhead. name old time/op new time/op delta VerifyWitness-8 93.4µs ± 3% 92.7µs ± 2% ~ (p=0.353 n=10+10) name old alloc/op new alloc/op delta VerifyWitness-8 3.43kB ± 0% 3.40kB ± 0% -0.70% (p=0.000 n=9+9) name old allocs/op new allocs/op delta VerifyWitness-8 67.0 ± 0% 66.0 ± 0% -1.49% (p=0.000 n=10+10)	2021-08-06 11:25:09 +03:00
Evgeniy Stratonikov	43ee671f36	mpt: do not allocate NodeObject for serialization Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-08-06 10:28:19 +03:00
Roman Khimov	e41fc2fd1b	Merge pull request #2111 from nspcc-dev/drop-refuel native: drop Refuel method from GAS	2021-08-05 16:42:29 +03:00
Roman Khimov	d6bd6b6888	native: drop Refuel method from GAS It can be used to attack the network (amplifying DOS), so it's broken beyond repair. This reverts `ac601601c1`. See also neo-project/neo#2560 and neo-project/neo#2561.	2021-08-05 10:27:13 +03:00
Roman Khimov	892c9785ad	transaction: don't allocate new buffer to calculate hash We can write directly to hash.Hash. name old time/op new time/op delta DecodeBinary-8 2.89µs ± 3% 2.82µs ± 5% ~ (p=0.052 n=10+10) DecodeJSON-8 13.0µs ± 1% 12.8µs ± 1% -1.54% (p=0.002 n=10+8) DecodeFromBytes-8 2.37µs ± 1% 2.25µs ± 5% -5.25% (p=0.000 n=9+10) name old alloc/op new alloc/op delta DecodeBinary-8 1.75kB ± 0% 1.53kB ± 0% -12.79% (p=0.000 n=10+10) DecodeJSON-8 3.49kB ± 0% 3.26kB ± 0% -6.42% (p=0.000 n=10+10) DecodeFromBytes-8 1.37kB ± 0% 1.14kB ± 0% -16.37% (p=0.000 n=10+10) name old allocs/op new allocs/op delta DecodeBinary-8 26.0 ± 0% 23.0 ± 0% -11.54% (p=0.000 n=10+10) DecodeJSON-8 58.0 ± 0% 55.0 ± 0% -5.17% (p=0.000 n=10+10) DecodeFromBytes-8 18.0 ± 0% 15.0 ± 0% -16.67% (p=0.000 n=10+10)	2021-08-04 23:43:20 +03:00
Roman Khimov	6d10cdc2f6	transaction: avoid ReadArray() Reflection adds some real cost to it: name old time/op new time/op delta DecodeBinary-8 3.14µs ± 5% 2.89µs ± 3% -8.19% (p=0.000 n=10+10) DecodeJSON-8 12.6µs ± 3% 13.0µs ± 1% +3.77% (p=0.000 n=10+10) DecodeFromBytes-8 2.73µs ± 2% 2.37µs ± 1% -13.12% (p=0.000 n=9+9) name old alloc/op new alloc/op delta DecodeBinary-8 1.82kB ± 0% 1.75kB ± 0% -3.95% (p=0.000 n=10+10) DecodeJSON-8 3.49kB ± 0% 3.49kB ± 0% ~ (all equal) DecodeFromBytes-8 1.44kB ± 0% 1.37kB ± 0% -5.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta DecodeBinary-8 29.0 ± 0% 26.0 ± 0% -10.34% (p=0.000 n=10+10) DecodeJSON-8 58.0 ± 0% 58.0 ± 0% ~ (all equal) DecodeFromBytes-8 21.0 ± 0% 18.0 ± 0% -14.29% (p=0.000 n=10+10)	2021-08-04 23:34:57 +03:00
Roman Khimov	d2732a71d8	transaction: don't overwrite error and witnesses length check ReadArray() can return some error and we shouldn't overwrite it. At the same time limiting ReadArray() to the number of Signers can make it return wrong error if the number of witnesses actually is bigger than the number of signers, so use MaxAttributes.	2021-08-04 23:17:50 +03:00
Roman Khimov	d487b54612	transaction: don't recalculate size when decoding from buffer name old time/op new time/op delta DecodeBinary-8 3.17µs ± 6% 3.14µs ± 5% ~ (p=0.579 n=10+10) DecodeJSON-8 12.8µs ± 3% 12.6µs ± 3% ~ (p=0.105 n=10+10) DecodeFromBytes-8 3.45µs ± 4% 2.73µs ± 2% -20.70% (p=0.000 n=10+9) name old alloc/op new alloc/op delta DecodeBinary-8 1.82kB ± 0% 1.82kB ± 0% ~ (all equal) DecodeJSON-8 3.49kB ± 0% 3.49kB ± 0% ~ (all equal) DecodeFromBytes-8 1.82kB ± 0% 1.44kB ± 0% -21.05% (p=0.000 n=10+10) name old allocs/op new allocs/op delta DecodeBinary-8 29.0 ± 0% 29.0 ± 0% ~ (all equal) DecodeJSON-8 58.0 ± 0% 58.0 ± 0% ~ (all equal) DecodeFromBytes-8 29.0 ± 0% 21.0 ± 0% -27.59% (p=0.000 n=10+10)	2021-08-04 23:13:58 +03:00
Roman Khimov	64c780ad7a	native: optimize totalSupply operations during token burn/mint We burn GAS in OnPersist for every transaction so some buffer reuse here is quite natural. This also doesn't change a lot in the overall TPS picture, maybe adding some 1%.	2021-08-03 17:59:38 +03:00
Roman Khimov	dede4fa7b1	state: convert NEO balance to stack item directly Avoid calling Append() that will reallocate the slice, we know the length of the slice exactly.	2021-08-03 17:59:38 +03:00
Roman Khimov	5c65d33439	native: move required balance check to token contracts Which duplicates the check, but deduplicates error path. This check forced double balance deserialization which is quite costly operation, so we better do it once. It's hardly noticeable as of TPS metrics though, maybe some 1-2%%.	2021-08-03 17:59:38 +03:00
Roman Khimov	3c1325035e	fee: use array for opcodes Use less memory and have faster access. name old time/op new time/op delta Opcode1-8 22.4ns ± 6% 3.0ns ± 6% -86.63% (p=0.000 n=10+10)	2021-08-02 20:18:33 +03:00
Roman Khimov	dfc514eda0	Merge pull request #2102 from nspcc-dev/store4 Improve (*MemCachedStore).Persist	2021-08-02 20:10:05 +03:00
Roman Khimov	82f481e143	Merge pull request #2105 from nspcc-dev/json-restrict native/std: restrint amount of items in JSON deserialization	2021-08-02 19:41:54 +03:00
Evgeniy Stratonikov	bdb9748c1b	native/std: restrict amount of items in JSON deserialization Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-08-02 18:57:47 +03:00
Roman Khimov	f8174ca64c	core: ensure data logged is from persistent store Using bc.dao here is wrong, it can contain unpersisted data.	2021-08-02 16:33:09 +03:00
Roman Khimov	8277b7a19a	core: don't spawn goroutine for persist function It doesn't make any sense, in some situations it leads to a number of goroutines created that will Persist one after another (as we can't Persist concurrently). We can manage it better in a single thread. This doesn't change performance in any way, but somewhat reduces resource consumption. It was tested neo-bench (single node, 10 workers, LevelDB) on two machines and block dump processing (RC4 testnet up to 62800 with VerifyBlocks set to false) on i7-8565U. Reference (`b9be892bf9`): Ryzen 9 5950X: RPS 27747.349 27407.726 27520.210 ≈ 27558 ± 0.63% TPS 26992.010 26993.468 27010.966 ≈ 26999 ± 0.04% CPU % 28.928 28.096 29.105 ≈ 28.7 ± 1.88% Mem MB 760.385 726.320 756.118 ≈ 748 ± 2.48% Core i7-8565U: RPS 7783.229 7628.409 7542.340 ≈ 7651 ± 1.60% TPS 7708.436 7607.397 7489.459 ≈ 7602 ± 1.44% CPU % 74.899 71.020 72.697 ≈ 72.9 ± 2.67% Mem MB 438.047 436.967 416.350 ≈ 430 ± 2.84% DB restore: real 0m20.838s 0m21.895s 0m21.794s ≈ 21.51 ± 2.71% user 0m39.091s 0m40.565s 0m41.493s ≈ 40.38 ± 3.00% sys 0m3.184s 0m2.923s 0m3.062s ≈ 3.06 ± 4.27% Patched: Ryzen 9 5950X: RPS 27636.957 27246.911 27462.036 ≈ 27449 ± 0.71% ↓ 0.40% TPS 27003.672 26993.468 27011.696 ≈ 27003 ± 0.03% ↑ 0.01% CPU % 28.562 28.475 28.012 ≈ 28.3 ± 1.04% ↓ 1.39% Mem MB 627.007 648.110 794.895 ≈ 690 ± 13.25% ↓ 7.75% Core i7-8565U: RPS 7497.210 7527.797 7897.532 ≈ 7641 ± 2.92% ↓ 0.13% TPS 7461.128 7482.678 7841.723 ≈ 7595 ± 2.81% ↓ 0.09% CPU % 71.559 73.423 69.005 ≈ 71.3 ± 3.11% ↓ 2.19% Mem MB 393.090 395.899 482.264 ≈ 424 ± 11.96% ↓ 1.40% DB restore: real 0m20.773s 0m21.583s 0m20.522s ≈ 20.96 ± 2.65% ↓ 2.56% user 0m39.322s 0m42.268s 0m38.626s ≈ 40.07 ± 4.82% ↓ 0.77% sys 0m3.006s 0m3.597s 0m3.042s ≈ 3.22 ± 10.31% ↑ 5.23%	2021-08-02 16:33:00 +03:00
Roman Khimov	b9be892bf9	storage: allow accessing MemCachedStore during Persist Persist by its definition doesn't change MemCachedStore visible state, all KV pairs that were acessible via it before Persist remain accessible after Persist. The only thing it does is flushing of the current set of KV pairs from memory to peristent store. To do that it needs read-only access to the current KV pair set, but technically it then replaces maps, so we have to use full write lock which makes MemCachedStore inaccessible for the duration of Persist. And Persist can take a lot of time, it's about disk access for regular DBs. What we do here is we create new in-memory maps for MemCachedStore before flushing old ones to the persistent store. Then a fake persistent store is created which actually is a MemCachedStore with old maps, so it has exactly the same visible state. This Store is never accessed for writes, so we can read it without taking any internal locks and at the same time we no longer need write locks for original MemCachedStore, we're not using it. All of this makes it possible to use MemCachedStore as normally reads are handled going down to whatever level is needed and writes are handled by new maps. So while Persist for (Blockchain).dao does its most time-consuming work we can process other blocks (reading data for transactions and persisting storeBlock caches to (Blockchain).dao). The change was tested for performance with neo-bench (single node, 10 workers, LevelDB) on two machines and block dump processing (RC4 testnet up to 62800 with VerifyBlocks set to false) on i7-8565U. Reference results (`bbe4e9cd7b`): Ryzen 9 5950X: RPS 23616.969 22817.086 23222.378 ≈ 23218 ± 1.72% TPS 23047.316 22608.578 22735.540 ≈ 22797 ± 0.99% CPU % 23.434 25.553 23.848 ≈ 24.3 ± 4.63% Mem MB 600.636 503.060 582.043 ≈ 562 ± 9.22% Core i7-8565U: RPS 6594.007 6499.501 6572.902 ≈ 6555 ± 0.76% TPS 6561.680 6444.545 6510.120 ≈ 6505 ± 0.90% CPU % 58.452 60.568 62.474 ≈ 60.5 ± 3.33% Mem MB 234.893 285.067 269.081 ≈ 263 ± 9.75% DB restore: real 0m22.237s 0m23.471s 0m23.409s ≈ 23.04 ± 3.02% user 0m35.435s 0m38.943s 0m39.247s ≈ 37.88 ± 5.59% sys 0m3.085s 0m3.360s 0m3.144s ≈ 3.20 ± 4.53% After the change: Ryzen 9 5950X: RPS 27747.349 27407.726 27520.210 ≈ 27558 ± 0.63% ↑ 18.69% TPS 26992.010 26993.468 27010.966 ≈ 26999 ± 0.04% ↑ 18.43% CPU % 28.928 28.096 29.105 ≈ 28.7 ± 1.88% ↑ 18.1% Mem MB 760.385 726.320 756.118 ≈ 748 ± 2.48% ↑ 33.10% Core i7-8565U: RPS 7783.229 7628.409 7542.340 ≈ 7651 ± 1.60% ↑ 16.72% TPS 7708.436 7607.397 7489.459 ≈ 7602 ± 1.44% ↑ 16.85% CPU % 74.899 71.020 72.697 ≈ 72.9 ± 2.67% ↑ 20.50% Mem MB 438.047 436.967 416.350 ≈ 430 ± 2.84% ↑ 63.50% DB restore: real 0m20.838s 0m21.895s 0m21.794s ≈ 21.51 ± 2.71% ↓ 6.64% user 0m39.091s 0m40.565s 0m41.493s ≈ 40.38 ± 3.00% ↑ 6.60% sys 0m3.184s 0m2.923s 0m3.062s ≈ 3.06 ± 4.27% ↓ 4.38% It obviously uses more memory now and utilizes CPU more aggressively, but at the same time it allows to improve all relevant metrics and finally reach a situation where we process 50K transactions in less than second on Ryzen 9 5950X (going higher than 25K TPS). The other observation is much more stable block time, on Ryzen 9 it's as close to 1 second as it could be.	2021-08-02 16:33:00 +03:00
Roman Khimov	3cebd2b129	interop: use non-Cached wrapped DAO Cached only caches NEP-17 tracking data now, it makes no sense here.	2021-07-30 15:45:17 +03:00
Roman Khimov	fa7314ea90	dao: drop dropNEP17Cache from Cached It's not used now.	2021-07-30 15:45:17 +03:00
Roman Khimov	49be753850	core: spread storeBlock actions to three goroutines Block processing consists of: * saving block/transactions to the DB * executing blocks/transactions * processing notifications/saving AERs * updating MPT * atomically updating Blockchain state Of these the first one is completely independent of others, it can be done in a separate routine easily. The third one technically depends on the second, it just doesn't have data until something is executed. At the same time it doesn't affect future executions in any way, so we can offload AER/notification processing to separate goroutine (while the main thread proceeds with other transactions). MPT update depends on all executions, so it can't be offloaded, but it can be done concurrently to AER processing. And only the last thing actually needs all previous ones to be finished, so it's a natural synchronization point. So we spawn two additional routines and let the main one execute transactions and update MPT as fast as it can. While technically all of these routines could share single DAO (they are working with different KV sets) benchmarking shows that using separate DAOs and then persisting them to lower one actually works about 7-8%% better. At the same time we can simplify DAOs used, Cached one is only relevant for AER processing because it caches NEP-17 tracking data, everything else can do just fine with Simple. The change was tested for performance with neo-bench (single node, 10 workers, LevelDB) on two machines and block dump processing (RC4 testnet up to 50825 with VerifyBlocks set to false) on i7-8565U. neo-bench creates huge blocks with lots of transactions while RC4 dump mostly consists of empty blocks. Reference results (`06c3dda5d1`): Ryzen 9 5950X: RPS ≈ 20059.569 21186.328 20158.983 ≈ 20468 ± 3.05% TPS ≈ 19544.993 20585.450 19658.338 ≈ 19930 ± 2.86% CPU ≈ 18.682% 23.877% 22.852% ≈ 21.8 ± 12.62% Mem ≈ 618.981MB 559.246MB 541.539MB ≈ 573 ± 7.08% Core i7-8565U: RPS ≈ 5927.082 6526.739 6372.115 ≈ 6275 ± 4.96% TPS ≈ 5899.531 6477.187 6329.515 ≈ 6235 ± 4.81% CPU ≈ 56.346% 61.955% 58.125% ≈ 58.8 ± 4.87% Mem ≈ 212.191MB 224.974MB 205.479MB ≈ 214 ± 4.62% DB restore: real 0m12.683s 0m13.222s 0m13.382s ≈ 13.096 ± 2.80% user 0m18.501s 0m19.163s 0m19.489s ≈ 19.051 ± 2.64% sys 0m1.404s 0m1.396s 0m1.666s ≈ 1.489 ± 10.32% After the change: Ryzen 9 5950X: RPS ≈ 23056.899 22822.015 23006.543 ≈ 22962 ± 0.54% TPS ≈ 22594.785 22292.071 22800.857 ≈ 22562 ± 1.13% CPU ≈ 24.262% 23.185% 25.921% ≈ 24.5 ± 5.65% Mem ≈ 614.254MB 613.204MB 555.491MB ≈ 594 ± 5.66% Core i7-8565U: RPS ≈ 6378.702 6423.927 6363.788 ≈ 6389 ± 0.49% TPS ≈ 6327.072 6372.552 6311.179 ≈ 6337 ± 0.50% CPU ≈ 57.599% 58.622% 59.737% ≈ 58.7 ± 1.82% Mem ≈ 198.697MB 188.746MB 200.235MB ≈ 196 ± 3.18% DB restore: real 0m13.576s 0m13.334s 0m12.757s ≈ 13.222 ± 3.18% user 0m19.113s 0m19.490s 0m20.197s ≈ 19.600 ± 2.81% sys 0m2.211s 0m1.558s 0m1.559s ≈ 1.776 ± 21.21% On Ryzen 9 we've got 12% better RPS, 13% better TPS with 12% CPU and 3% RAM more used. Core i7-8565U changes don't seem to be statistically significant: 1.8% more RPS, 1.6% more TPS with about the same CPU and 8.5% less RAM used. It also is 1% worse in DB restore time. The result is somewhat expected, on a powerful machine with lots of spare cores we get 10%+ better results while on average resource-constrained laptop it doesn't change much (the machine is already saturated). Overall, this seems to be worthwhile.	2021-07-30 15:45:17 +03:00
Roman Khimov	06c3dda5d1	Merge pull request #2093 from nspcc-dev/states-exchange/drop-nep17-balance-state core: implement dynamic NEP17 balances tracking	2021-07-29 19:08:42 +03:00
Anna Shaleva	a30e48ff90	core: increment the DB version DB scheme has been changed.	2021-07-29 10:23:13 +03:00
Anna Shaleva	e8bed184d5	core: implement dynamic NEP17 balances tracking Request NEP17 balances from a set of NEP17 contracts instead of getting them from storage. LastUpdatedBlock tracking remains untouched, because there's no way to retrieve it dynamically.	2021-07-29 10:23:01 +03:00
Anna Shaleva	e46d76d7aa	core: rename state.NEP17Balances to state.NEP17TransferInfo Balances are to be removed from state.NEP17TransferInfo, so the remnant fields are NextTransferBatch, NewBatch and a map of LastUpdatedBlocks. These fields are more staff-related. Also rename dao.[Get, Put, put]NEP17Balances and STNEP17Balances preffix. Also rename NEP17TransferInfo.Trackers to LastUpdatedBlockTrackers because NEP17TransferInfo.Balances are to be removed.	2021-07-28 13:22:53 +03:00
Anna Shaleva	c0a2c74e0c	core: maintain a set of NEP17-compliant contracts	2021-07-28 13:22:53 +03:00
Roman Khimov	50d99464e0	Merge pull request #2064 from nspcc-dev/fix-remove-stale-hang mempool: send events in a separate goroutine	2021-07-23 18:16:14 +03:00
Evgeniy Stratonikov	3507f52c32	notary: process new transactions in a separate goroutine Related #2063. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-23 14:48:00 +03:00
Roman Khimov	1d8ad5b84a	*: simplify some error messages Log: 2021-07-23T09:59:18.948+0300 WARN contract invocation failed {"tx": "de3e3c1f1d37e4528990f894dea5583fd320485ad3862a95eb0e8823eecf4a5f", "block": 9643, "error": "error encountered at instruction 1 (SYSCALL): error during call from native: error encountered at instruction 745 (CAT): invalid conversion: Map/ByteString"} The word "error" appears 4 times here.	2021-07-23 10:08:09 +03:00
Roman Khimov	002ad9dfee	go.mod: update miniredis to 2.15.1 It's only used for testing purposes and this version doesn't change anything for us, but still better be current.	2021-07-21 23:28:26 +03:00
Roman Khimov	df07ba505a	config: update mainnet magic It's NEO3, see neo-project/neo-node#795.	2021-07-21 14:42:26 +03:00
Roman Khimov	35c2c3ae8e	Merge pull request #2078 from nspcc-dev/configurable-initial-gas config: add InitialGASSupply, fix #2073	2021-07-20 17:10:25 +03:00
Roman Khimov	36d486a664	config: add InitialGASSupply, fix #2073 We now have 52M by default.	2021-07-20 16:59:54 +03:00
Roman Khimov	0583f252ab	*: create real temporary dirs and files in tests Improve reliability.	2021-07-20 12:51:11 +03:00
Roman Khimov	3b19b34122	storage: fix memcached test with boltdb store Everything was wrong here, wrong file used, wrong cleanup procedure, the net result is this (and some failing tests from time to time): $ ls -l /tmp/test_bolt_db* \| wc -l 30939	2021-07-20 12:35:24 +03:00
Roman Khimov	c88ebaede9	Merge pull request #2075 from nspcc-dev/small-refactoring Array util refactoring and naming improvement	2021-07-20 11:29:59 +03:00
Roman Khimov	7477e2cd9f	Merge pull request #2074 from nspcc-dev/fix-oracle-service-behaviour Fix oracle service behaviour	2021-07-20 11:29:39 +03:00
Roman Khimov	19717dd9a8	slice: introduce common Copy helper It's a bit more convenient to use.	2021-07-19 22:57:55 +03:00
Roman Khimov	a54e3516d1	slice: add Reverse function, deduplicate code a bit	2021-07-19 22:57:55 +03:00
Roman Khimov	3a93977b7b	oracle: only process new requests after initial sync If an oracle node is resynchronized from the genesis the service receives all requests from all blocks via AddRequests() invoked from the native contract. Almost all of them are long obsolete and need to be removed, native oracle contract will try to do that with RemoveRequests() calls, but they won't change anything. So queue up all "initial" requests in special map and manage it directly before the module is Run() which happens after synchronization completion. Then process any requests that are still active and work with new blocks as usual.	2021-07-19 22:52:59 +03:00
Roman Khimov	588f3fbbd3	state: drop State from NEOBalance and NEP17Balance We're in the `state` package already.	2021-07-19 22:01:07 +03:00
Roman Khimov	f4a9139a05	Merge pull request #2071 from nspcc-dev/fix-more-vm-bugs Fix more VM bugs	2021-07-19 22:00:17 +03:00
Roman Khimov	79b1bf72aa	native: check that oracle request GAS IsInt64() We use int64 value down below, so check for IsInt64() while MinimumResponseGas check still covers for values less than zero.	2021-07-19 15:42:42 +03:00
Roman Khimov	5f13de3a76	*: simplify some integer checks with IsUint64() If we need a positive number we can do `IsUint64()` instead of checking that `Int64()` is `> 0`.	2021-07-19 15:42:42 +03:00
Roman Khimov	233307aca5	stackitem: completely drop MaxArraySize Turns out C# VM doesn't have it since preview2, so our limiting of MaxArraySize in incompatible with it. Removing this limit shouldn't be a problem with the reference counter we have, both APPEND and SETITEM add things to reference counter and we can't exceed MaxStackSize. PACK on the other hand can't get more than MaxStackSize-1 of input elements. Unify NEWSTRUCT with NEWARRAY* and use better integer checks at the same time. Multisig limit is still 1024.	2021-07-19 15:42:42 +03:00
Roman Khimov	aab18c3083	stackitem: introduce Convertible interface We have a lot of native contract types that are converted to stack items before serialization, then deserialized as stack items and converted back to regular structures. stackitem.Convertible allows to remove a lot of repetitive io.Serializable code. This also introduces to/from converter in testserdes which unfortunately required to change util tests to avoid circular references.	2021-07-19 15:42:42 +03:00
Roman Khimov	2d993d0da5	state: store notary deposit as stackitem Which is less effective, but makes it more similar to other native contracts that are supposed to be contracts anyway.	2021-07-19 15:42:42 +03:00
Roman Khimov	70ddbf7180	native: reuse stackitem.(De)Serialize more for data structures Less code bloat, no functional changes.	2021-07-19 15:42:42 +03:00
Roman Khimov	4775b513f9	native: do proper error handling when deserializing user data	2021-07-19 15:42:42 +03:00
Roman Khimov	3a991abb62	fee: adjust SQRT price See neo-project/neo#2540.	2021-07-19 15:42:41 +03:00
Roman Khimov	21e05f5779	Merge pull request #2055 from nspcc-dev/fix-gas-limits Tune fixed GAS limits	2021-07-16 16:53:06 +03:00
Evgeniy Stratonikov	8077f9232d	interop: implement `System.Runtime.GetRandom` Our murmur3 implementation is architecture independent and optimized in assembly. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-15 16:00:01 +03:00
Evgeniy Stratonikov	fdb54f2dc3	core/test: get rid of empty tx scripts Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-15 15:58:49 +03:00
Evgeniy Stratonikov	3a4e0caeb8	core/block: add `Nonce` field to header Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-15 15:58:49 +03:00
Evgeniy Stratonikov	2cd5b63f0b	policy: fix max exec fee Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-14 10:27:09 +03:00
Evgeniy Stratonikov	451b02122a	*: increase GAS for verification Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-14 10:27:09 +03:00
Roman Khimov	2b7abd20e7	Merge pull request #2057 from nspcc-dev/optimize-storage-find Optimize `storageFind`	2021-07-13 12:51:10 +03:00
Roman Khimov	83a557f0eb	Merge pull request #2042 from nspcc-dev/oracle-not-supported Check oracle response Content-Type header	2021-07-13 11:31:37 +03:00
Evgeniy Stratonikov	eb7bd7b99b	core: optimize `storageFind` Because `Map` stores elements in arbitrary order, addition of new element takes linear time (`Index` iterates over all keys). Thus our `storageFind` is actually quadratic in time. Optimize this by creating map from sorted slice. ``` name old time/op new time/op delta StorageFind-8 157µs ± 2% 112µs ± 1% -28.60% (p=0.000 n=10+10) name old alloc/op new alloc/op delta StorageFind-8 69.4kB ± 0% 60.5kB ± 0% -12.90% (p=0.000 n=9+10) name old allocs/op new allocs/op delta StorageFind-8 2.21k ± 0% 2.00k ± 0% -9.37% (p=0.000 n=10+7) ``` Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-12 14:22:17 +03:00
Evgeniy Stratonikov	b8b272c8c4	core/test: add benchmark for `storageFind` Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-12 14:20:45 +03:00
Evgeniy Stratonikov	0d5ede0bff	core/test: use testing.TB in constructors This allows to use chain in benchmarks. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-12 14:20:45 +03:00
Evgeniy Stratonikov	9f377cde12	storage: convert key once in `MemoryStore.seek` There is no need in additional allocations. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-12 14:14:32 +03:00
Evgeniy Stratonikov	8e9302f40b	oracle: check response Content-Type If not specified everything is allowed. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-12 13:13:48 +03:00
Roman Khimov	bc5a1b7bcd	Merge pull request #2043 from nspcc-dev/runtime-getnetwork interop/runtime: add `System.Runtime.GetNetwork`, fix #2038	2021-07-12 10:46:41 +03:00
Roman Khimov	1853d0c713	core: don't copy config in ApplyPolicyToTxSet Makes no sense, GetConfig() is for external users.	2021-07-09 13:01:42 +03:00
Evgeniy Stratonikov	96a42cd011	interop: add `System.Runtime.GetNetwork`, fix #2038 Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-08 17:02:37 +03:00
Roman Khimov	7bc7457fbe	Merge pull request #2050 from nspcc-dev/fix-network-test-race Fix some test failures	2021-07-08 14:50:50 +03:00
Roman Khimov	bd400dfe20	native: copy contract on update It can be a pointer to cached data: 2021-07-07T20:05:24.8508647Z ================== 2021-07-07T20:05:24.8509294Z WARNING: DATA RACE 2021-07-07T20:05:24.8510243Z Write at 0x00c000142cc8 by goroutine 51: 2021-07-07T20:05:24.8511350Z github.com/nspcc-dev/neo-go/pkg/core/native.(Management).Update() 2021-07-07T20:05:24.8529622Z /home/runner/work/neo-go/neo-go/pkg/core/native/management.go:335 +0x70a 2021-07-07T20:05:24.8531266Z github.com/nspcc-dev/neo-go/pkg/core/native.(Management).updateWithData() 2021-07-07T20:05:24.8532544Z /home/runner/work/neo-go/neo-go/pkg/core/native/management.go:316 +0x1e9 2021-07-07T20:05:24.8533726Z github.com/nspcc-dev/neo-go/pkg/core/native.(Management).update() 2021-07-07T20:05:24.8534928Z /home/runner/work/neo-go/neo-go/pkg/core/native/management.go:303 +0x111 2021-07-07T20:05:24.8536123Z github.com/nspcc-dev/neo-go/pkg/core/native.(Management).update-fm() 2021-07-07T20:05:24.8537389Z /home/runner/work/neo-go/neo-go/pkg/core/native/management.go:302 +0x34 2021-07-07T20:05:24.8538462Z github.com/nspcc-dev/neo-go/pkg/core/native.Call() 2021-07-07T20:05:24.8539565Z /home/runner/work/neo-go/neo-go/pkg/core/native/interop.go:54 +0x90c 2021-07-07T20:05:24.8540751Z github.com/nspcc-dev/neo-go/pkg/core/interop.(Context).SyscallHandler() 2021-07-07T20:05:24.8542177Z /home/runner/work/neo-go/neo-go/pkg/core/interop/context.go:262 +0x216 2021-07-07T20:05:24.8543328Z github.com/nspcc-dev/neo-go/pkg/core/interop.(Context).SyscallHandler-fm() 2021-07-07T20:05:24.8544586Z /home/runner/work/neo-go/neo-go/pkg/core/interop/context.go:250 +0x53 2021-07-07T20:05:24.8545648Z github.com/nspcc-dev/neo-go/pkg/vm.(VM).execute() 2021-07-07T20:05:24.8546635Z /home/runner/work/neo-go/neo-go/pkg/vm/vm.go:1312 +0xb2d5 2021-07-07T20:05:24.8547632Z github.com/nspcc-dev/neo-go/pkg/vm.(VM).Step() 2021-07-07T20:05:24.8548640Z /home/runner/work/neo-go/neo-go/pkg/vm/vm.go:416 +0x1f2 2021-07-07T20:05:24.8549836Z github.com/nspcc-dev/neo-go/pkg/vm.(VM).Run() 2021-07-07T20:05:24.8550852Z /home/runner/work/neo-go/neo-go/pkg/vm/vm.go:393 +0x195 2021-07-07T20:05:24.8551989Z github.com/nspcc-dev/neo-go/pkg/rpc/server.(Server).runScriptInVM() 2021-07-07T20:05:24.8553174Z /home/runner/work/neo-go/neo-go/pkg/rpc/server/server.go:1326 +0x7eb 2021-07-07T20:05:24.8554345Z github.com/nspcc-dev/neo-go/pkg/rpc/server.(Server).invokeFunction() 2021-07-07T20:05:24.8555560Z /home/runner/work/neo-go/neo-go/pkg/rpc/server/server.go:1219 +0x50c 2021-07-07T20:05:24.8556616Z github.com/nspcc-dev/neo-go/pkg/rpc/server.(Server).handleIn() 2021-07-07T20:05:24.8557823Z /home/runner/work/neo-go/neo-go/pkg/rpc/server/server.go:345 +0xecb 2021-07-07T20:05:24.8558987Z github.com/nspcc-dev/neo-go/pkg/rpc/server.(Server).handleRequest() 2021-07-07T20:05:24.8560356Z /home/runner/work/neo-go/neo-go/pkg/rpc/server/server.go:315 +0x364 2021-07-07T20:05:24.8561599Z github.com/nspcc-dev/neo-go/pkg/rpc/server.(Server).handleHTTPRequest() 2021-07-07T20:05:24.8562976Z /home/runner/work/neo-go/neo-go/pkg/rpc/server/server.go:309 +0xf9b 2021-07-07T20:05:24.8564208Z github.com/nspcc-dev/neo-go/pkg/rpc/server.(Server).handleHTTPRequest-fm() 2021-07-07T20:05:24.8565523Z /home/runner/work/neo-go/neo-go/pkg/rpc/server/server.go:257 +0x64 2021-07-07T20:05:24.8566348Z net/http.HandlerFunc.ServeHTTP() 2021-07-07T20:05:24.8567290Z /opt/hostedtoolcache/go/1.15.13/x64/src/net/http/server.go:2042 +0x51 2021-07-07T20:05:24.8568185Z net/http.serverHandler.ServeHTTP() 2021-07-07T20:05:24.8569130Z /opt/hostedtoolcache/go/1.15.13/x64/src/net/http/server.go:2843 +0xca 2021-07-07T20:05:24.8569861Z net/http.(conn).serve() 2021-07-07T20:05:24.8570634Z /opt/hostedtoolcache/go/1.15.13/x64/src/net/http/server.go:1925 +0x84c 2021-07-07T20:05:24.8571139Z 2021-07-07T20:05:24.8571639Z Previous read at 0x00c000142cc8 by goroutine 41: 2021-07-07T20:05:24.8572892Z github.com/nspcc-dev/neo-go/pkg/core/interop/contract.callExFromNative() 2021-07-07T20:05:24.8574265Z /home/runner/work/neo-go/neo-go/pkg/core/interop/contract/call.go:101 +0x2d4 2021-07-07T20:05:24.8575581Z github.com/nspcc-dev/neo-go/pkg/core/interop/contract.callInternal() 2021-07-07T20:05:24.8576951Z /home/runner/work/neo-go/neo-go/pkg/core/interop/contract/call.go:85 +0x1f5 2021-07-07T20:05:24.8578094Z github.com/nspcc-dev/neo-go/pkg/core/interop/contract.Call() 2021-07-07T20:05:24.8579306Z /home/runner/work/neo-go/neo-go/pkg/core/interop/contract/call.go:69 +0x804 2021-07-07T20:05:24.8580514Z github.com/nspcc-dev/neo-go/pkg/core/interop.(Context).SyscallHandler() 2021-07-07T20:05:24.8581755Z /home/runner/work/neo-go/neo-go/pkg/core/interop/context.go:262 +0x216 2021-07-07T20:05:24.8582907Z github.com/nspcc-dev/neo-go/pkg/core/interop.(Context).SyscallHandler-fm() 2021-07-07T20:05:24.8584300Z /home/runner/work/neo-go/neo-go/pkg/core/interop/context.go:250 +0x53 2021-07-07T20:05:24.8585422Z github.com/nspcc-dev/neo-go/pkg/vm.(VM).execute() 2021-07-07T20:05:24.8586403Z /home/runner/work/neo-go/neo-go/pkg/vm/vm.go:1312 +0xb2d5 2021-07-07T20:05:24.8590451Z github.com/nspcc-dev/neo-go/pkg/vm.(VM).Step() 2021-07-07T20:05:24.8591549Z /home/runner/work/neo-go/neo-go/pkg/vm/vm.go:416 +0x1f2 2021-07-07T20:05:24.8592466Z github.com/nspcc-dev/neo-go/pkg/vm.(VM).Run() 2021-07-07T20:05:24.8593550Z /home/runner/work/neo-go/neo-go/pkg/vm/vm.go:393 +0x195 2021-07-07T20:05:24.8594531Z github.com/nspcc-dev/neo-go/pkg/core.(Blockchain).storeBlock() 2021-07-07T20:05:24.8595708Z /home/runner/work/neo-go/neo-go/pkg/core/blockchain.go:717 +0x1694 2021-07-07T20:05:24.8596793Z github.com/nspcc-dev/neo-go/pkg/core.(Blockchain).AddBlock() 2021-07-07T20:05:24.8598142Z /home/runner/work/neo-go/neo-go/pkg/core/blockchain.go:579 +0x544 2021-07-07T20:05:24.8599419Z github.com/nspcc-dev/neo-go/pkg/consensus.(service).processBlock() 2021-07-07T20:05:24.8601093Z /home/runner/work/neo-go/neo-go/pkg/consensus/consensus.go:521 +0x141 2021-07-07T20:05:24.8602485Z github.com/nspcc-dev/neo-go/pkg/consensus.(service).processBlock-fm() 2021-07-07T20:05:24.8603809Z /home/runner/work/neo-go/neo-go/pkg/consensus/consensus.go:517 +0x55 2021-07-07T20:05:24.8604910Z github.com/nspcc-dev/dbft.(DBFT).checkCommit() 2021-07-07T20:05:24.8606098Z /home/runner/go/pkg/mod/github.com/nspcc-dev/dbft@v0.0.0-20210302103605-cc75991b7cfb/check.go:73 +0xd8a 2021-07-07T20:05:24.8607235Z github.com/nspcc-dev/dbft.(DBFT).checkPrepare() 2021-07-07T20:05:24.8608551Z /home/runner/go/pkg/mod/github.com/nspcc-dev/dbft@v0.0.0-20210302103605-cc75991b7cfb/check.go:36 +0x677 2021-07-07T20:05:24.8609681Z github.com/nspcc-dev/dbft.(DBFT).sendPrepareRequest() 2021-07-07T20:05:24.8611016Z /home/runner/go/pkg/mod/github.com/nspcc-dev/dbft@v0.0.0-20210302103605-cc75991b7cfb/send.go:42 +0x47c 2021-07-07T20:05:24.8612107Z github.com/nspcc-dev/dbft.(DBFT).OnTimeout() 2021-07-07T20:05:24.8613257Z /home/runner/go/pkg/mod/github.com/nspcc-dev/dbft@v0.0.0-20210302103605-cc75991b7cfb/dbft.go:188 +0x68c 2021-07-07T20:05:24.8614499Z github.com/nspcc-dev/neo-go/pkg/consensus.(service).eventLoop() 2021-07-07T20:05:24.8615712Z /home/runner/work/neo-go/neo-go/pkg/consensus/consensus.go:274 +0x17ed 2021-07-07T20:05:24.8616284Z 2021-07-07T20:05:24.8616757Z Goroutine 51 (running) created at: 2021-07-07T20:05:24.8617367Z net/http.(Server).Serve() 2021-07-07T20:05:24.8618159Z /opt/hostedtoolcache/go/1.15.13/x64/src/net/http/server.go:2969 +0x5d3 2021-07-07T20:05:24.8619253Z github.com/nspcc-dev/neo-go/pkg/rpc/server.(Server).Start.func2() 2021-07-07T20:05:24.8620437Z /home/runner/work/neo-go/neo-go/pkg/rpc/server/server.go:224 +0x85 2021-07-07T20:05:24.8620936Z 2021-07-07T20:05:24.8621405Z Goroutine 41 (running) created at: 2021-07-07T20:05:24.8622393Z github.com/nspcc-dev/neo-go/pkg/consensus.(service).Start() 2021-07-07T20:05:24.8623562Z /home/runner/work/neo-go/neo-go/pkg/consensus/consensus.go:250 +0x17c 2021-07-07T20:05:24.8624682Z github.com/nspcc-dev/neo-go/pkg/network.(Server).tryStartServices() 2021-07-07T20:05:24.8626078Z /home/runner/work/neo-go/neo-go/pkg/network/server.go:445 +0x2e1 2021-07-07T20:05:24.8627226Z github.com/nspcc-dev/neo-go/pkg/network.(*Server).Start() 2021-07-07T20:05:24.8628333Z /home/runner/work/neo-go/neo-go/pkg/network/server.go:268 +0x2af 2021-07-07T20:05:24.8628973Z ==================	2021-07-08 10:40:54 +03:00
Roman Khimov	ea9dde257c	Merge pull request #2047 from nspcc-dev/fix-state Don't create an extension node for the last branch child	2021-07-08 10:20:59 +03:00
Evgeniy Stratonikov	a33e422b79	mpt: do not create an Extension for the last child of a Branch Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-07 15:49:53 +03:00
Evgeniy Stratonikov	25428d53f1	mpt: strip branch node in a simple implementation Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-07 15:47:07 +03:00
Roman Khimov	0cd9cd0c80	state/result: save/return real JSONization errors Don't hide/obfuscate real problems.	2021-07-07 00:42:36 +03:00
Roman Khimov	e62a766058	state: move nil check down to stackitem JSON processing We want to return real errors, not some generic thing for any kind of thing happening.	2021-07-07 00:38:19 +03:00
Roman Khimov	0de949b575	stackitem: remove Item/StackItem from function names They're useless in a package named 'stackitem', make this package a bit more user-friendly.	2021-07-06 19:56:23 +03:00
Evgeniy Stratonikov	9691eee10c	mpt: strip branch if 1 child is left If the child left is a hash node, we should retrieve it from store. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-05 11:04:20 +03:00
Evgeniy Stratonikov	d2e8254848	native: fix typo in comments Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-05 11:04:19 +03:00
Evgeniy Stratonikov	a7722f0fa5	native: save balance value in storage for failed transfers Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-05 11:03:42 +03:00
Roman Khimov	e3323faf69	Merge pull request #2032 from nspcc-dev/optimize-restore native: cache GAS per vote values	2021-07-01 15:17:37 +03:00
Evgeniy Stratonikov	0591366f85	native: cache GAS per vote values `storage.Seek()` is rather expensive and we need only last updated value of gas per block in `PostPersist()`. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-07-01 10:34:04 +03:00
Anna Shaleva	9673a04009	core: allow to add several headers with StateRootInHeader on Problem: with StateRootInHeader setting on only one header of height N+1 can be added to the chain of height N, because we need local stateroot to verify headers (which is calculated for the last stored block N). Thus, adding chunk of headers starting from the current chain's heigh is impossible and (*Blockchain).AddHeaders doesn't have much sense. Solution: verify header.PrevStateRoot only for header N+1. Rest of the headers should be added without PrevStateRoot verification.	2021-06-30 11:56:05 +03:00
Anna Shaleva	d49294b046	core: fix the way candidates are sorted (NEO).GetCandidates along with getCandidatesCall use candidates sorted by serialized ECPoint bytes. (NEO).computeCommitteeMembers use candidates sorted by votes, and then by deserialized ECPoint, i.e. using default ECPoint comparator.	2021-06-16 17:35:04 +03:00
Anna Shaleva	50296975e2	crypto: allow to provide non-default scrypt parameters	2021-06-11 15:22:28 +03:00
Anna Shaleva	6ff64153db	core: check stored native states against autogenerated ones on start	2021-06-10 22:16:05 +03:00
Anna Shaleva	be902afe9e	core: do not allow NEP17 roundtrip in case of insufficient funds NEP17 roundtrip is prohibited if from account doesn't have enough funds. This commit fixes states diff in block 92057 where account NfuwpaQ1A2xaeVbxWe8FRtaRgaMa8yF3YM initiates two NEO roundtrips with amount exceeding the account's balance: block 92057: value mismatch for key +////xTbYWBH3r5qhRKZAPFPHabKfb2vhQ==: QQMhAkwBIQOZZwEA vs QQMhAkwBIQN/ZwEA block 92057: value mismatch for key +v///ws=: kqlddcitCg== vs tphddcitCg== block 92057: value mismatch for key +v///xTbYWBH3r5qhRKZAPFPHabKfb2vhQ==: QQEhBUWyDu0W vs QQEhBWmhDu0W C#'s applog (contains False and False on stack for both transfers): ``` { "id" : 1, "jsonrpc" : "2.0", "result" : { "executions" : [ { "gasconsumed" : "11955500", "exception" : null, "stack" : [ { "value" : false, "type" : "Boolean" }, { "value" : false, "type" : "Boolean" } ], "vmstate" : "HALT", "trigger" : "Application", "notifications" : [] } ], "txid" : "0x8e73a7e9a566a514813907272ad65fc965002c3b098eacc5bdda529af19d7688" } } ``` Go's applog (both transfers succeeded and GAS minted): ``` { "result" : { "executions" : [ { "gasconsumed" : "11955500", "trigger" : "Application", "stack" : [ { "type" : "Boolean", "value" : true }, { "type" : "Boolean", "value" : true } ], "vmstate" : "HALT", "notifications" : [ { "eventname" : "Transfer", "contract" : "0xd2a4cff31913016155e38e474a2c06d08be276cf", "state" : { "value" : [ { "type" : "Any" }, { "value" : "22FgR96+aoUSmQDxTx2myn29r4U=", "type" : "ByteString" }, { "value" : "4316", "type" : "Integer" } ], "type" : "Array" } }, { "state" : { "type" : "Array", "value" : [ { "value" : "22FgR96+aoUSmQDxTx2myn29r4U=", "type" : "ByteString" }, { "type" : "ByteString", "value" : "22FgR96+aoUSmQDxTx2myn29r4U=" }, { "type" : "Integer", "value" : "1111111111" } ] }, "contract" : "0xef4073a0f2b305a38ec4050e4d3d28bc40ea63f5", "eventname" : "Transfer" }, { "contract" : "0xef4073a0f2b305a38ec4050e4d3d28bc40ea63f5", "state" : { "type" : "Array", "value" : [ { "value" : "22FgR96+aoUSmQDxTx2myn29r4U=", "type" : "ByteString" }, { "type" : "ByteString", "value" : "22FgR96+aoUSmQDxTx2myn29r4U=" }, { "type" : "Integer", "value" : "1111111" } ] }, "eventname" : "Transfer" } ] } ], "txid" : "0x8e73a7e9a566a514813907272ad65fc965002c3b098eacc5bdda529af19d7688" }, "id" : 1, "jsonrpc" : "2.0" } ```	2021-06-09 13:36:50 +03:00
Anna Shaleva	20e0a0d746	core: add price for CALLT instruction	2021-06-07 19:17:22 +03:00
Evgeniy Stratonikov	f3d02b9fef	mpt/tests: add compatibility tests	2021-06-04 11:09:17 +03:00
Evgeniy Stratonikov	e833d333fe	mpt: disallow empty keys This is not a problem in practice, as all keys are prefixed by a contract ID. However in theory it can lead to a different state root after new portion of changes thus this fix.	2021-06-04 11:09:17 +03:00
Evgeniy Stratonikov	5b1f6207de	mpt: reduce max key length The constant used is actually a nibbled-path restriction. Clarify this and make them private.	2021-06-04 11:09:17 +03:00
Anna Shaleva	b8e96ac82b	core: move mempool.Event to a separate package And write a marshaller for EventType, it'll be reused by the Notification subsystem.	2021-06-01 12:24:28 +03:00
Anna Shaleva	999fba81cd	core: export (*NEOBalanceState).FromStackItem	2021-05-31 11:18:54 +03:00
Roman Khimov	b858be63b4	Merge pull request #1969 from nspcc-dev/examples/nns-fix examples: fix IPv6 bounds check	2021-05-28 14:29:54 +03:00
Anna Shaleva	2a9ce03376	examples: fix IPv6 bounds check	2021-05-28 11:31:09 +03:00
Evgeniy Stratonikov	233996eec0	native/neo: add `getAccountState` method, close #1975	2021-05-27 10:59:38 +03:00
Evgeniy Stratonikov	192771a58a	native/std: add base58Check* methods, close #1974	2021-05-25 17:32:19 +03:00
Roman Khimov	e0779f2d6e	Merge pull request #1965 from nspcc-dev/native/remove_nns native: remove NNS contract	2021-05-17 22:51:58 +03:00
Anna Shaleva	2d20b0fa23	core: remove nnsrecords package from native Use nns from examples instead.	2021-05-17 22:24:56 +03:00
Anna Shaleva	c9099fa555	core: remove native nonfungible token	2021-05-17 22:22:07 +03:00
Anna Shaleva	99b37efc31	core: remove native NNS	2021-05-17 22:22:07 +03:00
Anna Shaleva	4c4361b2c6	native: move\remove native NNS tests Record types test is moved to non-native NNS tests and adjusted according to the non-native implementation behavior. NEP11-compliance test is removed (non-native NNS is checked against NEP11 standard during examples compilation test). Domain name test is removed (we already have the same non-native NNS tests).	2021-05-17 22:22:03 +03:00
Anna Shaleva	bfda758221	core: replace native NNS with non-native NNS in core tests	2021-05-17 22:12:38 +03:00
Anna Shaleva	7180b2ce06	rpc: use non-native NNS instead of native NNS in testchain	2021-05-17 22:08:15 +03:00
Anna Shaleva	4f1c50373f	core: detalize errors during contract.LoadToken and contract.Call	2021-05-17 22:08:15 +03:00
Evgeniy Stratonikov	33e1e61343	config: make `MaxValidUntilBlockIncrement` configurable	2021-05-17 13:43:03 +03:00
Roman Khimov	f2f9ec1a05	Merge pull request #1916 from nspcc-dev/fix/oraclefilter oracle: make JSONPath compatible with C# implementation	2021-05-13 15:34:52 +03:00
Evgeniy Stratonikov	1c30d8c395	oracle: make JSONPath compatible with C# implementation C# node uses simplified implementation which is easy to port.	2021-05-13 11:53:28 +03:00
Roman Khimov	9d2712573f	*: enable godot linter and fix all its warnings It's important for NeoGo to have clean documentation. No functional changes.	2021-05-12 23:17:03 +03:00
Roman Khimov	c4e084b0d8	*: fix whitespace errors leading/trailing newlines	2021-05-12 22:51:41 +03:00
Roman Khimov	b1710bebaa	native: fix errcheck errors in nns contract	2021-05-12 21:49:42 +03:00
Roman Khimov	e9cefc4bfc	*: fix all errcheck warnings in testing code	2021-05-12 21:45:12 +03:00
Roman Khimov	4cd3da99b4	core: fix ineffassign warning in test code ineffectual assignment to err (ineffassign)	2021-05-12 19:37:14 +03:00
Roman Khimov	b5ff87c2bd	native: fix minimum deployment fee setting SA4003: no value of type uint32 is less than 0 (staticcheck) But it's more involved than that, we should allow any positive big.Int here.	2021-05-12 19:27:02 +03:00
Roman Khimov	333f778aa6	*: drop empty branches Fix this warning from staticcheck: SA9003: empty branch	2021-05-12 19:10:31 +03:00
Roman Khimov	92dbb3c4b9	*: fix all `unused` warnings From golangci-lint.	2021-05-12 18:53:12 +03:00
Roman Khimov	bd48454c72	mempool: simpilfy boolean comparisons in test code gosimple: S1008: should use 'return t == tx2' instead of 'if t == tx2 { return true }; return false'	2021-05-12 18:40:41 +03:00

... 6 7 8 9 10 ...

2177 commits