4717 commits

Author	SHA1	Message	Date
Roman Khimov	0055b18a8a	core: export CreateGenesisBlock ... Nothing bad with it being public.	2022-06-08 18:20:34 +03:00
Roman Khimov	d70caf1da1	core: move GetScriptContainer to runtime ... It also brings ToStackItem to Block and Transaction, previously this was avoided to separate block and transaction packages from VM. But turns out `transaction` depends on `stackitem` already, so this makes little sense (but can be shuffled in another way if needed). Context.Container is still a hash.Hashable because we have a number of occasions (header or MPT root verification) where there is no ToStackItem implementation possible. Maybe they can go with `nil` Container, but I don't want to have this risk for now.	2022-06-08 18:12:41 +03:00
Roman Khimov	cdb55740ea	core: move ContractCreate*Account tests into the contract pkg ... No functional changes.	2022-06-08 16:56:06 +03:00
Roman Khimov	ff1545b7eb	core: move TestContractCall into the contract package ... It belongs there and now it can be moved. No functional changes.	2022-06-08 16:53:01 +03:00
Roman Khimov	bb021d0778	native: unbind PutContractState from Management ... It doesn't need Management's state, ID can't really change.	2022-06-08 16:41:28 +03:00
Roman Khimov	209b977e9a	core: move contract-related interop code into appropriate package ... And move one of the tests with it.	2022-06-08 16:02:07 +03:00
Roman Khimov	10f94e6119	core: move chain dump test into its own package	2022-06-08 15:28:08 +03:00
Roman Khimov	c2b3ee3d8e	core: move basic chain creation into a package of its own ... This allows to reuse it across different packages. testchain can't be used because of circular dependencies. Init() is not changed except for filepath.Join() use instead of direct string appends which is a better approach anyway. rootpath is required because current directory will change from package to package.	2022-06-08 15:25:27 +03:00
Roman Khimov	8673d2a79c	Merge pull request #2543 from nspcc-dev/perf-new ... Minor allocation improvements	2022-06-07 11:04:59 +03:00
Roman Khimov	19ad31dc52	vm: optimize IsSignatureContract ... We use it a lot in (*Blockchain).IsTxStillRelevant(). name old time/op new time/op delta IsSignatureContract-8 19.1ns ± 5% 1.2ns ± 4% -93.81% (p=0.000 n=10+10) name old alloc/op new alloc/op delta IsSignatureContract-8 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta IsSignatureContract-8 0.00 0.00 ~ (all equal)	2022-06-07 10:29:13 +03:00
Roman Khimov	92c94f265c	interop/vm: make VM reusable and use on VM for all in-block execs ... Avoid allocating again and again. Increases TPS by about 3%.	2022-06-07 10:05:47 +03:00
Roman Khimov	bdc6624c9d	interop: unify VM price getter setting	2022-06-06 22:00:16 +03:00
Roman Khimov	638b04b29a	interop: wrap contract.LoadToken in context.LoadToken ... Creating a closure in runtime is a relatively costly thing, but it can easily be avoided.	2022-06-06 21:53:03 +03:00
Anna Shaleva	7612ad1195	rpc: adjust test data	2022-06-06 13:02:29 +03:00
Anna Shaleva	7dcbfcbbdb	rpc: improve WS connection closure error a bit ... Ref. https://github.com/nspcc-dev/neofs-node/pull/1480#issuecomment-1147256917.	2022-06-06 12:58:42 +03:00
Anna Shaleva	1005c1f7db	vm: forbid jumping out of the script bounds	2022-06-06 12:18:19 +03:00
Anna Shaleva	a5b5f88fe2	core: doesn't allow to deploy contract with invalid method offset ... This commit partially reverts 16bf7c1426.	2022-06-06 12:18:16 +03:00
Anna Shaleva	bc85f00cc7	Partially revert "core: fix native NEO ABI" ... This partially reverts commit ca127f1615.	2022-06-06 12:08:52 +03:00
Roman Khimov	799394192b	state: create buffer/io writer once per TokenTransferLog ... name old time/op new time/op delta TokenTransferLog_Append-8 93.0µs ±170% 46.8µs ±152% ~ (p=0.053 n=10+9) name old alloc/op new alloc/op delta TokenTransferLog_Append-8 53.8kB ± 4% 38.6kB ±39% -28.26% (p=0.004 n=8+10) name old allocs/op new allocs/op delta TokenTransferLog_Append-8 384 ± 0% 128 ± 0% -66.67% (p=0.000 n=10+10)	2022-06-04 00:11:11 +03:00
Roman Khimov	1e5825c4af	core: don't allocate another int for notification handler ... It'll be serialized anyway.	2022-06-03 23:39:46 +03:00
Roman Khimov	7a2199c495	Merge pull request #2535 from nspcc-dev/drop-hf-prefix ... config: s/HF_Aspidochelone/Aspidochelone/	2022-06-03 11:59:53 +03:00
Roman Khimov	b6829f36fd	config: s/HF_Aspidochelone/Aspidochelone/ ... HF_ prefix makes zero sense to me. If it's "hardfork", then it's in the "Hardforks" section already. If it's "hotfix", then it made some sense back when it was HF_2712_FixSyscallFees, but now it's codenamed anyway. So we can drop it and have a cleaner config.	2022-06-03 11:53:18 +03:00
Anna Shaleva	629567717f	compiler: make TestNativeHelpersCompile test more verbose	2022-06-03 11:37:50 +03:00
Anna Shaleva	ca519492fc	rpc: adjust test data	2022-06-03 11:37:50 +03:00
Anna Shaleva	d3b15a60a2	core: add test for ABI checks on deploy ... Make sure it compatible with the reference implementation, see 736c346b9d/src/neo/SmartContract/Helper.cs (L83).	2022-06-03 11:37:50 +03:00
Anna Shaleva	16bf7c1426	core: adjust contract script check on deploy ... Reference implementation doesn't panic if the method offset is out of the contract script bounds, see: 736c346b9d/src/neo/SmartContract/Helper.cs (L82) and a65487fa56/src/Neo.VM/Script.cs (L146). This commit fixes T5 statediff at block #125000. Neo-go node FAULTed the deploying transaction: ``` { "version" : 0, "sysfee" : "1000106065", "validuntilblock" : 130758, "script" : "DdMDeyJuYW1lIjoiTmVwMTdUb2tlbiIsImdyb3VwcyI6W10sImZlYXR1cmVzIjp7fSwic3VwcG9ydGVkc3RhbmRhcmRzIjpbIk5FUC0xNyJdLCJhYmkiOnsibWV0aG9kcyI6W3sibmFtZSI6InN5bWJvbCIsInBhcmFtZXRlcnMiOltdLCJyZXR1cm50eXBlIjoiU3RyaW5nIiwib2Zmc2V0IjoyMiwic2FmZSI6dHJ1ZX0seyJuYW1lIjoiZGVjaW1hbHMiLCJwYXJhbWV0ZXJzIjpbXSwicmV0dXJudHlwZSI6IkludGVnZXIiLCJvZmZzZXQiOjIyLCJzYWZlIjp0cnVlfSx7Im5hbWUiOiJ0b3RhbFN1cHBseSIsInBhcmFtZXRlcnMiOltdLCJyZXR1cm50eXBlIjoiSW50ZWdlciIsIm9mZnNldCI6MjIsInNhZmUiOnRydWV9LHsibmFtZSI6ImJhbGFuY2VPZiIsInBhcmFtZXRlcnMiOlt7Im5hbWUiOiJvd25lciIsInR5cGUiOiJIYXNoMTYwIn1dLCJyZXR1cm50eXBlIjoiSW50ZWdlciIsIm9mZnNldCI6MjIsInNhZmUiOnRydWV9LHsibmFtZSI6InRyYW5zZmVyIiwicGFyYW1ldGVycyI6W3sibmFtZSI6ImZyb20iLCJ0eXBlIjoiSGFzaDE2MCJ9LHsibmFtZSI6InRvIiwidHlwZSI6Ikhhc2gxNjAifSx7Im5hbWUiOiJhbW91bnQiLCJ0eXBlIjoiSW50ZWdlciJ9LHsibmFtZSI6ImRhdGEiLCJ0eXBlIjoiQW55In1dLCJyZXR1cm50eXBlIjoiQm9vbGVhbiIsIm9mZnNldCI6MjIsInNhZmUiOmZhbHNlfV0sImV2ZW50cyI6W3sibmFtZSI6IlRyYW5zZmVyIiwicGFyYW1ldGVycyI6W3sibmFtZSI6ImZyb20iLCJ0eXBlIjoiSGFzaDE2MCJ9LHsibmFtZSI6InRvIiwidHlwZSI6Ikhhc2gxNjAifSx7Im5hbWUiOiJhbW91bnQiLCJ0eXBlIjoiSW50ZWdlciJ9XX1dfSwicGVybWlzc2lvbnMiOlt7ImNvbnRyYWN0IjoiKiIsIm1ldGhvZHMiOiIqIn1dLCJ0cnVzdHMiOltdLCJleHRyYSI6eyJlbWFpbCI6ImRldmVsb3BlckBuZW8ub3JnIiwiYXV0aG9yIjoibGF6eW5vZGUiLCJkZXNjcmlwdGlvbiI6IkEgU2ltcGxlIE5lcC0xNyBDb250cmFjdCJ9fQyyTkVGM25lb21sAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABOaHR0cHM6Ly9naXRodWIuY29tL2xhenlub2RlL25lb21sL2Jsb2IvZGV2L2V4YW1wbGVzL2EuZnVuY3Rpb24uc2ltcGxlbmVwMTcueG1sAAAAABYMBU5lb01MQBhAAgDh9QVAATkFQBFAkA456BLAHwwGZGVwbG95DBT9o/pDRupTKiWPxJfdrdtkN8n9/0FifVtS", "hash" : "0x40302bcf2021f63a1c24f6009e154c3200f73ad2fe1462d7d599145823dbfa7e", "witnesses" : [ { "verification" : "DCECExn08eznGBdguHbcwI+R2//EtVdDx4qf6CeizHqOJgBBVuezJw==", "invocation" : "DEBtoq+T9NrammQjuYnifco7KHCTk2v+woEJqJCUMr9IscS7PaZaN3FNzSt11yUglIi3T0CJ17KwArBOBvJ8kwq2" } ], "attributes" : [], "signers" : [ { "scopes" : "None", "account" : "0x13a192c56738900f9918d7f1ec07d9d8c278b804" } ], "size" : 1360, "nonce" : 1829882407, "sender" : "NLLvsqs7AyBNmQT6NThUxYWDFwV5b1evaK", "netfee" : "234352" } ``` Transaction script contains malformed contract manifest (all methods offsets are set to be 22, while the contract script lenght is 22): ``` { "name" : "Nep17Token", "groups" : [], "extra" : { "description" : "A Simple Nep-17 Contract", "email" : "developer@neo.org", "author" : "lazynode" }, "permissions" : [ { "contract" : "*", "methods" : "*" } ], "features" : {}, "supportedstandards" : [ "NEP-17" ], "abi" : { "events" : [ { "parameters" : [ { "name" : "from", "type" : "Hash160" }, { "type" : "Hash160", "name" : "to" }, { "name" : "amount", "type" : "Integer" } ], "name" : "Transfer" } ], "methods" : [ { "safe" : true, "offset" : 22, "name" : "symbol", "returntype" : "String", "parameters" : [] }, { "returntype" : "Integer", "parameters" : [], "safe" : true, "offset" : 22, "name" : "decimals" }, { "parameters" : [], "returntype" : "Integer", "name" : "totalSupply", "safe" : true, "offset" : 22 }, { "parameters" : [ { "name" : "owner", "type" : "Hash160" } ], "returntype" : "Integer", "name" : "balanceOf", "offset" : 22, "safe" : true }, { "name" : "transfer", "offset" : 22, "safe" : false, "parameters" : [ { "type" : "Hash160", "name" : "from" }, { "name" : "to", "type" : "Hash160" }, { "name" : "amount", "type" : "Integer" }, { "name" : "data", "type" : "Any" } ], "returntype" : "Boolean" } ] }, "trusts" : [] } ```	2022-06-03 11:37:50 +03:00
Anna Shaleva	1472c271e6	core: fix native NEO's getCandidateVote signature ... This commit fixes T5 statediff at block #0. Management's storage item differs between neo-go and C# nodes, the reason in native NEO contract state. The parameter should have `pubKey` name, unlike the other `pubkey` arguments in this contract.	2022-06-03 11:37:50 +03:00
Anna Shaleva	ca127f1615	core: fix native NEO ABI ... This commit fixes T5 statediff at block #0. The reason in Management's storage state. The diff occurs because of inconsistent NEO methods order. See https://github.com/neo-project/neo/issues/2766#issue-1257870089. The current solution is to preserve C#'s order of methods to be compatible with current testnet. See also https://docs.microsoft.com/ru-ru/dotnet/api/system.stringcomparer?view=net-6.0 and https://stackoverflow.com/questions/28638714/easiest-method-to-orderby-a-string-using-stringcomparison-ordinal for more details.	2022-06-03 11:37:41 +03:00
Roman Khimov	edb6ca8926	Merge pull request #2531 from nspcc-dev/perf ... Minor performance improvements	2022-06-03 10:40:56 +03:00
Roman Khimov	400cbde32c	state: optimize allocations in (*NEP17Transfer).EncodeBinary	2022-06-02 15:38:39 +03:00
Roman Khimov	54f75bb999	consensus: don't use WriteArray for PrepareRequests ... It's convenient, but it's not efficient due to reflection use.	2022-06-02 15:38:39 +03:00
Roman Khimov	b0744c2b21	util: optimize MarshalJSON allocations ... name old time/op new time/op delta Uint256MarshalJSON-8 230ns ± 6% 83ns ±13% -63.78% (p=0.000 n=8+10) name old alloc/op new alloc/op delta Uint256MarshalJSON-8 320B ± 0% 80B ± 0% -75.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta Uint256MarshalJSON-8 5.00 ± 0% 1.00 ± 0% -80.00% (p=0.000 n=10+10)	2022-06-02 15:38:39 +03:00
Roman Khimov	9a06995460	bigint: don't allocate in ToPreallocatedBytes ... Turns out, it's almost always allocating because we're mostly dealing with small integers while the buffer size is calculated in 8-byte chunks here, so preallocated buffer is always insufficient. name old time/op new time/op delta ToPreallocatedBytes-8 28.5ns ± 7% 19.7ns ± 5% -30.72% (p=0.000 n=10+10) name old alloc/op new alloc/op delta ToPreallocatedBytes-8 16.0B ± 0% 0.0B -100.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta ToPreallocatedBytes-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10) Fix StorageItem reuse at the same time. We don't copy when getting values from the storage, but we don when we're putting them, so buffer reuse could corrupt old values.	2022-06-02 15:38:39 +03:00
Roman Khimov	c3d989ebda	stackitem: reusable serialization context ... We serialize items a lot and this allows to avoid a number of allocations.	2022-06-02 15:38:39 +03:00
Anna Shaleva	3bec6657f5	core: adjust notary-related attributes encoding	2022-06-01 15:09:06 +03:00
Anna Shaleva	1b80215415	core: adjust types of NVB, Conflicts and NotaryAssisted attributes	2022-06-01 15:09:06 +03:00
Anna Shaleva	c4f3a92485	rpc: regenerate testchain	2022-06-01 15:09:02 +03:00
Anna Shaleva	d540f16e37	core: adjust noderoles package usages ... Don't use interop roles package for internal tests.	2022-06-01 15:03:29 +03:00
Anna Shaleva	56d5839a72	core: log stateroot N20 hash inside TestCreateBasicChain	2022-06-01 15:03:29 +03:00
AnnaShaleva	4291efc8f0	services: fix typo in method description	2022-06-01 15:03:29 +03:00
AnnaShaleva	50157b31cd	core: add maximum constraint to setNotaryServiceFeePerKey	2022-06-01 15:03:29 +03:00
AnnaShaleva	d7afb7bb2f	core: adjust value of P2PNotary node role	2022-06-01 15:03:29 +03:00
AnnaShaleva	9008cc500c	core: adjust Notary contract ID	2022-06-01 15:03:29 +03:00
Roman Khimov	3d4076ca36	vm: microoptimize new estack creation ... Subslice won't reach element -1, but it can reuse the same buffer space more effectively.	2022-05-31 18:53:05 +03:00
Roman Khimov	10110d4e70	bigint: correct MaxBytesLen ... It can't be 33, positive signed int256 all fit into 32 bytes (no need for leading zero), negative ones fit into 32 bytes as well.	2022-05-31 16:51:19 +03:00
Roman Khimov	3945e81857	bigint: don't allocate in ToPreallocatedBytes() for negative numbers ... In-place modifications are somewhat dangerous, but yet another allocation is quite costly.	2022-05-31 12:45:34 +03:00
Roman Khimov	3509523baf	contract: tune isolation logic ... Wrap when we have outer exception handler and the method is not safe. Otherwise we wrap almost always, since non-readonly methods are very common.	2022-05-31 11:44:12 +03:00
Roman Khimov	e1607e23c2	Merge pull request #2525 from nspcc-dev/immutable-items ... vm: implement immutable stackitems	2022-05-31 10:36:56 +03:00
Anna Shaleva	42a051e55a	core: DeepCopy notifiction event args inside System.Runtime.Notify	2022-05-31 08:07:53 +03:00
Anna Shaleva	7296f0c913	vm: support immutable compound types	2022-05-31 08:07:50 +03:00
Anna Shaleva	107f5e0793	vm: adjust refcount operations order ... Perform add/set/remove operations with VM type firstly, and with refcounter after that. It is needed to be able to extend add/set/remove operations with extra checks.	2022-05-31 08:02:13 +03:00
Roman Khimov	270dfbe241	Merge pull request #2526 from nspcc-dev/rpc-err ... rpc: do not allow empty error's Cause	2022-05-30 17:12:57 +03:00
Anna Shaleva	ebc3974545	rpc: do not allow empty error's Cause ... Server logger is broken after #2496: ``` 2022-05-30T10:35:06.096Z ERROR Error encountered with rpc request ```	2022-05-30 15:58:46 +03:00
Evgeniy Stratonikov	ec21c14ca9	gomod: upgrade yaml package from v2 to v3 ... Close #2085. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-05-30 15:26:17 +03:00
Roman Khimov	5e013311e6	native: emit vote/candidate events ... Follow neo-project/neo#2754.	2022-05-28 18:44:20 +03:00
Roman Khimov	502cdd68ab	Merge pull request #2508 from nspcc-dev/snapshot-isolation ... core, vm: implement snapshot isolation	2022-05-27 12:44:06 +03:00
Anna Shaleva	8055952bbc	core: rename hardfork HF_2712_FixSyscallFees ... Fantastic Beasts and Where to Find Them	2022-05-26 14:20:48 +03:00
Anna Shaleva	c4ad434f20	core: adjust System.Runtime.GetRandom ... 1. Make seed dependant on the GetRandom invocations counter. 2. Adjust syscall price.	2022-05-26 14:20:12 +03:00
Anna Shaleva	a79c80cb8d	vm: wrap cross-contract exceptions	2022-05-26 11:44:26 +03:00
Anna Shaleva	a39b7cc3fd	core, vm: move all isolation-related logic out of VM ... Keep it inside the interop context.	2022-05-26 09:26:31 +03:00
Anna Shaleva	f79f62dab4	vm: use single function instead of committer/discarder	2022-05-26 09:26:31 +03:00
Anna Shaleva	08b68e9b82	vm, core: push Null return value only if no exception occurs ... Close https://github.com/nspcc-dev/neo-go/issues/2509.	2022-05-26 09:26:31 +03:00
Anna Shaleva	ce226f6b76	vm: optimize context wrapping code ... We can omit DAO wrapping for safe methods and for those methods that are not wrapped into try-catch block. However, we still need to persist notificationsCount changes for these methods to the parent context.	2022-05-26 09:26:31 +03:00
Anna Shaleva	0cd19f550e	core, vm: implement snapshot isolation ... Initial implementation without optimisations, but it should work.	2022-05-26 09:26:25 +03:00
Roman Khimov	c6666c52bc	Merge pull request #2515 from nspcc-dev/interop-marshalling ... vm: stringify InteropInterface stackitem type as `InteropInterface`	2022-05-25 13:38:26 +03:00
Anna Shaleva	a3285eae04	vm: stringify InteropInterface stackitem type as InteropInterface	2022-05-25 13:20:21 +03:00
Anna Shaleva	98b5e2b353	rpc: always marshal FaultException	2022-05-25 10:48:58 +03:00
Roman Khimov	f77a775e61	core: raise System.Runtime.GetNotifications fee ... Fix DoS, follow neo-project/neo#2748.	2022-05-24 17:45:23 +03:00
Roman Khimov	c9ab553e5b	Merge pull request #2510 from nspcc-dev/rpc/ws-errors ... rpc: add ability to get WSClient connection closure error	2022-05-24 13:15:40 +03:00
Anna Shaleva	19646e0967	rpc: add ability to get WSClient connection closure error ... Close #2421.	2022-05-24 11:29:19 +03:00
Anna Shaleva	d8f7d5d5b6	core: adjust Signer to stackitem conversion ... Follow the https://github.com/neo-project/neo/pull/2708.	2022-05-23 14:01:42 +03:00
Anna Shaleva	b840674433	neotest: return failed tx hash ... It still may be useful for debugging and tests.	2022-05-19 13:56:24 +03:00
Anna Shaleva	deb1f6d3d8	core: emit notification events in a separate method	2022-05-19 08:48:26 +03:00
Roman Khimov	73ef36e03e	Merge pull request #2507 from nspcc-dev/fix-ws-read ... rpc: increase server-side WS read limit for websocket RPC message	2022-05-18 13:06:39 +03:00
Anna Shaleva	1a07d0f039	rpc: increase server-side WS read limit for websocket RPC message ... Close #2505. Turns out that existing limit is too low to fit `submitp2pnotaryrequest`. Thanks to @alexvanin for discovering this.	2022-05-18 12:53:50 +03:00
Roman Khimov	34e7d3e53c	Merge pull request #2499 from nspcc-dev/fix-concurrent-seek ... core: avoid concurrent map iteration and map write during SeekAsync over private MemCachedStore	2022-05-18 11:36:57 +03:00
Anna Shaleva	b66f666267	core: ensure memcached Seek operation is properly cancelled ... PR #2495 is not enought, the problem is reproduced during dump restore with the stacktrace attached down below. The reason is that SeekAsync starts goroutine that performs Seek operation over private MemCachedStore. The goroutine iterates over MemCachedStore's map without holding the lock (it's OK, because it's private), whereas the main thread continues invocation and performs writes to the same map. To fix that ic.Exec() needs to wait until all goroutines are properly exited. ``` 2022-05-17T08:34:50.430+0300 INFO persisted to disk {"blocks": 632, "keys": 16546, "headerHeight": 54091, "blockHeight": 54091, "took": "57.904387ms"} fatal error: concurrent map iteration and map write goroutine 218853 [running]: runtime.throw({0xf56a31, 0x614968}) runtime/panic.go:1198 +0x71 fp=0xc0000ceae0 sp=0xc0000ceab0 pc=0x4357b1 runtime.mapiternext(0x0) runtime/map.go:858 +0x4eb fp=0xc0000ceb50 sp=0xc0000ceae0 pc=0x40f82b runtime.mapiterinit(0xc0000cec18, 0xc00359ca40, 0x1a) runtime/map.go:848 +0x236 fp=0xc0000ceb70 sp=0xc0000ceb50 pc=0x40f2f6 github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).prepareSeekMemSnapshot(0xc005315680, {{0xc00359ca40, 0x1a, 0x1a}, {0x0, 0x0, 0x0}, 0x0}) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:209 +0x24a fp=0xc0000ced88 sp=0xc0000ceb70 pc=0x823fca github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).Seek(0xd94ac0, {{0xc00359ca40, 0x1a, 0x1a}, {0x0, 0x0, 0x0}, 0x0}, 0x20) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:156 +0x9b fp=0xc0000cee20 sp=0xc0000ced88 pc=0x82369b github.com/nspcc-dev/neo-go/pkg/core/storage.performSeek({0x11c3330, 0xc002240dc0}, {0x11cb258, 0xc005315680}, {0x0, 0x0, 0x1}, {{0xc00359ca40, 0x1a, 0x1a}, ...}, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:304 +0x4b7 fp=0xc0000cef00 sp=0xc0000cee20 pc=0x824a37 github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).SeekAsync.func1() github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:176 +0x16c fp=0xc0000cefe0 sp=0xc0000cef00 pc=0x823b8c runtime.goexit() runtime/asm_amd64.s:1581 +0x1 fp=0xc0000cefe8 sp=0xc0000cefe0 pc=0x468a41 created by github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).SeekAsync github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:175 +0x1f6 goroutine 1 [runnable]: github.com/nspcc-dev/neo-go/pkg/core/mpt.MapToMPTBatch.func1(0x4, 0x0) github.com/nspcc-dev/neo-go/pkg/core/mpt/batch.go:28 +0x95 sort.doPivot_func({0xc000457878, 0xc003305bc0}, 0x0, 0x1a) sort/zfuncversion.go:121 +0x46a sort.quickSort_func({0xc000457878, 0xc003305bc0}, 0xc001014d20, 0x0, 0xc003304ff0) sort/zfuncversion.go:143 +0x85 sort.Slice({0xd94800, 0xc001014d20}, 0x1a) sort/slice.go:20 +0x9f github.com/nspcc-dev/neo-go/pkg/core/mpt.MapToMPTBatch(0xc003304ff0) github.com/nspcc-dev/neo-go/pkg/core/mpt/batch.go:28 +0x2e7 github.com/nspcc-dev/neo-go/pkg/core.(*Blockchain).storeBlock(0xc000400280, 0xc000f178c0, 0xc005a04370) github.com/nspcc-dev/neo-go/pkg/core/blockchain.go:1136 +0xfef github.com/nspcc-dev/neo-go/pkg/core.(*Blockchain).AddBlock(0xc000400280, 0xc000f178c0) github.com/nspcc-dev/neo-go/pkg/core/blockchain.go:893 +0x755 github.com/nspcc-dev/neo-go/pkg/core/chaindump.Restore({0x11c3528, 0xc000400280}, 0xc350, 0x0, 0x4c221, 0xc000458710) github.com/nspcc-dev/neo-go/pkg/core/chaindump/dump.go:73 +0x2ca github.com/nspcc-dev/neo-go/cli/server.restoreDB(0xc000410000) github.com/nspcc-dev/neo-go/cli/server/server.go:381 +0xcfa github.com/urfave/cli.HandleAction({0xdbbfa0, 0x10a1078}, 0x7) github.com/urfave/cli@v1.22.5/app.go:524 +0xa8 github.com/urfave/cli.Command.Run({{0xf32b10, 0x7}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0xf4a41d, 0x1c}, {0x0, ...}, ...}, ...) github.com/urfave/cli@v1.22.5/command.go:173 +0x652 github.com/urfave/cli.(*App).RunAsSubcommand(0xc0001f7880, 0xc0001adce0) github.com/urfave/cli@v1.22.5/app.go:405 +0x9ec github.com/urfave/cli.Command.startApp({{0xf2e982, 0x2}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0xf41af9, 0x16}, {0x0, ...}, ...}, ...) github.com/urfave/cli@v1.22.5/command.go:372 +0x6e9 github.com/urfave/cli.Command.Run({{0xf2e982, 0x2}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0xf41af9, 0x16}, {0x0, ...}, ...}, ...) github.com/urfave/cli@v1.22.5/command.go:102 +0x808 github.com/urfave/cli.(*App).Run(0xc0001f76c0, {0xc00012e000, 0x8, 0x8}) github.com/urfave/cli@v1.22.5/app.go:277 +0x705 main.main() ./main.go:19 +0x33 goroutine 66 [select]: github.com/syndtr/goleveldb/leveldb/util.(*BufferPool).drain(0xc00027e1c0) github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/util/buffer_pool.go:209 +0xcd created by github.com/syndtr/goleveldb/leveldb/util.NewBufferPool github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/util/buffer_pool.go:240 +0x19b goroutine 67 [select]: github.com/syndtr/goleveldb/leveldb.(*session).refLoop(0xc0002441e0) github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/session_util.go:189 +0x5bb created by github.com/syndtr/goleveldb/leveldb.newSession github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/session.go:93 +0x2de goroutine 85 [select]: github.com/syndtr/goleveldb/leveldb.(*DB).compactionError(0xc0001f7a40) github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/db_compaction.go:91 +0x15e created by github.com/syndtr/goleveldb/leveldb.openDB github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/db.go:148 +0x4ef goroutine 86 [select]: github.com/syndtr/goleveldb/leveldb.(*DB).mpoolDrain(0xc0001f7a40) github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/db_state.go:101 +0xae created by github.com/syndtr/goleveldb/leveldb.openDB github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/db.go:149 +0x531 goroutine 87 [runnable]: github.com/syndtr/goleveldb/leveldb.(*compaction).shouldStopBefore(0xc001787440, {0xc001890720, 0x29, 0x30}) github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/session_compaction.go:272 +0x10a github.com/syndtr/goleveldb/leveldb.(*tableCompactionBuilder).run(0xc0001ca140, 0xc002039638) github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/db_compaction.go:461 +0x565 github.com/syndtr/goleveldb/leveldb.(*DB).compactionTransact(0xc0001f7a40, {0xf369f0, 0xb}, {0x11b9b60, 0xc0001ca140}) github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/db_compaction.go:186 +0x22f github.com/syndtr/goleveldb/leveldb.(*DB).tableCompaction(0xc0001f7a40, 0xc001787440, 0x0) github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/db_compaction.go:580 +0xa30 github.com/syndtr/goleveldb/leveldb.(*DB).tableAutoCompaction(0xc0001f7a40) github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/db_compaction.go:644 +0x39 github.com/syndtr/goleveldb/leveldb.(*DB).tCompaction(0xc0001f7a40) github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/db_compaction.go:863 +0x43b created by github.com/syndtr/goleveldb/leveldb.openDB github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/db.go:155 +0x5a7 goroutine 88 [select]: github.com/syndtr/goleveldb/leveldb.(*DB).mCompaction(0xc0001f7a40) github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/db_compaction.go:773 +0x119 created by github.com/syndtr/goleveldb/leveldb.openDB github.com/syndtr/goleveldb@v1.0.1-0.20210305035536-64b5b1c73954/leveldb/db.go:156 +0x5e9 goroutine 78 [select]: github.com/nspcc-dev/neo-go/pkg/core.(*Blockchain).Run(0xc000400280) github.com/nspcc-dev/neo-go/pkg/core/blockchain.go:615 +0x185 created by github.com/nspcc-dev/neo-go/cli/server.initBCWithMetrics github.com/nspcc-dev/neo-go/cli/server/server.go:217 +0x23d goroutine 79 [IO wait]: internal/poll.runtime_pollWait(0x7ffb00b2aad8, 0x72) runtime/netpoll.go:229 +0x89 internal/poll.(*pollDesc).wait(0xc00012e180, 0x4, 0x0) internal/poll/fd_poll_runtime.go:84 +0x32 internal/poll.(*pollDesc).waitRead(...) internal/poll/fd_poll_runtime.go:89 internal/poll.(*FD).Accept(0xc00012e180) internal/poll/fd_unix.go:402 +0x22c net.(*netFD).accept(0xc00012e180) net/fd_unix.go:173 +0x35 net.(*TCPListener).accept(0xc000280090) net/tcpsock_posix.go:140 +0x28 net.(*TCPListener).Accept(0xc000280090) net/tcpsock.go:262 +0x3d net/http.(*Server).Serve(0xc00027e380, {0x11bd4a8, 0xc000280090}) net/http/server.go:3001 +0x394 net/http.(*Server).ListenAndServe(0xc00027e380) net/http/server.go:2930 +0x7d github.com/nspcc-dev/neo-go/pkg/network/metrics.(*Service).Start(0xc000097d10) github.com/nspcc-dev/neo-go/pkg/network/metrics/metrics.go:29 +0x115 created by github.com/nspcc-dev/neo-go/cli/server.initBCWithMetrics github.com/nspcc-dev/neo-go/cli/server/server.go:218 +0x285 goroutine 9 [syscall]: os/signal.signal_recv() runtime/sigqueue.go:169 +0x98 os/signal.loop() os/signal/signal_unix.go:24 +0x19 created by os/signal.Notify.func1.1 os/signal/signal.go:151 +0x2c goroutine 8 [select]: github.com/nspcc-dev/neo-go/pkg/core.(*Blockchain).notificationDispatcher(0xc000400280) github.com/nspcc-dev/neo-go/pkg/core/blockchain.go:739 +0x2e7 created by github.com/nspcc-dev/neo-go/pkg/core.(*Blockchain).Run github.com/nspcc-dev/neo-go/pkg/core/blockchain.go:612 +0xe5 goroutine 10 [chan receive]: github.com/nspcc-dev/neo-go/cli/server.newGraceContext.func1() github.com/nspcc-dev/neo-go/cli/server/server.go:117 +0x28 created by github.com/nspcc-dev/neo-go/cli/server.newGraceContext github.com/nspcc-dev/neo-go/cli/server/server.go:116 +0xde ```	2022-05-18 07:35:48 +03:00
Roman Khimov	1e22024808	Merge pull request #2502 from nspcc-dev/fix-initsslot-refs ... Fix INITSSLOT refs	2022-05-17 16:53:50 +03:00
Roman Khimov	ae2395f55f	vm: simplify (slot).Set code ... Refcounter handles nil items just fine.	2022-05-17 16:26:22 +03:00
Roman Khimov	f2f66ad36e	vm: clear static slot refs on exit, fix #2501	2022-05-17 16:26:22 +03:00
Roman Khimov	7bda933e32	Merge pull request #2496 from nspcc-dev/fix-2484 ... rpc: differentiate log level for RPC errors	2022-05-17 14:57:59 +03:00
Anna Shaleva	33a0207bbb	rpc: differentiate log level for RPC errors ... Close #2484. Also, do not overuse InternalServerError.	2022-05-17 14:43:07 +03:00
Roman Khimov	711112ae40	Merge pull request #2485 from nspcc-dev/fix-rpc ... rpc: check transaction for validness before network fee calculation	2022-05-17 11:34:11 +03:00
Roman Khimov	0d93b353e6	vm: count initial Null slot variables as well ... Match C# behavior. Thanks to @ixje for finding this.	2022-05-16 17:42:57 +03:00
Roman Khimov	18d627e7f7	vm: count map key in the refcounter as well ... Thanks @ixje for spotting this.	2022-05-16 16:07:25 +03:00
Anna Shaleva	c5c5e4c208	core: do not panic if transaction with empty script is being serialized ... See https://github.com/nspcc-dev/neo-go/pull/2485#discussion_r872695786. Allows to avoid panic: ``` (18:28:29)[sergio@transient:morph-control-load]% downloads/neofs-adm morph -c configuration/config.yaml init --contracts downloads/neofs-contract-v0.15.1 Stage 1: transfer GAS to alphabet nodes. Waiting for transactions to persist... Stage 2: set notary and alphabet nodes in designate contract. Stage 2: already performed. Stage 3: deploy NNS contract. NNS contract is already deployed. Stage 4: deploy NeoFS contracts. Alphabet contract #0 is already deployed. Alphabet contract #1 is already deployed. Alphabet contract #2 is already deployed. Alphabet contract #3 is already deployed. audit contract is already deployed. balance contract is already deployed. container contract is already deployed. neofsid contract is already deployed. netmap contract is already deployed. proxy contract is already deployed. reputation contract is already deployed. subnet contract is already deployed. Waiting for transactions to persist... Stage 4.1: Transfer GAS to proxy contract. Stage 5: register candidates. Stage 6: transfer NEO to alphabet contracts. Stage 7: set addresses in NNS. NNS: Set alphabet0.neofs -> 2efeb27866fa774ec6bfb43babaadcc7b28f9bb7 NNS: Set alphabet1.neofs -> 5606bc6598a538ac59ded3caa842247b9b26097a NNS: Set alphabet2.neofs -> 2a8308cfd2706ddd5f67adfdf3954c6836806b5d NNS: Set alphabet3.neofs -> 718d0459e6787f0f13f1e1898bf2ce6bc4bb452d NNS: Set audit.neofs -> 54d516b36c3380efa2b2f26bda300b6c6302b8e7 NNS: Set balance.neofs -> 72b3255944524cb822788a7542c9d06cba208c0c NNS: Set container.neofs -> 20a20f4352a49f161eccb7d5a806fd46dcab81ea NNS: Set neofsid.neofs -> 04a3a71535689b820093cefe7ae188ed7591ad27 NNS: Set netmap.neofs -> 9a34c97b2ba6bd986fd9140a9c3d59059fa430f4 NNS: Set proxy.neofs -> 4eba34ec016f8709a511b02765a1195e31a921ea NNS: Set reputation.neofs -> 77b5b2cf596957cc05ca3d57503ef08d72792301 NNS: Set subnet.neofs -> b0abe16bc7f56b2e7e0694ae2b36207c6aaa8636 panic: error serializing *transaction.Transaction: transaction has no script goroutine 1 [running]: github.com/nspcc-dev/neo-go/pkg/io.GetVarSize({0xbf6240, 0xc0003634a0}) github.com/nspcc-dev/neo-go@v0.98.2/pkg/io/size.go:68 +0x6fd github.com/nspcc-dev/neo-go/pkg/rpc/client.(*Client).AddNetworkFee(0xc0004080c0, 0xc0003634a0, 0x0, {0xc00000e248, 0x1, 0x93}) github.com/nspcc-dev/neo-go@v0.98.2/pkg/rpc/client/rpc.go:966 +0x6b github.com/nspcc-dev/neo-go/pkg/rpc/client.(*Client).CreateTxFromScript(0x0, {0x0, 0x0, 0x0}, 0x1, 0x0, 0x0, {0xc0001c7990, 0x1, 0x1}) github.com/nspcc-dev/neo-go@v0.98.2/pkg/rpc/client/nep17.go:128 +0x345 github.com/nspcc-dev/neofs-node/cmd/neofs-adm/internal/modules/morph.(*initializeContext).sendCommitteeTx(0xc00014a370, {0x0, 0x0, 0x0}, 0xc0016bcf30, 0x2) github.com/nspcc-dev/neofs-node/cmd/neofs-adm/internal/modules/morph/initialize.go:336 +0x131 github.com/nspcc-dev/neofs-node/cmd/neofs-adm/internal/modules/morph.(*initializeContext).updateNNSGroup(0xc0001c7c88, {0x13, 0xd3, 0x6b, 0x85, 0x3e, 0x86, 0xbe, 0x77, 0xb7, ...}, ...) github.com/nspcc-dev/neofs-node/cmd/neofs-adm/internal/modules/morph/initialize_nns.go:89 +0x134 github.com/nspcc-dev/neofs-node/cmd/neofs-adm/internal/modules/morph.(*initializeContext).setNNS(0xc00014a370) github.com/nspcc-dev/neofs-node/cmd/neofs-adm/internal/modules/morph/initialize_nns.go:74 +0x8c5 github.com/nspcc-dev/neofs-node/cmd/neofs-adm/internal/modules/morph.initializeSideChainCmd(0x12a00e0, {0xc22a22, 0x4, 0x4}) github.com/nspcc-dev/neofs-node/cmd/neofs-adm/internal/modules/morph/initialize.go:94 +0x2bc github.com/spf13/cobra.(*Command).execute(0x12a00e0, {0xc00013a6c0, 0x4, 0x4}) github.com/spf13/cobra@v1.1.3/command.go:852 +0x60e github.com/spf13/cobra.(*Command).ExecuteC(0x129c760) github.com/spf13/cobra@v1.1.3/command.go:960 +0x3ad github.com/spf13/cobra.(*Command).Execute(...) github.com/spf13/cobra@v1.1.3/command.go:897 github.com/nspcc-dev/neofs-node/cmd/neofs-adm/internal/modules.Execute(...) github.com/nspcc-dev/neofs-node/cmd/neofs-adm/internal/modules/root.go:48 main.main() github.com/nspcc-dev/neofs-node/cmd/neofs-adm/main.go:10 +0x25 zsh: exit 2 downloads/neofs-adm morph -c configuration/config.yaml init --contracts ```	2022-05-16 15:19:17 +03:00
Anna Shaleva	d2dcdecca5	core: avoid concurrent map r/w during SeekAsync ... Close #2493.	2022-05-16 12:25:15 +03:00
Roman Khimov	4b785d4ffb	Merge pull request #2491 from nspcc-dev/fix-2489 ... core: pop native call arguments after call invocation	2022-05-16 11:12:45 +03:00
Anna Shaleva	a0774a2194	core: pop native call arguments after call invocation ... Close #2489.	2022-05-16 09:39:17 +03:00
Anna Shaleva	a033b212a3	rpc: bump getversion compat ... Version 0.98.5 is officially released with the old behaviour. The same thing as #2479.	2022-05-16 06:59:23 +03:00
Roman Khimov	058a7eff90	Merge PR #2488 from nspcc-dev/reorder-neo-gas-distribution	2022-05-13 19:36:34 +03:00
Roman Khimov	54d8a37f3b	native: make it mergeable with master again	2022-05-13 18:51:27 +03:00
Roman Khimov	85fe111aea	neo: mint GAS after NEO transfer processing ... See neo-project/neo#2734.	2022-05-13 18:05:27 +03:00
Anna Shaleva	6020ca9ae8	crypto: adjust Checksum documentation	2022-05-13 13:20:40 +03:00
Anna Shaleva	e31f4ca331	interop: add interop API for MODMUL, MODPOW opcodes	2022-05-12 14:31:24 +03:00
Anna Shaleva	e66e82278c	vm: upgrade submodule	2022-05-12 14:25:14 +03:00
Anna Shaleva	a94ccf9236	vm: add MODMUL and MODPOW opcodes ... Close #2470.	2022-05-12 14:25:14 +03:00
Roman Khimov	7fd0eb14b5	Merge pull request #2469 from nspcc-dev/hardfork ... core: add ability to create hard-forks	2022-05-12 14:05:48 +03:00
Roman Khimov	e7a0722849	rpc: bump getversion compat again ... Version 0.98.4 is officially released with the old behaviour. The same thing as #2472.	2022-05-12 10:37:56 +03:00
Roman Khimov	c6f8c33e66	Merge pull request #2478 from nspcc-dev/mainnet-fixes ... Mainnet fixes	2022-05-12 10:04:53 +03:00
Roman Khimov	64baa309cb	Merge pull request #2475 from nspcc-dev/vm/fix-jump ... vm: check instruction offset is valid before subsequent IP move	2022-05-12 10:04:04 +03:00
Roman Khimov	621db8c832	stackitem: allow to unJSONize big numbers (>int64), fix #2477 ... 100000000000000000000 overflows int64 and NeoGo returns some garbage to contracts instead of a proper number.	2022-05-11 21:03:10 +03:00
Roman Khimov	3d1a81df1f	native: std.itoa uses lower-cased letters, fix #2476	2022-05-11 19:33:17 +03:00
Anna Shaleva	5505acf10e	core: change Create[Standard, Multisig]Account prices ... And make a hard-fork from this change.	2022-05-11 14:21:43 +03:00
Anna Shaleva	e70bf7d12e	core: allow to create hard-fork	2022-05-11 14:21:38 +03:00
Anna Shaleva	3be37e8c5b	vm: check instruction offset is valid before subsequent IP move ... Reference implementation: e167f03e25/src/neo-vm/ExecutionContext.cs (L77). Turns out that exception-related code (try\finally handling) is the only place where next instruction pointer bounds are not pre-checked before assignment. This statement is true for both go and C# implementations. However, C# code has duplicate check located inside the InstructionPointer setter for all instructions except the exception-related ones. Neo-go code doesn't perform this duplicate check. Thus, C# VM FAULTs execution in case of invalid TRY/FINALLY offsets, and neo-go VM does not. This commit reverts a part of https://github.com/nspcc-dev/neo-go/pull/2396. This bug is discovered thanks to test added in https://github.com/neo-project/neo-vm/pull/453.	2022-05-11 14:04:02 +03:00
Anna Shaleva	d88ca102c6	services: forbid insecure Oracle request redirects	2022-05-11 09:45:44 +03:00
Roman Khimov	d1588115a2	Merge pull request #2473 from nspcc-dev/fix-gosimple-wrn ... services: fix gosimple warning	2022-05-11 09:22:05 +03:00
Roman Khimov	483130fa7c	Merge pull request #2472 from nspcc-dev/shift-getversion-compat ... rpc: move latest getversion compat to 0.98.3	2022-05-11 08:10:07 +03:00
Anna Shaleva	48ee33fd61	services: fix gosimple warning ... Fix the following warning: ``` S1001: should use copy() instead of a loop (gosimple) ```	2022-05-11 07:39:27 +03:00
Roman Khimov	2b79a162ce	Merge pull request #2467 from nspcc-dev/limit-eq ... vm: adjust comparable limit for ByteArray	2022-05-10 19:53:20 +03:00
Roman Khimov	bb0efed8b7	rpc: move latest getversion compat to 0.98.3 ... Version 0.98.3 is officially released with the old behavior.	2022-05-07 22:34:40 +03:00
Roman Khimov	711e21709f	rpc/notary: make this branch mergeable with master	2022-05-07 18:38:50 +03:00
Anna Shaleva	8af043520d	vm: adjust MaxByteArrayComparableSize value ... https://github.com/neo-project/neo-vm/pull/454#discussion_r857533800.	2022-05-07 12:56:09 +03:00
Anna Shaleva	23b78b0be2	vm: limit ByteArray comparable length ... Close #2460.	2022-05-07 12:56:04 +03:00
Roman Khimov	7dc0404306	transaction: fix maxSubitems handling in JSON scope unmarshaller ... Notice that binary deserializer (readArrayOfConditions) does it correctly. Can be checked with neo-project/neo#2720 case.	2022-05-07 12:05:34 +03:00
Roman Khimov	c410219cba	transaction: fix Rules stringer, it's WitnessRules in C# ... See neo-project/neo#2720.	2022-05-07 12:05:25 +03:00
Anna Shaleva	b1f74b549d	rpc: avoid panic during request after WS connection is closed ... Fix the following panic: ``` panic: assignment to entry in nil map goroutine 131 [running]: github.com/nspcc-dev/neo-go/pkg/rpc/client.(*WSClient).registerRespChannel(0xc00033c240, 0x0, 0xc00003e2a0) /home/denis/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.98.2/pkg/rpc/client/wsclient.go:244 +0x96 github.com/nspcc-dev/neo-go/pkg/rpc/client.(*WSClient).makeWsRequest(0xc00033c240, 0xc002080000) /home/denis/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.98.2/pkg/rpc/client/wsclient.go:264 +0x69 github.com/nspcc-dev/neo-go/pkg/rpc/client.(*Client).performRequest(0xc00033c240, {0xc9f173, 0xd}, {{0x13d09d0, 0x0, 0x0}}, {0xb44120, 0xc00147a000}) /home/denis/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.98.2/pkg/rpc/client/client.go:186 +0x15d github.com/nspcc-dev/neo-go/pkg/rpc/client.(*Client).GetBlockCount(0xc001fb5440) /home/denis/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.98.2/pkg/rpc/client/rpc.go:73 +0x69 ... ```	2022-05-07 12:02:42 +03:00
Anna Shaleva	a7fe85a2d8	services: fix changing of main tx size of Notary request	2022-05-07 12:00:16 +03:00
Anna Shaleva	d68f57b9f9	rpc: avoid panic on double-call to *WSClient.Close() ... Although it's the caller's duty to avoid WSClient re-closing, we still can handle it. Fixes the following neofs-node error: ``` panic: close of closed channel goroutine 98 [running]: github.com/nspcc-dev/neo-go/pkg/rpc/client.(*WSClient).Close(...) github.com/nspcc-dev/neo-go@v0.98.3-pre.0.20220321144433-3b639f518ebb/pkg/rpc/client/wsclient.go:120 github.com/nspcc-dev/neofs-node/pkg/morph/subscriber.(*subscriber).Close(0x13) github.com/nspcc-dev/neofs-node/pkg/morph/subscriber/subscriber.go:108 +0x29 github.com/nspcc-dev/neofs-node/pkg/morph/event.listener.Stop(...) github.com/nspcc-dev/neofs-node/pkg/morph/event/listener.go:573 created by github.com/nspcc-dev/neofs-node/pkg/innerring.(*Server).Stop github.com/nspcc-dev/neofs-node/pkg/innerring/innerring.go:285 +0x12f ```	2022-05-07 11:59:55 +03:00
Evgeniy Stratonikov	92a2ec5848	network: check compressed payload size in decompress ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-05-07 11:57:48 +03:00
Anna Shaleva	11bfb55b81	core: consider Rules witness scope as valid	2022-05-07 10:50:11 +03:00
Roman Khimov	7a2c7fa0bf	Merge pull request #2468 from nspcc-dev/rpc/improve-init ... rpc: improve RPC Client initialization	2022-05-06 15:04:48 +03:00
Anna Shaleva	1782e16be4	rpc: improve RPC Client initialization ... Thanks to #2463.	2022-05-06 14:15:59 +03:00
Anna Shaleva	a427411a57	core: fix race during native cache persist ... Fixes the following race: ``` 2022-05-06T06:51:33.3980029Z WARNING: DATA RACE 2022-05-06T06:51:33.3980178Z Read at 0x00c0007e02a0 by goroutine 96: 2022-05-06T06:51:33.3980338Z runtime.mapaccess2_fast32() 2022-05-06T06:51:33.3980863Z /opt/hostedtoolcache/go/1.17.9/x64/src/runtime/map_fast32.go:52 +0x0 2022-05-06T06:51:33.3981249Z github.com/nspcc-dev/neo-go/pkg/core/dao.(*Simple).getCache() 2022-05-06T06:51:33.3982707Z /home/runner/work/neo-go/neo-go/pkg/core/dao/dao.go:905 +0x64 2022-05-06T06:51:33.3983443Z github.com/nspcc-dev/neo-go/pkg/core/dao.(*Simple).GetROCache() 2022-05-06T06:51:33.3983900Z /home/runner/work/neo-go/neo-go/pkg/core/dao/dao.go:889 +0xd4 2022-05-06T06:51:33.3984231Z github.com/nspcc-dev/neo-go/pkg/core/dao.(*Simple).getCache() 2022-05-06T06:51:33.3984869Z /home/runner/work/neo-go/neo-go/pkg/core/dao/dao.go:913 +0x196 2022-05-06T06:51:33.3985254Z github.com/nspcc-dev/neo-go/pkg/core/dao.(*Simple).GetROCache() 2022-05-06T06:51:33.3985756Z /home/runner/work/neo-go/neo-go/pkg/core/dao/dao.go:889 +0xd4 2022-05-06T06:51:33.3986167Z github.com/nspcc-dev/neo-go/pkg/core/native.(*Policy).isBlockedInternal() 2022-05-06T06:51:33.3986824Z /home/runner/work/neo-go/neo-go/pkg/core/native/policy.go:258 +0x6a 2022-05-06T06:51:33.3987264Z github.com/nspcc-dev/neo-go/pkg/core/native.(*Policy).IsBlocked() 2022-05-06T06:51:33.3987743Z /home/runner/work/neo-go/neo-go/pkg/core/native/policy.go:250 +0x2f7 2022-05-06T06:51:33.3988155Z github.com/nspcc-dev/neo-go/pkg/core/native.(*NEO).getAllCandidatesCall.func1() 2022-05-06T06:51:33.3988645Z /home/runner/work/neo-go/neo-go/pkg/core/native/native_neo.go:948 +0x109 2022-05-06T06:51:33.3989053Z github.com/nspcc-dev/neo-go/pkg/core/native.(*NEO).getAllCandidatesCall.func2() 2022-05-06T06:51:33.3989550Z /home/runner/work/neo-go/neo-go/pkg/core/native/native_neo.go:959 +0x137 2022-05-06T06:51:33.3989561Z 2022-05-06T06:51:33.3989735Z Previous write at 0x00c0007e02a0 by goroutine 40: 2022-05-06T06:51:33.3989891Z runtime.mapassign_fast32() 2022-05-06T06:51:33.3990260Z /opt/hostedtoolcache/go/1.17.9/x64/src/runtime/map_fast32.go:92 +0x0 2022-05-06T06:51:33.3990640Z github.com/nspcc-dev/neo-go/pkg/core/dao.(*Simple).persistNativeCache() 2022-05-06T06:51:33.3991084Z /home/runner/work/neo-go/neo-go/pkg/core/dao/dao.go:876 +0x12d 2022-05-06T06:51:33.3991411Z github.com/nspcc-dev/neo-go/pkg/core/dao.(*Simple).Persist() 2022-05-06T06:51:33.3991852Z /home/runner/work/neo-go/neo-go/pkg/core/dao/dao.go:850 +0x1d4 2022-05-06T06:51:33.3992186Z github.com/nspcc-dev/neo-go/pkg/core.(*Blockchain).runPersist() 2022-05-06T06:51:33.3992650Z /home/runner/work/neo-go/neo-go/pkg/core/blockchain.go:1285 +0x28a 2022-05-06T06:51:33.3992971Z github.com/nspcc-dev/neo-go/pkg/core.(*Blockchain).storeBlock() 2022-05-06T06:51:33.3993845Z /home/runner/work/neo-go/neo-go/pkg/core/blockchain.go:1143 +0x1b9c 2022-05-06T06:51:33.3994241Z github.com/nspcc-dev/neo-go/pkg/core.(*Blockchain).AddBlock() 2022-05-06T06:51:33.3994707Z /home/runner/work/neo-go/neo-go/pkg/core/blockchain.go:910 +0x791 2022-05-06T06:51:33.3995053Z github.com/nspcc-dev/neo-go/pkg/neotest.(*Executor).AddNewBlock() 2022-05-06T06:51:33.3995492Z /home/runner/work/neo-go/neo-go/pkg/neotest/basic.go:334 +0xa7 2022-05-06T06:51:33.3995842Z github.com/nspcc-dev/neo-go/pkg/neotest.(*Executor).InvokeScript() 2022-05-06T06:51:33.3996288Z /home/runner/work/neo-go/neo-go/pkg/neotest/basic.go:178 +0x169 2022-05-06T06:51:33.3996725Z github.com/nspcc-dev/neo-go/pkg/core/native/native_test_test.TestNEO_GetCandidates.func2() 2022-05-06T06:51:33.3997253Z /home/runner/work/neo-go/neo-go/pkg/core/native/native_test/neo_test.go:549 +0x4cb 2022-05-06T06:51:33.3997672Z github.com/nspcc-dev/neo-go/pkg/core/native/native_test_test.TestNEO_GetCandidates() 2022-05-06T06:51:33.3998404Z /home/runner/work/neo-go/neo-go/pkg/core/native/native_test/neo_test.go:574 +0x2103 2022-05-06T06:51:33.3998751Z github.com/nspcc-dev/neo-go/pkg/neotest.(*Executor).AddNewBlock() 2022-05-06T06:51:33.3999193Z /home/runner/work/neo-go/neo-go/pkg/neotest/basic.go:334 +0xa7 2022-05-06T06:51:33.3999541Z github.com/nspcc-dev/neo-go/pkg/neotest.(*Executor).InvokeScript() 2022-05-06T06:51:33.3999988Z /home/runner/work/neo-go/neo-go/pkg/neotest/basic.go:178 +0x169 2022-05-06T06:51:33.4000305Z github.com/nspcc-dev/neo-go/pkg/neotest.AddSystemFee() 2022-05-06T06:51:33.4000733Z /home/runner/work/neo-go/neo-go/pkg/neotest/basic.go:291 +0x85 2022-05-06T06:51:33.4001062Z github.com/nspcc-dev/neo-go/pkg/neotest.(*Executor).SignTx() 2022-05-06T06:51:33.4001509Z /home/runner/work/neo-go/neo-go/pkg/neotest/basic.go:111 +0x109 2022-05-06T06:51:33.4001885Z github.com/nspcc-dev/neo-go/pkg/neotest.(*Executor).PrepareInvocation() 2022-05-06T06:51:33.4002435Z /home/runner/work/neo-go/neo-go/pkg/neotest/basic.go:191 +0x1b2 2022-05-06T06:51:33.4002808Z github.com/nspcc-dev/neo-go/pkg/neotest.(*Executor).InvokeScript() 2022-05-06T06:51:33.4003249Z /home/runner/work/neo-go/neo-go/pkg/neotest/basic.go:177 +0xed 2022-05-06T06:51:33.4003685Z github.com/nspcc-dev/neo-go/pkg/core/native/native_test_test.TestNEO_GetCandidates.func2() 2022-05-06T06:51:33.4004216Z /home/runner/work/neo-go/neo-go/pkg/core/native/native_test/neo_test.go:549 +0x4cb 2022-05-06T06:51:33.4004634Z github.com/nspcc-dev/neo-go/pkg/core/native/native_test_test.TestNEO_GetCandidates() 2022-05-06T06:51:33.4005165Z /home/runner/work/neo-go/neo-go/pkg/core/native/native_test/neo_test.go:558 +0x1bbb 2022-05-06T06:51:33.4005298Z testing.tRunner() 2022-05-06T06:51:33.4005674Z /opt/hostedtoolcache/go/1.17.9/x64/src/testing/testing.go:1259 +0x22f 2022-05-06T06:51:33.4005916Z testing.(*T).Run·dwrap·21() 2022-05-06T06:51:33.4006298Z /opt/hostedtoolcache/go/1.17.9/x64/src/testing/testing.go:1306 +0x47 ... ```	2022-05-06 13:46:17 +03:00
Anna Shaleva	ce35e69460	rpc: update testdata ... Fix failing historic test.	2022-05-06 13:46:17 +03:00
Anna Shaleva	5123b88c36	core: extend native Neo interop API ... Add GetAllCandidates and GetCandidateVote methods.	2022-05-06 13:43:12 +03:00
Anna Shaleva	5e2a81ad03	interop: fix the signature of Neo's GetCandidates interop API	2022-05-06 13:43:12 +03:00
Anna Shaleva	2a8ffd9318	core: refactor (*NEO).GetCandidates and add (*NEO).GetAllCandidates	2022-05-06 13:43:12 +03:00
Roman Khimov	75d06d18c9	Merge pull request #2466 from nspcc-dev/rules-fixes ... Rules scope fixes	2022-05-06 11:09:39 +03:00
Roman Khimov	acb1151d71	transaction: fix maxSubitems handling in JSON scope unmarshaller ... Notice that binary deserializer (readArrayOfConditions) does it correctly. Can be checked with neo-project/neo#2720 case.	2022-05-06 10:20:55 +03:00
Roman Khimov	bd352daab4	transaction: fix Rules stringer, it's WitnessRules in C# ... See neo-project/neo#2720.	2022-05-06 10:08:09 +03:00
Roman Khimov	7b1943a6e5	rpc/server: return original error for invoke* param errors	2022-05-06 10:07:34 +03:00
Roman Khimov	740488f7f3	Merge pull request #2442 from EliChin/feature/eng_review ... English Check	2022-05-05 17:12:37 +03:00
Elizaveta Chichindaeva	28908aa3cf	[#2442] English Check ... Signed-off-by: Elizaveta Chichindaeva <elizaveta@nspcc.ru>	2022-05-04 19:48:27 +03:00
Roman Khimov	58bda8be78	Merge pull request #2461 from nspcc-dev/rpc-json-error-in-exception ... rpc: signal JSON marshalling errors through exception	2022-05-04 17:22:05 +03:00
Anna Shaleva	ffdcdf4a95	core: restrict the maximum number of contract updates	2022-05-04 13:56:52 +03:00
Anna Shaleva	42e4021898	core: block destroyed contracts	2022-05-04 13:56:45 +03:00
Roman Khimov	930c439900	rpc: signal JSON marshalling errors through exception ... See neo-project/neo-modules#696. Unmarshaller is left unchanged to be compatible.	2022-05-04 13:13:21 +03:00
Roman Khimov	7f8b259994	Merge pull request #2457 from nspcc-dev/t5-testnet ... T5 testnet	2022-05-04 10:44:55 +03:00
Roman Khimov	3c0ee9c3a3	config: switch to T5 testnet ... See neo-project/neo-node#852, neo-project/neo-node#859.	2022-05-04 10:22:27 +03:00
Roman Khimov	f9c7693677	oracle: limit the number of redirections to 2 ... Be compatible with neo-project/neo-modules#698.	2022-05-03 23:18:53 +03:00
Anna Shaleva	473955c2d6	core: use proper current block height/hash for interop API	2022-04-29 18:00:46 +03:00
Anna Shaleva	9cc41528ef	core: avoid unnecessary NEO cached values copying	2022-04-29 16:10:04 +03:00
Anna Shaleva	335c1ee369	core: optimize access to NEO cache ... Do not copy RW cache each block. Instead we should get RO cache and change it only if there's a necessity.	2022-04-29 16:10:04 +03:00
Anna Shaleva	a6a0c1eb12	core: avoid lock copy in private DAO constructor ... Fix the following linter warning: ``` pkg/core/dao/dao.go:101:7 govet copylocks: assignment copies lock value to *d: github.com/nspcc-dev/neo-go/pkg/core/dao.Simple contains sync.RWMutex ```	2022-04-29 16:10:04 +03:00
Anna Shaleva	8d2d48f360	core: move native cache from MemCachedStore to DAO	2022-04-29 16:10:04 +03:00
Anna Shaleva	b77b412b04	core: refactor signature of (*NEO).dropCandidateIfZero ... It never returns an error.	2022-04-29 16:10:04 +03:00
Anna Shaleva	c36448f27e	core: don't reset NEO's registerPrice cache	2022-04-29 16:10:04 +03:00
Anna Shaleva	adec635f0e	core: don't reset NEO's gasPerBlock cache	2022-04-29 16:10:04 +03:00
Anna Shaleva	35d160075d	core: keep Policy cache always valid and up-to-date	2022-04-29 16:10:04 +03:00
Anna Shaleva	78b584053d	core: keep Oracle cache always valid and up-to-date	2022-04-29 16:10:04 +03:00
Anna Shaleva	0f6bf33f86	core: keep Notary cache always valid and up-to-date	2022-04-29 16:10:04 +03:00
Anna Shaleva	27b0193da0	core: use native cache to check whether the same contract exists on deploy	2022-04-29 16:10:04 +03:00
Anna Shaleva	c0b490c7bf	core: keep Management cache always valid and up-to-date	2022-04-29 16:10:04 +03:00
Anna Shaleva	11ab42d91c	core: keep Designation cache always valid and up-to-date ... Always use cache instead of DAO where possible. Update cache in-place each time new designated node is chosen.	2022-04-29 16:10:04 +03:00
Anna Shaleva	c8bdd2ad1a	core: remove Persist from NativeCache interface ... Lower native cache should be assigned to the upper's value during persist.	2022-04-29 16:10:04 +03:00
Anna Shaleva	8ec8511d9d	core: remove mutexes and atomic values from native cache ... Native cache is always wrapped into independant layers, so concurrent RW access is no-op.	2022-04-29 16:10:04 +03:00
Anna Shaleva	7b632c8ee8	core: refactor natives cache ... 1. Use layered natives cache. With layered cache the storeblock process includes the following steps: create a wrapper over current nativeCache, put changes into upper nativeCache layer, persist (or discard) changes. 2. Split contract getters to read-only and read-and-change. Read-only ones doesn't require the copy of an existing nativeCache item. Read-and-change ones create a copy and after that change the copy.	2022-04-29 16:10:04 +03:00
Anna Shaleva	aa886f67ce	core: use dao-binded cache for native contracts ... All native cached values are binded to DAO, so that it's possible to properly handle historic calls.	2022-04-29 16:10:04 +03:00
Anna Shaleva	812fa3f76a	core: initialize NEO config cache in constructor ... It isn't changed within the contract lifetime, thus initialisation can be safely performed in constructor.	2022-04-29 16:10:04 +03:00
Anna Shaleva	e63d6aeff7	core: move natives cache initialisation to a separate method	2022-04-29 16:10:04 +03:00
Anna Shaleva	93fde3b4e6	core: fix typo in TestCreateBasicChain	2022-04-29 16:10:04 +03:00
Anna Shaleva	63c26ca270	core, rpc: support [invokefunction, invokescript, invokecontractverify]historic	2022-04-29 16:10:04 +03:00
Anna Shaleva	f8b5972f61	core: support Store interface over MPT	2022-04-29 16:10:04 +03:00
Anna Shaleva	0cf525d62e	core: add ability to traverse backwards for Billet	2022-04-29 16:10:04 +03:00
Roman Khimov	3ae1647940	Merge pull request #2447 from nspcc-dev/gettransactionsigners ... core: add GetTransactionSigners method to native Ledger	2022-04-29 11:58:38 +03:00
Anna Shaleva	1762fd9128	core: add test to check GetTransactionSigners interop API	2022-04-29 11:34:26 +03:00
Anna Shaleva	8ca8a825ef	compiler: add compatibility test for GetTransactionSigners interop API	2022-04-29 11:34:22 +03:00
Anna Shaleva	441a3eb34c	interop: add API for getTransactionSigners Ledger's method	2022-04-29 11:22:21 +03:00
Anna Shaleva	47d52bd9c5	core: add getTransactionSigners method to native Ledger	2022-04-29 11:18:58 +03:00
Anna Shaleva	aaf7c423b4	core: remove voter reward per committee properly ... (*Simple).Seek cuts search prefix, thus to remove voterRewardPerCommittee we need to append it again to the height value. May affect dumps.	2022-04-28 17:15:18 +03:00
Roman Khimov	10acdbe40e	Merge pull request #2453 from nspcc-dev/check-policy-for-committee-members ... Check policy for committee members	2022-04-28 12:58:07 +03:00
Roman Khimov	ef93fd8cde	Merge pull request #2448 from nspcc-dev/rpc/fix-initialgas ... rpc: support InitialGasDistribution response from older Neo-Go nodes	2022-04-27 23:13:24 +03:00
Roman Khimov	a8607e43b1	native: check candidates againt Policy blocked list ... Follow neo-project/neo#2695 and neo-project/neo#2707.	2022-04-27 22:58:52 +03:00
Roman Khimov	bf3415e2bc	emit: introduce CheckSig function ... Which allows to create verification scripts without keys.PublicKey which is convenient in some cases where we already have serialized key and don't want to waste time decompressing it.	2022-04-27 22:57:10 +03:00
Anna Shaleva	9862b40f2c	rpc: support InitialGasDistribution response from old Neo-Go nodes ... https://github.com/nspcc-dev/neo-go/pull/2435 breaks compatibility between newer RPC clients and older RPC servers with the following error: ``` failed to get network magic: json: cannot unmarshal string into Go struct field Protocol.protocol.initialgasdistribution of type int64 ``` This behaviour is expected, but we can't allow this radical change. Thus, the following solution is implemented: 1. RPC server responds with proper non-stringified InitialGasDistribution value. The value represents an integral of fixed8 multiplied by the decimals. 2. RPC client is able to distinguish older and newer responses. For older one the stringified value without decimals part is expected. For newer responses the int64 value with decimal part is expected. The cludge will be present in the code for a while until nodes of version <=0.98.3 become completely absolete.	2022-04-27 19:00:46 +03:00
Roman Khimov	b8edf4ac73	Merge pull request #2450 from nspcc-dev/fix-ws ... rpc: avoid panic during WSClient request after WS connection is closed	2022-04-27 17:02:45 +03:00
Anna Shaleva	c042c5bb63	Revert "rpc: adjust getversion RPC response" ... This reverts commit 1c6afe402f.	2022-04-27 14:39:19 +03:00
Anna Shaleva	35d930951c	core: consider Rules witness scope as valid	2022-04-27 12:48:33 +03:00
Anna Shaleva	65dbe85ec5	rpc: avoid panic during request after WS connection is closed ... Fix the following panic: ``` panic: assignment to entry in nil map goroutine 131 [running]: github.com/nspcc-dev/neo-go/pkg/rpc/client.(*WSClient).registerRespChannel(0xc00033c240, 0x0, 0xc00003e2a0) /home/denis/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.98.2/pkg/rpc/client/wsclient.go:244 +0x96 github.com/nspcc-dev/neo-go/pkg/rpc/client.(*WSClient).makeWsRequest(0xc00033c240, 0xc002080000) /home/denis/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.98.2/pkg/rpc/client/wsclient.go:264 +0x69 github.com/nspcc-dev/neo-go/pkg/rpc/client.(*Client).performRequest(0xc00033c240, {0xc9f173, 0xd}, {{0x13d09d0, 0x0, 0x0}}, {0xb44120, 0xc00147a000}) /home/denis/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.98.2/pkg/rpc/client/client.go:186 +0x15d github.com/nspcc-dev/neo-go/pkg/rpc/client.(*Client).GetBlockCount(0xc001fb5440) /home/denis/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.98.2/pkg/rpc/client/rpc.go:73 +0x69 ... ```	2022-04-27 10:53:29 +03:00
Roman Khimov	8983d25f7f	Merge pull request #2445 from nspcc-dev/rpc-when-sync ... Add StartWhenSynchronized option for RPC server	2022-04-26 14:20:00 +03:00
Roman Khimov	a2126b92e1	rpc/server: only log errors during Shutdown ... Sending them down the errChan is not really helpful and it can lead to deadlock. If an error happens during node shutdown, we're exiting anyway, if it happens during service restart, the old server will be dead irrespective of this error (if this affects new one in any way we'll know it soon).	2022-04-26 00:31:48 +03:00
Roman Khimov	53423b7c37	network: fix panic in blockqueue during shutdown ... panic: send on closed channel goroutine 116 [running]: github.com/nspcc-dev/neo-go/pkg/network.(*blockQueue).putBlock(0xc00011b650, 0xc01e371200) github.com/nspcc-dev/neo-go/pkg/network/blockqueue.go:129 +0x185 github.com/nspcc-dev/neo-go/pkg/network.(*Server).handleBlockCmd(0xc0002d3c00, {0xf69b7f?, 0xc001520010?}, 0xc02eb44000?) github.com/nspcc-dev/neo-go/pkg/network/server.go:607 +0x6f github.com/nspcc-dev/neo-go/pkg/network.(*Server).handleMessage(0xc0002d3c00, {0x121f4c8?, 0xc001528000?}, 0xc01e35cf80) github.com/nspcc-dev/neo-go/pkg/network/server.go:1160 +0x6c5 github.com/nspcc-dev/neo-go/pkg/network.(*TCPPeer).handleIncoming(0xc001528000) github.com/nspcc-dev/neo-go/pkg/network/tcp_peer.go:189 +0x98 created by github.com/nspcc-dev/neo-go/pkg/network.(*TCPPeer).handleConn github.com/nspcc-dev/neo-go/pkg/network/tcp_peer.go:164 +0xcf	2022-04-26 00:31:48 +03:00
Roman Khimov	887fe0634d	rpc: add StartWhenSynchronized option, fix #2433	2022-04-26 00:31:48 +03:00
Roman Khimov	2593bb0535	network: extend Service with Name, use it to distinguish services	2022-04-26 00:31:48 +03:00
Anna Shaleva	1890e7cdc1	core: upgrade storage version	2022-04-22 18:38:05 +03:00
Anna Shaleva	8be6823cb1	core: fix broken stateroot storage ... Store stateroot by DataMPTAux prefix instead of storing it by index only.	2022-04-22 18:37:56 +03:00
Roman Khimov	a10b1ad32d	rpc/server: make Server conform network.Service interface ... With Start() and Shutdown() taking no parameters and returning no values.	2022-04-22 10:49:06 +03:00
Roman Khimov	4eee2f930e	rpc/server: make double-start a no-op	2022-04-22 10:33:52 +03:00
Anna Shaleva	d942940a82	core: support System.Runtime.GetAddressVersion syscall	2022-04-21 19:26:16 +03:00
Erik van den Brink	9fe3a86540	fix typo's	2022-04-20 14:00:12 +02:00
Roman Khimov	f73510b926	Merge pull request #2432 from nspcc-dev/fix-fees ... core: use proper BaseExecFee and StoragePrice for interop context	2022-04-14 15:10:22 +03:00
Anna Shaleva	1c6afe402f	rpc: adjust getversion RPC response ... Reference implementation includes `initialgasdistribution` as integer value with decimals. C# response: ``` { "id": 1, "jsonrpc": "2.0", "result": { "nonce": 1677922561, "protocol": { "addressversion": 53, "initialgasdistribution": 5200000000000000, "maxtraceableblocks": 2102400, "maxtransactionsperblock": 512, "maxvaliduntilblockincrement": 5760, "memorypoolmaxtransactions": 50000, "msperblock": 15000, "network": 860833102, "validatorscount": 7 }, "tcpport": 10333, "useragent": "/Neo:3.1.0/", "wsport": 10334 } } ``` Neo-Go response: ``` { "id": 1, "jsonrpc": "2.0", "result": { "network": 860833102, "nonce": 2847278838, "protocol": { "addressversion": 53, "initialgasdistribution": "52000000", "maxtraceableblocks": 2102400, "maxtransactionsperblock": 512, "maxvaliduntilblockincrement": 5760, "memorypoolmaxtransactions": 50000, "msperblock": 15000, "network": 860833102, "validatorscount": 7 }, "tcpport": 10333, "useragent": "/NEO-GO:0.98.2/" } } ```	2022-04-14 13:51:30 +03:00
Anna Shaleva	51a54fa248	core: return default BaseExecFee if blockchain height is 0 ... For (bc *Blockchain).GetBaseExecFee().	2022-04-08 14:28:30 +03:00
Anna Shaleva	d3672eb14a	core: use BaseExecFee from InteropContext instead of Blockchain's one ... The InteropContext's one contains all relevant fee changes applied in the prevouse transactions of the current block.	2022-04-08 12:56:46 +03:00
Anna Shaleva	544f2c2cb2	core: use proper storage price within the whole interop context ... We shouldn't use StoragePrice from Blockchain because its dao doesn't contain the whole set of changes from previouse transactions in the current block. Instead, we should use an updated storage price for each transaction and retrieve the price from cached DAO.	2022-04-08 12:50:56 +03:00
Anna Shaleva	91a4bc5beb	core: use proper DAO to get ExecFeeFactor ... The usage of the Blockchain's one leads to the same ExecFeeFactor within a single block. What we need is to update ExecFeeFactor after each transaction invocation, thus, cached DAO should be used as it contains all relevant changes.	2022-04-08 12:50:50 +03:00
Roman Khimov	6ff11baa1b	Merge pull request #2427 from nspcc-dev/add-hash-to-debug-info ... Add hash to debug info and use absolute path	2022-04-06 16:11:47 +03:00
Roman Khimov	f5d5019b70	compiler: use absolute paths for debug data ... It's not a perfect thing, but neo-debugger just doesn't work at all with relative pathes. Notice that `saveSequencePoint` still used absolute ones leading to invalid debug.json data, but fixing it there doesn't help, neo-debugger can't load source code using relatives.	2022-04-06 15:46:54 +03:00
Roman Khimov	e390981747	compiler: add hash field to debug info ... New debugger won't work without it.	2022-04-06 15:27:01 +03:00
Roman Khimov	017326dca4	Merge pull request #2417 from nspcc-dev/interop-update ... *: natives update	2022-04-05 19:02:59 +03:00
Roman Khimov	bdcb527ead	Merge pull request #2420 from nspcc-dev/fix-ws ... rpc: avoid panic on double-call to *WSClient.Close()	2022-04-05 16:41:51 +03:00
Anna Shaleva	850f56b367	rpc: avoid panic on double-call to *WSClient.Close() ... Although it's the caller's duty to avoid WSClient re-closing, we still can handle it. Fixes the following neofs-node error: ``` panic: close of closed channel goroutine 98 [running]: github.com/nspcc-dev/neo-go/pkg/rpc/client.(*WSClient).Close(...) github.com/nspcc-dev/neo-go@v0.98.3-pre.0.20220321144433-3b639f518ebb/pkg/rpc/client/wsclient.go:120 github.com/nspcc-dev/neofs-node/pkg/morph/subscriber.(*subscriber).Close(0x13) github.com/nspcc-dev/neofs-node/pkg/morph/subscriber/subscriber.go:108 +0x29 github.com/nspcc-dev/neofs-node/pkg/morph/event.listener.Stop(...) github.com/nspcc-dev/neofs-node/pkg/morph/event/listener.go:573 created by github.com/nspcc-dev/neofs-node/pkg/innerring.(*Server).Stop github.com/nspcc-dev/neofs-node/pkg/innerring/innerring.go:285 +0x12f ```	2022-04-05 16:31:51 +03:00
Anna Shaleva	5771bbb52a	services: fix changing of main tx size of Notary request	2022-04-05 16:00:12 +03:00
Anna Shaleva	72ec354039	compiler: add test for murmur32 interop API	2022-04-05 10:51:12 +03:00
Anna Shaleva	16f952270c	core: add murmur32 to CryptoLib native contract ... Close #2415.	2022-04-05 10:46:52 +03:00
Anna Shaleva	0e8bf83dda	compiler: add tests for GetTransactionVMState	2022-04-05 10:46:52 +03:00
Anna Shaleva	b431e47d2a	core: add GetTransactionVMState to native Ledger contract ... Close #2343.	2022-04-05 10:37:02 +03:00
Anna Shaleva	4254407a9b	dao: add GetTxExecResult method	2022-04-05 10:36:50 +03:00
Anna Shaleva	18c5f638b9	dao: adjust usages of Internal DB inconsistency error	2022-04-04 19:16:58 +03:00
Anna Shaleva	2972569a0a	vm: make byte representation of VMState compatible with C#	2022-04-04 13:52:29 +03:00
Anna Shaleva	6343720adf	dao: return ErrKeyNotFound from GetAppExecResults for dummy txs ... Otherwise decoding error may be returned which can be misleading.	2022-04-04 12:49:52 +03:00
Roman Khimov	7b3cc27b5f	LICENSE.md: add NSPCC copyright	2022-04-04 12:34:18 +03:00
Anna Shaleva	9a41356a3b	core: add getUint256FromItem helper to native ledger	2022-04-04 12:33:29 +03:00
Roman Khimov	3f57ff76ab	interop: add a physical copy of LICENSE.md ... Seems like pkg.go.dev can't pick it up from the symlink.	2022-04-04 12:32:17 +03:00
Roman Khimov	2d60d4021b	Merge pull request #2413 from nspcc-dev/smartcontract-big-numbers ... smartcontract: allow to use `*big.Int` numbers for integers	2022-04-01 10:38:33 +03:00
Roman Khimov	4e375fd8f4	Merge pull request #2414 from nspcc-dev/eliminate-getstorageitems ... Eliminate GetStorageItems	2022-04-01 09:16:42 +03:00
Evgeniy Stratonikov	739db259e3	smartcontract: remove unused ParameterFromStackItem ... It is exists from the times we used `smartcontract.Parameter` somewhere in the `NotificationEvent`/`ApplicationLog`. `stackitem.ToJSON` now handles this. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-04-01 08:38:35 +03:00
Evgeniy Stratonikov	fe0cd5fe32	smartcontract: remove EncodeBinary for Parameter ... It seems, we don't use it anywhere. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-04-01 08:38:35 +03:00
Evgeniy Stratonikov	0b0d39f797	smartcontract: allow to use *big.Int numbers for integers ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-04-01 08:38:34 +03:00
Roman Khimov	c12a3b71d4	dao: drop GetStorageItems* APIs ... They're just adding another useless caching layer to the Seek.	2022-03-31 19:18:51 +03:00
Roman Khimov	60375e9db3	core: drop GetStorageItems interface ... It's not used and not useful.	2022-03-31 16:46:41 +03:00
Roman Khimov	3ab2ab5cba	core: drop outdated comment from storageFind	2022-03-31 16:39:11 +03:00
Anna Shaleva	8965441288	core: rebase core tests onto neotest	2022-03-30 19:00:53 +03:00
Anna Shaleva	35ef58a47e	core: move Oracle response script creation to a separate function	2022-03-30 18:59:43 +03:00
Anna Shaleva	a4dab3a5ba	core: adjust error message of native call	2022-03-30 12:18:01 +03:00
Anna Shaleva	59f3fa1ef1	neotest: adapt framework to work with *testing.B	2022-03-30 12:17:55 +03:00
Anna Shaleva	ff13af804d	core: adjust persist-related Blockchain tests ... `newTestChain` runs blockchain, so persist is likely already happened before the first test iteration. Explicit call to persist makes no sence here.	2022-03-30 11:46:44 +03:00
Anna Shaleva	28e936eb95	core: export GetMaxNotValidBeforeDelta blockchain API ... Mostly for tests, but it can also be useful as a separate API.	2022-03-30 11:46:44 +03:00
Anna Shaleva	e0ab4ec6f0	core: adjust helper test contract ... Method is allowed to have single return value on stack after its invocation. Make sure that test contract follows this rule.	2022-03-30 11:46:44 +03:00
Anna Shaleva	13252bb941	core: refactor helper test contracts generation ... * Move generator to a separate package. * Move loader to a separate package and get rid of the code duplications.	2022-03-30 11:46:29 +03:00
Anna Shaleva	889a7ec378	rpc: regenerate basic chain and adjust RPC server tests	2022-03-30 11:32:30 +03:00
Anna Shaleva	4a74c117ee	*: refactor TestCreateBasicChain and its dependencies ... Close #2355	2022-03-30 11:32:26 +03:00
AnnaShaleva	3b45325319	neotest: extend multichain constructor	2022-03-29 15:01:10 +03:00
Anna Shaleva	150041d25e	core: unexport native Management's GetMinimumDeploymentFee ... This method is used only from Management contract. We also have neotest-based tests for `getMinimumDeploymentFee`, it should be enough.	2022-03-29 15:01:10 +03:00
Anna Shaleva	bedfd75086	neotest: port fix from 91350c3a48	2022-03-29 15:01:07 +03:00
Roman Khimov	c039133acf	Merge pull request #2408 from nspcc-dev/improve-examples ... Improve examples&documentation	2022-03-25 18:16:50 +03:00
Roman Khimov	52893d6a00	Merge pull request #2409 from nspcc-dev/network-message ... network: check compressed payload size in `decompress`	2022-03-24 21:22:53 +03:00
Evgeniy Stratonikov	34b1b52784	network: check compressed payload size in decompress ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-03-24 17:22:55 +03:00
Roman Khimov	be7527409c	compiler: fix panic in notification check ... Options is a pointer, so it can be nil: --- FAIL: TestCompiler (0.23s) --- FAIL: TestCompiler/TestCompile (0.21s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x960374] goroutine 8861 [running]: testing.tRunner.func1.2({0xa604c0, 0x112c230}) /usr/lib64/go/1.18/src/testing/testing.go:1389 +0x24e testing.tRunner.func1() /usr/lib64/go/1.18/src/testing/testing.go:1392 +0x39f panic({0xa604c0, 0x112c230}) /usr/lib64/go/1.18/src/runtime/panic.go:838 +0x207 github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).processNotify(0xc0000eba40, 0xc000233ae0?, {0xc00044ae90, 0x1, 0x1}) /home/rik/dev/neo-go/pkg/compiler/inline.go:134 +0xd4 github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).processStdlibCall(0xc0000eba40?, 0xc000233ae0, {0xc00044ae90, 0x1, 0x1}) /home/rik/dev/neo-go/pkg/compiler/inline.go:124 +0xda github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).inlineCall(0xc0000eba40, 0xc000233ae0, 0xc0001fe5c0) /home/rik/dev/neo-go/pkg/compiler/inline.go:35 +0x1fa github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).Visit(0xc0000eba40, {0xd36bf8?, 0xc0001fe5c0?}) /home/rik/dev/neo-go/pkg/compiler/codegen.go:932 +0x152c go/ast.Walk({0xd348e0?, 0xc0000eba40?}, {0xd36bf8?, 0xc0001fe5c0?}) /usr/lib64/go/1.18/src/go/ast/walk.go:52 +0x62 go/ast.Walk({0xd348e0?, 0xc0000eba40?}, {0xd36db0?, 0xc00044aeb0?}) /usr/lib64/go/1.18/src/go/ast/walk.go:207 +0x1154 github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).Visit(0xc0000eba40, {0xd36ba8?, 0xc0001cce70?}) /home/rik/dev/neo-go/pkg/compiler/codegen.go:1155 +0x54cd go/ast.Walk({0xd348e0?, 0xc0000eba40?}, {0xd36ba8?, 0xc0001cce70?}) /usr/lib64/go/1.18/src/go/ast/walk.go:52 +0x62 github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).Visit(0xc0000eba40, {0xd36f68?, 0xc0001fe600?}) /home/rik/dev/neo-go/pkg/compiler/codegen.go:733 +0x2e30 go/ast.Walk({0xd348e0?, 0xc0000eba40?}, {0xd36f68?, 0xc0001fe600?}) /usr/lib64/go/1.18/src/go/ast/walk.go:52 +0x62 github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).Visit(0xc0000eba40, {0xd36ba8?, 0xc0001ccea0?}) /home/rik/dev/neo-go/pkg/compiler/codegen.go:1155 +0x54cd go/ast.Walk({0xd348e0?, 0xc0000eba40?}, {0xd36ba8?, 0xc0001ccea0?}) /usr/lib64/go/1.18/src/go/ast/walk.go:52 +0x62 github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).convertFuncDecl(0xc0000eba40, {0xd36e28, 0xc000256700}, 0xc0001cced0, 0xc00041b68c?) /home/rik/dev/neo-go/pkg/compiler/codegen.go:502 +0x97d github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).compile.func2(0xc000256700, 0xc0001c64b0) /home/rik/dev/neo-go/pkg/compiler/codegen.go:2129 +0x1f9 github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).ForEachFile.func1(0xc000254a00) /home/rik/dev/neo-go/pkg/compiler/compiler.go:102 +0x96 github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).ForEachPackage(0xc0000eba40, 0xc0002f3c68) /home/rik/dev/neo-go/pkg/compiler/compiler.go:93 +0xdb github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).ForEachFile(0xa1f700?, 0xc000448f90?) /home/rik/dev/neo-go/pkg/compiler/compiler.go:99 +0x4d github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).compile(0xc0000eba40, 0xc00022c390, 0x1?) /home/rik/dev/neo-go/pkg/compiler/codegen.go:2116 +0x3d6 github.com/nspcc-dev/neo-go/pkg/compiler.codeGen(0xc00022c390) /home/rik/dev/neo-go/pkg/compiler/codegen.go:2167 +0x373 github.com/nspcc-dev/neo-go/pkg/compiler.CompileWithOptions({0xc000c525a0?, 0x16?}, {0x0?, 0x0?}, 0x0) /home/rik/dev/neo-go/pkg/compiler/compiler.go:218 +0x7d github.com/nspcc-dev/neo-go/pkg/compiler.Compile({0xc000c525a0?, 0xc000304340?}, {0x0?, 0x0?}) /home/rik/dev/neo-go/pkg/compiler/compiler.go:203 +0x34 github.com/nspcc-dev/neo-go/pkg/compiler_test.compileFile(...) /home/rik/dev/neo-go/pkg/compiler/compiler_test.go:89 github.com/nspcc-dev/neo-go/pkg/compiler_test.TestCompiler.func2(0x6a2a89?) /home/rik/dev/neo-go/pkg/compiler/compiler_test.go:61 +0x133 testing.tRunner(0xc000304340, 0xc7f5b0) /usr/lib64/go/1.18/src/testing/testing.go:1439 +0x102 created by testing.(*T).Run /usr/lib64/go/1.18/src/testing/testing.go:1486 +0x35f	2022-03-24 16:34:18 +03:00
Roman Khimov	7fe462a65d	neotest/chain: improve comments	2022-03-23 23:11:39 +03:00
Roman Khimov	f6094c8c4e	neotest: use public constants for default configuration ... And be more consistent about MaxTraceableBlocks use.	2022-03-23 23:11:27 +03:00
Roman Khimov	208e38803c	neotest: add some high-level documentation	2022-03-23 22:48:41 +03:00
Roman Khimov	479eda6786	interop: add LICENSE.md into the package ... Otherwise pkg.go.dev refuses to display the documentation.	2022-03-23 18:26:02 +03:00
Roman Khimov	9d5b8d606a	server: quote method in logs, fix CodeQL warnings ... CWE-117: Log entries created from user input If unsanitized user input is written to a log entry, a malicious user may be able to forge new log entries.	2022-03-22 16:05:06 +03:00
Roman Khimov	0a338ea94b	rpc/server: register ws calls in Prometheus ... They were completely missing.	2022-03-21 23:18:00 +03:00
Roman Khimov	d5a9af5860	Revert "Revert "interop: use All flags for management deploy and update calls"" ... This reverts commit 526c423a61, heading to 3.2.0.	2022-03-21 17:41:37 +03:00
Roman Khimov	526c423a61	Revert "interop: use All flags for management deploy and update calls" ... This reverts commit 37ca96c20b and a part of 7945097543, we need 0.98.2 release to be 3.1.0-compatible and this one breaks the testnet.	2022-03-21 14:32:11 +03:00
Roman Khimov	ad1dd3ebb7	Merge pull request #2399 from nspcc-dev/fuzz-tests ... vm: add some Fuzz tests	2022-03-21 12:00:55 +03:00
Evgeniy Stratonikov	3f65473f64	vm: add some Fuzz tests ... Both `IsScriptCorrect` and `VM.Run` should never panic. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-03-18 16:13:39 +03:00
Roman Khimov	906d99571b	Merge pull request #2369 from nspcc-dev/goshechka ... *: go 1.18 support 🎉😍🎊🍰🥂	2022-03-18 15:07:20 +03:00
Roman Khimov	4869049965	Merge pull request #2398 from nspcc-dev/trim-micro ... block/dao: simplify trimming, avoid allocations	2022-03-18 12:39:53 +03:00
Roman Khimov	5616585697	block/dao: simplify trimming, avoid allocations ... The only user of (*Block).Trim() is in DAO and it already has a nice buffer usually, so creating another one makes no sense. It also simplifies error handling a lot.	2022-03-18 10:49:25 +03:00
Roman Khimov	c2845852ae	Merge pull request #2397 from nspcc-dev/is-script-correct-panic ... vm: avoid panic in `IsScriptCorrect`	2022-03-18 10:08:39 +03:00
Evgeniy Stratonikov	ef28308dbf	vm: avoid panic in IsScriptCorrect ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-03-17 20:12:50 +03:00
AnnaShaleva	a4d402da86	compiler: revert a part of ad65d1fa1f ... Close #2335.	2022-03-17 19:39:18 +03:00
Anna Shaleva	753d604784	network: use net.ErrClosed to check network connection was closed ... Close #1765.	2022-03-17 19:39:18 +03:00
Anna Shaleva	2096ad6e81	*: remove io/ioutil uses ... Close #1764.	2022-03-17 19:39:18 +03:00
Roman Khimov	df3eb76aa2	Merge pull request #2396 from nspcc-dev/fuzz-script-panic ... Return error on negative instruction pointer in `Context.Next`	2022-03-17 19:13:20 +03:00
Evgeniy Stratonikov	492c91b4c5	vm: disallow negative offset in (*Context).Next() ... Currently the only known reason this can happen is processing ENDFINALLY opcode before the corresponding ENDTRY. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-03-17 18:52:48 +03:00
Roman Khimov	5cbf28a104	Merge pull request #2372 from nspcc-dev/jsonpath-oom ... jsonpath: restrict amount of intermediate objects	2022-03-17 12:34:49 +03:00
Roman Khimov	5379ef75bb	Merge pull request #2391 from nspcc-dev/fix-reverse ... vm: fix integer conversions	2022-03-10 12:27:10 +03:00
Evgeniy Stratonikov	32f4404954	vm: allow HASKEY on byte-arrays ... Current neo-vm master has them https://github.com/neo-project/neo-vm/blob/master/src/neo-vm/ExecutionEngine.cs#L1157 Were silently added in 029466fa9d . Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-03-10 10:34:13 +03:00
Evgeniy Stratonikov	39866b8512	vm: fix integer conversions ... As can be seen in https://dotnetfiddle.net/s7eg21 (int) conversions result in an exception in C# code. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-03-10 10:21:34 +03:00
Evgeniy Stratonikov	a8d2df874f	stackitem: limit JSON size in ToJSONWithTypes ... Also do not limit depth. It was introduced in e34fa2e915 as a simple solution to OOM problem. In this commit we do exactly the refactoring described there. Maximum size is the same as stack item size and can be changed if needed withouth significat refactoring. `1 MiB` seems sufficient, though. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-03-09 10:29:23 +03:00
Roman Khimov	6ece74a7c7	Merge pull request #2383 from nspcc-dev/oracle-redirection ... services: check Oracle response redirections	2022-03-04 22:19:22 +03:00
Anna Shaleva	5ace840cc7	services: improve Oracle redirection check ... Move IP check to later stage and do not resolve URI manually.	2022-03-04 19:27:52 +03:00
Roman Khimov	96cd415384	Merge pull request #2382 from nspcc-dev/compiler-optimize ... compiler: optimize tests	2022-03-04 18:55:40 +03:00
Evgeniy Stratonikov	0e86073a77	compiler: group small tests in a single file ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-03-04 17:55:33 +03:00
AnnaShaleva	537de18ac3	services: check Oracle response redirections ... 1. Move redirections check to the tcp level. Manually resolve request address and create connection for the first suitable resolved address. 2. Remove URIValidator. Redirections checks are set in the custom http client, so the user should take care of validation by himself when customizing the client.	2022-03-04 13:10:22 +03:00
AnnaShaleva	3d5b1d8d17	rpc: add Rules signer scope to request parameters	2022-03-03 12:18:19 +03:00
Roman Khimov	ff60571869	Merge pull request #2378 from nspcc-dev/notary-adjustments ... *: several Notary subsystem adjustments, part 1	2022-03-02 11:58:36 +03:00
AnnaShaleva	3996b3abb7	interop: extend native Notary interop API	2022-03-01 19:08:22 +03:00
AnnaShaleva	49e228ddf8	rpc: fix Client's GetOraclePrice	2022-03-01 19:08:22 +03:00
AnnaShaleva	92282c70cb	*: support customisable NotaryServiceFeePerKey value ... * Add corresponding methods to Notary contract. * Extend RPC Client API. * Adjust tests.	2022-03-01 19:08:16 +03:00
Roman Khimov	473d11d24e	Merge pull request #2370 from nspcc-dev/nonzero-blockchain-start ... core: add tests for non-zero blockchain start	2022-03-01 16:39:17 +03:00
Anna Shaleva	49c995ec06	core: add tests for blockchain initialisation ... Close #1577.	2022-02-28 19:00:43 +03:00
AnnaShaleva	8e3f2417f4	core: add check for native activations history ... It should be consistent with storage states.	2022-02-28 18:49:18 +03:00
Anna Shaleva	032d9749c2	core: improve blockchain error messages	2022-02-28 18:49:18 +03:00
Anna Shaleva	a57c3f4842	core: fix InitWithIncompleteStateJump test	2022-02-28 18:49:18 +03:00
Anna Shaleva	9adcefc2ef	core: gracefully wrap Seek error if failed to retrieve header hases	2022-02-28 18:49:18 +03:00
Anna Shaleva	8d6aa1782d	core: fix StateRootInHeader error message for (*Blockchain).init()	2022-02-28 18:49:18 +03:00
Anna Shaleva	ad0c53c067	core: unify the format of error messages for (*Blockchain).init()	2022-02-28 18:49:12 +03:00
Evgeniy Stratonikov	a2cef15932	compiler: emit bindings configuration ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-02-28 15:36:14 +03:00
Evgeniy Stratonikov	422a80f483	jsonpath: restrict amount of intermediate objects ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-02-28 13:18:34 +03:00
Anna Shaleva	21515e1835	core: refactor Level store creation for tests ... We don't need to create the whole DB configuration structure.	2022-02-25 12:14:17 +03:00
Anna Shaleva	339bec1632	core: adjust TestDumpAndRestore test ... `with state root` test should consider StateRootInHeader set to true.	2022-02-25 11:47:13 +03:00
Roman Khimov	870fd024c9	Merge pull request #2367 from nspcc-dev/rpc/thread-safe ... rpc: take care of RPC clients	2022-02-24 20:11:15 +03:00
Anna Shaleva	1f255e756f	rpc: add a note to RPC clients about thread-safeness	2022-02-24 19:01:21 +03:00
Anna Shaleva	2896c0a83a	rpc: add test for concurrent WSClient access and request IDs generation	2022-02-24 19:01:21 +03:00
AnnaShaleva	0d8723527c	rpc: refactor WSClient initialisation ... Fix the following linter warning: ``` pkg/rpc/client/wsclient.go:99:18 govet copylocks: literal copies lock value from *cl: github.com/nspcc-dev/neo-go/pkg/rpc/client.Client contains sync.RWMutex ```	2022-02-24 19:01:21 +03:00
AnnaShaleva	8991ee91cd	rpc: make RPC WSClient thread-safe ... Add ability to use unique request IDs for RPC requests.	2022-02-24 19:01:12 +03:00
Roman Khimov	b65ab011fe	Merge pull request #2349 from nspcc-dev/codegen-contract ... cli/smartcontract: generate bindings to an existing contract	2022-02-24 15:51:33 +03:00
Anna Shaleva	0357d9f4f4	smartcontract: add hash check to paramcontext ... Close #2344.	2022-02-24 10:21:08 +03:00
Evgeniy Stratonikov	da03d895de	cli/smartcontract: generate bindings to an existing contract ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-02-23 15:40:06 +03:00
AnnaShaleva	5b2e88b916	rpc: protect supscriptions of RPC WSClient from concurrent access	2022-02-22 15:40:08 +03:00
Anna Shaleva	d77f188d10	rpc: update native contract hashes inside (c *Client) GetNativeContracts()	2022-02-22 15:39:42 +03:00
AnnaShaleva	408f6b050e	rpc: make RPC Client thread-safe	2022-02-22 15:37:00 +03:00
AnnaShaleva	0092330fe1	rpc: carefully review places where Client.cache.initDone is used ... 1. Keep initDone check only for the places where cache is directly accessed. We don't need to check it in other places, otherwise we have a mess of duplicating checks. 2. Fix bug in code related to block deserialisation. There's no magic, so checking that initialisation is done is not enough for proper block deserialisation. We need to manually fill StateRootEnabled field. 3. Since transaction doesn't need network magic to compute its hash, we don't need to perform Client initialisation before transaction-related requests. 4. Check that cache is initialised before accessing network magic. 5. Refactor the way Policy contract hash is fetched for Client requests. We don't really need Client initialisation for that, it's OK to fetch Policy hash on-the-fly.	2022-02-22 12:52:14 +03:00
AnnaShaleva	7c1862a9ac	rpc: move all RPC client's cached fields to a separate cache structure ... No functional changes.	2022-02-21 18:16:49 +03:00
Evgeniy Stratonikov	4aab85ef51	callflag: allow to marshal call flags in YAML ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-02-21 10:43:35 +03:00
Evgeniy Stratonikov	c212b2be95	util: allow to marshal Uint160 in YAML ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-02-21 10:38:20 +03:00
Roman Khimov	9224f57323	Merge pull request #2365 from nspcc-dev/vm/replace-cli ... vm CLI: replace ishell with urfave/cli	2022-02-18 19:30:39 +03:00
AnnaShaleva	c35950206a	vm: add test to check CLI UTF-8 compatibility	2022-02-18 19:20:50 +03:00
Anna Shaleva	c182141624	vm: fix linter issue ... printf: `fmt.Fprintln` arg list ends with redundant newline (govet)	2022-02-18 19:20:43 +03:00
Anna Shaleva	2501ce3cb1	vm: adjust run description for VM CLI ... With urfave/cli method name can be `help`.	2022-02-18 16:34:58 +03:00
Anna Shaleva	d04d55708c	vm: setup autocompleter	2022-02-18 16:34:58 +03:00
Anna Shaleva	e8ec820d2e	vm: add unload command ... When execution fails it's the only way to change the prompt showing the last executed instruction. Example: ``` NEO-GO-VM > loadgo examples/engine/engine.go READY: loaded 117 instructions NEO-GO-VM 0 > run Error: at instruction 3 (SYSCALL): failed to invoke syscall 805851437: syscall not found NEO-GO-VM 8 > parse Error: missing argument NEO-GO-VM 8 > parse 123 Integer to Hex 7b Integer to Base64 ew== String to Hex 313233 String to Base64 MTIz NEO-GO-VM 8 > unload NEO-GO-VM > exit ```	2022-02-18 16:34:58 +03:00
Anna Shaleva	563c3a4baa	vm: replace ishell with urfave/cli ... Use github.com/chzyer/readline for readline capabilities (including history and ANSI escape sequences handling).	2022-02-18 16:34:50 +03:00
Roman Khimov	7d6f087337	storage: drop (KeyPrefix).Bytes() API ... It allocates and most of the time we can avoid that.	2022-02-18 15:19:57 +03:00
Roman Khimov	7223caf369	dao: improve PutCurrentHeader logic ... Move serialization out of the core.	2022-02-18 15:05:25 +03:00
Roman Khimov	522229d731	storage: drop AppendPrefix/AppendPrefixInt APIs ... We're not using them anymore and they allocate.	2022-02-18 14:59:59 +03:00
Roman Khimov	d2db58d748	dao: move header hash store logic out of the core ... Which allows for more efficient buffer use along the way.	2022-02-18 14:54:05 +03:00
Roman Khimov	de2579ec07	dao: put contract IDs into keys using big endianness ... We don't have a need to iterate over them at the moment, but since we're changing the DB format in the next release anyway let's add this ability also, just in case.	2022-02-18 14:38:51 +03:00
Roman Khimov	600da6909c	storage: put uint32 into keys using in big endianness ... Which allows to iterate over the contents easily.	2022-02-18 14:35:17 +03:00
Roman Khimov	1ca918e631	dao: delay buffer creation until it's needed ... Verification contexts don't ever touch the storage, so these allocations can be avoided for them.	2022-02-18 14:24:45 +03:00
Roman Khimov	e864768c88	dao: simplify NewPrivate	2022-02-18 14:18:56 +03:00
Roman Khimov	5402e654d1	core: don't create useless DAO layer in GetTestVM ... We're already wrapping in interop.NewContext.	2022-02-18 14:12:44 +03:00
Roman Khimov	b60d4ff191	dao: deduplicate header->KV conversion	2022-02-18 14:12:44 +03:00
Roman Khimov	d8cf879499	dao: deduplicate DeleteBlock, no functional changes	2022-02-18 14:12:44 +03:00
Roman Khimov	f80680187e	storage: expose private storage map for more efficient MPT batch ... It couldn't be done previously with two maps and mixed storage, but now all of the storage changes are located in a single map, so it's trivial to do exact slice allocations and avoid string->[]byte conversions.	2022-02-17 23:41:10 +03:00
Roman Khimov	7dc8fc443f	dao: simplify buffer management for private DAO ... Private DAO is only used in a single thread which means we can safely reuse key/data buffers most of the time and handle it all in DAO. Doesn't affect any benchmarks.	2022-02-17 22:27:39 +03:00
Roman Khimov	9bfb3357f2	storage: add "private" mode to MemCachedStore ... Most of the time we don't need locking on the higher-level stores and we drop them after Persist, so that's what private MemCachedStore is for. It doesn't improve things in any noticeable way, some ~1% can be observed in neo-bench under various loads and even less than that in chain processing. But it seems to be a bit better anyway (less allocations, less locks).	2022-02-17 22:27:39 +03:00
Roman Khimov	aefb26255a	dao: drop DAO interface ... It's a remnant from the days when we had Simple and Cached DAO implementations, now it makes zero sense.	2022-02-16 18:24:20 +03:00
Roman Khimov	9d2ef775cf	storage: simplify (*MemCachedStore).Put/Delete interface ... They never return errors, so their interface should reflect that. This allows to remove quite a lot of useless and never tested code. Notice that Get still does return an error. It can be made not to do that, but usually we need to differentiate between successful/unsuccessful accesses anyway, so this doesn't help much.	2022-02-16 18:24:20 +03:00
Roman Khimov	be24bf6412	storage: drop Put and Delete from Store interface ... It's only changed with PutChangeSet, single KV operations are handled by MemCachedStore.	2022-02-16 18:24:20 +03:00
Roman Khimov	017795c9c1	storage: completely remove MemoryBatch ... If you need something like that, just wrap another MemCachedStore layer around it.	2022-02-16 16:13:12 +03:00
Roman Khimov	17a43b19e0	storage: remove Batch from Store ... We never use it for real underlying stores, so these implementations are useless (everything goes though PutChangeSet now).	2022-02-16 15:55:48 +03:00
Roman Khimov	35bdfc5eca	storage: use two maps for MemoryStore ... Simple and dumb as it is, this allows to separate contract storage from other things and dramatically improve Seek() time over storage (even though it's still unordered!) which in turn improves block processing speed. LevelDB LevelDB (KeepOnlyLatest) BoltDB BoltDB (KeepOnlyLatest) Master real 16m27,936s real 10m9,440s real 16m39,369s real 8m1,227s user 20m12,619s user 26m13,925s user 18m9,162s user 18m5,846s sys 2m56,377s sys 1m32,051s sys 9m52,576s sys 2m9,455s 2 maps real 10m49,495s real 8m53,342s real 11m46,204s real 5m56,043s user 14m19,922s user 24m6,225s user 13m25,691s user 15m4,694s sys 1m53,021s sys 1m23,006s sys 4m31,735s sys 2m8,714s neo-bench performance is mostly unaffected, ~0.5% for 1-1 test and 4% for 10K-10K test both fall within regular test error range.	2022-02-16 15:55:48 +03:00
Roman Khimov	b6a4947cfd	storage: drop STAccount prefix ... It's unused for a long time.	2022-02-16 13:06:57 +03:00
Roman Khimov	54bc603831	core: remove old storage items synchronously during jump ... There won't be a lot of them and GC experience we have shows that iterating over 1-2M of entries is not a huge problem for DBs we have.	2022-02-16 13:03:13 +03:00
Roman Khimov	805d81e441	core: drop old transfer data during state jump	2022-02-16 12:12:03 +03:00
Roman Khimov	3a2b800e5f	core: remove stale transfer entries, fix #2096 ... Initially I thought of doing it in the next persist cycle, but testing shows that it needs just ~2-5% of the time MPT GC does, so doing it in the same cycle doesn't affect anything.	2022-02-15 15:51:03 +03:00
Roman Khimov	c4b49a2d52	storage: deduplicate storage closing in tests	2022-02-14 17:29:21 +03:00
Roman Khimov	261552516b	stateroot: use a better word for logs	2022-02-14 17:29:21 +03:00
Roman Khimov	ccdda21718	stateroot: add and use DataMPTAux for auxiliary data ... Use DataMPT for nodes only, otherwise with 1M blocks with have 1M height-stateroot mapping entries that our GC has to iterate over for no reason.	2022-02-14 17:29:21 +03:00
Roman Khimov	ad606101c7	storage: add SeekGC interface for GC ... It's very special, single-purpose thing, but it improves cumulative time spent in GC by ~10% for LevelDB and by ~36% for BoltDB during 1050K mainnet chain processing. While the overall chain import time doesn't change in any noticeable way (~1%), I think it's still worth it, for machines with slower disks the difference might be more noticeable.	2022-02-14 17:29:21 +03:00
Roman Khimov	51b804ab0e	storage: generalize Level/Bolt seek implementations ... Too much in common. Just refactoring. no functional changes.	2022-02-12 23:09:37 +03:00
Roman Khimov	a5f8b8870a	storage: use Update for changeset processing ... Batch is only relevant in multithreaded context, internally it'll do some magic and use the same locking/updating Update does, so it makes little sense for us. This doesn't change benchmarks in any noticeable way.	2022-02-11 16:48:35 +03:00
Roman Khimov	6380647770	Merge pull request #2354 from nspcc-dev/mpt-value-based-gc ... Value-based MPT GC	2022-02-11 16:25:08 +03:00
Roman Khimov	373fce54e6	config: conflict P2PStateExchangeExtensions/KeepOnlyLatestState ... They don't make sense together, for P2P state exchange to be possible we need a set of MPTs.	2022-02-11 14:19:54 +03:00
Roman Khimov	c5f1e2fbcd	mpt: don't allocate for every key ... Microoptimization.	2022-02-11 14:19:54 +03:00
Roman Khimov	423c7883b8	core: implement basic GC for value-based storage scheme ... The key idea here is that even though we can't ensure MPT code won't make the node active again we can order the changes made to the persistent store in such a way that it practically doesn't matter. What happens is: * after persist if it's time to collect our garbage we do it synchronously right in the same thread working the underlying persistent store directly * all the other node code doesn't see much of it, it works with bc.dao or layers above it * if MPT doesn't find some stale deactivated node in the storage it's OK, it'll recreate it in bc.dao * if MPT finds it and activates it, it's OK too, bc.dao will store it * while GC is being performed nothing else changes the persistent store * all subsequent bc.dao persists only happen after the GC is completed which means that any changes to the (potentially) deleted nodes have a priority, it's OK for GC to delete something that'll be recreated with the next persist cycle Otherwise it's a simple scheme with node status/last active height stored in the value. Preliminary tests show that it works ~18% worse than the simple KeepOnlyLatest scheme, but this seems to be the best result so far. Fixes #2095.	2022-02-11 14:19:54 +03:00
Roman Khimov	075fd05bfc	Merge pull request #2356 from nspcc-dev/rpc-big-numbers ... Allow to use big integers in RPC	2022-02-11 13:24:35 +03:00
Evgeniy Stratonikov	037076f2ee	rpc/request: return error from ExpandArrayIntoScript if any ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-02-11 12:48:55 +03:00
Evgeniy Stratonikov	c72b3f2176	vm/emit: check big integer size ... Fix a bug where big integer could be emitted as 0 without reporting an error. Also, add tests. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-02-11 12:48:55 +03:00
Evgeniy Stratonikov	0394a79ef8	rpc: support big integers as request parameters ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-02-11 12:48:54 +03:00
Roman Khimov	acd348c13f	Merge pull request #2353 from nspcc-dev/fix-win-tests ... *: fix windows tests	2022-02-10 21:57:10 +03:00
Roman Khimov	c4ee310e85	mpt: modify refcounted storage scheme to make GC possible ... Add "active" flag into the node data and make the remainder modal, for active nodes it's a reference counter, for inactive ones the deactivation height is stored. Technically, refcounted chains storing just one trie don't need a flag, but it's a bit simpler this way.	2022-02-10 21:56:20 +03:00
Roman Khimov	86cb4ed80f	mpt: add the notion of MPT mode ... It directly affects the storage format, so it's important. ModeGC is not used at the moment, but defined for future extensibility.	2022-02-10 19:15:18 +03:00
Anna Shaleva	9bbd94d0fa	network: tune waiting limits in tests ... Some tests are failing on Windows due to slow runners with errors like the following: ``` 2022-02-09T17:11:20.3127016Z --- FAIL: TestGetData/transaction (1.82s) 2022-02-09T17:11:20.3127385Z server_test.go:500: 2022-02-09T17:11:20.3127878Z Error Trace: server_test.go:500 2022-02-09T17:11:20.3128533Z server_test.go:520 2022-02-09T17:11:20.3128978Z Error: Condition never satisfied 2022-02-09T17:11:20.3129479Z Test: TestGetData/transaction ```	2022-02-10 18:58:50 +03:00
Anna Shaleva	0de4c0fc17	compiler: use full paths for debug info files if relative can't be constructed ... Firstly introduced in 9871dc8f5a. It's OK if relative path can't be constructed e.g. for interop dependencies. Otherwice leads to failing tests on Windows with the following error: ``` 2022-02-09T09:39:31.3307626Z panic: Rel: can't make D:\a\neo-go\neo-go\pkg\interop\neogointernal\syscall.go relative to C:\Users\RUNNER~1\AppData\Local\Temp\TestContractInitAndCompile1998984267\001\testcontract [recovered] 2022-02-09T09:39:31.3308830Z panic: Rel: can't make D:\a\neo-go\neo-go\pkg\interop\neogointernal\syscall.go relative to C:\Users\RUNNER~1\AppData\Local\Temp\TestContractInitAndCompile1998984267\001\testcontract 2022-02-09T09:39:31.3309285Z 2022-02-09T09:39:31.3309390Z goroutine 302 [running]: 2022-02-09T09:39:31.3309725Z testing.tRunner.func1.2({0x14dbfe0, 0xc00051bdb0}) 2022-02-09T09:39:31.3310187Z C:/hostedtoolcache/windows/go/1.17.6/x64/src/testing/testing.go:1209 +0x36c 2022-02-09T09:39:31.3310538Z testing.tRunner.func1() 2022-02-09T09:39:31.3310937Z C:/hostedtoolcache/windows/go/1.17.6/x64/src/testing/testing.go:1212 +0x3b6 2022-02-09T09:39:31.3311285Z panic({0x14dbfe0, 0xc00051bdb0}) 2022-02-09T09:39:31.3311689Z C:/hostedtoolcache/windows/go/1.17.6/x64/src/runtime/panic.go:1047 +0x266 2022-02-09T09:39:31.3312319Z github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).fillDocumentInfo.func1(0xc0002d0b40) 2022-02-09T09:39:31.3312885Z D:/a/neo-go/neo-go/pkg/compiler/analysis.go:240 +0x34d 2022-02-09T09:39:31.3313397Z go/token.(*FileSet).Iterate(0xc0000a69c0, 0xc0004898b0) 2022-02-09T09:39:31.3313839Z C:/hostedtoolcache/windows/go/1.17.6/x64/src/go/token/position.go:463 +0xde 2022-02-09T09:39:31.3314404Z github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).fillDocumentInfo(0xc0002e4d20) 2022-02-09T09:39:31.3314947Z D:/a/neo-go/neo-go/pkg/compiler/analysis.go:236 +0x97 2022-02-09T09:39:31.3315530Z github.com/nspcc-dev/neo-go/pkg/compiler.(*codegen).compile(0xc0002e4d20, 0xc00009a690, 0xc000101540) 2022-02-09T09:39:31.3316064Z D:/a/neo-go/neo-go/pkg/compiler/codegen.go:2088 +0x192 2022-02-09T09:39:31.3316563Z github.com/nspcc-dev/neo-go/pkg/compiler.codeGen(0xc00009a690) 2022-02-09T09:39:31.3317066Z D:/a/neo-go/neo-go/pkg/compiler/codegen.go:2167 +0x7cd 2022-02-09T09:39:31.3317679Z github.com/nspcc-dev/neo-go/pkg/compiler.CompileWithOptions({0xc0000435e0, 0x62}, {0x0, 0x0}, 0xc0004bcf70) 2022-02-09T09:39:31.3318233Z D:/a/neo-go/neo-go/pkg/compiler/compiler.go:225 +0xde 2022-02-09T09:39:31.3318804Z github.com/nspcc-dev/neo-go/pkg/compiler.CompileAndSave({0xc0000435e0, 0x62}, 0xc0004bcf70) 2022-02-09T09:39:31.3319353Z D:/a/neo-go/neo-go/pkg/compiler/compiler.go:241 +0x3a5 2022-02-09T09:39:31.3319889Z github.com/nspcc-dev/neo-go/cli/smartcontract.contractCompile(0xc0004e42c0) 2022-02-09T09:39:31.3320456Z D:/a/neo-go/neo-go/cli/smartcontract/smart_contract.go:520 +0xc2d 2022-02-09T09:39:31.3320873Z github.com/urfave/cli.HandleAction({0x14b6fa0, 0x17b8d60}, 0x7) 2022-02-09T09:39:31.3321344Z C:/Users/runneradmin/go/pkg/mod/github.com/urfave/cli@v1.22.5/app.go:524 +0xf4 2022-02-09T09:39:31.3321931Z github.com/urfave/cli.Command.Run({{0x16460d2, 0x7}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0x166fe9e, 0x27}, {0x0, ...}, ...}, ...) 2022-02-09T09:39:31.3322443Z C:/Users/runneradmin/go/pkg/mod/github.com/urfave/cli@v1.22.5/command.go:173 +0xc09 2022-02-09T09:39:31.3322894Z github.com/urfave/cli.(*App).RunAsSubcommand(0xc0000b7340, 0xc0004e4000) 2022-02-09T09:39:31.3323375Z C:/Users/runneradmin/go/pkg/mod/github.com/urfave/cli@v1.22.5/app.go:405 +0x106c 2022-02-09T09:39:31.3323852Z github.com/urfave/cli.Command.startApp({{0x1647536, 0x8}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0x1671070, 0x28}, {0x0, ...}, ...}, ...) 2022-02-09T09:39:31.3324365Z C:/Users/runneradmin/go/pkg/mod/github.com/urfave/cli@v1.22.5/command.go:372 +0x108c 2022-02-09T09:39:31.3324838Z github.com/urfave/cli.Command.Run({{0x1647536, 0x8}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0x1671070, 0x28}, {0x0, ...}, ...}, ...) 2022-02-09T09:39:31.3325327Z C:/Users/runneradmin/go/pkg/mod/github.com/urfave/cli@v1.22.5/command.go:102 +0xe8c 2022-02-09T09:39:31.3325744Z github.com/urfave/cli.(*App).Run(0xc000323880, {0xc0004237a0, 0xb, 0x12}) 2022-02-09T09:39:31.3326198Z C:/Users/runneradmin/go/pkg/mod/github.com/urfave/cli@v1.22.5/app.go:277 +0xa8c 2022-02-09T09:39:31.3326770Z github.com/nspcc-dev/neo-go/cli.(*executor).run(0xc0000709c0, {0xc0004237a0, 0xb, 0x12}) 2022-02-09T09:39:31.3327275Z D:/a/neo-go/neo-go/cli/executor_test.go:273 +0x3a5 2022-02-09T09:39:31.3327812Z github.com/nspcc-dev/neo-go/cli.(*executor).Run(0x14aa020, 0xc000493950, {0xc0004237a0, 0xb, 0x12}) 2022-02-09T09:39:31.3328324Z D:/a/neo-go/neo-go/cli/executor_test.go:263 +0x10f 2022-02-09T09:39:31.3328844Z github.com/nspcc-dev/neo-go/cli.TestContractInitAndCompile(0xc0001d69c0) 2022-02-09T09:39:31.3329377Z D:/a/neo-go/neo-go/cli/contract_test.go:155 +0x147f 2022-02-09T09:39:31.3329694Z testing.tRunner(0xc0001d69c0, 0x17b8be8) 2022-02-09T09:39:31.3330123Z C:/hostedtoolcache/windows/go/1.17.6/x64/src/testing/testing.go:1259 +0x230 2022-02-09T09:39:31.3330470Z created by testing.(*T).Run 2022-02-09T09:39:31.3330862Z C:/hostedtoolcache/windows/go/1.17.6/x64/src/testing/testing.go:1306 +0x727 2022-02-09T09:39:31.3331325Z FAIL github.com/nspcc-dev/neo-go/cli 5.552s ```	2022-02-10 18:58:44 +03:00
Anna Shaleva	a9872063fe	vm: refactor VM CLI tests as they take too long to pass ... These tests are slow on Windows, so refactor them a bit and avoid the following error: ``` --- FAIL: TestRunWithDifferentArguments (4.01s) cli_test.go:96: Error Trace: cli_test.go:96 cli_test.go:321 Error: command took too long time Test: TestRunWithDifferentArguments ```	2022-02-10 18:04:16 +03:00
Anna Shaleva	e306a90554	rpc: add NEP11-D tests to server and client ... Also refactor basic chain creation.	2022-02-09 11:57:16 +03:00
Anna Shaleva	47652643df	rpc: accept NEP11 token IDs as []byte for client methods ... Accepting IDs as string is encoding-ambiguous, so make it []byte instead.	2022-02-09 11:55:07 +03:00
Roman Khimov	de99c3acdb	storage: provide a way to escape from SeekAsync goroutine ... A routine blocked on channel send here can't really exit, so avoid goroutine leak: goroutine 2813725 [chan send, 6 minutes]: github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).SeekAsync.func1.1(0xc01a7118f7, 0x2, 0x25, 0xc01a7118f9, 0x23, 0x23, 0xc0366c7c01) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:120 +0x86 github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).seek.func2(0xc0079e7920, 0xa, 0x30, 0xc0079e792a, 0x26, 0x26, 0x1) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:183 +0x347 github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).seek(0xc000458480, 0x135c028, 0xc0000445d0, 0xc00f1721d0, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:224 +0x4f4 github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).Seek(0xc000458480, 0xc00f1721d0, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, 0xc0357c6620) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:110 +0x8a github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).seek(0xc0331a4f00, 0x135bff0, 0xc00ae26ec0, 0xc00f1721d0, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:210 +0x379 github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).SeekAsync.func1(0xc0331a4f00, 0x135bff0, 0xc00ae26ec0, 0xc00f1721d0, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:119 +0xc5 created by github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).SeekAsync github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:118 +0xc8 goroutine 2822823 [chan send, 6 minutes]: github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).SeekAsync.func1.1(0xc011859b77, 0x3, 0x3, 0xc017bea8d0, 0x26, 0x26, 0xc00f1afc00) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:120 +0x86 github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).seek.func2(0xc011859b60, 0xa, 0xa, 0xc017bea8a0, 0x26, 0x26, 0xc00ad9fb00) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:200 +0x47e github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).seek.func2(0xc01d5d8c90, 0xa, 0x30, 0xc01d5d8c9a, 0x26, 0x26, 0x1) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:200 +0x47e github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).seek(0xc035e12900, 0x135c028, 0xc0000445d0, 0xc01773bf60, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:224 +0x4f4 github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).Seek(0xc035e12900, 0xc01773bf60, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, 0xc030c9e0e0) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:110 +0x8a github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).seek(0xc000458480, 0x135c028, 0xc0000445d0, 0xc01773bf60, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:210 +0x379 github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).Seek(0xc000458480, 0xc01773bf60, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, 0xc030c9e070) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:110 +0x8a github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).seek(0xc00b340c60, 0x135bff0, 0xc00f1afbc0, 0xc01773bf60, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:210 +0x379 github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).SeekAsync.func1(0xc00b340c60, 0x135bff0, 0xc00f1afbc0, 0xc01773bf60, 0x7, 0x7, 0x0, 0x0, 0x0, 0x0, ...) github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:119 +0xc5 created by github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemCachedStore).SeekAsync github.com/nspcc-dev/neo-go/pkg/core/storage/memcached_store.go:118 +0xc8 ...	2022-02-09 00:22:42 +03:00
Roman Khimov	3307292597	storage: rework MemoryStore with a single map ... Doesn't affect any benchmarks or tests, but makes things a bit simpler.	2022-02-09 00:22:42 +03:00
Roman Khimov	2bc493a839	mpt: simplify makeStorageKey() interface	2022-02-08 12:38:03 +03:00
Evgeniy Stratonikov	b5afe24090	compiler: properly process defer in conditional statements ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-02-04 11:04:03 +03:00
Evgeniy Stratonikov	10d006195a	vm: properly clear try stack in CALL ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-02-04 11:04:03 +03:00
Evgeniy Stratonikov	ed43b75631	compiler: do not traverse defer function literals twice ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-02-02 16:52:15 +03:00
Roman Khimov	9719191770	Merge pull request #2342 from nspcc-dev/fix-management-contract-callflags ... Fix management contract callflags	2022-02-01 12:30:53 +03:00
Roman Khimov	7945097543	native: fix ContractManagement's call flags for update/deploy ... See neo-project/neo#2653.	2022-02-01 12:21:00 +03:00
Roman Khimov	1df447cd68	Merge pull request #2334 from nspcc-dev/extendable-validators ... Extendable validators	2022-02-01 12:09:56 +03:00
Roman Khimov	cda1c75db3	core: drop GetStandBy* methods ... They're misleading now that we have variable number of committee members/validators. The standby list can be seen in the configuration and the appropriate numbers can be received from it also.	2022-01-31 23:14:38 +03:00
Roman Khimov	e621f746a7	config/core: allow to change the number of validators ... Fixes #2320.	2022-01-31 23:14:38 +03:00
Roman Khimov	37ca96c20b	interop: use All flags for management deploy and update calls ... Unfortunately, tests will fail after this commit, but it needs to be done in order to update interop dependency afterwards. Fixes #1990.	2022-01-31 22:21:08 +03:00
Evgeniy Stratonikov	e890c32dcc	rpc/client: remove dependency on examples ... Duplicate necessary structures in a dedicated micropackage. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-01-25 12:41:06 +03:00
Roman Khimov	60d6fa1125	network: keep a copy of the config inside of Server ... Avoid copying the configuration again and again, make things a bit more efficient.	2022-01-24 18:43:01 +03:00
Roman Khimov	6e9d725a29	config: consolidate ProtocolConfiguration consistency checks	2022-01-24 18:42:57 +03:00
Anna Shaleva	9c2e92d7d9	compiler: check overloaded methods for safeness one more time ... It's possible that overloaded method is marked as `safe` in manifest, so that it must have `save` field set to true after its name was overwritten.	2022-01-21 18:03:04 +03:00
Anna Shaleva	fa1174ec7e	smartcontract: adjust NEP11-D standard ... Method `ownerOf` returns iterator which should be of the type InteropInterface.	2022-01-21 18:03:04 +03:00
Evgeniy Stratonikov	ad65d1fa1f	compiler: implement custom logic for go1.15 ... For some reason `foo.go` is interpreted as an http URL, and even if we replace it with `./foo.go` there is an errors with file missing on disk. Because `CompileWithOptions` should be able to compile file under any circumstances, we allocate temporary directory base on version used to compile a binary. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-01-21 17:43:28 +03:00
Evgeniy Stratonikov	970769e5b2	compiler: allow to use _ in constants ... When `_` is unused it can be omitted from constant values mapping. Catched when compiling `netmap` contract from nspcc-dev/neofs-contract. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-01-20 13:52:58 +03:00
Evgeniy Stratonikov	25583f9aeb	compiler: make pkg/interop a separate module ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-01-20 13:21:26 +03:00
Evgeniy Stratonikov	548a6a06f1	compiler: speed up boolean expression short-circuit test ... The amount of tests done is comparable to all other tests in compiler package (~2k). After we moved to a new x/tools package this became a bottleneck. In this commit we reduce the amount of compiled files by combining multiple tests in a single file. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-01-20 13:21:26 +03:00
Evgeniy Stratonikov	9871dc8f5a	compiler: update x/tools package ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-01-20 13:21:26 +03:00
Evgeniy Stratonikov	e7a0ecb349	compiler: provide .go filename to Compile ... First argument contains filename, thus we use '.go' suffix to distinguish between directories and files. Contract name should be provided in options. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-01-20 13:21:24 +03:00
Evgeniy Stratonikov	8af9c870b1	compiler: remove CompileWithDebugInfo ... It is a simple wrapper over `CompileWithOptions` which we don't really need. Custom options can be specified explicitly instead of using some random default. This default was introduced in 1578904da, however tests written there use `CompileWithOptions` and all other tests pass on that commit even without this default. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-01-20 13:15:48 +03:00
Evgeniy Stratonikov	46f623a48f	compiler/test: use public functions in tests ... `CompileWithOptions` does exactly the thing we need. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2022-01-20 13:15:48 +03:00
Roman Khimov	42769d11ff	Merge pull request #2330 from nspcc-dev/transfer-logs-opt ... core: improve Seek and optimise seek time for transfer logs	2022-01-19 21:55:40 +03:00
Anna Shaleva	9b841b9b8f	core, rpc: use Seek to iterate over NEP* transfers ... The results are controversial a bit. MemoryPS is a special storage and the new approach doesn't help it to iterate through NEP17 transfers. However, on long distances (if transfers are requested for more than 1000 blocks, which is ~4.1 hours of mainnet chain) both LevelDB and BoltDB perform good enough with the new approach. Taking into account the fact that default value for the query period of `getnep17transfers` RPC handler is a week (~40K mainnet blocks) we can sacrifice MemoryPS performance in favour of BoltDB and LevelDB optimisation. Close #2263. Benchmark results: name old time/op new time/op delta Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1_Take100Blocks-8 783µs ±13% 1762µs ± 4% +125.12% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1_Take1000Blocks-8 6.91ms ± 2% 9.00ms ± 2% +30.28% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-100_Take100Blocks-8 1.43ms ± 8% 1.79ms ± 4% +24.93% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-100_Take1000Blocks-8 7.78ms ± 3% 8.93ms ± 2% +14.78% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1000_Take100Blocks-8 7.69ms ± 3% 1.73ms ±10% -77.50% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1000_Take1000Blocks-8 14.1ms ± 2% 9.0ms ± 2% -36.53% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1_Take100Blocks-8 768µs ± 3% 801µs ± 2% +4.24% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1_Take1000Blocks-8 8.03ms ± 2% 8.05ms ± 8% ~ (p=0.436 n=10+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-100_Take100Blocks-8 1.70ms ±16% 0.85ms ± 7% -49.85% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-100_Take1000Blocks-8 10.8ms ± 2% 8.1ms ± 2% -25.21% (p=0.000 n=10+8) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1000_Take100Blocks-8 10.8ms ± 2% 0.9ms ± 7% -92.12% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1000_Take1000Blocks-8 18.2ms ±13% 8.2ms ± 6% -54.95% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1_Take100Blocks-8 874µs ± 6% 823µs ± 2% -5.81% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1_Take1000Blocks-8 9.35ms ± 2% 8.14ms ± 2% -12.91% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-100_Take100Blocks-8 1.85ms ± 4% 0.89ms ±10% -51.68% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-100_Take1000Blocks-8 10.6ms ± 4% 8.2ms ± 2% -22.44% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1000_Take100Blocks-8 10.7ms ± 2% 0.9ms ± 2% -91.90% (p=0.000 n=8+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1000_Take1000Blocks-8 21.8ms ±15% 8.2ms ± 1% -62.25% (p=0.000 n=10+10) name old alloc/op new alloc/op delta Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1_Take100Blocks-8 650kB ± 0% 1010kB ± 7% +55.45% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1_Take1000Blocks-8 6.39MB ± 0% 9.89MB ± 1% +54.74% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-100_Take100Blocks-8 1.28MB ± 0% 1.14MB ± 0% -11.25% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-100_Take1000Blocks-8 7.02MB ± 0% 10.01MB ± 0% +42.54% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1000_Take100Blocks-8 7.02MB ± 0% 1.08MB ± 0% -84.64% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1000_Take1000Blocks-8 12.8MB ± 0% 10.0MB ± 0% -22.04% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1_Take100Blocks-8 823kB ± 3% 866kB ± 5% +5.19% (p=0.001 n=9+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1_Take1000Blocks-8 9.92MB ± 0% 9.85MB ± 0% -0.71% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-100_Take100Blocks-8 1.84MB ± 4% 1.01MB ± 5% -44.75% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-100_Take1000Blocks-8 11.0MB ± 0% 10.0MB ± 1% -8.45% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1000_Take100Blocks-8 11.0MB ± 0% 1.0MB ± 1% -90.55% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1000_Take1000Blocks-8 20.0MB ± 0% 10.1MB ± 0% -49.69% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1_Take100Blocks-8 913kB ± 5% 907kB ± 6% ~ (p=0.497 n=9+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1_Take1000Blocks-8 10.0MB ± 1% 10.0MB ± 1% -0.63% (p=0.001 n=10+8) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-100_Take100Blocks-8 1.92MB ± 2% 1.04MB ± 0% -45.53% (p=0.000 n=9+8) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-100_Take1000Blocks-8 11.1MB ± 1% 10.1MB ± 0% -9.22% (p=0.000 n=10+7) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1000_Take100Blocks-8 11.1MB ± 1% 1.0MB ± 0% -90.61% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1000_Take1000Blocks-8 20.4MB ± 1% 10.1MB ± 0% -50.46% (p=0.000 n=10+10) name old allocs/op new allocs/op delta Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1_Take100Blocks-8 11.1k ± 0% 11.7k ± 0% +5.35% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1_Take1000Blocks-8 110k ± 0% 110k ± 0% +0.55% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-100_Take100Blocks-8 22.0k ± 0% 11.9k ± 0% -46.14% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-100_Take1000Blocks-8 120k ± 0% 110k ± 0% -8.44% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1000_Take100Blocks-8 120k ± 0% 12k ± 0% -90.36% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/MemPS_StartFromBlockN-1000_Take1000Blocks-8 219k ± 0% 110k ± 0% -49.73% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1_Take100Blocks-8 11.3k ± 0% 11.2k ± 0% -1.06% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1_Take1000Blocks-8 112k ± 0% 110k ± 0% -2.36% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-100_Take100Blocks-8 22.5k ± 0% 11.3k ± 0% -49.65% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-100_Take1000Blocks-8 124k ± 0% 110k ± 0% -11.08% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1000_Take100Blocks-8 124k ± 0% 11k ± 0% -90.84% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/BoltPS_StartFromBlockN-1000_Take1000Blocks-8 225k ± 0% 110k ± 0% -51.07% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1_Take100Blocks-8 11.4k ± 0% 11.3k ± 0% -1.36% (p=0.000 n=9+9) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1_Take1000Blocks-8 114k ± 0% 111k ± 0% -2.33% (p=0.000 n=10+9) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-100_Take100Blocks-8 22.7k ± 0% 11.5k ± 0% -49.56% (p=0.000 n=9+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-100_Take1000Blocks-8 125k ± 0% 111k ± 0% -11.12% (p=0.000 n=10+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1000_Take100Blocks-8 125k ± 0% 11k ± 0% -90.82% (p=0.000 n=8+10) Blockchain_ForEachNEP17Transfer/LevelPS_StartFromBlockN-1000_Take1000Blocks-8 229k ± 1% 111k ± 0% -51.42% (p=0.000 n=10+10)	2022-01-19 20:55:08 +03:00
Anna Shaleva	e3af21ab4a	core: add benchmark for ForEachNEP17Transfer	2022-01-19 20:54:35 +03:00
Anna Shaleva	cd42b8b20c	core: allow early Seek stop ... This simple approach allows to improve the performance of BoltDB and LevelDB in both terms of speed and allocations for retrieving GasPerVote value from the storage. MemoryPS's speed suffers a bit, but we don't use it for production environment. Part of #2322. Benchmark results: name old time/op new time/op delta NEO_GetGASPerVote/MemPS_10RewardRecords_1RewardDistance-8 25.3µs ± 1% 26.4µs ± 9% +4.41% (p=0.043 n=10+9) NEO_GetGASPerVote/MemPS_10RewardRecords_10RewardDistance-8 27.9µs ± 1% 30.1µs ±15% +7.97% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_10RewardRecords_100RewardDistance-8 55.1µs ± 1% 60.2µs ± 7% +9.27% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_1000RewardDistance-8 353µs ± 2% 416µs ±13% +17.88% (p=0.000 n=8+8) NEO_GetGASPerVote/MemPS_100RewardRecords_1RewardDistance-8 195µs ± 1% 216µs ± 7% +10.42% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_10RewardDistance-8 200µs ± 4% 214µs ± 9% +6.99% (p=0.002 n=9+8) NEO_GetGASPerVote/MemPS_100RewardRecords_100RewardDistance-8 223µs ± 2% 247µs ± 9% +10.60% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1000RewardDistance-8 612µs ±23% 855µs ±52% +39.60% (p=0.001 n=9+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1RewardDistance-8 11.3ms ±53% 10.7ms ±50% ~ (p=0.739 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_10RewardDistance-8 12.0ms ±37% 10.4ms ±65% ~ (p=0.853 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_100RewardDistance-8 11.3ms ±40% 10.4ms ±49% ~ (p=0.631 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1000RewardDistance-8 3.80ms ±45% 3.69ms ±27% ~ (p=0.931 n=6+5) NEO_GetGASPerVote/BoltPS_10RewardRecords_1RewardDistance-8 23.0µs ± 9% 22.6µs ± 4% ~ (p=0.059 n=8+9) NEO_GetGASPerVote/BoltPS_10RewardRecords_10RewardDistance-8 25.9µs ± 5% 24.8µs ± 4% -4.17% (p=0.006 n=10+8) NEO_GetGASPerVote/BoltPS_10RewardRecords_100RewardDistance-8 42.7µs ±13% 38.9µs ± 1% -8.85% (p=0.000 n=9+8) NEO_GetGASPerVote/BoltPS_10RewardRecords_1000RewardDistance-8 80.8µs ±12% 84.9µs ± 9% ~ (p=0.114 n=8+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_1RewardDistance-8 64.3µs ±16% 22.1µs ±23% -65.64% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_10RewardDistance-8 61.0µs ±34% 23.2µs ± 8% -62.04% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_100RewardDistance-8 62.2µs ±14% 25.7µs ±13% -58.66% (p=0.000 n=9+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_1000RewardDistance-8 359µs ±60% 325µs ±60% ~ (p=0.739 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1RewardDistance-8 242µs ±21% 13µs ±28% -94.49% (p=0.000 n=10+8) NEO_GetGASPerVote/BoltPS_1000RewardRecords_10RewardDistance-8 229µs ±23% 18µs ±70% -92.02% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_1000RewardRecords_100RewardDistance-8 238µs ±28% 20µs ±109% -91.38% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1000RewardDistance-8 265µs ±20% 77µs ±62% -71.04% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1RewardDistance-8 25.5µs ± 3% 24.7µs ± 7% ~ (p=0.143 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_10RewardDistance-8 27.4µs ± 2% 27.9µs ± 6% ~ (p=0.280 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_100RewardDistance-8 50.2µs ± 7% 47.4µs ±10% ~ (p=0.156 n=9+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1000RewardDistance-8 98.2µs ± 9% 94.6µs ±10% ~ (p=0.218 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_1RewardDistance-8 82.9µs ±13% 32.1µs ±22% -61.30% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_10RewardDistance-8 92.2µs ±11% 33.7µs ±12% -63.42% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_100RewardRecords_100RewardDistance-8 88.3µs ±22% 39.4µs ±14% -55.36% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_100RewardRecords_1000RewardDistance-8 106µs ±18% 78µs ±24% -26.20% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1RewardDistance-8 360µs ±24% 29µs ±53% -91.91% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_1000RewardRecords_10RewardDistance-8 353µs ±16% 50µs ±70% -85.72% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_100RewardDistance-8 381µs ±20% 47µs ±111% -87.64% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1000RewardDistance-8 434µs ±19% 113µs ±41% -74.04% (p=0.000 n=10+10) name old alloc/op new alloc/op delta NEO_GetGASPerVote/MemPS_10RewardRecords_1RewardDistance-8 4.82kB ± 0% 4.26kB ± 1% -11.62% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_10RewardRecords_10RewardDistance-8 4.99kB ± 0% 4.41kB ± 1% -11.56% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_100RewardDistance-8 8.45kB ± 0% 7.87kB ± 0% -6.88% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_1000RewardDistance-8 55.0kB ± 0% 54.5kB ± 0% -0.81% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1RewardDistance-8 29.1kB ± 0% 21.7kB ± 2% -25.56% (p=0.000 n=9+9) NEO_GetGASPerVote/MemPS_100RewardRecords_10RewardDistance-8 29.3kB ± 1% 21.8kB ± 2% -25.74% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_100RewardDistance-8 31.3kB ± 1% 23.6kB ± 1% -24.50% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1000RewardDistance-8 92.5kB ± 5% 84.7kB ± 3% -8.50% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_1000RewardRecords_1RewardDistance-8 324kB ±29% 222kB ±44% -31.33% (p=0.007 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_10RewardDistance-8 308kB ±32% 174kB ±14% -43.56% (p=0.000 n=10+8) NEO_GetGASPerVote/MemPS_1000RewardRecords_100RewardDistance-8 298kB ±23% 178kB ±36% -40.26% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1000RewardDistance-8 362kB ± 6% 248kB ± 6% -31.54% (p=0.004 n=6+5) NEO_GetGASPerVote/BoltPS_10RewardRecords_1RewardDistance-8 5.15kB ± 3% 4.64kB ± 2% -9.92% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_10RewardRecords_10RewardDistance-8 5.36kB ± 1% 4.75kB ± 5% -11.42% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_10RewardRecords_100RewardDistance-8 8.15kB ± 4% 7.53kB ± 1% -7.62% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_10RewardRecords_1000RewardDistance-8 33.2kB ± 5% 33.2kB ± 7% ~ (p=0.829 n=8+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_1RewardDistance-8 20.1kB ± 7% 5.8kB ±13% -70.90% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_10RewardDistance-8 19.8kB ±14% 6.2kB ± 5% -68.87% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_100RewardDistance-8 21.7kB ± 6% 8.0kB ± 7% -63.20% (p=0.000 n=9+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_1000RewardDistance-8 98.5kB ±44% 81.8kB ±48% ~ (p=0.143 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1RewardDistance-8 130kB ± 4% 4kB ± 9% -96.69% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_10RewardDistance-8 131kB ± 4% 5kB ±21% -96.48% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_1000RewardRecords_100RewardDistance-8 132kB ± 4% 6kB ±10% -95.39% (p=0.000 n=10+8) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1000RewardDistance-8 151kB ± 4% 26kB ±10% -82.46% (p=0.000 n=9+9) NEO_GetGASPerVote/LevelPS_10RewardRecords_1RewardDistance-8 5.92kB ± 3% 5.32kB ± 2% -10.01% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_10RewardDistance-8 6.09kB ± 2% 5.48kB ± 2% -10.00% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_100RewardDistance-8 9.61kB ± 1% 9.00kB ± 0% -6.29% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1000RewardDistance-8 33.4kB ± 7% 32.2kB ± 5% -3.60% (p=0.037 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_1RewardDistance-8 22.3kB ±10% 9.0kB ±16% -59.78% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_10RewardDistance-8 23.6kB ± 6% 8.5kB ±20% -63.76% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_100RewardDistance-8 24.2kB ± 9% 11.5kB ± 4% -52.34% (p=0.000 n=10+8) NEO_GetGASPerVote/LevelPS_100RewardRecords_1000RewardDistance-8 44.2kB ± 6% 30.8kB ± 9% -30.24% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1RewardDistance-8 144kB ± 4% 10kB ±24% -93.39% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_10RewardDistance-8 146kB ± 1% 11kB ±37% -92.14% (p=0.000 n=7+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_100RewardDistance-8 149kB ± 3% 11kB ±12% -92.28% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1000RewardDistance-8 171kB ± 4% 34kB ±12% -80.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta NEO_GetGASPerVote/MemPS_10RewardRecords_1RewardDistance-8 95.0 ± 0% 74.0 ± 0% -22.11% (p=0.001 n=8+9) NEO_GetGASPerVote/MemPS_10RewardRecords_10RewardDistance-8 100 ± 0% 78 ± 1% -21.70% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_100RewardDistance-8 153 ± 0% 131 ± 2% -14.25% (p=0.000 n=6+10) NEO_GetGASPerVote/MemPS_10RewardRecords_1000RewardDistance-8 799 ± 2% 797 ± 4% ~ (p=0.956 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1RewardDistance-8 438 ± 6% 167 ± 0% -61.86% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_100RewardRecords_10RewardDistance-8 446 ± 5% 172 ± 0% -61.38% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_100RewardDistance-8 506 ± 4% 232 ± 1% -54.21% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1000RewardDistance-8 1.31k ± 5% 0.97k ± 4% -26.20% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1RewardDistance-8 5.06k ± 1% 1.09k ± 2% -78.53% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_10RewardDistance-8 5.02k ± 3% 1.08k ± 0% -78.45% (p=0.000 n=10+8) NEO_GetGASPerVote/MemPS_1000RewardRecords_100RewardDistance-8 5.09k ± 3% 1.15k ± 2% -77.48% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1000RewardDistance-8 5.83k ± 1% 1.87k ± 3% -68.02% (p=0.004 n=6+5) NEO_GetGASPerVote/BoltPS_10RewardRecords_1RewardDistance-8 103 ± 2% 82 ± 1% -20.83% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_10RewardRecords_10RewardDistance-8 107 ± 0% 86 ± 0% -19.63% (p=0.000 n=8+8) NEO_GetGASPerVote/BoltPS_10RewardRecords_100RewardDistance-8 164 ± 1% 139 ± 0% -15.45% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_10RewardRecords_1000RewardDistance-8 820 ± 1% 789 ± 1% -3.70% (p=0.000 n=9+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_1RewardDistance-8 475 ± 0% 94 ± 3% -80.15% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_10RewardDistance-8 481 ± 0% 100 ± 2% -79.26% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_100RewardDistance-8 549 ± 0% 161 ± 2% -70.69% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_1000RewardDistance-8 1.61k ±19% 1.19k ±25% -26.05% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1RewardDistance-8 4.12k ± 0% 0.08k ± 2% -98.02% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_10RewardDistance-8 4.14k ± 0% 0.09k ± 3% -97.90% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_1000RewardRecords_100RewardDistance-8 4.19k ± 0% 0.15k ± 3% -96.52% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1000RewardDistance-8 4.82k ± 1% 0.74k ± 1% -84.58% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_10RewardRecords_1RewardDistance-8 112 ± 4% 90 ± 3% -19.45% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_10RewardDistance-8 116 ± 2% 95 ± 2% -17.90% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_100RewardDistance-8 170 ± 3% 148 ± 3% -12.99% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1000RewardDistance-8 800 ± 2% 772 ± 2% -3.50% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_1RewardDistance-8 480 ± 3% 118 ± 3% -75.32% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_10RewardDistance-8 479 ± 2% 123 ± 3% -74.33% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_100RewardRecords_100RewardDistance-8 542 ± 1% 183 ± 3% -66.34% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_100RewardRecords_1000RewardDistance-8 1.19k ± 1% 0.79k ± 1% -33.41% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1RewardDistance-8 4.21k ± 1% 0.13k ±21% -96.83% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_10RewardDistance-8 4.23k ± 1% 0.15k ±17% -96.48% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_100RewardDistance-8 4.27k ± 0% 0.19k ± 6% -95.51% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1000RewardDistance-8 4.89k ± 1% 0.79k ± 2% -83.80% (p=0.000 n=10+10)	2022-01-19 20:54:35 +03:00
Roman Khimov	4e864ca7fb	Merge pull request #2331 from nspcc-dev/extend-invokefunction-results ... Extend invokefunction results	2022-01-19 18:25:41 +03:00
Anna Shaleva	cc60bca491	core: adjust native Notary withdraw call flags ... It changes states and calls `transfer` method of GAS which emits `transfer` notification, so it requires States | AllowCall | AllowNotify, i.e. the widest permission. See https://github.com/nspcc-dev/neo-go/issues/1990#issuecomment-1014911528.	2022-01-19 11:33:33 +03:00
Roman Khimov	2e452df13a	rpc/storage: add storage changes to invoke* diagnostics	2022-01-19 00:02:19 +03:00
Roman Khimov	d79d8324e0	rpc: add notifications into the invoke* result	2022-01-18 22:35:44 +03:00
Roman Khimov	0afe8826ba	Merge pull request #2328 from nspcc-dev/rpc/getstateroot-client ... rpc: add `getstateroot` to RPC client	2022-01-18 18:13:27 +03:00
Anna Shaleva	b98fab6b38	rpc: refactor findstates client wrapper ... 1. Use empty `prefix` instead of nil `preifx` in order to avoid RPC server exceptions. 2. Allow to omit `start` parameter` if `maxCount` is not specified. 3. Use empty `start` instead of nil `start` to avoid RPC server exceptions.	2022-01-18 14:56:17 +03:00
Roman Khimov	89d754da6f	network: don't request blocks we already have in the queue ... Fixes #2258.	2022-01-18 00:04:41 +03:00
Roman Khimov	03fd91e857	network: use assert.Eventually in bq test ... Simpler and more efficient (polls more often and completes the test sooner).	2022-01-18 00:04:29 +03:00
Roman Khimov	d52a06a82d	network: move index-position relation into helper ... Just to make things more clear, no functional changes.	2022-01-18 00:02:16 +03:00
Anna Shaleva	e3c0a1635f	rpc: improve findstates errors reporting	2022-01-17 12:24:59 +03:00
Anna Shaleva	edcb6e2eee	rpc: fix parameters construction error for findstates client wrapper	2022-01-17 12:24:39 +03:00
Anna Shaleva	4c469e6f49	rpc: update docs of RPC client	2022-01-17 12:00:56 +03:00
Anna Shaleva	83b4c6734f	rpc: add support of getstateroot to RPC client	2022-01-17 11:59:13 +03:00
Roman Khimov	9c8ba5777e	Merge pull request #2323 from nspcc-dev/drop-blockchainer ... Reduce blockchainer.Blockchainer use	2022-01-14 20:47:26 +03:00
Roman Khimov	294a70646e	core: lock block addition on state jump ... It should be performed before we're able to process blocks or before we shutdown (which uses addition lock), fix panic: assignment to entry in nil map goroutine 5755 [running]: github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemoryStore).drop(...) /home/rik/dev/neo-go/pkg/core/storage/memory_store.go:74 github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemoryStore).PutChangeSet(0xc00093e700, 0xc0002051a0, 0xc000205200, 0x1, 0x1) /home/rik/dev/neo-go/pkg/core/storage/memory_store.go:100 +0x25c github.com/nspcc-dev/neo-go/pkg/core/storage.(*MemoryStore).PutBatch(...) /home/rik/dev/neo-go/pkg/core/storage/memory_store.go:90 github.com/nspcc-dev/neo-go/pkg/core.(*Blockchain).removeOldStorageItems(0xc000206a00) /home/rik/dev/neo-go/pkg/core/blockchain.go:495 +0x33a created by github.com/nspcc-dev/neo-go/pkg/core.(*Blockchain).jumpToStateInternal /home/rik/dev/neo-go/pkg/core/blockchain.go:553 +0x68a FAIL github.com/nspcc-dev/neo-go/pkg/core 52.084s	2022-01-14 20:25:39 +03:00
Roman Khimov	bc6d6e58bc	network: always pass transactions to consensus process ... Consensus can require conflicting transactions and it can require more transactions than mempool can fit, all of this should work. Transactions will be checked anyway using its secondary mempool. See the scenario from #668.	2022-01-14 20:08:40 +03:00
Roman Khimov	746644a4eb	network: decouple it from blockchainer.Blockchainer ... We don't need all of it.	2022-01-14 19:57:16 +03:00
Roman Khimov	ddb23ccf78	core: shrink blockchainer.StateRoot further, leave simple RO methods	2022-01-14 19:57:16 +03:00
Roman Khimov	077d5ccb03	core: drop dangerous methods from blockchainer.StateRoot ... CleanStorage and UpdateStateValidators should only be availabe to appropriate core modules.	2022-01-14 19:57:16 +03:00
Roman Khimov	380e706255	core/state*: drop blockchainer.Blockchainer use	2022-01-14 19:57:16 +03:00
Roman Khimov	44fd7af044	rpc/result: drop unnecessary blockchainer dependency	2022-01-14 19:57:16 +03:00
Roman Khimov	59b2696849	services/consensus: drop blockchainer.Blockchainer use ... Simplify testing, avoid monstrous Blockchainer interface.	2022-01-14 19:57:16 +03:00
Roman Khimov	fc45d3b132	blockchain: properly set invocation counter for verification ctx ... Fix problem noted in #2270.	2022-01-14 19:57:16 +03:00
Roman Khimov	9f9bd7261c	core: return *interop.Context from GetTestVM ... Return everything needed, fix #2273.	2022-01-14 19:57:16 +03:00
Roman Khimov	ab2e60458d	interop: drop blockchainer dependency ... Use local interface.	2022-01-14 19:57:16 +03:00
Roman Khimov	bf1604454c	blockchainer/network: move StateSync interface to the user ... Only network package cares about it.	2022-01-14 19:57:14 +03:00
Roman Khimov	af87cb082f	network: decouple Server from the notary service	2022-01-14 19:55:53 +03:00
Roman Khimov	508d36f698	network: drop consensus dependency	2022-01-14 19:55:53 +03:00
Roman Khimov	66aafd868b	network: unplug stateroot service from the Server ... Notice that it makes the node accept Extensible payloads with any category which is the same way C# node works. We're trusting Extensible senders, improper payloads are harmless until they DoS the network, but we have some protections against that too (and spamming with proper category doesn't differ a lot).	2022-01-14 19:55:50 +03:00
Roman Khimov	0ad3ea5944	network/cli: move Oracle service instantiation out of the network	2022-01-14 19:53:45 +03:00
Roman Khimov	5dd4db2c02	network/services: unify service lifecycle management ... Run with Start, Stop with Shutdown, make behavior uniform.	2022-01-14 19:53:45 +03:00
AnnaShaleva	ce5dfdbe90	nativetest: migrate Notary contract tests to neotest	2022-01-14 17:56:10 +03:00
Anna Shaleva	df6a7d4258	nativetest: migrate Oracle contract tests to neotest	2022-01-14 17:56:10 +03:00
Anna Shaleva	0e1f85b2bf	vm: optimise emit.Array() to use NEWARRAY0 for zero-lenght arrays	2022-01-14 17:56:10 +03:00
Anna Shaleva	2f18b114f2	nativetest: migrate NEO contract tests to neotest	2022-01-14 17:56:10 +03:00
Anna Shaleva	e0ca05f62c	nativetest: migrate Management contract tests to neotest	2022-01-14 17:56:04 +03:00
Anna Shaleva	73ecbb2fb3	rpc: adjust helper contract code ... Compiler forces notification parameters to match the one specified in manifest, and manifest of `test_contract.go` tells that `to` parameter type is hash160: ``` event 'Transfer' should have 'Hash160' as type of 1 parameter, got: ByteArray ```	2022-01-14 16:47:31 +03:00
Anna Shaleva	7927c8d8f5	nativetest: migrate Designation contract tests to neotest	2022-01-14 16:47:31 +03:00
Anna Shaleva	3f1af71f52	nativetest: migrate GAS contract tests to neotest framework	2022-01-14 16:47:31 +03:00
Anna Shaleva	4e7435081f	nativetest: migrate Ledger contract tests to neotest	2022-01-14 16:47:27 +03:00
Anna Shaleva	bbe92c21ea	nativetest: migrate Policy contract tests to neotest	2022-01-14 16:34:33 +03:00
AnnaShaleva	48355ba9bf	vm: allow to emit int[32, 16, 8] and some of uints	2022-01-13 19:12:20 +03:00
Anna Shaleva	6b105e6d10	neotest: use validators account instead of committee to pay the bills ... GAS and NEO tokens are sent to validators account (not the committee's one). For single-node chain they are the same, but for four-nodes chain they are different. Thus, use validators multisig address to create new accounts and to deploy contracts. Also, allow to provide desired account balance while creating new account.	2022-01-13 19:12:20 +03:00
Anna Shaleva	dcb06163da	neotest: improve neotest API ... Added several methods that are useful for testing.	2022-01-13 19:12:20 +03:00
Roman Khimov	5061a813c6	Merge pull request #2324 from carpawell/refactor/use-simple-neofs-client-mode ... Refactor: Upgrade NeoFS dependencies	2022-01-13 19:10:27 +03:00
Roman Khimov	ffe5df066e	Merge pull request #2316 from nspcc-dev/seek-optimisation ... storage: allow to Seek from some point and backwards	2022-01-13 19:07:15 +03:00
Pavel Karpy	a33779c55e	oracle/neofs: Upgrade NeoFS dependencies ... Update includes: 1. New simple client mode that parses erroneous status codes as `error` and returns them from the calls of the client methods. 2. `Client` is struct now, not an interface. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>	2022-01-13 16:34:47 +03:00
Anna Shaleva	2c46b81864	native: optimize gas per vote calculation ... GAS per vote records are being returned from Seek in ascending way, and we need the last record before the specified index which is close to the current chain's height (most of the time). To optimize we can iterate backwards strting from the last record using SeekBackwards. name old time/op new time/op delta NEO_GetGASPerVote/MemPS_10RewardRecords_1RewardDistance-8 27.7µs ± 8% 30.3µs ± 2% +9.36% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_10RewardDistance-8 32.1µs ± 6% 37.4µs ± 5% +16.41% (p=0.000 n=9+10) NEO_GetGASPerVote/MemPS_10RewardRecords_100RewardDistance-8 60.9µs ± 8% 68.1µs ± 9% +11.72% (p=0.001 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_1000RewardDistance-8 384µs ± 9% 437µs ± 2% +13.68% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1RewardDistance-8 227µs ± 5% 255µs ± 6% +12.37% (p=0.000 n=9+9) NEO_GetGASPerVote/MemPS_100RewardRecords_10RewardDistance-8 222µs ± 9% 332µs ±47% +49.64% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_100RewardDistance-8 245µs ± 8% 293µs ±13% +19.64% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_100RewardRecords_1000RewardDistance-8 731µs ±14% 1071µs ±57% +46.58% (p=0.001 n=9+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1RewardDistance-8 7.45ms ±48% 9.83ms ±44% +32.00% (p=0.019 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_10RewardDistance-8 8.54ms ±46% 10.18ms ±46% ~ (p=0.218 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_100RewardDistance-8 7.35ms ±43% 7.72ms ±56% ~ (p=0.579 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1000RewardDistance-8 3.52ms ±32% 3.91ms ±24% ~ (p=0.684 n=10+10) NEO_GetGASPerVote/BoltPS_10RewardRecords_1RewardDistance-8 25.2µs ± 5% 23.8µs ± 4% -5.25% (p=0.016 n=10+8) NEO_GetGASPerVote/BoltPS_10RewardRecords_10RewardDistance-8 29.5µs ± 8% 26.2µs ± 3% -11.13% (p=0.000 n=10+8) NEO_GetGASPerVote/BoltPS_10RewardRecords_100RewardDistance-8 44.9µs ±11% 40.2µs ± 9% -10.50% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_10RewardRecords_1000RewardDistance-8 100µs ± 9% 83µs ±15% -16.75% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_1RewardDistance-8 88.4µs ± 8% 65.8µs ±17% -25.52% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_10RewardDistance-8 88.9µs ± 7% 65.4µs ±20% -26.44% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_100RewardDistance-8 94.4µs ± 9% 63.1µs ±18% -33.15% (p=0.000 n=9+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_1000RewardDistance-8 354µs ±35% 443µs ±49% ~ (p=0.190 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1RewardDistance-8 469µs ±20% 227µs ±21% -51.66% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_10RewardDistance-8 468µs ±17% 267µs ±32% -42.92% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_1000RewardRecords_100RewardDistance-8 480µs ±14% 253µs ±20% -47.25% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1000RewardDistance-8 497µs ±15% 311µs ±37% -37.39% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1RewardDistance-8 27.2µs ± 8% 28.3µs ± 6% ~ (p=0.165 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_10RewardDistance-8 29.3µs ± 4% 30.2µs ± 8% ~ (p=0.089 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_100RewardDistance-8 51.7µs ±10% 54.3µs ±16% ~ (p=0.218 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1000RewardDistance-8 107µs ± 8% 112µs ±15% ~ (p=0.190 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_1RewardDistance-8 103µs ± 3% 97µs ±27% ~ (p=0.633 n=8+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_10RewardDistance-8 98.5µs ±10% 89.2µs ± 9% -9.46% (p=0.004 n=10+9) NEO_GetGASPerVote/LevelPS_100RewardRecords_100RewardDistance-8 100µs ±10% 95µs ±14% ~ (p=0.243 n=9+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_1000RewardDistance-8 222µs ± 7% 135µs ±40% -39.16% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1RewardDistance-8 587µs ± 3% 448µs ±29% -23.58% (p=0.000 n=8+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_10RewardDistance-8 569µs ± 9% 438µs ±24% -22.98% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_100RewardDistance-8 578µs ±17% 436µs ±19% -24.49% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1000RewardDistance-8 683µs ±10% 480µs ±29% -29.76% (p=0.000 n=9+9) name old alloc/op new alloc/op delta NEO_GetGASPerVote/MemPS_10RewardRecords_1RewardDistance-8 5.43kB ± 0% 4.83kB ± 0% -11.06% (p=0.000 n=9+9) NEO_GetGASPerVote/MemPS_10RewardRecords_10RewardDistance-8 5.74kB ± 0% 5.00kB ± 0% -12.91% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_100RewardDistance-8 9.90kB ± 0% 8.49kB ± 0% -14.24% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_1000RewardDistance-8 62.9kB ± 0% 55.6kB ± 0% -11.63% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1RewardDistance-8 37.5kB ± 0% 29.5kB ± 1% -21.31% (p=0.000 n=9+10) NEO_GetGASPerVote/MemPS_100RewardRecords_10RewardDistance-8 37.8kB ± 1% 30.0kB ± 2% -20.71% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_100RewardDistance-8 40.6kB ± 1% 32.0kB ± 1% -21.20% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1000RewardDistance-8 105kB ±13% 81kB ± 9% -22.81% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_1000RewardRecords_1RewardDistance-8 374kB ± 1% 282kB ±24% -24.58% (p=0.000 n=8+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_10RewardDistance-8 376kB ± 9% 280kB ±11% -25.55% (p=0.000 n=8+9) NEO_GetGASPerVote/MemPS_1000RewardRecords_100RewardDistance-8 359kB ± 9% 289kB ±19% -19.60% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1000RewardDistance-8 443kB ± 1% 362kB ± 8% -18.30% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_10RewardRecords_1RewardDistance-8 5.71kB ± 1% 5.17kB ± 1% -9.40% (p=0.000 n=10+7) NEO_GetGASPerVote/BoltPS_10RewardRecords_10RewardDistance-8 6.04kB ± 1% 5.40kB ± 1% -10.61% (p=0.000 n=10+8) NEO_GetGASPerVote/BoltPS_10RewardRecords_100RewardDistance-8 9.59kB ± 4% 8.19kB ± 1% -14.60% (p=0.000 n=10+8) NEO_GetGASPerVote/BoltPS_10RewardRecords_1000RewardDistance-8 41.6kB ± 2% 33.7kB ± 8% -18.98% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_1RewardDistance-8 29.2kB ± 2% 20.2kB ± 7% -30.94% (p=0.000 n=9+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_10RewardDistance-8 29.6kB ± 4% 20.3kB ± 8% -31.58% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_100RewardDistance-8 32.4kB ± 4% 21.7kB ± 5% -33.25% (p=0.000 n=9+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_1000RewardDistance-8 98.8kB ±17% 109.8kB ±41% ~ (p=0.353 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1RewardDistance-8 220kB ± 2% 129kB ± 3% -41.40% (p=0.000 n=9+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_10RewardDistance-8 219kB ± 4% 135kB ± 7% -38.52% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_100RewardDistance-8 223kB ± 5% 132kB ± 6% -40.69% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1000RewardDistance-8 263kB ± 5% 155kB ± 8% -41.23% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1RewardDistance-8 6.19kB ± 1% 5.94kB ± 1% -4.15% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_10RewardRecords_10RewardDistance-8 6.51kB ± 0% 6.10kB ± 2% -6.27% (p=0.000 n=8+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_100RewardDistance-8 10.1kB ± 2% 9.7kB ± 3% -4.45% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1000RewardDistance-8 35.4kB ± 1% 33.6kB ± 3% -5.13% (p=0.000 n=9+9) NEO_GetGASPerVote/LevelPS_100RewardRecords_1RewardDistance-8 28.1kB ± 3% 22.6kB ±10% -19.58% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_10RewardDistance-8 28.0kB ± 3% 23.7kB ± 9% -15.54% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_100RewardDistance-8 29.5kB ± 3% 24.8kB ±10% -16.08% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_1000RewardDistance-8 53.7kB ± 4% 44.6kB ± 5% -16.83% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1RewardDistance-8 207kB ± 2% 148kB ± 3% -28.58% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_10RewardDistance-8 206kB ± 2% 148kB ± 4% -28.20% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_100RewardDistance-8 208kB ± 1% 149kB ± 3% -28.07% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1000RewardDistance-8 234kB ± 2% 171kB ± 5% -26.71% (p=0.000 n=10+10) name old allocs/op new allocs/op delta NEO_GetGASPerVote/MemPS_10RewardRecords_1RewardDistance-8 129 ± 1% 95 ± 1% -26.33% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_10RewardRecords_10RewardDistance-8 139 ± 1% 100 ± 1% -27.85% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_100RewardDistance-8 225 ± 1% 155 ± 1% -31.11% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_10RewardRecords_1000RewardDistance-8 1.22k ± 3% 0.86k ± 1% -29.14% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1RewardDistance-8 863 ± 2% 468 ± 4% -45.72% (p=0.000 n=9+9) NEO_GetGASPerVote/MemPS_100RewardRecords_10RewardDistance-8 872 ± 2% 490 ± 7% -43.89% (p=0.000 n=8+10) NEO_GetGASPerVote/MemPS_100RewardRecords_100RewardDistance-8 973 ± 1% 550 ± 5% -43.44% (p=0.000 n=9+10) NEO_GetGASPerVote/MemPS_100RewardRecords_1000RewardDistance-8 2.11k ± 1% 1.37k ± 2% -35.11% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1RewardDistance-8 9.00k ± 1% 5.05k ± 1% -43.94% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_10RewardDistance-8 9.04k ± 1% 5.06k ± 1% -43.97% (p=0.000 n=10+9) NEO_GetGASPerVote/MemPS_1000RewardRecords_100RewardDistance-8 9.15k ± 1% 5.10k ± 2% -44.24% (p=0.000 n=10+10) NEO_GetGASPerVote/MemPS_1000RewardRecords_1000RewardDistance-8 10.2k ± 0% 5.8k ± 1% -42.60% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_10RewardRecords_1RewardDistance-8 136 ± 1% 103 ± 0% -24.15% (p=0.000 n=10+7) NEO_GetGASPerVote/BoltPS_10RewardRecords_10RewardDistance-8 146 ± 0% 107 ± 0% -26.71% (p=0.000 n=9+6) NEO_GetGASPerVote/BoltPS_10RewardRecords_100RewardDistance-8 232 ± 1% 164 ± 0% -29.46% (p=0.000 n=10+7) NEO_GetGASPerVote/BoltPS_10RewardRecords_1000RewardDistance-8 1.21k ± 1% 0.82k ± 1% -31.99% (p=0.000 n=10+8) NEO_GetGASPerVote/BoltPS_100RewardRecords_1RewardDistance-8 876 ± 0% 474 ± 0% -45.85% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_10RewardDistance-8 888 ± 0% 481 ± 0% -45.82% (p=0.000 n=9+10) NEO_GetGASPerVote/BoltPS_100RewardRecords_100RewardDistance-8 990 ± 1% 550 ± 0% -44.49% (p=0.000 n=10+9) NEO_GetGASPerVote/BoltPS_100RewardRecords_1000RewardDistance-8 2.29k ± 8% 1.70k ±19% -25.86% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1RewardDistance-8 8.18k ± 1% 4.15k ± 2% -49.33% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_10RewardDistance-8 8.19k ± 1% 4.14k ± 0% -49.41% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_100RewardDistance-8 8.29k ± 1% 4.21k ± 2% -49.20% (p=0.000 n=10+10) NEO_GetGASPerVote/BoltPS_1000RewardRecords_1000RewardDistance-8 9.31k ± 1% 4.84k ± 1% -48.05% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1RewardDistance-8 144 ± 1% 112 ± 3% -22.09% (p=0.000 n=8+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_10RewardDistance-8 153 ± 2% 116 ± 3% -23.66% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_100RewardDistance-8 236 ± 1% 172 ± 4% -27.33% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_10RewardRecords_1000RewardDistance-8 1.16k ± 0% 0.81k ± 1% -30.00% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_1RewardDistance-8 859 ± 1% 481 ± 2% -44.07% (p=0.000 n=9+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_10RewardDistance-8 872 ± 1% 478 ± 2% -45.14% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_100RewardRecords_100RewardDistance-8 968 ± 1% 550 ± 2% -43.21% (p=0.000 n=10+8) NEO_GetGASPerVote/LevelPS_100RewardRecords_1000RewardDistance-8 1.89k ± 1% 1.19k ± 1% -37.21% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1RewardDistance-8 8.14k ± 0% 4.22k ± 0% -48.10% (p=0.000 n=10+9) NEO_GetGASPerVote/LevelPS_1000RewardRecords_10RewardDistance-8 8.17k ± 0% 4.21k ± 1% -48.43% (p=0.000 n=10+10) NEO_GetGASPerVote/LevelPS_1000RewardRecords_100RewardDistance-8 8.23k ± 0% 4.28k ± 0% -48.00% (p=0.000 n=10+8) NEO_GetGASPerVote/LevelPS_1000RewardRecords_1000RewardDistance-8 9.14k ± 0% 4.90k ± 1% -46.45% (p=0.000 n=10+10)	2022-01-13 13:47:05 +03:00
Anna Shaleva	04a8e6666f	storage: allow to seek backwards	2022-01-13 12:44:29 +03:00
AnnaShaleva	6bc92abe19	storage: allow to seek starting from some point	2022-01-13 12:44:29 +03:00
Anna Shaleva	7d5b20d8dd	core: fix comments formatting	2022-01-13 12:44:29 +03:00
Anna Shaleva	5770a581c3	store: improve Seek tests ... After #2193 Seek results are sorted in an ascending way, so technically the test was needed to be fixed along with these changes.	2022-01-13 12:44:29 +03:00
Anna Shaleva	9879514412	core: add benchmark for (*NEO).getGASPerVote	2022-01-13 12:44:19 +03:00
Roman Khimov	c942402957	blockchainer: drop Policer interface ... We never use it as a proper interface, so it makes no sense keeping it this way.	2022-01-12 00:58:03 +03:00
Evgeniy Stratonikov	ffb6504f67	vm: cut trailing spaces in PrintOps ... When there is a single big instruction (like PUSHDATA4) in script, all other instructions are padded to the right with spaces. This makes it hard to view script in terminal, because long lines are usually wrapped at the screen boundary and printed as multiple lines. The culprit is our `cursor` field which is printed in the last column and causes all previous fields to have the same length for every instruction. One way to fix this is to omit cursor field if it is empty. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-12-28 11:27:31 +03:00
AnnaShaleva	8c6de35ec2	core: fix GAS distribution to primary node when notary enabled ... Close #2310.	2021-12-14 12:18:47 +03:00
Roman Khimov	b43335e591	Merge pull request #2306 from nspcc-dev/call-tokens ... compiler: use CALLT for native contract calls, fix #2257	2021-12-10 13:05:55 +03:00
Roman Khimov	299a7ea614	compiler: use CALLT for native contract calls, fix #2257	2021-12-10 11:58:50 +03:00
Roman Khimov	e6f64b7e3d	Merge pull request #2298 from nspcc-dev/test-signer ... Improve signers handling in test framework	2021-12-10 11:25:01 +03:00
Evgeniy Stratonikov	4ab97094c2	neotest: provide full account list for committee ... Make the behaviour of `committee.Single(n)` more predictable, i.e be able to return every committee member. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-12-09 21:59:02 +03:00
Evgeniy Stratonikov	8886fa8ca9	neotest: simplify committee account construction ... Simple `sort.Slice` is more readable than multi-level for-loop. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-12-09 21:59:02 +03:00
Evgeniy Stratonikov	37ecf51d13	neotest: allow to extract simple signers from multi-signer ... There is a quirk related to ordering: we store accounts in such an order that is expected by multi-signature verification script. This was done to speed up transaction/block signing which is done quite frequently in tests. This commit allows to provide accounts in any order and to extract a single signer from multi-signer based on this order. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-12-09 21:59:02 +03:00
Evgeniy Stratonikov	d4689db47e	neotest: allow to extract account from single signer ... Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>	2021-12-09 21:59:02 +03:00
Roman Khimov	4c39b6600d	*: store application long along with tx/block ... Two times less keys inserted into the DB per tx leads to ~13% TPS improvement. We also drop one goroutine with it which isn't bad as well.	2021-12-09 15:39:26 +03:00
Roman Khimov	f87c595d94	core: fix TestRestoreAfterDeploy ... A bit longer script easily solves the size problem.	2021-12-08 12:05:31 +03:00