Denis Kirillov dkirillov
  • Joined on 2023-03-06
dkirillov pushed to featue/553-dont_use_basic_acl at dkirillov/frostfs-s3-gw 2024-11-18 12:32:20 +00:00
4253fc5b90 [#553] authmate: Don't use basic acl
368c7d2acd [#549] Add tracing attributes
31076796ce [#550] Execute CI on push to master
Compare 3 commits »
dkirillov created pull request TrueCloudLab/frostfs-s3-gw#554 2024-11-18 12:31:45 +00:00
WIP: [#553] authmate: Don't use basic acl
dkirillov pushed to featue/553-dont_use_basic_acl at dkirillov/frostfs-s3-gw 2024-11-18 12:31:23 +00:00
a45bbe9c14 [#553] authmate: Don't use basic acl
eff0de43d5 [#538] Return headers with 304 Not Modified
fb00dff83b [#540] Add md5 S3Tests compatability
d8f126b339 [#539] Fix listing v1 bookmark marker
7ab902d8d2 [#536] Add rule ID generation
Compare 9 commits »
dkirillov created branch featue/553-dont_use_basic_acl in dkirillov/frostfs-s3-gw 2024-11-18 12:31:22 +00:00
dkirillov opened issue TrueCloudLab/frostfs-s3-gw#553 2024-11-15 12:20:36 +00:00
Don't use basaic acl in authmate
dkirillov pushed to feature/tags at dkirillov/frostfs-s3-gw 2024-11-14 06:51:53 +00:00
93c03a6b26 [#Issue] tmp
dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-13 13:30:18 +00:00
[#469] List multipart uploads streaming

Well, maybe I point to different error. Output sometime doesn't contain NextUploadIDMarker

$ AWS_MAX_ATTEMPTS=1 aws s3api --no-verify-ssl --endpoint http://localhost:8084   list-multipart-upl…
dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#541 2024-11-13 13:14:25 +00:00
[#541] Use default value if config param is unset after SIGHUP

Well, then I suppose keep flags also (env variables not reloadable and new viper instance get them also)

diff --git a/cmd/s3-gw/app_settings.go b/cmd/s3-gw/app_settings.go
index…
dkirillov created branch feature/tags in dkirillov/frostfs-s3-gw 2024-11-13 09:38:51 +00:00
dkirillov pushed to feature/tags at dkirillov/frostfs-s3-gw 2024-11-13 09:38:51 +00:00
a365f7af81 [#Issue] tmp
17d40245de [#505] docs: Add example of uploading file using presigned URL
979d85b046 [#505] authmate: Add flag for headers in generate-presigned-url cmd
539dab8680 [#501] Add the trace id to the logs of middlware
76008d4ba1 [#501] Consider using request logger in logAndSendError
Compare 10 commits »
dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 10:00:08 +00:00
[#469] List multipart uploads streaming

Why do we use only tNode.ID[0]?

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 09:59:45 +00:00
[#469] List multipart uploads streaming

It's better to use more meaningful name.

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 09:56:15 +00:00
[#469] List multipart uploads streaming

Consider using approach like here aaca4f84b8/pkg/service/tree/tree.go (L1114)

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 09:40:51 +00:00
[#469] List multipart uploads streaming

Result must be sorted by upload-id if some uploads have the same key

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 09:27:55 +00:00
[#469] List multipart uploads streaming

Probably we should return error rather than coninue

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 09:20:32 +00:00
[#469] List multipart uploads streaming

It seems here we must use next rather than info.

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 09:00:38 +00:00
[#469] List multipart uploads streaming

If we add new cache we also should be able configure this

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 08:59:34 +00:00
[#469] List multipart uploads streaming

Not only. It also contains Marker for listing v1 and ContinuationToken for listing v2