5163 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Evgenii Stratonikov	53661159da	[#1522] adm: Split NewLocalClient() into functions ... No functional changes. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-25 16:23:37 +03:00
Evgenii Stratonikov	45caab52f1	[#1522] adm/helper: Simplify Client interface ... Just reuse `actor.RPCActor`. No functional changes. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-25 16:23:37 +03:00
Evgenii Stratonikov	5f9bd6420a	[#1522] adm/helper: Remove unused GetCommittee() method from the Client interface ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-25 16:23:37 +03:00
Evgenii Stratonikov	59ee9e8fb8	[#1522] adm: Remove unnecessary variable declaration ... It is better to have small scope. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-25 16:23:37 +03:00
George Bartolomey	0e5524dac7	[#1515] adm: Print address in base58 format in morph ape get-admin ... Signed-off-by: George Bartolomey <george@bh4.ru>	2024-11-25 10:38:05 +00:00
Airat Arifullin	3ebd560f42	[#1519] cli: Make descriptive help for--rule option ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-11-25 07:21:05 +00:00
Airat Arifullin	1ed7ab75fb	[#1517] cli: Print the reason of ape manager error ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-11-22 15:24:32 +03:00
Evgenii Stratonikov	99f9e59de9	[#1514] adm: Remove --alphabet-wallets flag from readonly commands ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-21 14:37:34 +00:00
Evgenii Stratonikov	256f96e252	[#1514] adm/nns: Rename getRPCClient() to nnsWriter() ... Make it more specific and similar to nnsReader(). Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-21 14:37:34 +00:00
Evgenii Stratonikov	e5ea95c045	[#1514] adm/nns: Do not return hash from getRPCClient() ... It was unused and we employ better abstractions now. gopatch: ``` @@ var a, b expression @@ -a, b, _ := getRPCClient(...) +a, b := getRPCClient(...) ``` Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-21 14:37:34 +00:00
Evgenii Stratonikov	9073e555db	[#1514] adm/nns: Do not create actor for readonly commands ... `nns get-records` and `nns tokens` command do not need to sign anything, so remove useless actor and use invoker directly. `NewLocalActor()` is only used in `ape` and `nns` packages. `ape` package seem to use it correctly, only when alphabet wallets are provided, so no changes there. Also, remove --alphabet-wallets flag from commands that do not need it. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-21 14:37:34 +00:00
Evgenii Stratonikov	2771fdb8c7	[#1514] adm/nns: Use nns.GetAllRecords() wrapper ... It was not possible previously, because GetAllRecords() was not declared safe in frostfs-contract. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-21 14:37:34 +00:00
Evgenii Stratonikov	efa4ce00b8	[#1514] go.mod: Update frostfs-contract to v0.21.0-rc.3 ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-21 14:37:34 +00:00
Anton Nikiforov	f12f04199e	[#1516] traverser: Check for placement vector out of range ... Placement vector may contain fewer nodes count than it required by policy due to the outage of the one of the node. Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>	2024-11-21 14:18:55 +03:00
Evgenii Stratonikov	2e2c62147d	[#1513] adm: Move ProtoConfigPath from constants to commonflags package ... Refs #932 Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-21 09:39:06 +03:00
Evgenii Stratonikov	6ae8667fb4	[#1509] .forgejo: Run actions on push to master ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-20 11:42:12 +03:00
Evgenii Stratonikov	49a4e727fd	[#1507] timer/test: Use const for constants ... Make it easy to see what the test is about. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-20 08:36:25 +00:00
Evgenii Stratonikov	2e974f734c	[#1507] timer/test: Improve test coverage ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-20 08:36:25 +00:00
Evgenii Stratonikov	3042490340	[#1507] timer: Remove unused OnDelta() method ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-20 08:36:25 +00:00
Airat Arifullin	a339b52a60	[#1501] adm: Refactor APE-chains managing subcommands ... * Use `cmd/internal/common/ape` parser commands within `ape` subcommands * Use flag names from `cmd/internal/common/ape Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-11-20 07:58:32 +00:00
Airat Arifullin	4ab4ed6f96	[#1501] cli: Refactor bearer subcommand ... * Use `cmd/internal/common/ape` parser commands within `generate-ape-override` subcommand * Use flag names from `cmd/internal/common/ape` Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-11-20 07:58:32 +00:00
Airat Arifullin	3b1364e4cf	[#1501] cli: Refactor ape-manager subcommands ... * Refactor ape-manager subcommands * Use `cmd/internal/common/ape` parser commands within ape-manager subcommands * Use flag names from `cmd/internal/common/ape` Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-11-20 07:58:32 +00:00
Airat Arifullin	daff77b273	[#1501] cli: Refactor local override managing subcommands ... * Refactor local override managing subcommands * Use `cmd/internal/common/ape` parser commands within local override subcommands * Use flag names from `cmd/internal/common/ape` Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-11-20 07:58:32 +00:00
Airat Arifullin	7a7ee71a4d	[#1501] cmd: Introduce common APE-chain parser commands ... * Introduce common parsing commands to use them in `frostfs-cli` and `frostfs-adm` APE-related subcommands * Introduce common flags for these parsing commands Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-11-20 07:58:32 +00:00
Airat Arifullin	ffe9906266	[#1501] cli: Move APE-chain parser methods to pkg/util ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-11-20 07:58:32 +00:00
Airat Arifullin	ae31ef3602	[#1501] cli: Move PrintHumanReadableAPEChain to a common package ... * Both `frostfs-cli` and `frostfs-adm` APE-related subcommands use `PrintHumanReadableAPEChain` to print a parsed APE-chain. So, it's more correct to have it in a common package over `frostfs-cli` and `frostfs-adm` folders. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-11-20 07:58:32 +00:00
Airat Arifullin	e2cb0640f1	[#1501] util: Move eACL-to-APE converter to pkg/util ... * `ConvertEACLToAPE` is useful method which couldn't be imported out of frostfs-node so far as it has been in `internal` * Since `ConvertEACLToAPE` and related structures and unit-tests are placed in `pkg/util` Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-11-20 07:58:32 +00:00
Evgenii Stratonikov	9f4ce600ac	[#1505] adm: Allow to manage additional keys in frostfsid ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-19 16:25:16 +03:00
Evgenii Stratonikov	d82f0d1926	[#1496] node/control: Await until SetNetmapStatus() persists ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-15 16:36:07 +03:00
Evgenii Stratonikov	acd5babd86	[#1496] morph: Merge InvokeRes and WaitParams ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-15 16:36:07 +03:00
Evgenii Stratonikov	b65874d1c3	[#1496] morph: Return InvokeRes from all invoke*() methods ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-15 16:36:07 +03:00
Evgenii Stratonikov	69c63006da	[#1496] morph: Move tx waiter to morph package ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-15 16:36:07 +03:00
Evgenii Stratonikov	d77a218f7c	[#1493] metabase: Merge Inhume() and DropGraves() for tombstones ... DropGraves() is only used to drop gravemarks after a tombstone removal. Thus, it makes sense to do Inhume() and DropGraves() in one transaction. It has less overhead and no unexpected problems in case of sudden power failure. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-14 06:47:04 +00:00
Evgenii Stratonikov	44df67492f	[#1493] metabase: Split inhumeTx() into 2 functions ... No functional changes. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-14 06:47:04 +00:00
Evgenii Stratonikov	1e6f132b4e	[#1493] metabase: Pass InhumePrm by value ... Unify with the other code, no functional changes. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-14 06:47:04 +00:00
Evgenii Stratonikov	6dc0dc6691	[#1493] shard: Take mode mutex in HandleExpiredTombstones() ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-14 06:47:04 +00:00
Alexander Chuprov	f7cb6b4d87	[#1482] Makefile: Update golangci-lint ... Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>	2024-11-13 15:01:41 +00:00
Aleksey Savchuk	7fc6101bec	[#1491] engine/test: Rework engine test utils ... - Remove `testNewShard` and `setInitializedShards` because they violated the default engine workflow. The correct workflow is: first use `New()`, followed by `Open()`, and then `Init()`. As a result, adding new logic to `(*StorageEngine).Init` caused several tests to fail with a panic when attempting to access uninitialized resources. Now, all engines created with the test utils must be initialized manually. The new helper method `prepare` can be used for that purpose. - Additionally, `setInitializedShards` hardcoded the shard worker pool size, which prevented it from being configured in tests and benchmarks. This has been fixed as well. - Ensure engine initialization is done wherever it was missing. - Refactor `setShardsNumOpts`, `setShardsNumAdditionalOpts`, and `setShardsNum`. Make them all depend on `setShardsNumOpts`. Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-11-13 14:42:53 +03:00
Aleksey Savchuk	7ef36749d0	[#1491] engine/test: Move BenchmarkExists to exists_test.go ... Move `BenchmarkExists` from `engine_test.go` to `exists_test.go` for better organization and clarity. Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-11-13 14:09:29 +03:00
Aleksey Savchuk	c6066d6ee4	[#1491] engine/test: Use more suitable testing utils here and there ... Use `setShardsNum` instead of `setInitializedShards` wherever possible. Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-11-13 14:09:29 +03:00
Dmitrii Stepanov	612b34d570	[#1437] logger: Add caller skip to log original caller position ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-13 10:36:12 +03:00
Dmitrii Stepanov	7429553266	[#1437] node: Fix contextcheck linter ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-13 10:36:10 +03:00
Dmitrii Stepanov	6921a89061	[#1437] ir: Fix contextcheck linters ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-13 10:36:10 +03:00
Dmitrii Stepanov	16598553d9	[#1437] shard: Fix contextcheck linter ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-13 10:36:09 +03:00
Dmitrii Stepanov	c139892117	[#1437] ir: Fix contextcheck linter ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-13 10:36:09 +03:00
Dmitrii Stepanov	62b5181618	[#1437] blobovnicza: Fix contextcheck linter ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-13 10:36:08 +03:00
Dmitrii Stepanov	6db46257c0	[#1437] node: Use ctx for logging ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-13 10:36:07 +03:00
Dmitrii Stepanov	c16dae8b4d	[#1437] logger: Use context to log trace id ... Signed-off-by: Dmitrii Stepanov	2024-11-13 10:36:07 +03:00
Evgenii Stratonikov	fd004add00	[#1492] metabase: Fix import formatting ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-13 07:30:25 +00:00
Evgenii Stratonikov	8ed7a676d5	[#1492] metabase: Ensure Unmarshal() is called on a cloned slice ... The slice returned from bucket.Get() is only valid during the tx lifetime. Cloning it is not necessary everywhere, but better safe than sorry. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-13 07:30:25 +00:00