397 commits

Author	SHA1	Message	Date
Evgenii Stratonikov	58668e6bc3	storage: Remove "could not/can't/failed to" from error messages ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-12-18 09:38:14 +03:00
Aleksey Savchuk	f0c43c8d80	[#1502] Use zap.Error for logging errors ... Use `zap.Error` instead of `zap.String` for logging errors: change all expressions like `zap.String("error", err.Error())` or `zap.String("err", err.Error())` to `zap.Error(err)`. Leave similar expressions with other messages unchanged, for example, `zap.String("last_error", lastErr.Error())` or `zap.String("reason", ctx.Err().Error())`. This change was made by applying the following patch: ```diff @@ var err expression @@ -zap.String("error", err.Error()) +zap.Error(err) @@ var err expression @@ -zap.String("err", err.Error()) +zap.Error(err) ``` Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-12-16 11:13:42 +03:00
Aleksey Savchuk	3821645085	[#1555] engine: Refactor (*StorageEngine).GetLocks ... Refactored after renaming the method to replace the confusing `locked` variable with `locks`. Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-12-11 15:06:38 +03:00
Aleksey Savchuk	72470d6b48	[#1555] local_object_storage: Rename method GetLocked -> GetLocks ... Renamed to better reflect the method's purpose of returning locks for the specified object. Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-12-11 15:06:37 +03:00
Dmitrii Stepanov	1f6cf57e30	[#1548] metabase: Check if EC parent is removed or expired ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-12-11 07:26:33 +00:00
Dmitrii Stepanov	386a12eea4	[#1548] engine: Rename parent -> ecParent ... Parent could mean split parent or EC parent. In this case it is EC parent only. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-12-11 07:26:33 +00:00
Dmitrii Stepanov	41da27dad5	[#1549] engine: Drop Async flag from evacuation parameters ... Now it is only async evacuation. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-12-10 17:00:00 +03:00
Aleksey Savchuk	281d65435e	[#1450] engine: Group object by shard before Inhume ... ``` goos: linux goarch: amd64 pkg: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/engine cpu: 12th Gen Intel(R) Core(TM) i5-1235U │ old.txt │ new.txt │ │ sec/op │ sec/op vs base │ InhumeMultipart/objects=1-12 11.42m ± 1% 10.71m ± 0% -6.27% (p=0.000 n=10) InhumeMultipart/objects=10-12 113.5m ± 0% 100.9m ± 3% -11.08% (p=0.000 n=10) InhumeMultipart/objects=100-12 1135.4m ± 1% 681.3m ± 2% -40.00% (p=0.000 n=10) InhumeMultipart/objects=1000-12 11.358 ± 0% 1.089 ± 1% -90.41% (p=0.000 n=10) InhumeMultipart/objects=10000-12 113.251 ± 0% 1.645 ± 1% -98.55% (p=0.000 n=10) geomean 1.136 265.5m -76.63% ``` Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-12-04 10:09:00 +03:00
Aleksey Savchuk	b348b20289	[#1450] engine: Add benchmark for Inhume operation ... Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-12-04 10:08:34 +03:00
Aleksey Savchuk	748edd1999	[#1450] engine: Return shard-level error if object is expired on inhume ... Since we have errors defined on the shard-level, it looks strage that we check an error againt the shard-level error `ErrLockObjectRemoval`, but then return the metabase-level error. Let's return the same shard-level error instead. Since we have errors defined on the shard-level Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-12-04 10:06:57 +03:00
Aleksey Savchuk	432042c534	[#1527] engine: Add tests for handling expired objects on inhume and lock ... Currently, it's allowed to inhume or lock an expired object. Consider the following scenario: 1) An user inhumes or locks an object 2) The object expires 3) GC hasn't yet deleted the object 4) The node loses the associated tombstone or lock 5) Another node replicates tombstone or lock to the first node In this case, the second node succeeds, which is the desired behavior. Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-12-03 12:29:45 +03:00
Aleksey Savchuk	9cabca9dfe	[#1527] engine/test: Move default metabase options to separate function ... Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-12-02 16:13:37 +03:00
Aleksey Savchuk	60feed3b5f	[#1527] engine/test: Allow to specify current epoch in epochState ... Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-12-02 15:37:25 +03:00
Aleksey Savchuk	7fc6101bec	[#1491] engine/test: Rework engine test utils ... - Remove `testNewShard` and `setInitializedShards` because they violated the default engine workflow. The correct workflow is: first use `New()`, followed by `Open()`, and then `Init()`. As a result, adding new logic to `(*StorageEngine).Init` caused several tests to fail with a panic when attempting to access uninitialized resources. Now, all engines created with the test utils must be initialized manually. The new helper method `prepare` can be used for that purpose. - Additionally, `setInitializedShards` hardcoded the shard worker pool size, which prevented it from being configured in tests and benchmarks. This has been fixed as well. - Ensure engine initialization is done wherever it was missing. - Refactor `setShardsNumOpts`, `setShardsNumAdditionalOpts`, and `setShardsNum`. Make them all depend on `setShardsNumOpts`. Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-11-13 14:42:53 +03:00
Aleksey Savchuk	7ef36749d0	[#1491] engine/test: Move BenchmarkExists to exists_test.go ... Move `BenchmarkExists` from `engine_test.go` to `exists_test.go` for better organization and clarity. Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-11-13 14:09:29 +03:00
Aleksey Savchuk	c6066d6ee4	[#1491] engine/test: Use more suitable testing utils here and there ... Use `setShardsNum` instead of `setInitializedShards` wherever possible. Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-11-13 14:09:29 +03:00
Dmitrii Stepanov	7429553266	[#1437] node: Fix contextcheck linter ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-13 10:36:10 +03:00
Dmitrii Stepanov	16598553d9	[#1437] shard: Fix contextcheck linter ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-13 10:36:09 +03:00
Dmitrii Stepanov	62b5181618	[#1437] blobovnicza: Fix contextcheck linter ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-13 10:36:08 +03:00
Dmitrii Stepanov	6db46257c0	[#1437] node: Use ctx for logging ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-13 10:36:07 +03:00
Dmitrii Stepanov	9bd05e94c8	[#1449] tree: Add ApplyBatch method ... Concurrent Apply can lead to child node applies before parent, so undo/redo operations will perform. This leads to performance degradation in case of tree with many sublevels. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-12 12:11:07 +00:00
Dmitrii Stepanov	8a57c78f5f	[#1484] engine: Fix engine metrics ... 1. Add forgotten metrics for client requests 2. Include execIfNotBlocked into metrics Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-11 12:59:20 +03:00
Airat Arifullin	9b13a18aac	[#1479] go.mod: Bump frostfs-sdk-go version ... * Update version within go.mod; * Fix deprecated frostfs-api-go/v2 package and use frostfs-sdk-go/api instead. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-11-08 10:43:19 +03:00
Evgenii Stratonikov	7ac0852364	[#1459] .golangci.yml: Add intrange linter, fix issues ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-30 15:18:22 +00:00
Alexander Chuprov	d53732f663	[#1431] engine: Delete always false condition ... Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>	2024-10-15 08:53:59 +00:00
Anton Nikiforov	936ebbb8e5	[#1423] metabase: Hide BucketName form upper levels ... Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>	2024-10-08 18:41:16 +03:00
Dmitrii Stepanov	4572fa4874	[#1412] searchSvc: Check container is indexed ... For non S3 containers it is expected to use attributes index for some attributes. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-10-08 11:41:50 +03:00
Dmitrii Stepanov	be744ae3e6	[#1412] metabase: Index attributes for indexed containers ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-10-08 11:41:49 +03:00
Dmitrii Stepanov	1b520f7973	[#1412] engine: Add IsIndexedContainer flag ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-10-08 11:41:49 +03:00
Dmitrii Stepanov	899cd55c27	[#1412] engine: PutPrm refactoring ... Use fields instead of methods. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-10-08 11:41:48 +03:00
Evgenii Stratonikov	4dc9a1b300	[#1413] engine: Remove error counting methods from Shard ... All error counting and hangling logic is present on the engine level. Currently, we pass engine metrics with shard ID metric to shard, then export 3 methods to manipulate these metrics. In this commits all methods are removed and error counter is tracked on the engine level exlusively. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-04 15:10:17 +03:00
Evgenii Stratonikov	963faa615a	[#1413] engine: Cleanup shard error reporting ... - `reportShardErrorBackground()` no longer differs from `reportShardError()`, reflect this in its name; - reuse common pieces of code to make it simpler. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-04 15:10:17 +03:00
Evgenii Stratonikov	9a87acb87a	[#1410] engine: Provide the default implementation to MetricsRegister ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-03 08:23:06 +00:00
Anton Nikiforov	d0ed29b3c7	[#1350] node: Add ability to evacuate objects from REP 1 only ... Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>	2024-09-27 15:41:17 +03:00
Dmitrii Stepanov	63a567a1de	[#1388] engine: Drop unused ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-25 08:55:38 +00:00
Dmitrii Stepanov	76268e3ea2	[#1385] metabase: Validate that tombstone and target have the same container ID ... Target container ID is taken from tombstone: cmd/frostfs-node/object.go:507 Also object of type `TOMBSTONE` contains objectID, so tombstone and tombstoned object must have the same containerID. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-24 17:09:06 +03:00
Anton Nikiforov	34e6a309c6	[#1356] engine: Evacuate object from shards concurrently ... Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>	2024-09-24 12:50:19 +03:00
Dmitrii Stepanov	3b236160a6	[#1367] writecache: Drop DB label from metrics ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-12 15:06:33 +03:00
Dmitrii Stepanov	a61201a987	[#1337] config: Move rebuild_worker_count to shard section ... This makes it simple to limit performance degradation for every shard because of rebuild. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-06 13:57:27 +03:00
Dmitrii Stepanov	6b6eabe41c	[#1337] cli: Add control shards rebuild command ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-06 13:57:27 +03:00
Anton Nikiforov	108e4e07be	[#1349] node: Evacuate objects without setting mode to MAINTENANCE ... Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>	2024-09-05 16:08:27 +03:00
Ekaterina Lebedeva	a685fcdc96	[#1317] go.mod: Use range over int ... Since Go 1.22 a "for" statement with a "range" clause is able to iterate through integer values from zero to an upper limit. gopatch script: @@ var i, e expression @@ -for i := 0; i <= e - 1; i++ { +for i := range e { ... } @@ var i, e expression @@ -for i := 0; i <= e; i++ { +for i := range e + 1 { ... } @@ var i, e expression @@ -for i := 0; i < e; i++ { +for i := range e { ... } Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>	2024-09-03 13:00:54 +03:00
Evgenii Stratonikov	03976c6ed5	[#1341] .golangci.yml: Replace exportloopref with copyloopvar ... exportloopref is deprecated. gopatch: ``` @@ var index, value identifier var slice expression @@ for index, value := range slice { ... -value := value ... } @@ var index, value identifier var slice expression @@ for index, value := range slice { ... -index := index ... } @@ var value identifier var channel expression @@ for value := range channel { ... -value := value ... } ``` Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-08-28 15:44:41 +00:00
Dmitrii Stepanov	93d63e1632	[#1284] writecache: Allow to seal writecache async ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-09 13:23:35 +03:00
Dmitrii Stepanov	36efccd862	[#1298] writecache: Add shrink flag for Seal command ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-08 16:32:29 +03:00
Dmitrii Stepanov	5c01bd5be8	[#1298] writecache: Add restore-mode flag for Seal command ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-07 11:20:14 +03:00
Dmitrii Stepanov	8e51d7849a	[#1295] getSvc: Assemble complex EC object headers without linking object ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-06 16:48:12 +03:00
Dmitrii Stepanov	10602b55b1	[#1295] engine: Resolve funlen linter ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-06 09:45:47 +03:00
Dmitrii Stepanov	eeca796d2e	[#1295] engine: Log object address in case of error ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-06 09:45:43 +03:00
Evgenii Stratonikov	3940bc17c1	[#1251] pilorama: Allow traversing multiple branches in parallel ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-07-17 11:25:07 +03:00