637 commits

Author	SHA1	Message	Date
Airat Arifullin	87ac3c5279	[#1458] object: Make patch not set key before target construction ... * `SignRequestPrivateKey` field should be initialized either within `newUntrustedTarget` or within `newTrustedTarget`. Otherwise, all requests are signed by local node key that makes impossible to perform patch on non-container node. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-10-29 15:20:28 +00:00
Evgenii Stratonikov	b42bcdc6fa	[#1433] services/object: Put object before auxiliary info ... Consider the following operations ordering: 1. Inhume(with tombstone A) --> add tombstone mark for an object 2. --> new epoch arives 3. --> GCMark is added for a tombstone A, because it is unavailable 4. Put(A) --> return error, because the object already has a GCMark It is possible, and I have successfully reproduced it with a test on the shard level. However, the error is related to the specific _ordering_ of operations with engine. And triggering race-conditions like this is only possible on a shard level currently, so no tests are written. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-17 14:43:13 +03:00
Alexander Chuprov	d83879d4b8	[#1431] node: Fix comment format ... Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>	2024-10-15 08:53:59 +00:00
Alexander Chuprov	f6582081a4	[#1431] obj_storage/metabase: Delete unused variable ... Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>	2024-10-15 08:53:59 +00:00
Vitaliy Potyarkin	714ff784fa	[#1431] objsvc: Use specific values in message about address mismatch ... This makes troubleshooting failed operations much easier Signed-off-by: Vitaliy Potyarkin <v.potyarkin@yadro.com>	2024-10-15 07:34:03 +00:00
Anton Nikiforov	acd6eb1815	[#1427] object: Fix Put for EC object when node unavailable ... There might be situation when context canceled earlier than traverser move to another part of the nodes. To avoid this, need to wait for the result from concurrent put at each traverser iteration. Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>	2024-10-11 16:53:30 +03:00
Dmitrii Stepanov	4572fa4874	[#1412] searchSvc: Check container is indexed ... For non S3 containers it is expected to use attributes index for some attributes. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-10-08 11:41:50 +03:00
Dmitrii Stepanov	1b520f7973	[#1412] engine: Add IsIndexedContainer flag ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-10-08 11:41:49 +03:00
Airat Arifullin	5f22ba6f38	[#1397] object: Correctly set namespace before APE check ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-09-27 11:43:29 +00:00
Dmitrii Stepanov	a5e1aa22c9	[#1394] putSvc: Fix relay ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-25 17:28:03 +03:00
Dmitrii Stepanov	4fbfffd44c	[#1388] putSvc: Drop unused ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-25 08:55:38 +00:00
Dmitrii Stepanov	d1d6e3471c	[#1388] signSvc: Drop unused ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-25 08:55:38 +00:00
Dmitrii Stepanov	580cd55180	[#1388] getSvc: Drop unused ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-25 08:55:38 +00:00
Dmitrii Stepanov	e319bf403e	[#1388] apeSvc: Drop unused and make annotations ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-25 08:55:38 +00:00
Dmitrii Stepanov	839dead226	[#1297] getSvc: Return AccessDenied instead of ObjectNotFound ... Do not replace the access denied error if it was received earlier. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-24 12:05:09 +03:00
Airat Arifullin	3bb65ba820	[#1392] object: Fix target initialization within put streamer ... * Remove `relay` field from put streamer as it's no longer used; * Fix initialization of `Relay` object writer parameter. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-09-24 09:04:13 +00:00
Dmitrii Stepanov	d4493a6d08	[#1390] getSvc: Fix Head EC1.1 ... If local EC chunk found, but remote node is off, then `HEAD --raw` request returns object not found. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-23 15:12:06 +03:00
Airat Arifullin	61d5e140e0	[#1383] object: Add restrictions for Patch method ... * `Patch` can't be applied for non-regular type object (tombstones, locks etc.) * Complex object parts can't be patched. So, if an object has EC/Split header, it won't be patched. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-09-19 13:54:49 +03:00
Airat Arifullin	a812932984	[#1362] ape: Move common APE check logic to separate package ... * Tree and object service have the same log for checking APE. So, this check should be moved to common package. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-09-10 12:40:34 +00:00
Airat Arifullin	273980cfb9	[#1310] object: Remove irrelevant comments ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-09-05 16:40:32 +03:00
Airat Arifullin	b3deb893ba	[#1310] object: Move target initialization to separate package ... * Split the logic of write target initialization to different packages; * Refactor patch and put services: since both service initialize the target themselves. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-09-05 13:03:58 +00:00
Ekaterina Lebedeva	a685fcdc96	[#1317] go.mod: Use range over int ... Since Go 1.22 a "for" statement with a "range" clause is able to iterate through integer values from zero to an upper limit. gopatch script: @@ var i, e expression @@ -for i := 0; i <= e - 1; i++ { +for i := range e { ... } @@ var i, e expression @@ -for i := 0; i <= e; i++ { +for i := range e + 1 { ... } @@ var i, e expression @@ -for i := 0; i < e; i++ { +for i := range e { ... } Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>	2024-09-03 13:00:54 +03:00
Evgenii Stratonikov	03976c6ed5	[#1341] .golangci.yml: Replace exportloopref with copyloopvar ... exportloopref is deprecated. gopatch: ``` @@ var index, value identifier var slice expression @@ for index, value := range slice { ... -value := value ... } @@ var index, value identifier var slice expression @@ for index, value := range slice { ... -index := index ... } @@ var value identifier var channel expression @@ for value := range channel { ... -value := value ... } ``` Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-08-28 15:44:41 +00:00
Dmitrii Stepanov	7abbdca064	[#1340] getSvc: Fix access denied error handling ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-28 14:02:28 +03:00
Airat Arifullin	6488ddee88	[#1338] object: Fix range provider in Patch handler ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-08-27 16:51:12 +03:00
Airat Arifullin	d6b42972a8	[#1338] object: Fix audit patch stream ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-08-27 16:18:29 +03:00
Dmitrii Stepanov	bd24beecf8	[#1329] putSvc: Reset SuccessAfter for non-EC objects in EC container broadcasting ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-23 13:51:16 +03:00
Anton Nikiforov	8319b59238	[#1318] Fix gofumpt issue ... Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>	2024-08-20 14:34:54 +03:00
Airat Arifullin	eeab417dcf	[#1307] object: Add APE check for Patch handler ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-08-16 14:13:09 +00:00
Airat Arifullin	e890f1b4b1	[#1307] object: Implement Patch method ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-08-16 14:13:09 +00:00
Airat Arifullin	a4a1c3f18b	[#1307] go.mod: Bump frostfs-sdk-go/frostfs-api-go/v2 versions ... * Also, resolve dependencies and conflicts for object service by creating stub for `Patch` method. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-08-16 14:13:09 +00:00
Dmitrii Stepanov	c985b1198f	[#1302] putSvc: Override SuccessAfter for non-regular objects in EC containers ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-09 10:42:55 +03:00
Dmitrii Stepanov	8e51d7849a	[#1295] getSvc: Assemble complex EC object headers without linking object ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-06 16:48:12 +03:00
Dmitrii Stepanov	8021bacc43	[#1288] putSvc: Respect TTL for EC put ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-02 13:01:42 +00:00
Dmitrii Stepanov	7fd7961dfa	[#1271] getSvc: Fix local EC chunk get ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-07-24 08:52:16 +03:00
Dmitrii Stepanov	8398a8b4b3	[#1271] getSvc: Fix head --raw assemble for EC ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-07-24 08:52:08 +03:00
Airat Arifullin	eadcea8df0	[#1249] object: Remove all APE pre-checks in handlers ... * Methods `Head`, `Get`, `GetRangeHash` should no longer use APE pre-checks as that leads only to incorrect rule chain processing for requests: 1. Immediate return with `NoRuleFound` may be unexpected as some `Allow` rule is actually defined but can't be matched yet as it gets no object attributes; 2. Immdediate return with `Allow` may be incorrect as some `Deny` rule is actually defined but can't bet matched yet as it gets no object attirbutes; 3. Pre-check breaks compatibility for converted EACL-tables. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-07-18 13:52:43 +00:00
Dmitrii Stepanov	e83d39e33f	[#1253] deleteSvc: Use copy of common parameters ... getSvc may change the values of some fields, so Head will affect Delete or Put. In this case, the change is necessary so that the session token is stored in the tombstone object (EC assemble calls `ForgetTokens`). Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-07-17 14:24:27 +03:00
Dmitrii Stepanov	fc383ea6ae	[#1253] getSvc: Fix EC objects get ... Now EC objects assembling is performed concurrently. Also fixed issue with an error in case of getting EC object via non-container node. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-07-17 14:24:27 +03:00
Airat Arifullin	d5dc14c639	[#1243] object: Make APE checker set x-headers to request properties ... * Update go.mod, go.sum; * Add x-headers to request properties; * Add a unit-test. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-07-16 07:28:42 +00:00
Dmitrii Stepanov	84ecd61dfd	[#1233] putSvc: Try to put EC chunk to any node ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-07-09 07:54:29 +00:00
Airat Arifullin	d90aab5454	[#1229] util: Fix session token expiration check ... * Make session token expired at `current_epoch + 1` but not at `current_epoch` when it's still valid. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-07-08 08:15:56 +00:00
Airat Arifullin	0c2b6f3dac	[#1216] ape: Make services use bearer chains fed router ... * Refactor object and tree service - they should instantiate chain router cheking the bearer token. If there are no bearer token rules, then defaul chain router is used. * Fix unit-tests. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-07-05 18:26:48 +00:00
Airat Arifullin	f3a861806e	[#1218] object: Fix bearer token validation ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-07-03 07:22:11 +00:00
Airat Arifullin	a378ff9cf6	[#1218] object: Pass container owner for backward get method check ... * `getStreamBasicChecker` must define `containerOwner` for backward checks, otherwise bearer token cannot be validated for the token issuer. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-07-03 07:22:11 +00:00
Dmitrii Stepanov	dc2867682f	[#1213] deleteSvc: Do not allow to delete EC chunks ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-07-01 06:49:35 +00:00
Airat Arifullin	0b87388c18	[#1190] object: GroupIDs must also be target of APE checks ... * Also add new test case for ape middleware in container service. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-06-25 08:49:20 +00:00
Dmitrii Stepanov	ecd1ed7a5e	[#1184] node: Add audit middleware for grpc services ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-06-19 16:05:53 +03:00
Airat Arifullin	04a3f891fd	[#1157] object: Make APE checker use Bearer-token's APE overrides ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-06-07 12:11:11 +00:00
Anton Nikiforov	c1af13b47e	[#1147] node: Fix issue from gopls ... Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>	2024-05-30 08:13:04 +00:00