654 commits

Author	SHA1	Message	Date
Aleksey Savchuk	17d2dc5341	[#1445] local_object_storage: Append expiration epoch to tombstones ... Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-12-16 16:31:28 +03:00
Aleksey Savchuk	f0c43c8d80	[#1502] Use zap.Error for logging errors ... Use `zap.Error` instead of `zap.String` for logging errors: change all expressions like `zap.String("error", err.Error())` or `zap.String("err", err.Error())` to `zap.Error(err)`. Leave similar expressions with other messages unchanged, for example, `zap.String("last_error", lastErr.Error())` or `zap.String("reason", ctx.Err().Error())`. This change was made by applying the following patch: ```diff @@ var err expression @@ -zap.String("error", err.Error()) +zap.Error(err) @@ var err expression @@ -zap.String("err", err.Error()) +zap.Error(err) ``` Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>	2024-12-16 11:13:42 +03:00
Dmitrii Stepanov	7df3520d48	[#1540] getSvc: Drop redundant returns ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-12-05 12:39:49 +00:00
Dmitrii Stepanov	5fe78e51d1	[#1540] getSvc: Do not log context canceled errors during EC assemble ... Those errors are fired when it is enough chunks retrieved and error group cancels other requests. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-12-05 12:39:49 +00:00
Dmitrii Stepanov	7429553266	[#1437] node: Fix contextcheck linter ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-13 10:36:10 +03:00
Dmitrii Stepanov	6db46257c0	[#1437] node: Use ctx for logging ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-13 10:36:07 +03:00
Evgenii Stratonikov	c82c753e9f	[#1480] objsvc: Remove useless stream wrappers ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-08 12:01:14 +00:00
Evgenii Stratonikov	f666898e5d	[#1480] objsvc: Remove EACL checks ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-08 12:01:14 +00:00
Evgenii Stratonikov	b1a31281e4	[#1480] ape: Remove SoftAPECheck flag ... Previous release was EACL-compatible. Starting from now all EACL should've been migrated to APE chains. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-11-08 12:01:14 +00:00
Airat Arifullin	9b13a18aac	[#1479] go.mod: Bump frostfs-sdk-go version ... * Update version within go.mod; * Fix deprecated frostfs-api-go/v2 package and use frostfs-sdk-go/api instead. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-11-08 10:43:19 +03:00
Dmitrii Stepanov	ef64930fef	[#1477] ape: Fix EC chunk test ... Initially, this test was a check that only the container node can assemble an EC object. But the implementation of this test was wrong. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-07 16:00:20 +03:00
Dmitrii Stepanov	3cf6ea745d	[#1451] ec: Check all parts are saved ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-06 08:18:10 +00:00
Dmitrii Stepanov	9a77527f46	[#1451] ape: Drop unused ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-06 08:18:10 +00:00
Dmitrii Stepanov	5b1ba8e23d	[#1451] ape: Perform strict APE checks for EC parts ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-06 08:18:10 +00:00
Dmitrii Stepanov	9902965ff4	[#1451] writer: Sign EC parts with node's private key ... As EC put request may be processed only by container node, so sign requests with current node private to not to perform APE checks. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-11-06 08:18:10 +00:00
Evgenii Stratonikov	c2effcc61c	[#1465] Makefile: Update golangci-lint, fix warnings ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-31 06:39:59 +00:00
Evgenii Stratonikov	7ac0852364	[#1459] .golangci.yml: Add intrange linter, fix issues ... Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-30 15:18:22 +00:00
Airat Arifullin	87ac3c5279	[#1458] object: Make patch not set key before target construction ... * `SignRequestPrivateKey` field should be initialized either within `newUntrustedTarget` or within `newTrustedTarget`. Otherwise, all requests are signed by local node key that makes impossible to perform patch on non-container node. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-10-29 15:20:28 +00:00
Evgenii Stratonikov	b42bcdc6fa	[#1433] services/object: Put object before auxiliary info ... Consider the following operations ordering: 1. Inhume(with tombstone A) --> add tombstone mark for an object 2. --> new epoch arives 3. --> GCMark is added for a tombstone A, because it is unavailable 4. Put(A) --> return error, because the object already has a GCMark It is possible, and I have successfully reproduced it with a test on the shard level. However, the error is related to the specific _ordering_ of operations with engine. And triggering race-conditions like this is only possible on a shard level currently, so no tests are written. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-17 14:43:13 +03:00
Alexander Chuprov	d83879d4b8	[#1431] node: Fix comment format ... Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>	2024-10-15 08:53:59 +00:00
Alexander Chuprov	f6582081a4	[#1431] obj_storage/metabase: Delete unused variable ... Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>	2024-10-15 08:53:59 +00:00
Vitaliy Potyarkin	714ff784fa	[#1431] objsvc: Use specific values in message about address mismatch ... This makes troubleshooting failed operations much easier Signed-off-by: Vitaliy Potyarkin <v.potyarkin@yadro.com>	2024-10-15 07:34:03 +00:00
Anton Nikiforov	acd6eb1815	[#1427] object: Fix Put for EC object when node unavailable ... There might be situation when context canceled earlier than traverser move to another part of the nodes. To avoid this, need to wait for the result from concurrent put at each traverser iteration. Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>	2024-10-11 16:53:30 +03:00
Dmitrii Stepanov	4572fa4874	[#1412] searchSvc: Check container is indexed ... For non S3 containers it is expected to use attributes index for some attributes. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-10-08 11:41:50 +03:00
Dmitrii Stepanov	1b520f7973	[#1412] engine: Add IsIndexedContainer flag ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-10-08 11:41:49 +03:00
Airat Arifullin	5f22ba6f38	[#1397] object: Correctly set namespace before APE check ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-09-27 11:43:29 +00:00
Dmitrii Stepanov	a5e1aa22c9	[#1394] putSvc: Fix relay ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-25 17:28:03 +03:00
Dmitrii Stepanov	4fbfffd44c	[#1388] putSvc: Drop unused ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-25 08:55:38 +00:00
Dmitrii Stepanov	d1d6e3471c	[#1388] signSvc: Drop unused ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-25 08:55:38 +00:00
Dmitrii Stepanov	580cd55180	[#1388] getSvc: Drop unused ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-25 08:55:38 +00:00
Dmitrii Stepanov	e319bf403e	[#1388] apeSvc: Drop unused and make annotations ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-25 08:55:38 +00:00
Dmitrii Stepanov	839dead226	[#1297] getSvc: Return AccessDenied instead of ObjectNotFound ... Do not replace the access denied error if it was received earlier. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-24 12:05:09 +03:00
Airat Arifullin	3bb65ba820	[#1392] object: Fix target initialization within put streamer ... * Remove `relay` field from put streamer as it's no longer used; * Fix initialization of `Relay` object writer parameter. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-09-24 09:04:13 +00:00
Dmitrii Stepanov	d4493a6d08	[#1390] getSvc: Fix Head EC1.1 ... If local EC chunk found, but remote node is off, then `HEAD --raw` request returns object not found. Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-09-23 15:12:06 +03:00
Airat Arifullin	61d5e140e0	[#1383] object: Add restrictions for Patch method ... * `Patch` can't be applied for non-regular type object (tombstones, locks etc.) * Complex object parts can't be patched. So, if an object has EC/Split header, it won't be patched. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-09-19 13:54:49 +03:00
Airat Arifullin	a812932984	[#1362] ape: Move common APE check logic to separate package ... * Tree and object service have the same log for checking APE. So, this check should be moved to common package. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-09-10 12:40:34 +00:00
Airat Arifullin	273980cfb9	[#1310] object: Remove irrelevant comments ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-09-05 16:40:32 +03:00
Airat Arifullin	b3deb893ba	[#1310] object: Move target initialization to separate package ... * Split the logic of write target initialization to different packages; * Refactor patch and put services: since both service initialize the target themselves. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-09-05 13:03:58 +00:00
Ekaterina Lebedeva	a685fcdc96	[#1317] go.mod: Use range over int ... Since Go 1.22 a "for" statement with a "range" clause is able to iterate through integer values from zero to an upper limit. gopatch script: @@ var i, e expression @@ -for i := 0; i <= e - 1; i++ { +for i := range e { ... } @@ var i, e expression @@ -for i := 0; i <= e; i++ { +for i := range e + 1 { ... } @@ var i, e expression @@ -for i := 0; i < e; i++ { +for i := range e { ... } Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>	2024-09-03 13:00:54 +03:00
Evgenii Stratonikov	03976c6ed5	[#1341] .golangci.yml: Replace exportloopref with copyloopvar ... exportloopref is deprecated. gopatch: ``` @@ var index, value identifier var slice expression @@ for index, value := range slice { ... -value := value ... } @@ var index, value identifier var slice expression @@ for index, value := range slice { ... -index := index ... } @@ var value identifier var channel expression @@ for value := range channel { ... -value := value ... } ``` Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-08-28 15:44:41 +00:00
Dmitrii Stepanov	7abbdca064	[#1340] getSvc: Fix access denied error handling ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-28 14:02:28 +03:00
Airat Arifullin	6488ddee88	[#1338] object: Fix range provider in Patch handler ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-08-27 16:51:12 +03:00
Airat Arifullin	d6b42972a8	[#1338] object: Fix audit patch stream ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-08-27 16:18:29 +03:00
Dmitrii Stepanov	bd24beecf8	[#1329] putSvc: Reset SuccessAfter for non-EC objects in EC container broadcasting ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-23 13:51:16 +03:00
Anton Nikiforov	8319b59238	[#1318] Fix gofumpt issue ... Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>	2024-08-20 14:34:54 +03:00
Airat Arifullin	eeab417dcf	[#1307] object: Add APE check for Patch handler ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-08-16 14:13:09 +00:00
Airat Arifullin	e890f1b4b1	[#1307] object: Implement Patch method ... Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-08-16 14:13:09 +00:00
Airat Arifullin	a4a1c3f18b	[#1307] go.mod: Bump frostfs-sdk-go/frostfs-api-go/v2 versions ... * Also, resolve dependencies and conflicts for object service by creating stub for `Patch` method. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>	2024-08-16 14:13:09 +00:00
Dmitrii Stepanov	c985b1198f	[#1302] putSvc: Override SuccessAfter for non-regular objects in EC containers ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-09 10:42:55 +03:00
Dmitrii Stepanov	8e51d7849a	[#1295] getSvc: Assemble complex EC object headers without linking object ... Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>	2024-08-06 16:48:12 +03:00