TrueCloudLab
/
frostfs-node
19
1
Fork 20
Code Issues 93 Pull Requests 9 Actions Releases Activity

Add block and mutex profiles #39

Merged
carpawell merged 1 commits from carpawell/optional-profiles into master 2023-07-26 21:07:56 +00:00
Conversation 3 Commits 1 Files Changed 1
carpawell commented 2023-02-01 07:24:19 +00:00 (Migrated from github.com)

Closes #22.

@alexvanin, @KirillovDenis, @fyrchik, @acid-ant, lets discuss config format, values (int or bool?) and if the IR shoud have it too?

Also, i think that should be merged after some adoption of the https://github.com/nspcc-dev/neofs-node/pull/2094.

Closes #22. @alexvanin, @KirillovDenis, @fyrchik, @acid-ant, lets discuss config format, values (`int` or `bool`?) and if the IR shoud have it too? Also, i think that should be merged after some adoption of the https://github.com/nspcc-dev/neofs-node/pull/2094.
alexvanin (Migrated from github.com) reviewed 2023-02-01 07:24:19 +00:00
KirillovDenis (Migrated from github.com) reviewed 2023-02-01 07:24:19 +00:00
fyrchik (Migrated from github.com) reviewed 2023-02-01 07:24:19 +00:00
acid-ant (Migrated from github.com) reviewed 2023-02-01 07:24:19 +00:00
alexvanin commented 2023-02-03 14:05:53 +00:00 (Migrated from github.com)

if the IR shoud have it too

I would like to adopt the same scheme across all apps, including IR, gateways, etc.

I am perfectly fine with proposed format.

> if the IR shoud have it too I would like to adopt the same scheme across all apps, including IR, gateways, etc. I am perfectly fine with proposed format.
fyrchik commented 2023-02-06 18:12:31 +00:00 (Migrated from github.com)

I believe IR should have it too, it blocks a lot.
I would make a section profile.debug for this (with values block_rate, mutex_rate). This way it is obvious, that this is not intended to be used in production.

I believe IR should have it too, it blocks a lot. I would make a section `profile.debug` for this (with values `block_rate`, `mutex_rate`). This way it is obvious, that this is not intended to be used in production.
fyrchik changed title from Feat/Add optional profiles to WIP: Feat/Add optional profiles 2023-03-09 15:00:12 +00:00
carpawell changed title from WIP: Feat/Add optional profiles to Feat/Add optional profiles 2023-04-19 17:02:25 +00:00
carpawell added 311 commits 2023-04-19 17:02:46 +00:00
5a9d6a09d8 [#8] cli: Set flag `mode` required for `control shards set-mode` 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
2b09564355 [#1889] Move netmap.go and exit.go from `cli` to `cmd/internal/common` 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
ee24815748 [#1889] Move flag `--config` in `cmd/frostfs-adm/internal/commonflags/flags.go` 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
515c60bdf4 [#1889] adm: Add command `morph netmap-candidates` 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
73bc1b0b68 [#38] node: Fix linter warnings 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
1858f11146 [#1] Fix viper env prefix in cli tools 
Changing env prefix and corresponding example config files.

Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
1cedd446bb [#1] Fix sample configs 
- Update sample configs to match unit tests
- Remove Docker container for N3 testnet
  Will return with updates when FrostFS enters N3

Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
488eece25f [#1] Fix Debian package references to old upstream 
Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
c6645ef775 [#1] Documentation rebranding 
Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
f825cfac78 [#1] Fix project name in comments here and there 
Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
c761a95eef [#1] Fix project name in control service 
Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
cb016d53a6 [#1] Fix comments and error messages 
Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
5ffa826897 [#1] Update Changelog 
Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
ab21d90cfb [#1794] shard: Add increasing case for the payload size metric 
Signed-off-by: Artem Tataurov <a.tataurov@yadro.com>
abbecf49d6 [#31] fstree: Speedup string-to-address conversion 
```
name                  old time/op    new time/op    delta
_addressFromString-8    1.25µs ±30%    1.02µs ± 6%  -18.49%  (p=0.000 n=9+9)

name                  old alloc/op   new alloc/op   delta
_addressFromString-8      352B ± 0%      256B ± 0%  -27.27%  (p=0.000 n=9+10)

name                  old allocs/op  new allocs/op  delta
_addressFromString-8      6.00 ± 0%      4.00 ± 0%  -33.33%  (p=0.000
n=10+10)
```

Also, assure compiler that `s` doesn't escape:
Before this commit:
```
./fstree.go:74:24: leaking param: s
./fstree.go:90:6: moved to heap: addr
```

After this commit:
```
./fstree.go:74:24: s does not escape
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
dee4498c1e [#31] fstree: Do not check for a file existence twice 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
204cd3a11c [#31] fstree: Optimize `treePath` 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
1d3669232e [#48] adm: Allow using nonzero magic with local client 
neo-go actor API uses `getVersion` call which returned incorrect magic.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
3e5bc394b5 [#48] adm: Add initialize test for 1 node 
Single node is used in dev-env, worth testing.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
269a4e9b50 [#53] Fix dirty in version 
Signed-off-by: Aleksey Pastukhov <a.pastukhov@yadro.com>
901d62567d [#57] node: Broadcast link objects 
It boosts object assembling by an _average_ container node.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
362f24953a [#47] shard: Switch container size metric from physical to logical capacity 
Signed-off-by: Artem Tataurov <a.tataurov@yadro.com>
85cf1f47ac [#1465] node: Prevent process from killing by systemd when shutting down 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
c43b2dbac9 [#1465] Add log entry for morph components shutdown action 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
9afe86ba3e [#2212] morph: Fix subscription restoration 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
a6f071d66f CHANGELOG: fix whitespacing errors 
Signed-off-by: Roman Khimov <roman@nspcc.ru>
ad93d4db7c CHANGELOG: add more fancy glyphs 
How could you forget adding it?

Signed-off-by: Roman Khimov <roman@nspcc.ru>
40822adb51 [#2213] node: Do not return object expired object 
"Object is expired" means that object is presented in `meta` but it is not
`ObjectNotFound` error. Previous implementation made `shard` search for an
object without `meta` which was an error.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
236c4af615 [#2224] adm: Use native neo-go sessions in `dump-hashes` 
If we had lots of domains in one zone, `dump-hashes` for all others
can miss some domains, because we need to restrict ourselves with _some_
number.
In this commit we use neo-go sessions by default, with a proper
failback to in-script iterator unwrapping.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
58367e4df6 [#2232] pilorama: Merge in-queue batches 
To achieve high performance we must choose proper values for both
batch size and delay. For user operations we want to set low delay.
However it would prevent tree synchronization operations to form big
enough batches. For these operations, batching gives the most benefit
not only in terms of on-CPU execution cost, but also by speeding up
transaction persist (`fsync`).
In this commit we try merging batches that are already
_triggered_, but not yet _started to execute_. This way we can still
query batches for execution after the provided delay while also allowing
multiple formed batches to execute faster.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
e0309e398c [#2239] writecache: Fix possible deadlock 
LRU `Peek`/`Contains` take LRU mutex _inside_ of a `View` transaction.
`View` transaction itself takes `mmapLock` [1], which is lifted after tx
finishes (in `tx.Commit()` -> `tx.close()` -> `tx.db.removeTx`)

When we evict items from LRU cache mutex order is different:
first we take LRU mutex and then execute `Batch` which _does_ take
`mmapLock` in case we need to remap. Thus the deadlock.

[1] 8f4a7e1f92/db.go (L708)

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
c53903ccd0 [#2238] engine: Make `Open` and `Init` similar 
1. Both could initialize shards in parallel.
2. Both should close shards after an error.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
427fe276f2 [#2238] shard: Try closing all components 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
59748b7ae8 [#2238] neofs-node: Gracefully handle shard initialization errors 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
5cb2c5ae62 [#2238] engine: Add test for component initialization failures 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
2272c55c4d [#2238] engine: Add test for component initialization failures 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
6fd88a036f [#2241] metrics: Fix request count metrics names 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
351fdd9fa2 [#2246] node: Allow to configure tombsone lifetime 
Currently, DELETE service sets tombstone expiration epoch to
`current epoch + 5`. This works less than ideal in private networks
where an epoch can be e.g. 10 minutes. In this case, after a node is
unavailable for more than 1 hour, already deleted objects have a chance
to reappear.

After this commit tombstone lifetime can be configured.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
dbbbef9ddb [#2244] node: Update expired storage ID by WC 
Previously, node could get an "infinite" small object: it could be expired
and thus could not be flushed (update its storage ID) to metabase => could
not be marked as flushed => node never removes such object and repeat all
the cycle one more time. If object exists and is not marked with GC (meta
returns `ErrObjectIsExpired`, not `ObjectNotFound` and not
`ObjectAlreadyRemoved`), its ID is safe to update _in the same_ bbolt
transaction.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
07ec51ea60 [#2244] node: Add object address to WC's operations 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
95ee905861 [#2244] node: Fix subscriptions lock 
Subscribing without async listening could lead to a dead-lock in the
`neo-go` client.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
b422ac9f94 [#2164] node: Fix multi-client error reporting 
Missing `ReportError` method did not allow casing multi-client interface to
`errorReporter` interface and dropping broken connections.
`replicationClient` embeds that interface, and it is widely used across
node's code. Embedded interface does not allow casting its parent structure
to `errorReporter` and breaks multi client error reporting logic.
Multi-client scheme is extremely hard to maintain, it makes unpredictable
casts and does not allow tracking code flow, so it will be refactored in the
future anyway.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
315141dc2c [#2252] fstree: Allow concurrent writes 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
d1d123d180 [#2234] writecache: Fix possible panic in `initFlushMarks` 
In case we have many small objects in the write-cache, `indices` should
not be reused between iterations.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
2567f8020e [#2260] services/object: Do not assemble object with TTL=1 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
bf1e59bb83 [#2260] network/cache: Ignore `context cancelled` errors 
Timeouts on client side should node affect inter-node communication.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
0b61a3c961 [#2260] network/cache: Ignore clients only on `Dial` errors 
The problem is that accidental timeout errors can make us to ignore
other nodes for some time. The primary purpose of the whole ignore
mechanism is not to degrade in case of failover. For this case,
closing connection and limiting the amount of dials is enough.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
2b755ddb12 [#2260] node: Use a separate client cache for PUT service 
Currently, under a mixed load one failed PUT can lead to closing
connection for all concurrent GETs. For PUT it does no harm: we have
many other nodes to choose from. For GET we are limited by `REP N`
factor, so in case of failover we can close the connection with the only
node posessing an object, which leads to failing the whole operation.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
22f3c7d080 [#1868] Reload config for pprof and metrics on SIGHUP 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
5303736acd [#62] Fix CHANGELOG.md 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
3beef10f89 [#61] node: Do not fetch missing objects 
If an object is missing in a `meta`, shard should not look for it in
a `blobstor`.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
337049b2ce [#56] node: Allow reading expired locked object 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
87e69b9349 [#44] node: Support multiple configs 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
bed5a36235 [#44] ir: Support multiple configs 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
5f06232d34 [#44] cli: Support multiple configs 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
633c5a35de [#44] adm: Support multiple configs 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
3d873237d5 [#44] Update Changelog 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
cb5468abb8 [#66] node: Replace interface{} with any 
Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
7eaf159a8b [#63] adm: Fix contract wallet creation 
Create contract wallet only by init and update-config command.

Close #63

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
73bb590cb1 [#64] node: Use pool_size_local and separate pool for local puts 
Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
a1ab25b33e [#72] .github: Fix CODEOWNERS 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
c3a7039801 [TrueCloudLab/hrw#2] node: Optimize shard hash 
Compute shard hash only once

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
6925fb4c59 [TrueCloudLab/hrw#2] node: Use typed HRW methods 
Update HRW lib and use typed HRW methods to sort shards and nodes

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
88e3868f47 [#37] cli: Add `nns-name` and `nns-zone` for `container create` 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
e9f3c24229 [#65] Use `strings.Cut` instead of `strings.Split*` where possible 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
6d4f48f37a [TrueCloudLab#78] .github: Fix CODEOWNERS 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
79ba34714a [#79] cli: Fix panic when setting domain for container 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
20de74a505 Rename package name 
Due to source code relocation from GitHub.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>
381e363a8b [#32] node: Always close general components after testing 
It will prevent test fails with `-race` flag on components that have
background processes and make some actions on test framework.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
f1f3c80dbf [#32] node: Init write-cache asynchronously 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
7486c02bbc [#88] adm: Fix method `nnsResolveKey` 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
9929dcf50b [#126] adm: Exclude `group.frostfs` key from output of the `dump-hashes` 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
f2250a316f [#129] tree: Do not remove tree if the netmap is empty 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
6226c3ba86 [#129] policer: Use safer defaults 
If `processNodes` exits earlier for some reason, `needLocalCopy` could
be false.
See https://github.com/nspcc-dev/neofs-node/issues/2267

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
24a540caa8 [#132] cli/util: Fix basic ACL rendering 
In previous implementation pretty-printer of basic ACL in NeoFS CLI had
mistakes:
 * F-bit was set to `Extendable()` property instead of its inversion
 * B-bits were set to `acl.RoleInnerRing` rights

Make `PrettyPrintTableBACL` to correctly render mentioned bits.

Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
861e9ab59a [#83] pre-commit: Add initial configuration 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
a4931ea4c7 [#83] .github: Remove CODEOWNERS and actions 
Issue templates are still supported by Gitea:
https://docs.gitea.io/en-us/issue-pull-request-templates/ .

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
0893689c6a [#83] pre-commit: Add golangci-lint hook 
Skip deprecated warning for now, adopting new neo-go API will be done in
another task.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
8226d49376 [#83] pre-commit: Add gitlint hook 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
05471d3827 [#83] util/autocomplete: Fix deprecated warning 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
bce5827f64 [#83] pre-commit: Add shellcheck hook 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
365adb4ebd [#133] .github: Restore logo.svg 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
5890cd4d7d [#50] ir: Fix config property name for prometheus 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
5ae4446280 [#50] ir: Add Health status 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
3e6fd4c611 [#82] pilorama: Allow to store last sync height 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
6cd806f998 [#82] services/tree: Save last synchronized height in a persistent storage 
Remember the last synchronized height and use it after service restart.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
4e244686cf [#83] Makefile fixes for pre-commit 
Add make targets to simplify pre-commit setup for individual developers.

Signed-off-by: Stanislav Bogatyrev <realloc@realloc.spb.ru>
b4582239bf [#130] adm: Fix adding of pub key for `group.frostfs` at init step 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
8b9e40a848 [#85] get-service: Add assembler 
Extract assemble logic to assembler

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
2886b1581b [#85] get-service: Add unit tests 
Add unit tests to cover all assemble statements

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
07de839f18 [#85] get-service: Fix corrupted chain logic 
Should return an error in case of a broken LOB reference chain.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
b8e93d4c08 [#85] get-service: Use assembler to assemble LOB 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ac0a278a05 [#85] get-service: Drop unused assemble flag 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
b1c165a93b [#83] Fix shellcheck pre-commit action 
Original shellcheck action requires Docker to run and it's not always
available, especially inside Docker containers. Replacing it with python
wrapper to simplify usage with Docker-based CI systems like Drone and
WoodpeckerCI.

Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
724debfdcd [#81] node: Add basic read/write benchmarks for substorages 
Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
22be532cbd object/put: Persist session token till the end of a session 
Previously a token could've expired in the middle of an object.PUT
stream, leading to upload being interrupted. This is bad, because user
doesn't always now what is the right values for the session token
lifetime. More than that, setting it to a very high value will
eventually blow up the session token database.

In this commit we read the session token once and reuse it for the whole
stream duration.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
f006f3b342 [#67] node: Make engine's `IsLocked` public 
It will allow reusing that method in expiration checks.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
64bde68fb9 [#67] node: Accept expired locked objects 
Allow replication of any (expired too) locked object. Information about
object locking is considered to be presented on the _container nodes_.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
b70caa216b [#144] Don't copy cache inside Docker environment 
May make docker builds not so clean.

Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
10c419adf0 [#67] node: Fix infinite recursion in SE's wrapper 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
abd21f8099 [#136] Revert "[#2260] services/object: Do not assemble object with TTL=1" 
This reverts commit 2567f8020e. It assumes
that assembling logic could break some failover scenarios if request
forwarding is done. However, it also breaks requesting big objects via a
non-container node with TTL=2. Failover has been rechecked without that
commit and no problems were found. Any (if found) other bugs related to
the forwarding and object assembling must be solved more carefully.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
392be818e5 [#149] Fix gitlint regex to match our policy 
In our policy we mark commits not having a PR/Issue yet with a `[#XX]`
reference to be replaced after PR creation.

Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
d64fb887ff [#149] Reorder pre-commit hooks 
Minor changes to see what fails first

Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
573d920821 [#149] Use custom image and kludges for node 
Until #139 is fixed, we can't use root inside Docker container running
CI, but Woodpecker CI can't run non-root containers until they fix
https://github.com/woodpecker-ci/woodpecker/issues/1077, hence we use
temporary kludges with custom image and manual permissions in pipelines.

Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
2dc86058c3 [#148] memstore: Drop space line 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
cc8ff015b4 [#148] linter: Add containedctx linter 
Context has to be passed as an argument: https://pkg.go.dev/context

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
97c36ed3ec [#148] linter: Add funlen linter 
Long functions are hard to understand and source of errors

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
481a1ca6f3 [#148] linter: Add gocognit linter 
Code with high cognitive complexity is hard intuitively to understand

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/full-pre-commit Pipeline failed Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
44b86bac5a [#148] linter: Add contextcheck linter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/full-pre-commit Pipeline failed Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
9cd8f7cea0 [#152] IR: Process empty basic incomes 
If network is not configured for basic income earnings, do not distribute
GAS by the Alphabet nodes.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
6c4a1699ef [#145] shard-gc: Expired locked unit test 
Added unit test that verifies that GC deletes expired
locked objects in one epoch.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
5059dcc19d [#145] shard-gc: Delete expired objects after locks 
GC deletes expired locks and objects sequentially. Expired locks and
objects are now being deleted concurrently in batches. Added a config
parameter that controls the number of concurrent workers and batch size.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/pr/full-pre-commit Pipeline failed Details
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/full-pre-commit Pipeline failed Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
7a31988a36 [#145] docs: Add expired object collector params 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/full-pre-commit Pipeline failed Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
9a4f40626c [#128] IR: Do not try to emit GAS to nobody 
Fix sending GAS to an empty extra wallets receivers list. Also, send GAS to
extra wallets even if netmap is empty.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
9aeea0b974 [#153] ci: Minor pipeline fixes 
- We can skip full pre-commit run
- On a very slow agent golangci run may take up to 10 minutes

Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
7eb9e88f8f Add bug label; Delte label addition 
Signed-off-by: Liza <e.chichindaeva@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
ec2c5d45b4 Add to Possible Solutions 
Signed-off-by: Liza <e.chichindaeva@yadro.com>
47e8c5bf23 [#156] pilorama: Remove CIDDescriptor from TreeApply() 
Initially it was there to check whether an update is being initiated by
a proper node. It is now obsolete for 2 reasons:
1. Background synchronization fetches all operations from a single node.
2. There are a lot more problems with trust in the tree service, it is
   only used in controlled environments.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
5368c4207a [#156] services/tree: Split syncLoop() in functions 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
3f6b962349 [#156] services/tree: Pass context to replicationWorker() 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fb13902db9 [#156] shard: Make refillMetabase() pass linter checks 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
8014fdb21a [#156] metabase: Make freePotentialLocks() pass linter checks 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
484ac502ca [#156] frostfs-adm: Make dumpBalances() pass linter checks 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
cbc2efb1d6 [#156] object/get: Make toHeadPrm() pass gocognit 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
1637a3edce [#155] search-service: Add search with ST test 
In case of session token (ST) with object IDs search should
return only objects allowed in static session

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
49234b915e [#155] search-service: Fix search with ST 
Search should return only objects allowed in static session

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
da8da1c63a [#98] fstree: Do not fail iteration over just removed files 
A directory is read and files are saved to a local variable. The iteration
over such files may lead to a non-existing files reading due to a normal SN
operation cycle and, therefore, may lead to a returning the OS error to a
caller. Skip just removed (or lost) files as the golang std library does in
similar situations:
5f1a0320b9/src/os/dir_unix.go (L128-L133).

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
f111704ceb [#158] Fix gitlint run in pre-commit under CI 
Wrong stage was used.
It still may run gitlint against only latest commit in PR.

Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
342e571d89 [#159] Add handle __SYSTEM__ sys attributes 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline failed Details
9808dec591 [#86] node: Move testing utils to one package 
Move testing utils from tests in local_object_storage package to
unified testutil package

Signed-off-by: Airat Arifullin <aarifullin@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
34329d67ff [#86] node: Fix unit test and linter errors 
Signed-off-by: Airat Arifullin <aarifullin@yadro.com>
d857ffeb2e [#171] Syncrhonize pre-commit settings across FrostFS repos 
This change allows to use `[#xx]` placeholders for issue number.
This change adds go unit test run if .go files were changed.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
9ffa0d8fea [#171] Remove unit tests from pipeline 
Unit tests are included as pre-commit hook. They are
triggered by the change of .go files.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>
533e9f8b75 [#59] morph: Adopt updated `neo-go` client API for subs 
It does not use deprecated methods anymore but also adds more code that
removes. Future refactor that will affect more components will optimize
usage of the updated API.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
f3ff9fd251 [#73] morph: Rename vars that collide with package names 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
a5ece7889d [#174] go.mod: Update dependencies 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
3c7ed21f74 [#141] Add big object's parts to a lock object's body 
That will prevent part/link object from being removed by both an external
`DELETE` call and the object expiration procedure.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
c78e9cc857 [#165] cli: Refactor get command 
Resolve funlen linter for getObject method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
c2cf708e0e [#165] cli: Refactor put command 
Resolve funlen linter for putObject method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
1d5f2dd681 [#165] cli: Refactor collectObjectRelatives 
Resolve funlen linter

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
04b3d9d068 [#165] cli: Drop redundant nolint comment 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
f2e880465e [#165] ir: Refactor config default init 
Resolve funlen linter for defaultConfiguration function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
9534ade716 [#161] adm: Refactor restore-containers command 
Resolve funlen linter for restoreContainers function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
5f7d70c59c [#161] adm: Refactor deploy command 
Resolve funlen linter for deployContractCmd function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ecbc211016 [#161] adm: Refactor update-contracts command 
Resolve funlen linter for updateContracts method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
d62b11f5e7 [#161] adm: Refactor init context creation 
Resolve funlen linter for newInitializeContext function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
b0fefcb21f [#161] adm: Refactor deposit-notary command 
Resolve funlen linter for depositNotary function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
92f8810970 [#161] adm: Refactor commands initialization 
Resolve funlen linter for init function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
e1b99dacad [#161] adm: Refactor netmap add/remove commands 
Resolve funlen linter for manageSubnetAdmins function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
512b72591a [#161] adm: Refactor subnet commands 
Resolve funlen linter for init method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
93cb9e3a94 [#161] morph: Refactor invokeNotary method 
Resolve funlen linter

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
5bf1ec348f [#161] adm: Refactor storage-config command 
Resolve funlen linter for storageConfig function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
bf7d80f44b [#172] morph/client: Support iterators via neo-go session API 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
9e54646248 [#172] client/container: Support listing containers with `containersOf` 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
382ecae96a [#172] Use ContainersOf() for container list fetching 
Previously we were limited by ~2048 containers because of
neo-go VM limits.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
91717d4b98 [#176] morph: Resolve funlen linter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
221203beeb [#180] node: Refactor panics in unit test 
* Replace panics in unit tests by require.NoError and t.Fatalf

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
97e201993b [#184] *: Unify done contexts handling 
If `ctx.Done()`, return `ctx.Err()` in every function that returns an error.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
3646723ae3 [#184] morph: Make deposit logs INFO 
We have already had and solved plenty of deposit issues and notary balance
is a really important thing. Deserves to be INFO even before the huge logs
severity refactor, happens on an app start only.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
ba58a77f8c [#184] node, ir: Do not wait for already made notary deposits 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
e843e7f090 [#184] ir: Delete unused config reader param 
Not used since notary environments do endless and non-configurable
deposits.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
341fe1688f [#139] test: Add test storage implementation 
This aims to reduce the usage of chmod hackery to induce or simulate
OS-related failures.

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
9f0bce5c15 [#183] gc: Fix drop expired locked simple objects 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
ab32067152 [#183] gc: Fix drop expired locked complex objects 
Do not delete bucket keys during iteration

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
7be5a0fd79 [#189] node: Fix bug with sync/atomic package 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
85fb9e77c4 [#185] ir: Resolve funlen linter 
Resolve funlen linter for GlagoliticLetter.String method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
c8a6978563 [#185] ir: Refactor ir start 
Resolve funlen linter for Server.Start method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
4d160bd4ab [#185] ir: Refactor ir service creation 
Resolve funlen linter for New function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
6be2688fb4 [#185] ir: Refactor gas emit 
Resolve funlen linter for processEmit method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
30c18d46cc [#185] ir: Refactor audit 
Resolve funlen linter for processStartAudit method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
aeb4bbc51e [#185] ir: Refactor alphabet update 
Resolve funlen linter for processAlphabetSync method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
c1cbe6ff2d [#185] ir: Refactor signature verification 
Resolve funlen linter for verifySignature method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
8426d25f4b [#185] ir: Resolve containedctx linter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
a7c79c773a [#168] node: Refactor node config 
Resolve containedctx linter for cfg

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
3bbb516528 [#168] node: Refactor node config read 
Resolve funlen linter for readConfig method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
c94372e6f9 [#168] node: Refactor config initialization 
Resolve funlen linter for initCfg function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dcd39f8fdd [#168] node: Refactor shard opts initialization 
Resolve funlen linter for shardOpts method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
28dc9e2190 [#168] node: Refactor container service init 
Resolve funlen linter for initContainerService function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
56161d39b4 [#168] node: Refactor container services 
Resolve containedctx for remoteLoadAnnounceWriter struct

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dd572825c7 [#168] node: Refactor object service init 
Resolve funlen linter for initObjectService function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
1f929fdd57 [#168] node: Refactor netmap service init 
Resolve funlen linter for initNetmapService function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
ed28ce24cd [#168] node: Refactor reputation service 
Resolve funlen linter for initReputationService function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
44d5412e10 [#181] ir: Do not deposit notary GAS by non-alphabet nodes 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
db5321309d [#181] ir: Do not sync the Alphabet by non-alphabet nodes 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
aa92f977ef [#181] ir: Do not pay for audit by non-alphabet nodes 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
2bdf7126b8 [#181] Update CHANGELOG 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
a69c6d1ec9 [#2272] morph: Do not subscribe to events without listening 
It led to a neo-go dead-lock in the `subscriber` component. Subscribing to
notifications is the same RPC as any others, so it could also be blocked
forever if no async listening (reading the notification channel) routine
exists. If a number of subscriptions is big enough (or a caller is lucky
enough) subscribing loop might have not finished subscribing before the
first notification is received and then: subscribing RPC is blocked by
received notification (non)handling and listening notifications routine is
blocked by not finished subscription loop.
That commit starts listening notification channel _before_ any subscription
actions.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
14d894178e [#199] putsvc: Refactor placement iterator 
Resolve funlen linter for iteratePlacement method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
cecea8053a [#199] putsvc: Refactor streamer pool 
Resolve staticcheck linter for putBytesPool

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
27bdddc48f [#199] putsvc: Refactor put object 
Resolve containedctx linter for streamer and remote target

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
ece6c820e7 [#199] putsvc: Refactor streamer initialization 
Resolve funlen linter for initTarget method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline failed Details
0948a280fa [#195] morph: use blocking unlimited pool for notifications 
With non-blocking pool restricted by 10 in capacity, the probability of
dropping events is unexpectedly big. Notifications are an essential part of the FrostFS,
we should not drop anything, especially new epochs.
```
Mar 31 07:07:03 vedi neofs-ir[19164]: 2023-03-31T07:07:03.901Z        debug        subscriber/subscriber.go:154        new notification event from sidechain        {"name": "NewEpoch"}
Mar 31 07:07:03 vedi neofs-ir[19164]: 2023-03-31T07:07:03.901Z        warn        event/listener.go:248        listener worker pool drained        {"chain": "morph", "capacity": 10}
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
8e5a0dcf27 [#204] gc: Fix GC handlers start 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
e85e5382e4 [#175] adm: list containers using `containersOf` 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
49cc23e03c [#175] adm: pipeline container iteration 
Do not accumulate everything in memory.
Also, CLI should be responsive.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
ee7468daa7 [#205] innerring: Provide `alphabetState` param to `epochTimer` 
Fix NPE, introduced in f09ee27a.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
594b5821ed [#188] blobstor: Refactor put data to blobovniczas 
Resolve funlen linter for Blobovniczas.Put method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
8273a3dfb2 [#188] blobstor: Refactor blobstor test 
Resolve funlen linter for TestIterate function

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
0739c36a3b [#188] metabase: Refactor object put to metabase 
Resolve funlen linter for db.put method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
3010ca2649 [#188] engine: Refactor get object from engine 
Resolve funlen linter for StorageEngine.get method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
456bc097f7 [#188] engine: Refactor get range from engine 
Resolve funlen linter for StorageEngine.getRange method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
5a66db80c5 [#188] engine: Refactor shard evacuation 
Resolve funlen and gocognit linter for StorageEngine.Evacuate method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
1f1aed87be [#188] metabase: Refactor object inhume 
Resolve funlen linter for db.Inhume method

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
cd33a57f44 [#207] aclsvc: Refactor EACL check 
Resolve funlen linter for CheckEACL method.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
9ef790f782 [#207] aclsvc: Refactor object headers read 
Resolve funlen linter for readObjectHeaders method.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
585415fa92 [#207] aclsvc: Refactor send checker 
Resolve funlen linter for putStreamBasicChecker.Send method.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
4941926c9d [#207] aclsvc: Drop outdated tag 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
5f2a1531fe [#208] deletesvc: Resolve containedctx linter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
0b38419fbf [#208] searchsvc: Resolve context linters 
Resolve containedctx and contextcheck linters.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
d85703a963 [#208] searchsvc: Refactor request forwarding 
Resolve funlen & gocognit linters for toPrm method.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
760af6b912 [#211] fstree: Consider ENOSPC a logical error 
We already do this for file writing, however directory creation can also
fail.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
9098d0eec0 [#211] engine: Unify shard mode checks for tree operations 
All operations must ensure the shard is not in a degraded mode.
Write operations must also ensure the shard is not in a read-only mode.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
23575e1ac0 [#210] policier: Resolve contextcheck linter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
080be5cfcd [#210] policier: Refactor object placement 
Resolve containedctx and contextcheck linters.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
d6486d172e [#210] policier: Refactor nodes processing 
Resolve funlen linter for processNodes method.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
6f7b6a8813 [#116] node: Improve shard/engine construction in tests 
* Introduce testEngineWrapper that can be constructed with different options

Signed-off-by: Airat Arifullin a.arifullin@yadro.com
279261ace3 [#217] containersvc: Refactor route passing 
Resolve containedctx for routeCtx.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
206458c841 [#217] containersvc: Resolve containedctx linter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
1bf21dbb47 [#193] getsvc: Resolve context linters 
Resolve containedctx and contextcheck linters.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
91ead04fa4 [#193] getsvc: Resolve funlen linter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
f889893216 [#193] getsvc: Refactor head param creation 
Resolve funlen linter for toHeadPrm method.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
b0786d2e5c [#193] getsvc: Refactor get params creation 
Resolve funlen linter for toPrm function.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
6c7b708a98 [#193] getsvc: Refactor get range params creation 
Resolve funlen linter for toRangePrm function.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
89924071cd [#193] getsvc: Edit request forwarder signature 
Pass context to forwarder direct, without closure.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
c58ab0c369 [#193] getsvc: Reduce private key requests 
Get private key only once for request forwaring.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
ab891517de [#116] node: Fix bug with extra generated files in TestReload 
* Create testNewEngine in engineWithShards without default opts

Signed-off-by: Airat Arifullin a.arifullin@yadro.com
9e2df4b7c7 [#203] node: Fix double imports 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
68a2f36636 [#203] morph: Mark depracated methods 
Skip staticcheck for depracated methods. Will be fixed soon.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
e21c5bea21 [#203] cli: Fix error message 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
bab11492ad [#203] node: Resolve never used errors 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
8908798f59 [#203] node: Resolve unused vars 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
f32f61df87 [#203] pilorama: Refactor tests 
Do not pass 0 as channel capacity.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
4ec69cbbf8 [#203] control: Fix test 
Fix shard compare loop.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
9027695371 [#203] node: Add staticcheck target and pre-commit 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
56282edf02 [#166] node: Parallelize background tree service sync 
* Run sync task for nodes in parallel within errgroup worker pool

Signed-off-by: Airat Arifullin a.arifullin@yadro.com
e815b19101 [#219] morph: Resolve containedctx linter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
775179f823 [#219] morph: Refactor notary invoke 
Resolve funlen linter for Client.notaryInvoke method.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
d07e40d6fe [#219] morph: Refactor moprh event listener 
Resolve funlen and gocognit linters for listener.listenLoop method.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
fe87735073 [#219] morph: Refactor notary preparator 
Resolve funlen linter for Preparator.Prepare method.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
3dbff0a478 [#222] auditsvc: Resolve containedctx linter 
Resolve containedctx linter for commonCommunicatorPrm type.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
e8d340287f [#222] auditsvc: Refactor audit task 
Resolve containedctx linter. Cancel task by listen cancel.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
e2f13d03d7 [#222] auditsvc: Refactor PoR audit 
Resolve funlen linter for Context.checkStorageGroupPoR method.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
469e8a6e59 [#212] reputationsvc: Resolve containedctx linter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
7ebbfa3358 [#212] reputationsvc: Resolve linters and rename 
Resolved containedctx linters.
Renamed context structs and interfaces to more understandble names.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
c236b54a65 [#212] reputationsvc: Resolve funlen linter 
Resolve funlen linter for Calculator.iterateDaughter method.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
cb172e73a6 [#228] node: Use uber atomic package instead standard 
Signed-off-by: Airat Arifullin a.arifullin@yadro.com
dbc3811ff4 [#191] engine: Allow to remove redundant object copies 
RemoveDuplicates() removes all duplicate object copies stored on
multiple shards. All shards are processed and the command tries to leave
a copy on the best shard according to HRW.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
0b9622c418 [#191] control: Add Doctor RPC 
Doctor RPC performs complex operations on the storage engine.
Currently only duplicate removal is supported.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
b689027d57 [#191] cli: Add `control shards doctor` command 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
38ae71cc7d [#213] metrics: Refactor engine metrics 
Resolve funlen linter for newEngineMetrics function.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
02831d427b [#213] metrics: Refactor object metrics 
Resolve funlen linter for newObjectServiceMetrics function.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
6016d78a45 [#223] core: Refactor object format validator 
Resolve funlen linter for FormatValidator.ValidateContent method.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ae86cda58c [#223] sg: Refactor storage group parameters 
Resolve containedctx linter for SearchSGPrm and GetSGPrm  structs.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ccf8463e69 [#223] controlsvc: Drop unnecessary nolint 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
2ed9fd3f94 [#223] objectsvc: Refactor request parameters 
Resolve containedctx linter for commonPrm.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
93eba19a8e [#223] objectsvc: Refactor split-tree traverse 
Resolve funlen & gocognit linters for traverseSplitChain method.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
2c07f831c7 [#223] node: Refactor cache usage 
Drop excess type args.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
6bf11f7cca [#230] CHANGELOG.md: Remove older entries 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
c85a0bc866 [#236] blobstor/test: Reduce test descriptions 
I tried to add 4 more tests and suddenly, it became harder to navigate in
code. Move directory creation in a common function.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
6ad5c38225 [#236] testutil: Use random object id in `RandObjGenerator` 
Before this commit it was like this:
```
BenchmarkSubstorageWritePerf/memstore-rand10-8            227425              4859 ns/op
BenchmarkSubstorageWritePerf/fstree_nosync-rand10-8     --- FAIL: BenchmarkSubstorageWritePerf/fstree_nosync-rand10-8
    perf_test.go:165: writing entry: file exists
    perf_test.go:165: writing entry: file exists
    perf_test.go:165: writing entry: file exists
BenchmarkSubstorageWritePerf/fstree-rand10-8            --- FAIL: BenchmarkSubstorageWritePerf/fstree-rand10-8
    perf_test.go:165: writing entry: file exists
    perf_test.go:165: writing entry: file exists
    perf_test.go:165: writing entry: file exists
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
c4865783fc [#236] blobstor/test: Prefill storage in parallel in read benchmark 
`blobovniczatree` takes a really long time to prefill, because each
batch takes at least 10ms, so for 10k iterations we have at least 100s of
prefill.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
72565a91ef [#135] node: Update api-go version 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
5af9f58469 [#135] tracing: Add tracing to node gRPC endpoints 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
0920d848d0 [#135] get-object: Add tracing spans 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
b2ca730547 [#135] acl: Add tracing spans 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
5778980252 [#135] signature: Add tracing 
Add tracing to verify request and sign response.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
5d2affa5cd testutil: Fix linter warning 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
7d39fecc6a Release v0.36.0 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
01c0c90a86 [#113] cli: add "name" option for "get container" command 
* Make get container command filter out the container by attribute name

Signed-off-by: Airat Arifullin a.arifullin@yadro.com
2f1beddfd3 [#202] adm: Remove deprecated warnings in tests 
`VerifyBlocks` is now `SkipBlockVerification` and is false by default.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
96b38f7e86 [#239] morph/client: Add CalledByEntry into the "grouped" scope 
Fixes #2230, fixes #2263. CustomGroups are nice while we're only calling NeoFS
contracts, but it doesn't work at all for standard ones like GAS or Notary.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
be4df989e5 [#239] morph/client: Deduplicate signers in Client a bit 
One signer in the cfg is enough.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
f41ad9d419 [#239] morph/client: Recreate actor/wrappers in SetGroupSignerScope 
That's the reason #2230 and #2263 were not detected earlier, we actually had
Global scope being used before reconnection to RPC node.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
d686ab49e8 [#202] adm: Remove deprecated RPC client methods 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
d29b13454f [#239] morph/client: Simplify code interacting with magic numbers 
It can't be uint64 in fact, but this error is buried deeply in the NetworkInfo
API structure, so we're not touching MagicNumber() for now.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
0e31c12e63 [#240] logs: Move log messages to constants 
Drop duplicate entities.
Format entities.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
cffcc7745e [#240] logs: Factor out common service log messages 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
4496999e52 [#100] Fix CHANGELOG 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
0c6aeaaf18 [#100] adm: Take net settings into account during netmap contract update 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
299b6a6938 [#100] adm: Use netmap constants from pkg 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
adcfce39cf [#246] .gitattributes: Do not show diff for go.sum 
When we update dependencies it can be rather big. However it is
generated automatically with `go mod tidy`, no need to review.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
41eb3129ae [#139] Refactor blobovnicza exist test to not use chmod 
Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
8d2f443868 [#238] Fix linter error 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
995db117d0 [#238] node: Read cfg from dir even if cfg file not set 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
200fc8b882 [#242] put: Pass context to relay function 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
d62c6e4ce6 [#242] node: Add tracing spans 
Add tracing spans for PUT requests.
Add tracing spans for DELETE requests.
Add tracing spans for SELECT requests.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
6121b541b5 [#242] treesvc: Add tracing spans 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
560f73ab7e [#247] node, ir: Drop reputation related code 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
960e3c219e [#247] config, doc: Drop reputation references 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
8799138fcb [#247] morph: Drop reputation contract 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
ci/woodpecker/pr/pre-commit Pipeline was successful Details
b453bb754c [#247] logs: Drop reputation log messages 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
beabed788c [#247] network_config: Drop reputation 
Drop the code that was expected to work with global reputation network
parameters.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
070154d506 [#247] client: Drop reputation related RPCs 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
8466894fdf [#250] control: remove `DumpShard` and `RestoreShard` RPC 
We have `Evacuate` with a cleaner interface.
Also, remove them from CLI and engine.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
0b42a00a60 [#254] innerring: Remove unused TimersHandlers() method from processors 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
262c9c2b93 [#256] blobovniczaTree: Make `Exists` test stable 
Corrupt and request _the same_ file.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
160147b05d [#249] adm: Drop subnet support 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
05c870f39a [#249] cli: Drop subnet support 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
d757d881d0 [#249] node: Drop subnet from config 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
f07d4158f5 [#249] node: Drop subnet from IR and morph 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
7b981bfe97 [#249] logs: Drop unused consts 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
b447ff99aa [#265] node: Up SDK and API-Go versions 
Fix tracing panic.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
a358255c1b [#265] node: Drop unused 
Resolve unused linter.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
3d43b0f7f9 [#265] node: Fix after SDK & API-Go version up 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
20cd080323 [#255] write-cache: Fix init race condition 
Do not use WC's internals in the initialization routines without mode
protection. WC should be able to change its mode even if the initialization
is not finished yet.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
ci/woodpecker/push/pre-commit Pipeline was successful Details
13c8afcb02 [#118] node: add unit concurrent tests for blobstor 
Signed-off-by: Airat Arifullin a.arifullin@yadro.com
ci/woodpecker/push/pre-commit Pipeline was successful Details
3d23b08773 [#262] meta: Do not return old expired objects 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
carpawell force-pushed carpawell/optional-profiles from 32350ed1e6 to b287a8a290 2023-04-19 17:03:10 +00:00 Compare
carpawell force-pushed carpawell/optional-profiles from b287a8a290 to 1250dd23d7 2023-04-19 17:05:05 +00:00 Compare
carpawell force-pushed carpawell/optional-profiles from 1250dd23d7 to 7f41586137 2023-04-19 17:11:20 +00:00 Compare
fyrchik approved these changes 2023-04-20 08:22:37 +00:00
cmd/frostfs-node/pprof.go Outdated
@ -8,0 +19,4 @@
mutexRate = -1
}
runtime.SetBlockProfileRate(blockRate)
fyrchik commented 2023-04-20 08:21:28 +00:00
Owner

Where do we have .enabled check?

Where do we have `.enabled` check?
carpawell commented 2023-04-20 12:20:08 +00:00
Collaborator

hm. reorganized a little, also, added support for SIGHUP

hm. reorganized a little, also, added support for `SIGHUP`
fyrchik marked this conversation as resolved
docs/storage-node-configuration.md Outdated
@ -83,1 +89,4 @@
| Parameter | Type | Default value | Description |
|--------------|-------|---------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `block_rate` | `int` | `0` | Controls the fraction of goroutine blocking events that are reported in the blocking profile. The profiler aims to sample an average of one blocking event per rate nanoseconds spent blocked. Non-positive values disable profiler reports. |
fyrchik commented 2023-04-20 08:22:34 +00:00
Owner

Can we just give a brief description refer to a Go-doc instead of copying?

Can we just give a brief description refer to a Go-doc instead of copying?
carpawell commented 2023-04-20 12:20:39 +00:00
Collaborator

check the updated version, please

check the updated version, please
fyrchik marked this conversation as resolved
carpawell force-pushed carpawell/optional-profiles from 7f41586137 to 0c7040bdf2 2023-04-20 12:14:22 +00:00 Compare
carpawell force-pushed carpawell/optional-profiles from 0c7040bdf2 to dd56abf020 2023-04-20 12:22:32 +00:00 Compare
carpawell requested review from fyrchik 2023-04-20 12:22:41 +00:00
carpawell requested review from storage-core-developers 2023-04-20 12:22:48 +00:00
carpawell requested review from storage-core-committers 2023-04-20 12:22:48 +00:00
carpawell force-pushed carpawell/optional-profiles from dd56abf020 to a491b875fa 2023-04-20 12:27:24 +00:00 Compare
acid-ant reviewed 2023-04-20 12:37:54 +00:00
cmd/frostfs-node/main.go Outdated
@ -88,3 +87,3 @@
initAndLog(c, pprof.name, pprof.init)
initAndLog(c, metrics.name, metrics.init)
initAndLog(c, "profiler", initProfilerService)
acid-ant commented 2023-04-20 12:37:54 +00:00
Collaborator

pprof was on top of init process to give us the ability to debug shutdown process. Now it is possible to stuck at the metrics when shutdown node without instrument for profiling routines.

pprof was on top of init process to give us the ability to debug shutdown process. Now it is possible to stuck at the metrics when shutdown node without instrument for profiling routines.
👍 1
fyrchik commented 2023-05-10 07:34:03 +00:00
Owner

Fixed

Fixed
dstepanov-yadro reviewed 2023-04-20 14:58:06 +00:00
cmd/frostfs-ir/main.go Outdated
@ -111,2 +112,4 @@
func initHTTPServers(cfg *viper.Viper, log *logger.Logger) []*httputil.Server {
pprof := "pprof"
pprofDebug := pprof + ".debug"
dstepanov-yadro commented 2023-04-20 14:58:06 +00:00
Collaborator

Do we really need this debug section? Is it about pprof overhead?

Do we really need this debug section? Is it about pprof overhead?
fyrchik commented 2023-05-10 07:59:16 +00:00
Owner

They can have noticeable overhead for small values, e.g. reasonable default is 10k, not 1. Let's disable it by default (0 value) and remove from the debug section.

They can have noticeable overhead for small values, e.g. reasonable default is 10k, not 1. Let's disable it by default (0 value) and remove from the `debug` section.
dstepanov-yadro marked this conversation as resolved
fyrchik force-pushed carpawell/optional-profiles from a491b875fa to b05cb54681 2023-05-10 07:33:19 +00:00 Compare
fyrchik commented 2023-05-10 08:00:06 +00:00
Owner

Updated, also, please, check the values we pass to runtime.Set..., there was a bug here in the previous iteration.

Updated, also, please, check the values we pass to `runtime.Set...`, there was a bug here in the previous iteration.
fyrchik changed title from Feat/Add optional profiles to Add block and mutex profiles 2023-05-10 08:02:23 +00:00
dstepanov-yadro approved these changes 2023-05-10 11:14:14 +00:00
fyrchik force-pushed carpawell/optional-profiles from b05cb54681 to 701e6c5323 2023-05-12 08:42:21 +00:00 Compare
fyrchik requested review from acid-ant 2023-05-12 08:42:27 +00:00
acid-ant approved these changes 2023-05-12 12:02:32 +00:00
fyrchik requested review from dstepanov-yadro 2023-05-12 12:50:05 +00:00
dstepanov-yadro requested changes 2023-05-12 14:06:17 +00:00
cmd/frostfs-ir/httpcomponent.go Outdated
@ -27,3 +30,1 @@
c.enabled = cfg.GetBool(c.enabledKey)
c.address = cfg.GetString(c.addressKey)
c.shutdownDur = cfg.GetDuration(c.shutdownTimeoutKey)
c.enabled = cfg.GetBool(c.name + ".enabled")
dstepanov-yadro commented 2023-05-12 14:03:27 +00:00
Collaborator

enabledKeyPostfix ?

enabledKeyPostfix ?
fyrchik commented 2023-05-12 14:50:45 +00:00
Owner

fixed

fixed
dstepanov-yadro marked this conversation as resolved
fyrchik force-pushed carpawell/optional-profiles from 701e6c5323 to 429a87e83b 2023-05-12 14:50:41 +00:00 Compare
dstepanov-yadro approved these changes 2023-05-12 15:00:42 +00:00
aarifullin approved these changes 2023-05-15 08:22:50 +00:00
fyrchik merged commit 429a87e83b into master 2023-05-15 08:36:49 +00:00
fyrchik deleted branch carpawell/optional-profiles 2023-05-15 08:36:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
dstepanov-yadro
aarifullin
alexvanin
KirillovDenis
fyrchik
acid-ant
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#39
There is no content yet.
Delete Branch "carpawell/optional-profiles"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?